[koha-commits] main Koha release repository branch master updated. v18.11.00-1369-g90f8eb6
Git repo owner
gitmaster at git.koha-community.org
Fri Apr 26 14:57:49 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 90f8eb626d32694e3297a4cfe6566cbb9abe192b (commit)
via bfce1fea9652f84c2031f59e7213694b05e4ca8a (commit)
via bf473396ab1313867ead815ca3e8758b76233931 (commit)
via 5743bb2945d3fb8900129123bf1f36f67310d843 (commit)
via 831e9fc98fd99a52da09f0b5a6fdd88a37c66e1f (commit)
via 21127d4a47bbebb74d44d32d5b51dac4bc470ce6 (commit)
via 443c2fafb7be74aa74282eb4dee7ad5f3d827f31 (commit)
via 80be039d6c6ccff18ac029b4e2081728aeba5748 (commit)
via 6e6a6230a5e59ec1866a12174233471a07d616b8 (commit)
via 428fcb3421d0176bdb92cc394fbaec00b84871a8 (commit)
via 2b45630e42813f0e9a383cb7f97c63f68f30a4a3 (commit)
via 6d93872d5a8f060a30104751997e312e74d21c33 (commit)
via 7be6714148f35f3d33d848d4cc9dca251356971a (commit)
via 27691d2db6b74fb42b8be169a5feb7577ff582eb (commit)
via 696035229137ffb139446ba99f8ad41dab94a199 (commit)
via 020da0e81712ca3d6856e31af4cd3b8d18346c01 (commit)
via f82d6acab668dfb86a227b155116679a2a540eea (commit)
via 1d6e9ff44c19379a41e9ce688685a24788583e0c (commit)
via 20496bc78b7830d812fda454a0fe243fae9c465c (commit)
via 7e85754083bd66f45009f55a01e9dec9eda81504 (commit)
via 6e641c5bcb7370556326fb64838fce1eefbc2c18 (commit)
via c9927a97ab814b18453f981b50ada546ca2ba064 (commit)
from 90a15e2d82cd345c6d2fd3cb3ddd1e318e3a79f7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 90f8eb626d32694e3297a4cfe6566cbb9abe192b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Apr 24 09:51:36 2019 -0400
Bug 22765: Add class beside loggedinusername to indicate if logged in user is a superlibrarian
It would be useful to know if a logged in user is a superlibrarian for the purpose of customization
using Javascript and CSS.
Test Plan:
1) Apply this patch, restart all the things
2) Log in as a superlibraraian
3) Note the new class 'is_superlibrarian' next to the 'loggedinusername' class
4) Log in as a non-superlibrarian
5) Note the new class is not present
Signed-off-by: Barton Chittenden <barton at bywatersolutions.com>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit bfce1fea9652f84c2031f59e7213694b05e4ca8a
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Apr 26 12:04:57 2019 +0000
Bug 15496: (QA follow-up) Fix new uses of Koha::Biblio::items in list context
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit bf473396ab1313867ead815ca3e8758b76233931
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Apr 17 16:20:18 2019 +0000
Bug 15496: (follow-up) Update interaction for deleting records
This patch makes minor changes to markup and JavaScript to alter the
interaction for deleting the record. Now a successful deletion will
convert the dialog to a "message" type dialog and show only the success
message.
To test, apply the patch and test the process of attaching the last item
from a record and deleting that record.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5743bb2945d3fb8900129123bf1f36f67310d843
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Wed Apr 17 10:47:06 2019 +0000
Bug 15496: (QA follow-up) Change success status on api
DELETE response code must be 204, not 200 according to our API coding
guidelines
Test plan:
prove t/db_dependent/api/v1/biblios.t
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 831e9fc98fd99a52da09f0b5a6fdd88a37c66e1f
Author: Liz Rea <wizzyrea at gmail.com>
Date: Mon Apr 15 17:55:04 2019 +0000
Bug 15496: (QA follow-up) remove text/javascript
Make the QA tool happy for html5
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 21127d4a47bbebb74d44d32d5b51dac4bc470ce6
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Apr 12 13:50:32 2019 -0400
Bug 15496: Delete Bib After Moving Item
Librarians have requested the ability to delete records with no items
quickly and easily from the "Attach item" results page as items are
moved from one record to another.
Test Plan:
1) Apply this patch
2) Create 2 records with 2 items each
3) Move one item from record A to record B
4) You should see no change from pre-patch behavior
5) Move the second item from record A to record B
6) You should now see a "Delete record" button
7) Click the button
8) Note the record in question has been deleted
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 443c2fafb7be74aa74282eb4dee7ad5f3d827f31
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Apr 26 11:48:17 2019 +0000
Bug 10300: DBRev 18.12.00.065
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 80be039d6c6ccff18ac029b4e2081728aeba5748
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Feb 28 16:23:22 2019 +0100
Bug 10300: (follow-up) add controls on transfers page
This patch moves the check of IndependentBranchesTransfers pref to templates and adds permission test inside branchtransfers.pl.
It also corrects the libraries combobox in branchtransfers.tt, this list can contain all libraries, it is the access to the page that may be protected.
Additions to test plan :
1)
1.1) Enable CircSidebar
1.2) In circulation home page check the effect of IndependentBranchesTransfers on "Transfer" link
1.3) Go to return page and check then effect of IndependentBranchesTransfers on "Transfer" link
2)
2.1) In circ/branchtransfers.pl, with and without IndependentBranches you see all libraries are in combobox
3)
3.1) Set IndependentBranchesTransfers to no and go to circ/branchtransfers.pl
3.2) You are redirected to page 403 unless you are superlibarian
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6e6a6230a5e59ec1866a12174233471a07d616b8
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Aug 25 14:03:31 2016 +0000
Bug 10300: Allow transferring of items to be have separate IndependentBranches syspref
Some libraries want to have IndependentBranches enabled, but still be
able to transfer items between themselves.
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable IndpendentBranches and IndependentBranchesTransfers
4) Log in as a super librarian
5) Note you can transfer items
6) Log in as a non-super librarian
7) Note you cannot transfer items
8) Disable IndependentBranchesTransfers
9) Note you can now transfer items
Signed-off-by: Maribeth Shafer <mshafer at ckls.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Bug 10300: (QA follow-up) Make database update idempotent
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 428fcb3421d0176bdb92cc394fbaec00b84871a8
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Apr 12 13:07:18 2019 -0400
Bug 15496: Tidy code block (Whitespace changes only)
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2b45630e42813f0e9a383cb7f97c63f68f30a4a3
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Apr 11 10:05:14 2019 -0400
Bug 15496: Add API endoint for deleting a bib
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6d93872d5a8f060a30104751997e312e74d21c33
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Apr 26 10:52:41 2019 +0000
Bug 22035: Compiled CSS
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7be6714148f35f3d33d848d4cc9dca251356971a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jan 16 18:27:54 2019 +0000
Bug 22035: Improve local cover image browser page
This patch makes changes to the way local cover images are handled on
the image viewer page in the staff client. From this page you can now
delete images or reach the upload images page.
The patch also modifies slightly the process for deleting an image from
the images tab on the bibliographic detail page.
To test, apply the patch and regenerate the staff client CSS.
LocalCoverImages and AllowMultipleCovers should be enabled.
- Open the detail view for a record which has multiple cover images
attached. On the Images tab, click the "Delete image" link for an
image. After confirming, the link should change to a spinner icon and
image should fade out.
- Click one of the cover images to open the image viewer page. The
thumbnails should each have a delete link which looks like and
behaves like the delete links on the biblio detail page.
- Clicking an image thumbnail should load a spinner icon into the area
where the full-sized image was, which should be replaced by the image
you chose.
- There should be a button for uploading images which takes you to the
correct page for adding images to that record.
- The page title and breadcrumbs should show the title of the record.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 27691d2db6b74fb42b8be169a5feb7577ff582eb
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date: Fri Apr 26 15:22:30 2019 +1200
Bug 22056: Removed test directory, including search.pl and README
Test plan: Check that this directory has been removed.
Sponsored-by: Catalyst IT
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 696035229137ffb139446ba99f8ad41dab94a199
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Apr 25 12:35:24 2019 +0100
Bug 22200: (follow-up) Wrap accountline creation in a transaction
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 020da0e81712ca3d6856e31af4cd3b8d18346c01
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Apr 18 09:44:01 2019 +0100
Bug 22200: Add credit when forgiving overdue
Prior to this patch the exemptfine option for_FixOverduesOnReturn would
directly set the overdue amount to 0 rather than creating an appropriate
credit of the type forgiven and offseting it against the debt.
Test Plan:
1) Find a checkout that is overdue with fines
2) Check the item in with the forgive fines option checked
3) Note that the users account details now shows the overdue as forgiven
and a forgiven credit is added which matches the overdue amount (and is
applied against it, i.e. both overdue and forgiven lines have 0
amountoutstanding).
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f82d6acab668dfb86a227b155116679a2a540eea
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Apr 18 09:56:24 2019 +0100
Bug 22200: Add Tests for change
Unit tests to check for the addition of a credit of type 'FOR' when
_FixOverduesOnReturn is called with $exemptfine set to true.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1d6e9ff44c19379a41e9ce688685a24788583e0c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 23 22:49:46 2019 -0400
Bug 22621: Fix filters on subscription search results
Caused by
commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b
Bug 18426: Allow to edit subscriptions in batch
There is a shift caused by a hidden column, which make the filters
searching on the previous column.
Test plan:
- Add 1+ searchable additional field for subscription
- Create a new subscription
- Search for subscriptions
- Use the column filters to filter the results
=> The results must be filtered accordingly
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 20496bc78b7830d812fda454a0fe243fae9c465c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Oct 17 14:43:11 2018 -0400
Bug 21589: Series link formed from 830 field is incorrect
Bug 13692 corrected the series link for records using a 490/800 combination
When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank)
Test Plan:
1) Catalog two or more records with 830 fields
2) Note the series links are broken
3) Apply this patch
4) Reload the record details page
5) The series link should now work
6) Repeat for the OPAC
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7e85754083bd66f45009f55a01e9dec9eda81504
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Apr 25 17:47:14 2019 +0000
Bug 22715: Remove extraneous html filter
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6e641c5bcb7370556326fb64838fce1eefbc2c18
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Apr 16 10:34:56 2019 -0400
Bug 22715: Searching for patrons with "" in the circulation note hangs patron search
To replicate:
Edit a patron to have a circ note, include quoted text in it, such as "this is quoted string"
Go to the patron search, search for a set of results that would include the patron with the quotes in the note
Enjoy looking at "Processing" for forever.
Test Plan:
1) Apply this patch
2) Attempt to replicate using the steps above
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
I took this a step further and used <script>"something in
quotes"</script> for my test note and this worked just fine. YAY.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c9927a97ab814b18453f981b50ada546ca2ba064
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 23 23:48:35 2019 -0400
Bug 22669: Fix item editing on receiving an order
Since
commit 1253975389975a8ff11a9bb2ef84582aeb6bd08b
Bug 21091: Move add item template JavaScript to a separate file
items cannot longer be edited when receiving an order.
When moving the code to the JS file, the JS variable "opisadd" was
always set to "true":
var opisadd = '[% opisadd | html %]';
Even if the TT variable is 0, opisadd will be "0", which is evaluated to
true in Javascript
To clean the situation it is easier to remove this variable and use "op"
instead.
Test plan:
- Make sure acqcreateitem is set to "when placing an order"
- Create a basket with some orders
- Close the basket
- Go to your vendor and receive an order
- On the receive page, try to edit your item
=> Without the patch, the pop up page will open and then close, not allowing the item to be edited.
=> With this patch applied you will see the item edit form. Save and
confirm that the parent window is updated with the new value (actually
it's refreshed)
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 66 ++++++----
C4/ILSDI/Services.pm | 2 +-
Koha.pm | 2 +-
Koha/Biblio.pm | 15 +--
Koha/REST/V1/Biblios.pm | 76 +++++++++++
api/v1/swagger/parameters.json | 3 +
api/v1/swagger/parameters/biblio.json | 9 ++
api/v1/swagger/paths.json | 3 +
.../{acquisitions_funds.json => biblios.json} | 49 +++-----
cataloguing/additem.pl | 1 -
cataloguing/moveitem.pl | 53 ++++----
circ/branchtransfers.pl | 6 +
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 11 ++
.../intranet-tmpl/prog/css/src/staff-global.scss | 1 +
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../intranet-tmpl/prog/en/includes/circ-nav.inc | 2 +-
.../intranet-tmpl/prog/en/includes/header.inc | 3 +-
.../prog/en/includes/str/cataloging_additem.inc | 2 +-
.../prog/en/modules/admin/preferences/admin.pref | 7 ++
.../prog/en/modules/catalogue/detail.tt | 3 +-
.../prog/en/modules/catalogue/imageviewer.tt | 133 +++++++++++++-------
.../prog/en/modules/cataloguing/additem.tt | 4 +-
.../prog/en/modules/cataloguing/moveitem.tt | 40 ++++++
.../prog/en/modules/circ/branchtransfers.tt | 2 +-
.../prog/en/modules/circ/circulation-home.tt | 2 +-
.../en/modules/members/tables/members_results.tt | 2 +-
.../prog/en/modules/serials/serials-search.tt | 18 +--
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 33 ++++-
.../intranet-tmpl/prog/js/cataloging_additem.js | 10 +-
.../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 32 ++++-
t/db_dependent/Circulation.t | 12 +-
t/db_dependent/Koha/Biblio.t | 2 +-
t/db_dependent/api/v1/biblios.t | 72 +++++++++++
test/README | 3 -
test/search.pl | 70 -----------
36 files changed, 517 insertions(+), 235 deletions(-)
create mode 100644 Koha/REST/V1/Biblios.pm
create mode 100644 api/v1/swagger/parameters/biblio.json
copy api/v1/swagger/paths/{acquisitions_funds.json => biblios.json} (51%)
create mode 100644 t/db_dependent/api/v1/biblios.t
delete mode 100644 test/README
delete mode 100755 test/search.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list