[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.04-144-g461c717

Fri Apr 26 17:33:02 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  461c7176735cbfd4ed7db97a9fa094b60ac2e0ca (commit)
       via  1269f7d6c7712b3c9115824660d5f12933ba6462 (commit)
       via  5acddea685c665463aa0ca755962734a75700ecb (commit)
       via  4863e59c5798fda6883c354eeb5096d4609e42bd (commit)
       via  b2f9cfe4528ecd57b1cc45f602a578147b282cd5 (commit)
       via  376004638699aa8d1712ba24621280927c40822b (commit)
       via  49c99ced88af8d9d17d433c69322b862d30aee8a (commit)
      from  b99fbdd8fc85beb989a51142bb531673748bc344 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 461c7176735cbfd4ed7db97a9fa094b60ac2e0ca
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 19 11:25:43 2019 +0000

    Bug 22743: Add password modal to overdrive results page

    This patch also removes a line abotu ratings which was throwing an error.
    Confirm stars rating for OD results are still shown as expected

    To test:
     1 - Enable overdrive circulation with password required
     2 - Sign in to OPAC but not overdrive
     3 - Perform a search that returns overdrive results
     4 - Click in to results page
         http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats
     5 - Note 'Login to OverDrive account' link
     6 - Click it
     7 - Nothing happens!
     8 - Apply patch
     9 - Repeat
    10 - Success!

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7be176cf1da5adb5f264bb9668667dfeb1d9a2ae)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1269f7d6c7712b3c9115824660d5f12933ba6462
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Apr 19 09:28:35 2019 -0300

    Bug 22739: Test SelfCheckInTimeout <> 0, not just defined

    On sci-main.pl the preference value is tested for 'defined'. This patch
    tests it is different than empty string too. This was causing a
    JavaScript syntax error, that made it display a wrong message.

    To test:
    1 - Blank the syspref SelfCheckInTimeout
    2 - Attempt to checkin something via sci
    => FAIL: The 'Your request included no check-ins.' message is printed.
    3 - Apply this patch, reload the sci-main.pl page
    4 - Attempt to checkin something via sci
    => SUCCESS: The UI correctly stacks the scanned barcodes
    5 - Sign off :-D

    Signed-off-by: Liz Rea <wizzyrea at gmail.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit c1949cda9b2847bc6ecf7e1dbc07990c4055b69a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5acddea685c665463aa0ca755962734a75700ecb
Author: Agustin Moyano <agustinmoyano at theke.io>
Date:   Tue Apr 23 00:50:49 2019 +0000

    Bug 16232: Fix edit as new in Rancor

    When you edit a biblio as new, and you have enabled advanced editor,
    current record was opened, and was overwritten when saved. This patch
    effectively opens a new record based on the one selected.

    To test:
    1) Enable "EnableAdvancedCatalogingEditor" preference
    2) Go to cataloguing and click on advanced editor to save preference to the cookie
    3) Search for an item in catalog
    4) Click in "Edit as new (duplicate)"
    5) Advanced editor should appear.
    CHECK => browser url ends with #catalog/{original biblionumber}
          => Title above toolbar is "Editing catalog record #{original biblionumber}"
    6) Apply this patch
    7) Repeat steps 3 to 5
    SUCCESS => browser url ends with #duplicate/{original biblionumber}
            => Title above toolbar is "Editing duplicate record of #{original biblionumber}"
    8) Save
    SUCCESS => browser url ends with #catalog/{new biblionumber}
            => Title above toolbar is "Editing catalog record #{new biblionumber}"
    9) Sign off

    Sponsored-by: Carnegie

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 680dd7f340ef445820864045127da9c65b3be0e2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4863e59c5798fda6883c354eeb5096d4609e42bd
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Apr 17 13:58:57 2019 +0200

    Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm

    In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes.

    It may generates this error :

    Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448.
    " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448.
    "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186.

    Simply missing double quotes.
    Also missing use Carp to call confess.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4e2c74fced685db861a78fc1aa151dd35ad0d5f2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b2f9cfe4528ecd57b1cc45f602a578147b282cd5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Apr 24 06:55:12 2019 +0000

    Bug 22753: Fix tabs pointed out by QA script

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 40cf22ab5f9dbdcaa37f46977fe5386a6303a42e)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 376004638699aa8d1712ba24621280927c40822b
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Apr 23 18:03:33 2019 +0000

    Bug 22753: Fix hold priority adjustment, move to top

    Since the holds table can be split we need to calculate the
    first priority for each table. However, currently we use the
    first in the loop, not taking into account the waiting status.
    This patchset sets the first_priority to the first non-found hold

    Additionally, some clean-up is done to not display the alter
    priority arrows for waiting holds.

    To test:
    1 - Place several holds on a title
    2 - Confirm one of the holds to be waiting
    3 - Attempt to move the last hold to the top
    4 - Nothing happens
    5 - Apply patch
    6 - Note that the waiting hold has no options to move in the list
    7 - Attempt to move the last hold to the top
    8 - It moves as expected!
    9 - Split the holds queue by pickup library
    10 - PLace some holds for pickup at another branch
    11 - Confirm moving these holds works within their own table
    12 - Unsplit the queue
    13 - Ensure the holds end where you expect (moving in a split
         table didn't move above holds form another table)

    Signed-off-by: Liz Rea <wizzyrea at gmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit eb956eb4cf3d44f45ad54be58fe95d7355a2b8bf)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 49c99ced88af8d9d17d433c69322b862d30aee8a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 24 00:09:44 2019 -0400

    Bug 22762: Fix items.collection display on receiving

    Caused by
      commit 31c29fd31f557306233e6a2936148a5bb10b89a1
      Bug 21206: Replace C4::Items::GetItem

    The log says: The method Koha::Item->collection is not covered by tests!

    It has highlighted an older problem:
    Since
      commit bb1e9c500c810402c64436c53bcc00ffb9a0b857
      Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib
    the "Collection code" is not filled correctly (items.collection vs items.ccode).

    Test plan:
    - Set acqcreateitem to "when placing an order"
    - Receive an order with items
    => The "Collection code" column must be filled with the items.ccode value
    - Edit an item
    - Change the collection code value
    => The "Collection code" column must be filled with the new value

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/MetadataRecord/Authority.pm                   |    3 +-
 acqui/orderreceive.pl                              |    2 +-
 catalogue/getitem-ajax.pl                          |    2 +-
 cataloguing/addbiblio.pl                           |    2 +-
 .../prog/en/includes/cateditor-ui.inc              |   15 ++++
 .../intranet-tmpl/prog/en/includes/holds_table.inc |   74 +++++++++++---------
 .../bootstrap/en/modules/opac-overdrive-search.tt  |    8 ++-
 opac/sci/sci-main.pl                               |    2 +-
 8 files changed, 69 insertions(+), 39 deletions(-)

hooks/post-receive
-- 
main Koha release repository