[koha-commits] main Koha release repository branch master updated. v18.11.00-1407-gdd35242
Git repo owner
gitmaster at git.koha-community.org
Tue Apr 30 15:59:35 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via dd352428bb4fe9c5656bdf4921f913440db259a2 (commit)
via 1ad52b371d028e4ffd65bce0599dcc0f6a412465 (commit)
via 1a44ce023e3c5dc0e8a547b8535c080602674c26 (commit)
via 10faf56c8eac5d9e9c1c8bddd267460f72116284 (commit)
via 9e6be55a06bc44450845199dc3db25b4021da7ef (commit)
via d0e6a26558be8338af52a723a2664111abcbe861 (commit)
via 6e7b8f6f675d8657c431d6a899e6a47bb1049762 (commit)
via 7a44c9edb969cd92db4de0223a2c9db06d576451 (commit)
via 4ca1d8e3b3f60722321f9f4b5f1f0caa461beecb (commit)
via 59b740613e7a72bf6e5283c2876bad9444a7ef6a (commit)
from 7de4511cef9c7204ff039356775ff3d59ceefc44 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit dd352428bb4fe9c5656bdf4921f913440db259a2
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Apr 29 15:10:17 2019 +0000
Bug 22424: (follow-up) Show blank value for empty status
This patch updates the screen and CSV output of item searches so that if
the item does not have a lost status a blank table cell is shown instead
of "0."
This patch also amends the table headers so that "Not for loan" statuses
are explicitly labeled as such, and the "Lost" column has the header
"Lost status."
To test, apply the patch and perform an item search in the staff client
which will return results with notforloan and lost items. Verify that
the values display correctly in both onscreen and CSV output. Verify
that the column headers look correct.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1ad52b371d028e4ffd65bce0599dcc0f6a412465
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Feb 27 15:31:29 2019 +0000
Bug 22424: Add search by all lost statuses to item search
This patch changes the item search form so that searching by lost status
includes options for all lost authorised values instead of just "yes" or
"no."
To test you should have multiple authorized values for LOST.
- Apply the patch and open the item search form.
- Test searches which limit by lost status. Confirm that results are
correctly limited.
- Confirm that lost statuses are correctly displayed in the search
results.
- Confirm that in the search results table, the column header for
"Lost" includes a dropdown menu for filtering by all available
authorized values for lost.
- Test the CSV export function and confirm that lost status is
correctly exported.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1a44ce023e3c5dc0e8a547b8535c080602674c26
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Apr 30 13:04:24 2019 +0000
Bug 22408: Compiled CSS
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 10faf56c8eac5d9e9c1c8bddd267460f72116284
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Feb 25 16:28:10 2019 +0000
Bug 22408: Subscription entry form cleanup
This patch makes a number of changes to the subscription entry form:
- Make the default layout single-column.
- Switch the layout to two-column only when testing prediction
pattern.
- Add a button to hide the prediction pattern test pane.
- Change the style of some buttons and links. Add Font Awesome icons
to some.
- Clean up some issues with capitalization and spacing.
- Make it clearer when form fields are read-only: Move "locked" form
field style from addbiblio.css to staff-global.css and improve it
with regard to mouse interactions
To test, apply the patch and regenerate the staff client CSS. Clear your
browser cache if necessary.
- Go to Serials -> New subscription.
- Readonly fields under "Vendor" and "Record" should show a small
padlock icon.
- Test the process of adding a subscription, paying special attention
to the advanced pattern controls: Showing, hiding, modifying,
canceling.
- Test the process of editing a subscription in the same way.
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9e6be55a06bc44450845199dc3db25b4021da7ef
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Apr 27 13:42:17 2019 +0000
Bug 21364: (QA follow-up) Fix QA script complaints (tabs and filters)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d0e6a26558be8338af52a723a2664111abcbe861
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Apr 22 20:00:37 2019 +0000
Bug 21364: (follow-up) Check for standing status and uncertain prices
Fetch 'uncertainprices' when getting basket info. A side effect is that styling on baskets with uncertain prices is restored by this bug. They will appear in red
To test:
1 - Add an order with an uncertainprice to the basket
2 - Return to vendor baskets view
3 - Note the actions now include "Uncertain prices"
4 - Click that, resolve the uncertain prcie
5 - Return to vendor basket view
6 - Note you can now close the basket, but don't
7 - Edit the basket, mark it as standing
8 - Return to vendor basket view
9 - Note you cannot close the basket
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6e7b8f6f675d8657c431d6a899e6a47bb1049762
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Sun Sep 16 03:05:59 2018 +0000
Bug 21364: Allow closing basket from vendor view/search
To test:
1 - Have a vendor
2 - Add some empty baskets
3 - Add some non-empty baskets
4 - Search for vendor and note you now
a - Can only 'View' empty or closed baskets
b - Have a dropup menu to 'Add to ' or 'Close' open baskets
5 - Confirm things look correct and buttons work
6 - Confirm that basket name is now a link to view basket
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7a44c9edb969cd92db4de0223a2c9db06d576451
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Dec 17 13:35:09 2018 +0000
Bug 22010: Check preferences for ebook integration
To test:
1 - Enable OverDrive and RecordedBooks (you can put anything in the
prefs)
2 - Search on the opac - verify you get results (or search error) on
first page of results'
3 - Go to second page of results - OD and RB are not searched
4 - Apply patch
5 - Verify nothing has changed
If you have valid credentials:
1 - Enable RB prefs
2 - Sign in with an account that has an email matching your registered
account for recordedbooks
3 - Confirm you RB account loads on opac-user.pl
Otherwise:
Read the patches, verify it all makes sense
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4ca1d8e3b3f60722321f9f4b5f1f0caa461beecb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Apr 28 21:40:21 2019 -0400
Bug 22357: Do not duplicate report rows if several reports exist
At the moment every time you run runreport.pl with the --store-results
option another line will appear for your report in the saved
reports table. This is not a data, but a display problem as the
report is still only stored once.
1) Create a report and note the report number
2) Run from command line (replace X by report number) :
misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results
3) Go to saved reports table
4) Look at the table, each run of the cronjob will create a new row
in the table instead of just updating the saved results column.
5) Apply patch
6) Veriy the table displays correctly again and there are no regressions
QA: Run t/db_dependent/Reports/Guided.t
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 59b740613e7a72bf6e5283c2876bad9444a7ef6a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Apr 26 20:49:14 2019 -0400
Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration
Silly bug caused by:
commit ef410fd62f279a10687636a4f26babb2c91ecadc
Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber
Constructors take a hashref!
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 3 +-
C4/External/OverDrive.pm | 18 ---
C4/Reports/Guided.pm | 3 +-
catalogue/itemsearch.pl | 24 +++-
koha-tmpl/intranet-tmpl/prog/css/addbiblio.css | 1 -
.../intranet-tmpl/prog/css/src/staff-global.scss | 28 +++--
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../en/includes/catalogue/itemsearch_item.csv.inc | 3 +-
.../en/includes/catalogue/itemsearch_item.json.inc | 1 +
.../includes/csv_headers/catalogue/itemsearch.tt | 2 +-
.../prog/en/modules/acqui/booksellers.tt | 55 +++++----
.../prog/en/modules/catalogue/itemsearch.tt | 15 ++-
.../en/modules/serials/showpredictionpattern.tt | 4 +
.../prog/en/modules/serials/subscription-add.tt | 126 +++++++++++---------
.../intranet-tmpl/prog/js/subscription-add.js | 19 ++-
.../bootstrap/en/includes/opac-bottom.inc | 5 +-
.../bootstrap/en/modules/opac-overdrive-search.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 7 +-
opac/opac-search.pl | 6 +-
opac/svc/auth/googleopenidconnect | 4 +-
opac/svc/overdrive_proxy | 2 +-
t/External/OverDrive.t | 55 ---------
.../Acquisition/GetBasketsInfosByBookseller.t | 16 ++-
23 files changed, 217 insertions(+), 184 deletions(-)
delete mode 100755 t/External/OverDrive.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list