[koha-commits] main Koha release repository branch master updated. v19.05.00-525-ge31cddf
Git repo owner
gitmaster at git.koha-community.org
Mon Aug 19 11:46:50 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e31cddf8b0fca3f4847c093d52aa911cd502749e (commit)
via 90b48c2c48e2056a93b2619b94518769e6cefc9f (commit)
via ae4e992dfb2251d6a7cd9268a5171a814162b293 (commit)
via f1f66d73006e0de49dad36ff969ad974d4bd0fce (commit)
via ee9587f983fafa4c47e809c301b4f3698be9215c (commit)
via 5b90019f8ad956915baa13873284eeb344ffd58f (commit)
via b349fa10017e1dc397aeb32502296c7fd7e3c741 (commit)
via 388f5fa0ffef6a1a5720cb1a94f2f9eb7b6dcf8a (commit)
via 54d7fe5250eefac32520f520469d5882c0a67628 (commit)
from 51c716cfe1d15d29136b4f05717bb820ffed4df6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e31cddf8b0fca3f4847c093d52aa911cd502749e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jul 8 15:23:09 2019 -0300
Bug 23281: Cleanup Koha::Patron::Attribute::Types->search
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 90b48c2c48e2056a93b2619b94518769e6cefc9f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jul 8 14:15:48 2019 -0300
Bug 23281: Implement ->search_with_library_limits in Koha::Patron::Attribute::Types
This patch makes Koha::Patron::Attribute::Types inherit from
Koha::Objects::Limit::Library so it now has the
->search_with_library_limits method.
Tests are adjusted so it is clear that there is no behaviour change
compared to the (previsouly) called ->search
To test:
- Run:
k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests pass!
- Apply this patch
- Run:
k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests still pass!
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ae4e992dfb2251d6a7cd9268a5171a814162b293
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jul 8 14:13:12 2019 -0300
Bug 23281: Add Koha::Objects::Limit::Library
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f1f66d73006e0de49dad36ff969ad974d4bd0fce
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Aug 12 18:08:37 2019 +0000
Bug 23448: (follow-up) Add comments on markup structure
This patch adds comments to the markup in order to highlight the
structure of the page.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ee9587f983fafa4c47e809c301b4f3698be9215c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Aug 12 17:57:55 2019 +0000
Bug 23448: Clean up subscription detail template
This patch makes a number of corrections to the subscription detail
page: Re-indented consistently with four spaces. Removed invalid
attributes. Added missing </div>.
To test, apply the patch and go to Serials. Search for a subscription
and view the details page.
The page should look correct. Validating the source should return no
errors.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5b90019f8ad956915baa13873284eeb344ffd58f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Aug 13 18:26:57 2019 +0000
Bug 23458: (follow-up) Add comments to markup
This patch adds a few comments to the markup in order to highlight the
structure of the page.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b349fa10017e1dc397aeb32502296c7fd7e3c741
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Aug 13 15:47:08 2019 +0000
Bug 23458: Clean up holds template in the staff client
This patch reindents reserve/request.tt to use four spaces and
to eliminate tabs, following coding guidelines. Trailing white space has
been removed.
To test, apply the patch and use your preferred method for checking the
differences between files while ignoring whitespace. I use diff with the
"-w" flag, but I'm no diffctator.
Test the process of placing a hold in the staff client: A single hold,
multiple holds, etc. Everything should work correctly.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 388f5fa0ffef6a1a5720cb1a94f2f9eb7b6dcf8a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Aug 13 15:54:30 2019 +0000
Bug 17057: (follow-up) Replace onsubmit attributes
This patch removes the "onsubmit" attribute from the place hold form.
To test, apply the patch and test placing a hold:
Begin the process of placing a hold on a single title. On the
place hold screen, uncheck the "Hold next available item" checkbox and
click the "Place hold" button.
You should be get an alert saying "Please select an item to place a
hold." Select an item and click the "Place hold" button again. The hold
should be placed.
This patch affects the form validation for placing multiple holds, but I
don't think the JavaScript ever has a chance to run: The template blocks
the user from placing multiple holds if one of the titles has no items.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 54d7fe5250eefac32520f520469d5882c0a67628
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Aug 13 14:51:10 2019 +0000
Bug 17057: Remove event attributes from holds template
My orginal patch for this bug contained a lot of changes made obsolete
by Bug 19469, which created holds_table.inc.
This new version makes one minor change only to request.tt, adding a
class name and removing an onclick attribute.
To test, apply the patch and place an item-level hold on a title.
Start the process of placing another hold on that item. On the "place
hold" screen, in the table of items, you should see a "Cancel hold" link
for the item you previously placed on hold.
- Click the "Cancel hold" link
- Clicking "Cancel" in the confirmation dialog should cancel the
operation.
- Clicking "OK" should cancel the hold.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/Objects/Limit/Library.pm | 86 ++
Koha/Patron/Attribute/Types.pm | 34 +-
.../prog/en/modules/reserve/request.tt | 1228 ++++++++++----------
.../prog/en/modules/serials/subscription-detail.tt | 853 +++++++-------
t/db_dependent/Koha/Patron/Attribute/Types.t | 16 +-
5 files changed, 1176 insertions(+), 1041 deletions(-)
create mode 100644 Koha/Objects/Limit/Library.pm
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list