[koha-commits] main Koha release repository branch master updated. v19.05.00-551-g205ab8f
Git repo owner
gitmaster at git.koha-community.org
Tue Aug 20 17:37:07 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 205ab8f50ba3274e6382b114036b9bc0c943c918 (commit)
via 949b5b37110d5510b39bfe43921f581ed8439cce (commit)
via 77d197c361a71f7090add40651630a1d99b17058 (commit)
via d09444c735c9879f7aebe8139f0a921a1076940b (commit)
via ee178f42ded6c3c0342e9ed478b070117a8b9776 (commit)
via 3bff8a17eaf96c10b1b30babd0271f0eb2bc4fc0 (commit)
via b4b95b97263f858f6dd19e71c26e0c5ba841e607 (commit)
via 3ab5d3b1253f255c8d06988e4a54054c811c19d3 (commit)
via 540136bb470ec66bff45881e97f51897bee731d8 (commit)
via abb801ebbc986b40573ecfb3d7ce3093dd67f803 (commit)
via 5d2a082647caf2f163bd9a895145a3994172f797 (commit)
via f827064badfa261d6123752ec4aebd8c4378677e (commit)
via 200352183824011c5435cd12368944c3a678e889 (commit)
via 7e591e9cb6c5e7711ff9811ebf0cfc9e8c5449a5 (commit)
via a17245a52e1b11dfef9808a1a88731c63814efb9 (commit)
via 89bd7872e357e029daee685b078170781ef42ba3 (commit)
via 53b3ebe9d0b359ac88671ed489afc49ab65d2520 (commit)
via c8ff1e4701854ab74b6f85fd4ff02592f8205bf6 (commit)
via 109334102fbb29c60fa9a7a762c5e68f4b2ce0be (commit)
from a5828bc7dccdfbc574b30a7f39c822d4a4cab8fe (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 205ab8f50ba3274e6382b114036b9bc0c943c918
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Aug 20 16:15:17 2019 +0100
Bug 14570: DBRev 19.06.00.022
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 949b5b37110d5510b39bfe43921f581ed8439cce
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Aug 20 15:55:45 2019 +0100
Bug 14570: (RM follow-up) Consistent button styling
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 77d197c361a71f7090add40651630a1d99b17058
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 19 10:32:06 2019 -0300
Bug 14570: Add about.pl entry for wrong relationship data
This patch adds a check and an entry to the about.pl, for bad
relationship data. The checks are:
- 'relationship' containing '_bad_data' (generated by the atomicupdate
on undef relationships.
- 'relationship' values that are not in the borrowerRelationship
syspref.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d09444c735c9879f7aebe8139f0a921a1076940b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 19 10:31:41 2019 -0300
Bug 14570: (QA follow-up) Call Koha::Patron->find in scalar context
This patch prevents opac/opac-memberentry.pl from exploding.
To test:
- Login with a known user in the OPAC
- Open the opac/opac-memberentry.pl page
=> FAIL: It explodes
- Apply this patch
- Restart all the things just in case:
$ restart_all
- Reload the page
=> SUCCESS: Things work!
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ee178f42ded6c3c0342e9ed478b070117a8b9776
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 19 07:22:50 2019 -0300
Bug 14570: Handle missing 'relationship' in atomicupdate (bad data)
This patch adds two steps to the upgrade process:
- Handle the pathologic case in which there's a guarantorid and no
'relationship'.
- Performs a cleanup on the relevant columns when the guarantor data
contains a guarantorid, and is then migrated into the
borrower_relationships table. The original code left the information
in the borrowers table, so no clear separation between guarantors as
patrons and the virtual ones.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3bff8a17eaf96c10b1b30babd0271f0eb2bc4fc0
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Aug 16 14:43:42 2019 -0300
Bug 14570: (QA follow-up) Fix tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b4b95b97263f858f6dd19e71c26e0c5ba841e607
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 12 17:14:22 2019 -0300
Bug 14570: (QA follow-up) Consistency displaying the list of guarantors
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3ab5d3b1253f255c8d06988e4a54054c811c19d3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 12 16:43:14 2019 -0300
Bug 14570: Remove wrong parameter in add_guarantor call
This patch just removes an unused parameter.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 540136bb470ec66bff45881e97f51897bee731d8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 12 16:13:25 2019 -0300
Bug 14570: Add error handling to Koha::Patron::Relationship->store
This patch adds checks on the values for the 'relationship'. This is
done to avoid future problems when migrating relationships from the
plain text syspref into (why not) a proper table. And to preserve
consistency.
There's also catching on possible broken constraints and throwing a new
exception
Tests are added for both the new exceptions and the changes to
Koha::Patron::Relationship.
To test:
- Apply this patches
- Run:
$ kshell
k$ prove t/Koha/Exceptions.t \
t/db_dependent/Koha/Patron.t \
t/db_dependent/Koha/Patron/Relationship.t
=> SUCCESS: Tests pass!
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit abb801ebbc986b40573ecfb3d7ce3093dd67f803
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Aug 13 13:28:26 2019 -0300
Bug 14570: Add a UNIQUE constraint on guarantor_id+guarantee_id
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5d2a082647caf2f163bd9a895145a3994172f797
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Aug 12 14:21:07 2019 -0400
Bug 14570: (QA follow-up) Fix issues in Guarantor context
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f827064badfa261d6123752ec4aebd8c4378677e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Aug 12 14:14:39 2019 -0400
Bug 14570: (QA follow-up) Fix issues in Guarantee context
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 200352183824011c5435cd12368944c3a678e889
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri May 17 08:15:08 2019 -0400
Bug 14570: Update schema files [Do Not Push]
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7e591e9cb6c5e7711ff9811ebf0cfc9e8c5449a5
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Wed Jul 3 14:36:00 2019 -0300
Bug 14570: (follow-up) Fix patron type when "add child" button is pressed
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a17245a52e1b11dfef9808a1a88731c63814efb9
Author: Liz Rea <wizzyrea at gmail.com>
Date: Tue May 21 19:08:39 2019 -0500
Bug 14570: (QA follow-up) fix sample borrowers, remove guarantorid)
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 89bd7872e357e029daee685b078170781ef42ba3
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Tue May 21 00:07:47 2019 -0300
Bug 14570: (follow-up) Fix tests
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 53b3ebe9d0b359ac88671ed489afc49ab65d2520
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Fri May 17 21:38:37 2019 -0300
Bug 14570: (follow-up) fix qa FAIL tests
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c8ff1e4701854ab74b6f85fd4ff02592f8205bf6
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Fri May 17 21:10:02 2019 -0300
Bug 14570: (follow-up) fix table name in j2a.pl
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 109334102fbb29c60fa9a7a762c5e68f4b2ce0be
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon May 2 15:00:39 2016 +0000
Bug 14570: Make it possible to add multiple guarantors to a record
This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Find some patrons with guarantors, verify the still have their guarantor
4) Test adding and removing guarantors on a patron record, both Koha users and not
5) Verify the "Add child" button works
6) Verify NoIssuesChargeGuarantees still works
7) Verify tools/cleanborrowers.pl will not delete a guarantor
8) Verify the guarantors are displayed on moremember.pl
9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship, contactfirstname,
and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t
Signed-off-by: Kim Peine <kmpeine at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth_with_ldap.pm | 1 -
C4/Circulation.pm | 2 +-
C4/Members.pm | 14 +-
C4/SIP/ILS/Patron.pm | 1 -
Koha.pm | 2 +-
Koha/Exceptions/Patron/Relationship.pm | 89 +++++
Koha/Object.pm | 5 +-
Koha/Patron.pm | 120 ++++--
Koha/Patron/Relationship.pm | 108 ++++++
Koha/Patron/Relationships.pm | 101 +++++
Koha/Patrons.pm | 16 +-
Koha/Patrons/Import.pm | 16 +
Koha/REST/V1/Auth.pm | 2 +-
Koha/Schema/Result/Borrower.pm | 47 ++-
Koha/Schema/Result/BorrowerModification.pm | 11 +-
...temsLastBorrower.pm => BorrowerRelationship.pm} | 71 ++--
Koha/Schema/Result/Deletedborrower.pm | 11 +-
about.pl | 46 +++
api/v1/swagger/definitions/patron.json | 4 -
circ/circulation.pl | 16 +-
.../data/mysql/en/optional/sample_patrons.sql | 102 ++---
installer/data/mysql/kohastructure.sql | 20 +-
installer/data/mysql/updatedatabase.pl | 68 ++++
koha-tmpl/intranet-tmpl/prog/en/columns.def | 1 -
.../prog/en/includes/members-toolbar.inc | 13 +-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 19 +-
.../prog/en/modules/circ/circulation.tt | 2 +-
.../prog/en/modules/members/memberentrygen.tt | 402 +++++++++++---------
.../prog/en/modules/members/moremember-brief.tt | 24 +-
.../prog/en/modules/members/moremember.tt | 21 +-
koha-tmpl/intranet-tmpl/prog/js/members.js | 104 ++---
.../bootstrap/en/modules/opac-memberentry.tt | 11 +-
.../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 9 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 8 +-
members/deletemem.pl | 6 +-
members/memberentry.pl | 116 +++---
members/moremember.pl | 28 +-
members/update-child.pl | 18 +-
misc/cronjobs/j2a.pl | 76 +++-
opac/opac-memberentry.pl | 4 +-
opac/opac-user.pl | 15 +-
t/Koha/Exceptions.t | 48 ++-
t/Patron.t | 24 +-
.../Circulation/NoIssuesChargeGuarantees.t | 26 +-
t/db_dependent/Items.t | 8 +-
t/db_dependent/Koha/Patron.t | 74 ++++
t/db_dependent/Koha/Patron/Relationship.t | 111 ++++++
t/db_dependent/Koha/Patrons.t | 152 ++++++--
t/db_dependent/Members.t | 20 +-
t/db_dependent/Patron/Relationships.t | 167 ++++++++
tools/import_borrowers.pl | 1 +
51 files changed, 1751 insertions(+), 630 deletions(-)
create mode 100644 Koha/Exceptions/Patron/Relationship.pm
create mode 100644 Koha/Patron/Relationship.pm
create mode 100644 Koha/Patron/Relationships.pm
copy Koha/Schema/Result/{ItemsLastBorrower.pm => BorrowerRelationship.pm} (52%)
create mode 100644 t/db_dependent/Koha/Patron.t
create mode 100644 t/db_dependent/Koha/Patron/Relationship.t
create mode 100755 t/db_dependent/Patron/Relationships.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list