[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.00-14-g0e21de1

Mon Dec 16 22:23:36 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  0e21de15d61999183ea17624465ab0bc1a6c867e (commit)
       via  7a9d8937f753685471dfde7a62c5871062d41a11 (commit)
       via  98a2090a0e2abd64d7d4c38c5f1f811cb91e5b99 (commit)
       via  7c5a0759acf5f5a5a51e54f69d65067b6f22a0c5 (commit)
       via  54e114833260055cd2b0131bc0548f80a5d7ff29 (commit)
      from  529cd43b68863a2b8d09e410b62808d3d81a0a77 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0e21de15d61999183ea17624465ab0bc1a6c867e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jul 1 14:13:15 2019 -0300

    Bug 23246: (follow-up) Hardcoding tab position is not enough

    There are many conditions that determine the tab number for 'media'.
    Translated into variables that hold the tabs count on each condition, it
    is clear that '3' was not good enough:
                [%- holdings      = (SeparateHoldings)   ? 2 : 1
                    notes         = (MARCNOTES || notes) ? 1 : 0
                    acq           = (Koha.Preference('AcquisitionDetails')) ? 1 : 0
                    frbr          = (FRBRizeEditions  && XISBNS) ? 1 : 0
                    local_covers  = (LocalCoverImages && (localimages || CAN_user_tools_upload_local_cover_images)) ? 1 : 0
                    media_tab     = holdings + notes + acq + frbr + local_covers
                -%]

    This patch gets rid of the hardcoded value, adds an id to the 'media'
    tab (i.e. 'media_tab') and uses JS to get the right index.

    To test:
    - Play with the different options governing those variables
    => FAIL: 3 is not always the 'media' tab
    - Apply this patch
    - Repeat your tests
    => SUCCESS: It always picks the 'media' tab
    - Sign off :-D

    Sponsored-by: American Numismatics Society
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 7a9d8937f753685471dfde7a62c5871062d41a11
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jul 1 13:16:42 2019 -0300

    Bug 23246: Only jump into the 'images' tab HTML5MediaEnabled is set

    This patch makes jumping into the third tab happen only if
    HTML5MediaEnabled is set to 'both' or 'staff'.

    To test:
    - Have HTML5MediaEnabled set to 'opac' or 'not at all'
    - Open the detail page of a record with no holdings
    => FAIL: The 'images' tab is selected
    - Apply this patch
    - Reload
    => SUCCESS: The 'holdings' tab is selected as it should be.
    - Sign off :-D

    Sponsored-by: America Numismatic Society
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 98a2090a0e2abd64d7d4c38c5f1f811cb91e5b99
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Nov 26 17:31:15 2019 +0000

    Bug 24126: Article requests tab appears twice on patron's checkout screen

    This patch removes duplicated markup on the checkout page which results
    in the "Article requests" tab appearing twice.

    To test, apply the patch and enable ArticleRequests.

    Check out to a patron. In the set of tabs that includes checkouts,
    holds, restrictions, etc., the "Article requests" tab should appear only
    once.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 7c5a0759acf5f5a5a51e54f69d65067b6f22a0c5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 20 10:56:24 2019 +0100

    Bug 23987: "return to cataloguing" if the record is deleted from bachMod-del

    If a bibliographic record is deleted after having deleted all their items in a batch,
    we should not display a "return to the record" button but "return to cataloguing" instead

    Test plan:
    1 - Have/make a bib with items
    2 - On details page select Edit->Delete items in a batch
    3 - Select all items and check "Delete record if no items remain"
    4 - Delete the things
    5 - On confirmation screen you have a count of items/bibs deleted
    => Without the patch there is a 'Return to record' button that leads to nowhere
    => With this patch there is a "Return to cataloging module" button
    6 - Repeat using the "Delete selected items" link on top of the items table
    => Without the patch there is a 'Return to where you were' button that leads to nowhere
    => With this patch there is a "Return to cataloging module" button

    Note that there is a link AND a button, coming from
      commit 928c0af2b6a2c7aa6ed54019c5bd7dbddbccf4ee
      Bug 15824 - 'Done' button is unclear on batch item modification and deletion
    I do not think it makes sense to have both.

    Signed-off-by: George Williams <george at nekls.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit 54e114833260055cd2b0131bc0548f80a5d7ff29
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 20 10:53:32 2019 +0100

    Bug 23987: Use src=CATALOGUING for edition/deletion in batch from items table

    There are 2 ways to land in batchMod from the detail page of a bib
    record: from the Edit menu, and the action buttons on top of the items
    table.

    We want the same behavior for both and so use src=CATALOGUING
    It will make batchMod to behave identically for the "return" button

    Signed-off-by: George Williams <george at nekls.org>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/catalogue/detail.tt              |   12 ++++++------
 .../prog/en/modules/circ/circulation.tt              |    6 ------
 .../prog/en/modules/tools/batchMod-del.tt            |   12 ++++++++++--
 tools/batchMod.pl                                    |   18 ++++++++++++------
 4 files changed, 28 insertions(+), 20 deletions(-)

hooks/post-receive
-- 
main Koha release repository