[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.11-5-gcbe5837

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  cbe5837f6cbbe8c5c86eadb19b288d72e7107c76 (commit)
       via  7439bdab199527ebf356a351080191ed2fc58bcb (commit)
      from  807a1a8c1280f91747f2ad6f4598478420aaefbe (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cbe5837f6cbbe8c5c86eadb19b288d72e7107c76
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Dec 10 11:22:59 2019 +0100

    Bug 24199: (bug 23042 follow-up) Prevent t/Auth_with_shibboleth.t to fail randomly
    
    CGI->url_param does not always return the parameters in the same order.
    
    Test plan:
    0/ Recreate the random failure, does not apply the patch and run
    t/Auth_with_shibboleth.t several times.
    You will notice that it fails inconsistenly
    1/ Apply the patch and confirm that it now passes 100% of the time
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit b022b37db75e468cc56f3189b2f284f03e81ca2d)
    (cherry picked from commit 62875f2b40c2608ddc2447d2a72f89d225b7c88c)

commit 7439bdab199527ebf356a351080191ed2fc58bcb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Dec 2 17:50:40 2019 +0100

    Bug 24145: (bug 22543 follow-up) Fix Auth.t
    
    Auth.t is failing because of: 1. recent changes from bug 22543 and 2. wrong mocked CGI->param in tests
    Without this patch we hit the exit statement that breaks the tests with the following error:
    
    t/db_dependent/Auth.t .. 1/22 Un-mocked method 'url()' called at /kohadevbox/koha/C4/Auth.pm line 1223.
    Un-mocked method 'redirect()' called at /kohadevbox/koha/C4/Auth.pm line 1227.
    A context appears to have been destroyed without first calling release().
    Based on $@ it does not look like an exception was thrown (this is not always
    a reliable test)
    
    This is a problem because the global error variables ($!, $@, and $?) will
    not be restored. In addition some release callbacks will not work properly from
    inside a DESTROY method.
    
    Here are the context creation details, just in case a tool forgot to call
    release():
      File: t/db_dependent/Auth.t
      Line: 74
      Tool: Test::More::subtest
    
    Cleaning up the CONTEXT stack...
        # Looks like you planned 22 tests but ran 1.
    t/db_dependent/Auth.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
    Failed 21/22 subtests
    
    Test Summary Report
    -------------------
    t/db_dependent/Auth.t (Wstat: 65280 Tests: 1 Failed: 0)
      Non-zero exit status: 255
      Parse errors: Bad plan.  You planned 22 tests but ran 1.
    Files=1, Tests=1,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.54 cusr  0.24 csys =  1.80 CPU)
    Result: FAIL
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    (cherry picked from commit 678b4bf4642852aba0d11af0ba826164ffdfd012)
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    (cherry picked from commit f7851500a9f44a4e5f5096f3f74ec9dba9c6991c)

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth_with_shibboleth.pm |    2 +-
 t/db_dependent/Auth.t      |   10 ++++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository