[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.00-39-g798cc76

Git repo owner gitmaster at git.koha-community.org
Fri Dec 20 18:11:47 CET 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.11.x has been updated
       via  798cc769fe25478ed41fa50cd41fd3a90c0a4a24 (commit)
       via  c383cf2fa5bece671d3654ed5b16eae7b354187f (commit)
      from  7e86f5ef5df3ccda95df36d1e746469a06cd87e9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 798cc769fe25478ed41fa50cd41fd3a90c0a4a24
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Nov 22 16:47:45 2019 +0000

    Bug 13806: Sanitize inputs where creating Reports subgroup
    
    This patch adds validation of report group and subgroup inputs so that
    the user can't enter data into only one half of the group code/name
    pair.
    
    To test, apply the patch and go to Reports -> Use saved.
    
      - Create or edit a report which doesn't have a group or subgroup
        assigned.
    
      - Under "Report group," select the "or create" radio button.
    
      - Click the "Update SQL" button to submit the form without entering a
        group code or name. The form should require taht you enter data into
        both fields.
    
      - Enter data into the report group code and name fields. Add data to
        either the code or data field under "Report subgroup." You should
        not be able to submit the form without populating both.
    
      - Start over editing a report which doesn't have a group or subgroup
        assigned.
    
        - Select an existing group under "Report group."
    
        - Under "Report subgroup," select the "or create" option.
    
          - You should not be able to submit the form without adding data in
            both the code and name fields for the report subgroup.
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

commit c383cf2fa5bece671d3654ed5b16eae7b354187f
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Dec 13 07:01:23 2019 +0100

    Bug 24230: fix intranet_js plugin hook before body end tag
    
    The plugin hook intranet_js is after body tag in intranet-bottom.inc :
        </body>
    [% KohaPlugins.get_plugins_intranet_js | $raw %]
    </html>
    
    It must be before like in opac-bottom.inc
    
    Test plan :
    1) Install a Koha plugin with intranet_js hook, like KitechenSink
    2) Go to an intranet page
    3) Look at source of the page to see plugin code is before body end tag
    
    Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/includes/intranet-bottom.inc           |    2 +-
 .../en/modules/reports/guided_reports_start.tt     |   80 ++++++++++++++++----
 2 files changed, 66 insertions(+), 16 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list