[koha-commits] main Koha release repository branch master updated. v19.11.00-82-ge28f986

Mon Dec 23 12:33:17 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  e28f9861a94dc0428832cc15511d97cb9c51cfad (commit)
       via  92c6d3511ee42d9040fd8c4cda1fc1661024b075 (commit)
       via  8112e2a6361af871cada25c328ab9c04c0796fb7 (commit)
       via  3c222cf569c3b7d236c93df92696548a8bb8e1c5 (commit)
       via  d2bdccdb64b950114ae485970d85ec9e6598d0b5 (commit)
       via  09aa99391f0111f06f29b5cfb65ccfec2f1f538f (commit)
       via  c3a1a6b9ad0bcec770293f437b1bf594a2314801 (commit)
      from  5432cbd92a85513e68f65fede2b4d31f078f1cfa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e28f9861a94dc0428832cc15511d97cb9c51cfad
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun Dec 15 12:32:34 2019 +0100

    Bug 24242: Display funds that the logged in user can access - suggestions

    The design of this script is pretty bad and any modifications is a
    challenge.
    Here we are trying to display to display the funds available for the
    logged in user. I did not understand previous code, as we are doing a
    limit using CanUserUseBudget, I do not think it makes sense to retrieve
    funds for a given library.
    Also, I am wondering if the dropdown list in the filters has ever been
    populated: budgetid_loop in the template *never* appeared in the history
    of suggestion.pl (??)

    Test plan:
    Search for suggestions
    Add/edit suggestions
    => The funds in the dropdown list should be the ones the logged in user
    can use.

    Signed-off-by: hc <hc at interleaf.ie>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 92c6d3511ee42d9040fd8c4cda1fc1661024b075
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Dec 13 12:41:20 2019 +0100

    Bug 21232: Add a client-side check on biblionumber when creating a subscription

    This patch adds an AJAX call to the REST API (/api/v1/biblios/) to
    retrieve and display the biblio's title.
    On clicking the "next" button a check is done to make sure the title
    exists, which means the biblionumber we manually entered is valid (can
    we assume a title is mandatory?)

    Test plan:
    - Create or edit a new subscription
    - Enter an invalid biblionumber in the input
    => A friendly note is telling you that the biblio does not exist
    - Try to switch to the next screen
    => You get an alert
    - Enter a valid biblionumber in the input
    => The title is displayed
    => Try to switch to the next screen
    => It works!

    Signed-off-by: hc <hc at interleaf.ie>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8112e2a6361af871cada25c328ab9c04c0796fb7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun Dec 15 12:53:06 2019 +0100

    Bug 24243: Do not explode if invalid metadata when searching catalogue

    If the bibliographic record metadata cannot be decoded, the get_coins
    call should catch the exception raised by Koha::Biblio::Metadata->record
    to not explode

    Error is: "Invalid data, cannot decode objec"

    Test plan:
    0/ Do not apply the patch
    1/ Search for record at the OPAC
    2/ Note one of the biblionumber from the first page result
    3/ Set to empty string the biblio_metadata to make the error appears:
      update biblio_metadata set metadata="" where biblionumber=42;
    4/ Try the same search
    => You get an internal server error
    5/ Apply the patch, restart plack and try again
    => It now works, ie. it does not explode

    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3c222cf569c3b7d236c93df92696548a8bb8e1c5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Dec 17 14:57:58 2019 +0100

    Bug 24175: Simplify tests

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d2bdccdb64b950114ae485970d85ec9e6598d0b5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Dec 17 14:23:16 2019 +0100

    Bug 24175: Take advantage of Koha::Item->holds

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 09aa99391f0111f06f29b5cfb65ccfec2f1f538f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Dec 4 18:50:41 2019 +0000

    Bug 24175: Use itemnumber when searching for holds in SIP drop_hold

    To test:
    1 - place a hold for a patron
    2 - Get SIP running
        https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
    3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-'
    4 - Attempt to cancel hold
    5 - It fails
    6 - Apply patch
    7 - Try again
    8 - It succeeds

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c3a1a6b9ad0bcec770293f437b1bf594a2314801
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Dec 4 18:38:22 2019 +0000

    Bug 24175: Unit tests

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/SIP/ILS/Transaction/Hold.pm                     |    9 +---
 .../prog/en/modules/serials/subscription-add.tt    |    1 +
 .../prog/en/modules/suggestion/suggestion.tt       |    4 +-
 .../intranet-tmpl/prog/js/subscription-add.js      |   30 +++++++++++-
 opac/opac-search.pl                                |    3 +-
 suggestion/suggestion.pl                           |    9 +---
 t/db_dependent/SIP/Transaction.t                   |   50 +++++++++++++++++++-
 7 files changed, 85 insertions(+), 21 deletions(-)

hooks/post-receive
-- 
main Koha release repository