[koha-commits] main Koha release repository branch master updated. v19.11.00-97-gb6937d7
Git repo owner
gitmaster at git.koha-community.org
Mon Dec 23 13:35:40 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via b6937d790e8224b3e1b61d72f5a24ec7ce83311e (commit)
via f50106a605b59570e03a601034387505a7a0c525 (commit)
via 2c9d7079b282e77413a08c4cfd9c72aa60279830 (commit)
via 15db14d62f9a5e830c6ed9b6c27658b203cf0933 (commit)
via 5c5f8ecfed387cef647dcc9d37b8bca1eac7480c (commit)
via 58a36dd18612b0d6c1734992937f8e9fd40f510f (commit)
via f93e5bc59ace4696ca721be116f029b07506a673 (commit)
via 83749931604043f3321820c8584dc53c09c36430 (commit)
via dbf4b49ae9685f12c994f92c3d17eeac400aa0ff (commit)
via 3d662f087772d3d71c56a237aa8c7e111e6808fd (commit)
via 6e3e8fef6ac203fc1fbe6666af92f0694570496e (commit)
via 61ca2359f276e04c554ea7020fe2298e65eff249 (commit)
from 403763679a3f2ec7c19fbae0813a1012c22b75ed (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b6937d790e8224b3e1b61d72f5a24ec7ce83311e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Dec 16 11:45:51 2019 +0000
Bug 7047: (QA follow-up) Fix tests
Tests fail on biblionumber constraint for suggestions if 'RenewSerialAddsSuggestion' is enabled
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f50106a605b59570e03a601034387505a7a0c525
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Dec 16 11:22:58 2019 +0000
Bug 7047: (QA follow-up) Add missing filters
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2c9d7079b282e77413a08c4cfd9c72aa60279830
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 16 11:55:48 2019 +0100
Bug 7047: Revert changes relative to the new column on suggestion list
We should move that to its own bug report if needed, not sure we will
all agree on that new column.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 15db14d62f9a5e830c6ed9b6c27658b203cf0933
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 16 11:54:05 2019 +0100
Bug 7047: Change ReNewSubscription prototype - use hashref
It also removes a warn statement.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5c5f8ecfed387cef647dcc9d37b8bca1eac7480c
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Mon Dec 4 13:35:01 2017 +1300
Bug 7047: Storing subscription renewal note in suggestion to be displayed on the suggestion page.
Additionally I have added a library input field in case the librarian wants to set a library branch whilst renewing a subscription. With the use case being they may have ommitted to set the branchcode whilst creating the subscription.
Test plan:
1. Create a subscription (if one does not already exist)
2. Set the RenewSerialAddsSuggestion syspref to 'Add'
3. Renew the item making sure to write in a value into the note field
3. Visit the suggestions page and notice that the note is not displayed
for the newly created suggestion
4. Apply patch
5. Repeat step 3. Notice that there is now a new branchcode dropdown
box. Select one of your libraries and write in the value into the note
field
6. Visit suggestions and notice there is now a 'Suggestion note' column
in the table containing the note.
Also note that the suggestion has the correct branchcode associated with
it
Sponsored-By: Catalyst IT
Signed-off-by: Maksim Sen <maksim at inlibro.com>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 58a36dd18612b0d6c1734992937f8e9fd40f510f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 18 11:09:51 2019 +0100
Bug 24166: Do not hang when displaying checkout list if barcode is not set
If a barcode is not set, there is a JS error in the log:
TypeError: oObj.barcode is null
We should not call escapeHtml() on it if not barcode is set for a given
item.
Test plan:
Check an item out
Remove its barcode
Load the checkout list
=> Without this patch you get the "loading" popup and the table is never
displayed
=> With this patch applied you see the checkout list
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f93e5bc59ace4696ca721be116f029b07506a673
Author: Pedro Amorim <pjamorim91 at gmail.com>
Date: Wed Dec 11 10:28:34 2019 -0100
Bug 24121: Item types icons in intra search results are requesting icons from opac images path
When searching in INTRA you'll notice the item type icons not showing.
To test:
1) Set syspref item-level_itypes to biblio
2) Confirm that there is a biblioitems.itemtype mapping to a MARC field
3) Verify that item type icons are set for all the types
4) Perform a search where biblios with said MARC field is filled with a type value
5) Verify that where the icon should appear, it's showing the browser icon for image not found
6) Apply patch.
7) Repeat step 4.
8) Observe the icons are now displayed correctly
Sponsored-by: Governo Regional dos Açores
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 83749931604043f3321820c8584dc53c09c36430
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Dec 19 09:47:44 2019 +0000
Bug 24274: Remove field 01e from sql installer files
Field 01e comes from an older utility (RLIN) and does not belong here.
Note: It is the only non-numeric field tag in Koha. And it seems to be
an violation of the MARC standard.
Test plan:
Run a new install and check the bibliographic frameworks.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dbf4b49ae9685f12c994f92c3d17eeac400aa0ff
Author: Maryse Simard <maryse.simard at inlibro.com>
Date: Fri Dec 20 09:03:39 2019 -0500
Bug 24281: Fix the list of types of visual materials
In the MARC21 XSLT files for results in both staff and OPAC, the
type of visual material for code "g" is "legal article" instead
of "game". This patch change the value to "game".
To test:
0. Set up:
- have a MARC21 database
- use default XSLT file for display of results :
OPACXSLTResultsDisplay : default
XSLTResultsDisplay : defaul
- If needed, catalog a game. In the 008 tag editor :
Type of Material : VM - Visual Materials
33 - Type of visual material : g - Game
1. On both staff and OPAC, make a search which returns results
including visual materials of type game (the title catalogued
in previous step).
2. Note that in the list of results, the label "Type of visual
material" is followed by "legal article".
3. Apply patch.
4. Repeat step 1.
5. Note "legal article" has been replaced by "game".
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3d662f087772d3d71c56a237aa8c7e111e6808fd
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Dec 20 11:29:39 2019 +0000
Bug 24283: (bug 21446 follow-up) close strong and add missing parens
To Test:
1) Create a course in course reserves, make it inactive
2) Add an item to it, changing item type and location
3) Make the course enabled
4) Note that the normal item type is no longer bold and has both opening and closing parentheses; Note that the normal location is also not bold and has both opening and closing parentheses.
5) Disable the course
6) Note that the normal item type is in bold with an opening parentheses but no closing parentheses; Note that the normal location is in bold with both opening and closing parentheses.
7) Apply patch
8) Note view is fixed
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6e3e8fef6ac203fc1fbe6666af92f0694570496e
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Mon Dec 9 20:41:45 2019 -0300
Bug 18688: Warnings about UTF-8 charset when creating a new language
This patch removes some warnings when creating new languages,
those related with uft8 and two not related.
Tipical messages are:
>Warning: Can't determine original templates' charset, defaulting to UTF-8
>Warning: Charset Out defaulting to UTF-8
>...
>Removing empty file /../xx-YY-marc-NORMARC.po
>I UTF-8 O UTF-8 at /../kohaclone/misc/translator/tmpl_process3.pl line 365.
>Use of uninitialized value $pref_name in concatenation (.) or string at /.../misc/translator/LangInstaller.pm line 197.
>Created /../misc/translator/po/xx-YY-messages.po.
First four are 'normal' messages
The fifth one correspond to an unquoted preference string
The sixth one is a normal output message from msgint command
We will hide them unless verbose '-v' option is selected,
and fix the error.
To test:
1) Go to misc/translator
2) Create new language files
$ perl translate create xx-YY
3) Check warnings and messages
4) Apply the patch
5) Remove created files, and create them again
Ther must be no messages
6) Repeat 5) with verbose option '-v', check
old messages
7) BONUS: without the patch update a language,
for example de-DE:
$ perl translate update de-DE
Note (git status) a new file, po/de-DE-messages.po~
This is a backup file from msgmerge command
With the patch this backup is removed.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 61ca2359f276e04c554ea7020fe2298e65eff249
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Nov 22 14:42:56 2019 +0000
Bug 11500: Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages)
This patch modifies the cataloging plugin dateaccessioned.pl so that it
triggers the addition of a datepicker widget to fields it is linked
with. Despite its name the plugin can be used on any item field which
requires a date.
To test, apply the patch and make sure you have one or more item
subfields linked to the dateaccessioned.pl plugin. For instance, in
MARC21:
- Administration -> MARC bibliographic framework -> MARC structure ->
952 -> Edit subfields:
- subfields d ("Date acquired") and w ("Price effective from"):
- Other options -> Plugin -> dateaccessioned.pl
- Go to cataloging and add or edit an item on a bibliographic record
- The "Date acquired" and "Price effective from" fields should be
styled as datepickers.
- Clicking in these fields should populate the field with today's date
and trigger the datepicker popup.
- Test that all the datepicker features work correctly.
- Test that manual entry of a date works.
- With the AcqCreateItem system preference set to "placing an order,"
go to Acquisitions -> Vendor -> Add to basket.
- Add a title to your basket using your preferred method.
- In the "New order" form, find the section for adding an item.
- Test the "Date acquired" and "Price effective from" fields, which
should behave just like they did in the cataloging module.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Search.pm | 2 +-
C4/Serials.pm | 20 +++++++++++---
cataloguing/value_builder/dateaccessioned.pl | 11 +++++++-
.../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 --
.../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 --
.../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 --
.../Obligatoire/marc21_framework_DEFAULT.sql | 2 --
.../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 --
.../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 --
.../marc21/mandatory/marc21_framework_DEFAULT.sql | 1 -
.../marc21_bibliographic_DEFAULT_general.sql | 6 +---
.../marc21_bibliographic_DEFAULT_general.sql | 7 ++---
.../prog/en/modules/acqui/neworderempty.tt | 1 +
.../prog/en/modules/acqui/newordersubscription.tt | 1 +
.../prog/en/modules/acqui/newordersuggestion.tt | 1 +
.../admin/preferences/enhanced_content.pref | 2 +-
.../prog/en/modules/cataloguing/additem.tt | 1 +
.../en/modules/course_reserves/course-details.tt | 2 +-
.../prog/en/modules/serials/subscription-renew.tt | 14 ++++++++++
.../prog/en/xslt/MARC21slim2intranetResults.xsl | 2 +-
koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 4 +--
.../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 2 +-
misc/translator/LangInstaller.pm | 5 ++--
misc/translator/tmpl_process3.pl | 8 +++---
serials/subscription-renew.pl | 29 +++++++++++++++-----
suggestion/suggestion.pl | 1 -
t/db_dependent/Serials/ReNewSubscription.t | 14 ++++++++--
27 files changed, 94 insertions(+), 52 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list