[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.02-98-g491ad8f

Mon Feb 4 12:30:21 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  491ad8fc3389be9db46eb8d42f03f78befd69e66 (commit)
       via  87d59cfb7d5a44524bc626ad41323eef5e2d293a (commit)
       via  b1af157152c459b2094d2d2f9290ff49ee67116d (commit)
       via  2e4883bdc57f0acd23435abed983dfccccf96f98 (commit)
       via  c139076372ccc8dc286a060fc0c392aba8d9c94b (commit)
       via  0582bd25d885f49073bc4c84e087f1cfc5354287 (commit)
      from  574c89ef49fdb573d89cca4b28a74a65adb18132 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 491ad8fc3389be9db46eb8d42f03f78befd69e66
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 19 08:22:20 2018 -0300

    Bug 21610: Improve default values for dates

    This patch fixes failures on t/db_dependent/Koha/Patrons/Import.t
    and keep t/Auth_with_shibboleth.t and t/db_dependent/Koha/Object.t green

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 766eaa0df45f04523737a8f04b045122b3e11b18)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 87d59cfb7d5a44524bc626ad41323eef5e2d293a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 19 12:14:20 2018 +0200

    Bug 21610: (follow-up) Default value for dates

    We have some dates with DEFAULT CURRENT_TIMESTAMP and some dates with
    default and UPDATE clause.

    Test plan:
    Run Object.t again.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0ee4e9e14fe461e72806491c819f4c033f95f13b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b1af157152c459b2094d2d2f9290ff49ee67116d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 19 11:05:50 2018 +0200

    Bug 21610: (QA follow-up) Better use columns_info from DBIx

    We should better use the published method than a private hash key.
    And shorter to go via _result than adding a new schema call.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8625eefc76a9390e28e9136f19b9767814bc27a5)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2e4883bdc57f0acd23435abed983dfccccf96f98
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 18 18:55:44 2018 -0300

    Bug 21610: Fix integers and dates values at Koha::Object->store level

    With strict SQL modes, we are facing several issues when objects are stored.

    The following errors can be raised by DBIx::Class when an object does not have
    a valid (as defined at DB level) value:
    - Incorrect integer value: '' for column COLUMN
    - Incorrect decimal value: '' for column COLUMN
    - Column 'COLUMN' cannot be null
    - Field 'COLUMN' doesn't have a default value
    - Incorrect date value: '' for column 'COLUMN'

    We already handled some of them for Koha::Patron. As we do not want to provide such
    changes for all Koha::* modules we are going to fix this at Koha::Object->store level
    in order to provide a global fix.

    This is related to bug 21599 (for item types) and bug 21596 (for patrons)

    Test plan:
    - Apply first patch, run the tests
    => Patch fail because of the previous error in Koha::ItemType->store, to make them pass
    you can replace
      $self->notforloan(0) unless $self->notforloan;
    with
      $self->notforloan(undef) unless $self->notforloan;
    - Apply second patch, run the tests
    => They fail because of dates and/or integers values
    - Apply third patch, run the tests
    => They now pass

    Deep code review wanted!

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit abb51797d8d5ebb274856e912e207a921ace478b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c139076372ccc8dc286a060fc0c392aba8d9c94b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 18 18:46:30 2018 -0300

    Bug 21610: Remove specific changes we made previously

    We handled integers and dates for Koha::Patron and Koha::ItemType, we
    want now Koha::Object to deal with.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit bc30f84e583959a8c9f4b77db5b8a24ef24e04dd)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0582bd25d885f49073bc4c84e087f1cfc5354287
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 18 18:38:18 2018 -0300

    Bug 21610: Add tests

    Adding few tests to Koha/Object.t in order to highlight what we are
    trying to fix.

    Note that Koha::ItemType->store was wrong for notforloan, the default
    value should be null
        `notforloan` smallint(6) DEFAULT NULL,
    but the previous fix (bug 21599) made it default to '0'

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9330deee558f553c357edf8eb1aa96bd40563087)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/ItemType.pm             |   12 ------------
 Koha/Object.pm               |   41 +++++++++++++++++++++++++++++++++++++++++
 Koha/Patron.pm               |   31 -------------------------------
 t/db_dependent/Koha/Object.t |   41 ++++++++++++++++++++++++++++++++++++++++-
 4 files changed, 81 insertions(+), 44 deletions(-)

hooks/post-receive
-- 
main Koha release repository