[koha-commits] main Koha release repository branch master updated. v18.11.00-404-gdf611b1
Git repo owner
gitmaster at git.koha-community.org
Mon Feb 4 18:53:05 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via df611b17d12b63bb2f14909969ff8e8f67a332d0 (commit)
via 98798a6be8ddcca981c8cc21a2ce381c9a0af49e (commit)
via 20a38ee50e6fe62712e299bcec9e939dc2bbb58e (commit)
via b4c9058b871b17a20f08a52875582c617bfd91d9 (commit)
via 0c53a07a829299067186cd5c5dfbc74eec9fac8d (commit)
via 85d09997c988c9acc7e00c3a128002c83e044ca0 (commit)
via ee94197482ccd68ba88e3fce33eb3029f4e88f6f (commit)
via ba1f33e6ae69e9e1e499b5fedee299211580469f (commit)
via dd7daf493b50c019cd8b7737e42536567ebdc694 (commit)
via aa3294ae579a49c7279c89aef475b0134426a943 (commit)
via 5189a42588209ae3e2d34dfbe5ae6e3a451bdb73 (commit)
via 268a1248a39ce2cbf641e9161932e4b060d71225 (commit)
via 12e331d14890569eaca1f0a7a4948641be4bbd18 (commit)
via 2578b9469141a4f0c7f24b4fd5743fa2ce4fbca2 (commit)
via 24ffe470ffbe17318ae16f2beb3a2dd488ef00b5 (commit)
via 6179f23dd8b4ed24add2e76c7b8e193372052201 (commit)
via b3c25b64b868b56423c50b9df4fac4bb55947679 (commit)
via 9caede8d3ce67c684afd615b93ae2eb3dd5991bb (commit)
via 7f918ed8b1deed69609850800675e704da4cbf68 (commit)
via e142e85d65f91a58a7aefbab3560d59f92134c2f (commit)
via 1575d339629e68902ad9a92565f4b331e8c04d79 (commit)
via 081bb2d9bc8ba6bf53c57507a2f6e7bdf0b4fa32 (commit)
via d0a8d0e55a07e07d95474a09b751f23a79fac979 (commit)
via ab9e4ca6a46519ddc69ad76837407c0a4f0ed0cd (commit)
via 7520ede89987a7a65301debdda46950a6364ebfd (commit)
via 1da0ba48b6fdf38cfd3d3ea63ec076b15995610f (commit)
via a32653a66fa02f1fe9002647d337261bf36d62e0 (commit)
via 9961e2c08f8dba0896ed4f6bfa6a7befebd28d5d (commit)
via a8259c38dbe910188ece5126d226166014e001ed (commit)
via d2ce727e260f6b45266a8147aee7654811a44fa1 (commit)
via c345d30cc8284f690f375faa140de49e62358709 (commit)
via 186209875a4951b15faded3f8c47eba71716c7af (commit)
via fb62e8d1fc8b210a5b23801b7b8faff3280bf638 (commit)
via e33bdbd9dae74987869b52fd6df748784657b632 (commit)
via 0904863c7559467ef9a6f5210950c04dcc5ee04e (commit)
via 014baf181cd4b8c74bfeb04d53f418c58e14ebb8 (commit)
via 4b82ed3549fcea3588b1500574a6715d0fe51702 (commit)
via 3ca0234d34ac9708a8335cfa97805fb7498201bf (commit)
via b2dce05ddff8a047e7770ea241b1edd9b798212e (commit)
via 7e69ab62a5ef3fbd350c6606d25b5ab6f6bc168e (commit)
via 0f83ac98c753efbae7e33619be717327a820f2e1 (commit)
from 766eaa0df45f04523737a8f04b045122b3e11b18 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit df611b17d12b63bb2f14909969ff8e8f67a332d0
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date: Sat Sep 29 19:08:47 2018 +0000
Bug 21446: Remove fix comment
Fix is not needed.
Signed-off-by: helene hickey <hickeyhe at wgc.school.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 98798a6be8ddcca981c8cc21a2ce381c9a0af49e
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date: Sat Sep 29 18:09:03 2018 +0000
Bug 21446: Improve display of changed values on course reserves and show permanent location instead of cart
TO TEST:
1) Set ReturnToShelvingCart on.
2) Create a Course Reserve and make inactive.
3) Add an item, changing Item type, Collection code, Shelving
location, and Holding library.
4) Note these four fields in the item list.
5) Activate course reserve.
6) Note subtle/no difference in these fiels in the list.
7) Check in the item.
8) Go back to course reserves and note that the cart is listed in the
field instead of permanent location.
9) Deactivate course reserve.
10) Reset permanent location on item manually.
11) Apply patch.
12) Repeat steps 4-9 noting that the permanent location is showing
instead of current location.
Also, if a change is assigned to the item, the change AND
the regular state always show. The active state will be in
bold.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 20a38ee50e6fe62712e299bcec9e939dc2bbb58e
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Wed Dec 19 20:32:32 2018 +0000
Bug 20000: Use Modern::Perl in installer scripts
To test:
Check that we are using Modern::Perl when strict *and* warnings were used before,
and commented lines and FIXMEs have been removed from the rest, out of
files listed below.
data/mysql/backfill_statistics.pl
data/mysql/labels_upgrade.pl
data/mysql/patroncards_upgrade.pl
data/mysql/update22to30.pl
data/mysql/updatedatabase.pl
externalmodules.pl
html-template-to-template-toolkit.pl
install.pl
Sponsored-by: Catalyst IT
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b4c9058b871b17a20f08a52875582c617bfd91d9
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jan 11 16:05:12 2019 +0000
Bug 11373: (follow-up) Add "change calculation" feature to the fine payment forms
This patch provides some follow-ups, including corrections to the
JavaScript and updates to the text for readability.
- Remove obsolete script "type" attribute
- Update the use of the obsolete jQuery method "bind"
- Use Bootstrap's built-in "show" option instead of simulated click
- Handle preventDoubleFormSubmit function's "waiting" class if modal is
closed manually
To test, apply the patch and follow the original test plan. Everything
should work as expected.
Note that when the modal is shown, the cursor changes to the "waiting"
one when you hover over the body of the page. If you click "No" in the
modal, the cursor should return to normal.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0c53a07a829299067186cd5c5dfbc74eec9fac8d
Author: Frédérick <frederick.capovilla at libeo.com>
Date: Tue Dec 10 16:51:39 2013 -0500
Bug 11373: Show the difference between the amount collected and the amount paid of a fine payment.
This patch adds a feature in the fine payment section. It allows to see the change due to patrons when the amount collected is higher than the amount paid.
Test plan :
- Apply patch.
- Select a patron with a fine.
- Go to Fines > Pay fines.
- Click the button pay.
- Choose the amount paid equal to the outstanding amount (exemple : 3$).
- Choose the amount collected to be more than the outstanding amount (exemple : 5$).
- Confirm that the change is correct (example : 5$ - 3$ = 2$).
- Click the button confirm.
- Click on Yes in the dialog box.
- Confirm that the payment has been made (example : last amount = 3$).
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 85d09997c988c9acc7e00c3a128002c83e044ca0
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Feb 1 14:12:18 2019 +0000
Bug 22195: (follow-up) Add text labels to buttons if window is wide enough
This patch adds responsive handling of text labels to the columns
configuration and export buttons.
To test, apply the patch and clear your browser cache if necessary.
- View a page with column configuration, e.g. Administration -> Patron
categories.
- At wider browser widths the buttons should have text labels.
- At narrower browser widths the labels should be hidden.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ee94197482ccd68ba88e3fce33eb3029f4e88f6f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sat Jan 26 19:20:32 2019 +0000
Bug 22195: (follow-up) Add tooltip to buttons
This patch adds title attributes and Bootstrap tooltips to the columns
configuration and export/print butttons.
To test, apply the patch and visit a page with columns configuration
buttons. Confirm that when you hover over each of the DataTable control
buttons a tooltip is shown.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ba1f33e6ae69e9e1e499b5fedee299211580469f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jan 23 16:40:44 2019 +0000
Bug 22195: Change default DataTables configuration to consolidate buttons
This patch changes the default DataTables configuration provided by the
columns settings include file. It consolidates DataTables buttons into
to menus: One for column configuration and one for export options.
This change would not affect tables which aren't set up for column
configuration.
To test, apply the patch and view a page with columns configuration.
Example: Tools -> Notices & slips
- Confirm that the buttons appear as expected.
- Confirm that each button menu performs its task correctly (column
visiblity, export, print).
- Test other pages with columns configuration. For instance:
Acquisitions order search, Currencies administration, Holds queue
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit dd7daf493b50c019cd8b7737e42536567ebdc694
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Jan 28 18:46:41 2019 +0000
Bug 21850: (follow-up) Add query information in title attribute
This follow-up adds back the old machine-friendly search details to a
title attribute in case it might be useful for debugging purposes.
To test, apply the patch and perform a search in the OPAC. On the search
results page, hover your mouse over the "Results" link in the
breadcrumbs. The title attribute value should appear with the search
details.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit aa3294ae579a49c7279c89aef475b0134426a943
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jan 4 15:26:05 2019 +0000
Bug 21850: Remove search request from page title of OPAC result list
This patch modifies the OPAC search results template so that advanced
search terms are not shown in the page title and breadcrumbs. This
removes potentially confusing computer-oriented code from the public
view.
For simple searches the search term is displayed, using the same logic
that determines whether the search bar should be populated with the last
search term.
To test:
- Apply the patch
- Peform a simple keyword search in the OPAC
- On the results page the title and breadcrumbs should show 'Results
of search for [your keyword]
- Perform an advanced search with multiple parameters
- The page title and breadrumbs should show only 'Search results'
- The breadcrumbs should also show a link back to Advanced search
using the returntosearch parameter
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: mikael <mikael.Olangcay-Brisebois at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5189a42588209ae3e2d34dfbe5ae6e3a451bdb73
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Feb 4 15:54:59 2019 +0000
Bug 20809: Compiled CSS
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 268a1248a39ce2cbf641e9161932e4b060d71225
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Jan 6 00:22:28 2019 +0000
Bug 20809: (QA follow-up) Fix missing filters
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 12e331d14890569eaca1f0a7a4948641be4bbd18
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Sep 14 17:06:31 2018 +0000
Bug 20809: (follow-up) Add missing JS to view log page
If the log viewer is being used to track patron-related data the
patron-related JavaScript file should be included.
To test, apply the patch and open a patron record. In the left-hand
sidebar choose Modification Log. Test the patron image edit/replace
process from the patron image in the sidebar and confirm that it works
correctly.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2578b9469141a4f0c7f24b4fd5743fa2ce4fbca2
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Sep 12 16:33:48 2018 +0000
Bug 20809: (follow-up) Corrections to CSS and JS
This follow-up modifies JavaScript so that the confirmation dialog is
triggered when deleting a patron image from the modal window.
The CSS is modified to improve the alignment of patron image and edit
button.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 24ffe470ffbe17318ae16f2beb3a2dd488ef00b5
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Aug 14 13:04:39 2018 +0000
Bug 20809: Link patron image to patron image add/edit form
This patch modifies an include file so that it is possible with edit a
patron's image on any patron-related page which uses that include.
To test you must have the patronimages system preference enabled.
Apply the patch and open any patron record for viewing.
- Hover the mouse over the patron image.
- If the patron has a previously-defined patron image, should you see
an "Edit" button appear. Clicking the button should display a modal
dialog titled "Edit patron image." Test that the "Upload,"
"Delete," and "Cancel" buttons work correctly.
- If a patron has no patron image defined, you should see an "Add"
button appear. Clicking the button should display a modal
dialog titled "Edit patron image." Test that the "Upload,"
"Delete," and "Cancel" buttons work correctly.
This process should work from any page which shows the patron sidebar:
Check out, Details, Fines, Routing lists, Circulation history, etc.
Patch works as described.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6179f23dd8b4ed24add2e76c7b8e193372052201
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Nov 12 11:48:23 2018 +0100
Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code
The test should check $4 or $e for fields ne 111,711.
And should check $4 or $j for 111,711.
Test plan:
Edit a record, add a meeting in 711 without $4 but with $j.
Without this patch the term is not visible, with this patch it is.
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b3c25b64b868b56423c50b9df4fac4bb55947679
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Jan 10 14:32:22 2019 -0500
Bug 22097: CataloguingLog should be suppressed for item branch transfers
Bug 18816 missed the fact that a branch transfer triggers ModItem and
thus generates an action log line. We should not be creating those
action logs, especially considering the transfers table itself already
documents the transfer.
Test Plan:
1) Enable CataloguingLog
2) Transfer an item to another branch
3) Note the new action log line created
4) Apply this patch
5) Create another item transfer
6) No new action log line should be created!
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9caede8d3ce67c684afd615b93ae2eb3dd5991bb
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jan 24 13:48:42 2019 +0000
Bug 22197: Add Mana KB link to administration sidebar menu
This patch adds a link to the Mana KB configuration page to the
administration sidebar menu.
To test, apply the patch and:
- Log in to the staff client as a user who lacks permission to manage
Mana KB.
- Go to an Administration page which shows the sidebar, like
Libraries or Patron categories. There should be no link to Mana KB
in the left-hand sidebar.
- Log in to the staff client as a user who has permission to manage
Mana KB.
- Go to Administration -> Mana KB
- In the sidebar menu you should see a link to Mana KB and it
should be bold.
- Navigate to another Administration page which shows the sidebar.
The Mana KB link should not be highlighted.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7f918ed8b1deed69609850800675e704da4cbf68
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Feb 4 14:59:37 2019 +0000
Bug 22198: DBRev 18.12.00.013
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e142e85d65f91a58a7aefbab3560d59f92134c2f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jan 24 13:47:26 2019 +0000
Bug 22198: Add granular permission setting for Mana KB
This patch adds a separate permission for managing Mana KB.
To test, apply the patch and update the database.
- Open the permissions page for a patron with staff client privileges
- Confirm that there is a "Manage Mana KB content sharing
(manage_mana)" permission.
- Leaving this new permission unchecked, log into the staff client
with as that patron and go to the Administration home page.
- The "Using Mana-KB" link should not appear.
- Navigate directly to /cgi-bin/koha/admin/share_content.pl. You
should get a "permission denied" message.
- Modify the patron's permissions to grant them access to Mana KB.
- Confirm that the link now appears on the Administration home
page and that the user can access the page.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1575d339629e68902ad9a92565f4b331e8c04d79
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Jan 28 20:56:40 2019 +0000
Bug 22196: (QA follow-up) Fix some more typo
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 081bb2d9bc8ba6bf53c57507a2f6e7bdf0b4fa32
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Jan 27 01:07:01 2019 +0000
Bug 22196: (QA follow-up) Fix some typo
Fixes the typo on the admin main page.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d0a8d0e55a07e07d95474a09b751f23a79fac979
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jan 23 17:56:50 2019 +0000
Bug 22196: Clean up Mana KB administration template
This patch makes language changes to the Mana KB administration
template, and corresponding language changes to the Web Services
preference file.
Some markup errors have been fixed:
- Correct title and breadcrumbs, copied and pasted from another
template
- Add ids to form fields to match their label "for" attributes
- Make <input>s self-closing
- Correct class names on alert dialogs
- Wrap text in JavaScript with _() to make it translatable
Also changed: Some language revisions to the Mana dialogs on the
Administration home page.
To test, apply the patch and go to Administration -> Share content with
Mana KB.
Test the process for enabling and configuring Mana KB. Check that
forms work correctly and that the language of instructions and labels
reads well.
Go to Administration -> System preferences -> Web services, and confirm
that the language changes to the Mana KB preference look good.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ab9e4ca6a46519ddc69ad76837407c0a4f0ed0cd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 11 10:13:42 2018 -0300
Bug 21907: Fix article requests count for non-superlibrarians
The query generates "Column 'branchcode' in where clause is ambiguous"
Test plan:
1 - Enable 'IndependentBranchesPatronModifications' and article requests
2 - Sign in as non-superlibrarian
3 - View plack log
4 - Refresh mainpage, see error in logs
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7520ede89987a7a65301debdda46950a6364ebfd
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Oct 3 16:07:19 2018 +0000
Bug 16231: Correct permission handling in subscription edit
This patch corrects the way subscription edit menu items are displayed
according to the user's permissions settings.
To test, apply the patch and log in to the staff client as a user who
has permission to create, edit, and delete subscriptions.
- Locate an subscription and view the details for it.
- Confirm that each "Edit" menu item works correctly.
- Repeat the process when logged in as a user with varying combinations
of create, edit, and delete permissions.
- Test as a user limited by IndependentBranches.
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1da0ba48b6fdf38cfd3d3ea63ec076b15995610f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Feb 1 09:55:54 2019 +0000
Bug 22254: Correction to datehandling in test
Adding 13 months is not always the same as adding 1 month and then
adding 12 months in DateTime maths. This patch rectified the test
to match the correct behaviour in koha.
Test plan.
1) Modify the test (around line 268) to test against the suspect
leap date of 2019-01-31 and watch the test fail.
2) Apply the patch (which also adds this modification to test
for such a leap date) and watch the test now pass.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a32653a66fa02f1fe9002647d337261bf36d62e0
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 4 18:37:09 2019 +0000
Bug 19915: (follow-up) Fix test count from rebase
https://bugs.koha-community.org/show_bug.cgi?id=19905
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9961e2c08f8dba0896ed4f6bfa6a7befebd28d5d
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Nov 1 13:11:16 2018 +0000
Bug 19915: Don't delete in tests
https://bugs.koha-community.org/show_bug.cgi?id=19905
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a8259c38dbe910188ece5126d226166014e001ed
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jun 15 04:10:39 2018 +0000
Bug 19915: Only show class sources in use
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
https://bugs.koha-community.org/show_bug.cgi?id=19905
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d2ce727e260f6b45266a8147aee7654811a44fa1
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jan 4 15:00:28 2018 +0000
Bug 19915: Use cn_sort values for getting inventory items
To test:
1 - Catalog an item under LCC with callnumber GT95
2 - cn_sort should calculate as GT0095
3 - Go to inventory tool
4 - Enter a range that should have your item e.g LC GT90 to GT100
5 - Item is not returned
6 - Apply patch
7 - Item should be returned
8 - Verify things otherwise work as expected
Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin at univ-rennes1.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
https://bugs.koha-community.org/show_bug.cgi?id=19905
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c345d30cc8284f690f375faa140de49e62358709
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jul 6 11:20:47 2018 +0200
Bug 19915: (QA follow-up) Tidy up GetItemsForInventory.t
Standard edits like modules, schema, Koha objects instead of DBIC.
Removing unneeded autoflush.
Moving initial test to a first subtest.
No need to clear issues if you clear items.
Adding a FIXME for OldWay; would be nice to remove that code..
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
https://bugs.koha-community.org/show_bug.cgi?id=19905
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 186209875a4951b15faded3f8c47eba71716c7af
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jan 4 14:53:14 2018 +0000
Bug 19915: Add unit test to GetItemsForInventory.t
prove -v t/db_dependent/Items/GetItemsForInventory.t
Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin at univ-rennes1.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Moved the betwen typo edit back here.
https://bugs.koha-community.org/show_bug.cgi?id=19905
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fb62e8d1fc8b210a5b23801b7b8faff3280bf638
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Jan 30 15:37:10 2019 +0000
Bug 22236: Translation should generate tags with consistent attribute order
When running misc/translator/translate, the order of attributes in the translated templates is not consistent and may vary. This is caused by the random order of hash keys in perl.
This causes things like this in run 1:
<input type="submit" class="btn" value="Plaats aanvraag" />
And this in run 2:
<input value="Plaats aanvraag" type="submit" class="btn" />
As you can see, there is actually no difference apart from the order.
When comparing the result of various translation runs, I would rather get rid of such noise and only see the real changes.
The needed change is not trivial to find, but only requires a simple addition to a sort operation in tmpl_process3.pl. The current sort only makes sure that the '/' comes at the end. We should sort the names of the keys too when this value is 0 (just meaning: no end tag symbol).
Test plan:
[1] Run a translation without this patch and set a few templates aside.
[2] Run a translation with this patch.
[3] Run a compare (diff) on the templates copied in step 1. Verify that the
only changes are found in the sort order of attributes in html tags.
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e33bdbd9dae74987869b52fd6df748784657b632
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Feb 4 14:28:19 2019 +0000
Bug 21751: Compiled CSS
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0904863c7559467ef9a6f5210950c04dcc5ee04e
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Jan 28 13:28:30 2019 +0000
Bug 21751: (follow-up) Correction to selectors
This patch makes a couple of corrections to the selectors used by
hcsticky in targeting the position of the floating toolbar. These
changes were made necessary by changes made in recently-pushed patches.
To test, confirm that these two pages work correctly:
- Acquisitions -> Vendor -> View basket
- Patrons -> New patron
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 014baf181cd4b8c74bfeb04d53f418c58e14ebb8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 6 14:54:58 2018 -0300
Bug 21751: Remove former fixFloat plugin
Signed-off-by: David Cook <dcook at prosentient.com.au>
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4b82ed3549fcea3588b1500574a6715d0fe51702
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Dec 6 17:15:49 2018 +0000
Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display
This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky
(https://github.com/somewebmedia/hc-sticky). This plugin provides the
same functionality without the page-reflow problems fixFloat suffers
from.
To test, apply the patch and regenerate the staff client CSS. Test the
behavior of the floating toolbar on these pages:
- Acquisitions -> Vendor -> Vendor details
- Acquisitions -> Vendor -> View basket
- On both these pages, test toolbar behavior before and after
expanding the "Orders search" options at the top of the page.
- Administration -> System preferences
- Authorities -> Create or edit an authority
- Catalog -> Advanced search
- Search results
- Catalog -> Item search
- Cataloging -> Add or edit a record
- Open the plugin window for the 008 field
- Tools -> Label creator -> New label batch -> Add items -> Search ->
Results
- Patrons -> New patron
- Test before and after expanding the patron search options at the
top of the page
- Test editing a patron too
- Tools -> Automatic item modifications by age -> Edit
- Tools -> Notices & slips -> Edit
- Lists -> View list
Check that the About page has been updated with information about the
plugin.
Signed-off-by: David Cook <dcook at prosentient.com.au>
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3ca0234d34ac9708a8335cfa97805fb7498201bf
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Jan 31 09:12:13 2019 +0100
Bug 22242: Javascript error in value builder cased by Select2
Same as Bug 17780 but in value builders.
Select2 (Bug 13501) introduced divs and inputs that broke some
assumptions about the expected HTML structure. This patch checks if
input has name attribute, because some inputs in Select2 have not.
It brakes value builders marc21_linking_section.tt and
unimarc_field_4XX.tt.
Test plan :
1) On a MARC21 database
2) Define 774$0 as a regular subfield
3) Define 774$4 with an authorised value category
4) Define 774$t with value builder marc21_linking_section
5) Create a new record
6) Use value builder in 774$t
7) Search for a record and click choose
8) Without patch : a popup window does not close and show a blank
screen
9) With patch : popup windows get close and you see in field 774 $0 and
$t field with values
10) Same tests with a UNIMARC database on field 461 with value builder
unimarc_field_4XX.tt
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Tested successfully with MARC21
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b2dce05ddff8a047e7770ea241b1edd9b798212e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jan 24 14:29:09 2019 -0300
Bug 19816: Implement dateonly for rfc3339 format
This patch implements the dateonly option for the rfc3339. This is
described in the OpenAPI 2.0 specification [1]. The required output
format is described on RFC 3339 [2], as 'full-date'.
[1] https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#dataTypeFormat
[2] https://tools.ietf.org/html/rfc3339#section-5.6
To test:
- Apply the regression tests patch
- Run:
k$ prove t/DateUtils.t
=> FAIL: Tests fail because dateonly is not implemented
- Apply this patch
- Run:
k$ prove t/DateUtils.t
=> SUCCESS: Tests pass!
- Sign off :-D
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7e69ab62a5ef3fbd350c6606d25b5ab6f6bc168e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jan 24 14:27:28 2019 -0300
Bug 19816: Regression tests
This patch adds tests for the rfc3339 behaviour when dateonly => 1.
To test:
- Run:
$ kshell
k$ prove t/DateUtils.t
=> SUCCESS: Tests pass
- Apply this patch
- Run:
k$ prove t/DateUtils.t
=> FAIL: dateonly is not implemented
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0f83ac98c753efbae7e33619be717327a820f2e1
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jan 31 16:30:25 2019 -0300
Bug 22253: Check we actually need to update the password
This patch makes memberentry.pl check if password needs to be updated
before attempting to call set_password. Above this there's a check that
won't raise any errors if no password is passed, or the default string (****) is received.
So we could reach that line of code with no password, but the code
wouldn't check that.
To test:
- In master, edit any patron without changing the password
=> FAIL: It raises an exception
- Apply this patch
- Edit the patron withtout changing the password
=> SUCCESS: Edit successful
- Edit the patron, changing the password
- Try to login with the new password
=> SUCCESS: The password got changed correctly
- Sigh off :-D
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Items.pm | 14 ++-
Koha.pm | 2 +-
Koha/DateUtils.pm | 9 +-
admin/share_content.pl | 2 +-
gulpfile.js | 2 +-
installer/data/mysql/backfill_statistics.pl | 3 +-
installer/data/mysql/labels_upgrade.pl | 3 -
installer/data/mysql/patroncards_upgrade.pl | 3 -
installer/data/mysql/update22to30.pl | 1 -
installer/data/mysql/updatedatabase.pl | 12 ++-
installer/data/mysql/userpermissions.sql | 1 +
installer/externalmodules.pl | 5 +-
installer/html-template-to-template-toolkit.pl | 3 +-
installer/install.pl | 3 +-
koha-tmpl/intranet-tmpl/lib/hc-sticky.js | 11 +++
.../lib/jquery/plugins/jquery.fixFloat.js | 73 ---------------
koha-tmpl/intranet-tmpl/prog/css/datatables.css | 10 ++
.../intranet-tmpl/prog/css/src/staff-global.scss | 79 +++++++++++-----
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../intranet-tmpl/prog/en/includes/admin-menu.inc | 3 +
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 54 ++++++++---
.../prog/en/includes/columns_settings.inc | 35 +++++--
.../intranet-tmpl/prog/en/includes/permissions.inc | 1 +
.../prog/en/includes/serials-toolbar.inc | 35 ++++---
.../prog/en/includes/str/members-menu.inc | 15 ++-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 3 +
.../intranet-tmpl/prog/en/modules/acqui/basket.tt | 13 ++-
.../prog/en/modules/acqui/supplier.tt | 11 ++-
.../prog/en/modules/admin/admin-home.tt | 39 ++++----
.../prog/en/modules/admin/preferences.tt | 14 ++-
.../en/modules/admin/preferences/web_services.pref | 11 ++-
.../prog/en/modules/admin/share_content.tt | 81 +++++++++--------
.../prog/en/modules/authorities/authorities.tt | 9 +-
.../prog/en/modules/catalogue/advsearch.tt | 9 +-
.../prog/en/modules/catalogue/itemsearch.tt | 10 +-
.../prog/en/modules/catalogue/results.tt | 11 ++-
.../prog/en/modules/cataloguing/addbiblio.tt | 9 +-
.../cataloguing/value_builder/marc21_field_008.tt | 11 ++-
.../value_builder/marc21_linking_section.tt | 1 +
.../cataloguing/value_builder/unimarc_field_4XX.tt | 1 +
.../en/modules/course_reserves/course-details.tt | 40 ++++++--
.../intranet-tmpl/prog/en/modules/labels/result.tt | 11 ++-
.../prog/en/modules/members/memberentrygen.tt | 41 ++++-----
.../prog/en/modules/members/moremember.tt | 16 +---
.../prog/en/modules/members/paycollect.tt | 96 ++++++++++++++++++--
.../tools/automatic_item_modification_by_age.tt | 9 +-
.../prog/en/modules/tools/inventory.tt | 13 ++-
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 2 +-
.../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 4 +
.../prog/en/modules/virtualshelves/shelves.tt | 9 +-
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 2 +-
koha-tmpl/intranet-tmpl/prog/js/letter.js | 8 +-
koha-tmpl/intranet-tmpl/prog/js/members-menu.js | 16 ++++
koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 5 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 27 ++++--
.../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 +-
mainpage.pl | 2 +-
members/memberentry.pl | 5 +-
misc/translator/tmpl_process3.pl | 1 +
t/DateUtils.t | 5 +-
t/db_dependent/Items/GetItemsForInventory.t | 61 ++++++++++++-
t/db_dependent/Koha/Patrons.t | 8 +-
tools/inventory.pl | 10 ++
63 files changed, 669 insertions(+), 338 deletions(-)
create mode 100644 koha-tmpl/intranet-tmpl/lib/hc-sticky.js
delete mode 100644 koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.fixFloat.js
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list