[koha-commits] main Koha release repository branch master updated. v18.11.00-563-gf0aa1c0
Git repo owner
gitmaster at git.koha-community.org
Fri Feb 22 16:14:20 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via f0aa1c06a100108b66cd58cb3614915fc589f13e (commit)
via 986d551ac49488216f51773172bf6a2c7d041e40 (commit)
via 9c1a87b8b1351d1659773729e39079328fc59e83 (commit)
via 7c14483010b22099b07512399889b8dab182e423 (commit)
via 9f9b809b606a486f94eb1feaa05ce87e71eb5476 (commit)
via a2ced89ab486d4cc46f66553ff8fe7dff1022b78 (commit)
via cee652af6b49aeef5aa50eb5f3888cb67f8c40f0 (commit)
via fb0bc2d18cc58a66df77a8779204f07c5dccae12 (commit)
via 39471ea91255b11cf238009f0a0576514d8774e9 (commit)
via c6f98aab5b0f8e3e09704e8513b6741cf0dd4e02 (commit)
via bc05a8a6058625f939c6d31d046752ac570a7eec (commit)
via 4758c2e234341342c1ff5e9fe07ad2a85db3b0c7 (commit)
via 3921636e5a9b2689234310cb24e71dd1b1329fd6 (commit)
via 5e0e8246be0f6dfcfb4870231bbdcfed4de0dbfa (commit)
via 06415f962cc463217f289805e8f4c57ac4980d58 (commit)
via de532ac80a31db83c2dabf45a65b9561733fceec (commit)
via 1e98932b401110a0af1876ba29917285eae1fdd3 (commit)
via aea77a61da806d1e221a2db7c525479d8c3f3409 (commit)
via 790b365831c0c883853a4f4c2b7755f03d1d9dd6 (commit)
via cc9c773c02c93e55447076a5d286d63f00204834 (commit)
via 85c9b7fb3a3802a892e011437fada866383c71e1 (commit)
via d8fd680d0ce034dbe1517c8e9a0642c967519a3c (commit)
via f808923e67a5b79150f39a0b6c5d92a5ff73277c (commit)
via e631207eaa7df02601353d34ade406ec9c8a5bc3 (commit)
via a54eb7fd5cba95f6ef350fa50b7713c8c096a204 (commit)
via 90b43c6e5fceda3d6bcc4fb24c99934331df1acc (commit)
via abb1b4a75053aa026740e16cc0197d86f417818e (commit)
via 9d69a4238269073fd03961e091b5099b85fea6e6 (commit)
via d90d7a6ce7187016698c280adedf1cb892d320cb (commit)
via da85289767975938e9e0778a8f64e6ef1eca8d97 (commit)
via cdd14f05ae8672786e5306c41ff0f15ec9fed26f (commit)
via fe0a2474c9b6702e7d452032f7657da9b990e81a (commit)
via 55332977bf4d70de9d78c324ad88b302d2174c10 (commit)
via 8211aad8c7ad772685b5e3624b3b55b738fe18a2 (commit)
via 569c64252eba27607deb9eccefe7d72678c7bbb9 (commit)
via 34c36a32a057c3a9be062e4ea8b6ec46c41859a0 (commit)
via 8083bc2ff0629dce8301330e144a61fee35d9836 (commit)
via fac2c172143b31255767684e4b22c0ba1ae0aaaf (commit)
via d0a6469ad58ccd6067bdfbb6cfb0e28dabc5862a (commit)
via 2d904a55e7f0d5da23d61e5272e36a75e4b68af2 (commit)
via 25006c04da500078b2af1b14824b67076f2f9df5 (commit)
via 8a9c82c3ec42fb5c2937fa523170b3710288d7fd (commit)
via 9f27a63b9ad770ac56e32a3e79d1ecb657534482 (commit)
via 63c5a813c994a4893eaef2cb87fcd26bc594c3e4 (commit)
via ba7c3f51ccf72565fb721403e1b24c6a56284b49 (commit)
via e429c4b84d662fcc9466a5ed4ee38ba704881507 (commit)
from 6c7c97f67cdcd6dc90e3fa34aa7bd289b80a9c4b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit f0aa1c06a100108b66cd58cb3614915fc589f13e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 21 18:03:21 2019 -0300
Bug 22049: Do not pass Koha::Patron to AddIssue
The tests are not supposed to pass with such obvious mistake (?)
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 986d551ac49488216f51773172bf6a2c7d041e40
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Feb 22 14:53:41 2019 +0000
Bug 20639: DBRev 18.12.00.016
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9c1a87b8b1351d1659773729e39079328fc59e83
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Mon Feb 11 11:08:52 2019 +0000
Bug 20581: (follow-up) Fix status_alias -1 bug
Stupid bug, we need to pass NULL not -1 when unsetting status_alias
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7c14483010b22099b07512399889b8dab182e423
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Thu Feb 7 10:43:51 2019 +0000
Bug 20581: (follow-up) Passed value to status_alias
Now we have overloaded status_alias, we can no longer pass it undef (as
it uses that to determine if it's being used as a getter or setter). So
we now pass it -1 to indicate it should actually be setting undef (a
hack, I know, but what are you going to do...)
This patch makes sure ill-request.pl conforms to that. It also fixes the
testing of the passed parameter, which was wrong.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9f9b809b606a486f94eb1feaa05ce87e71eb5476
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Wed Feb 6 14:18:59 2019 +0000
Bug 20581: (follow-up) Fix unit test
Since we're now storing the authorised_value column as the foreign key,
rather than the id, we need to account for this in the test
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a2ced89ab486d4cc46f66553ff8fe7dff1022b78
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Wed Feb 6 14:17:01 2019 +0000
Bug 20581: (follow-up) Fix status_alias comparison
status_alias will arrive in the Koha object as a string, so when we
special case it, we should also pass a string
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cee652af6b49aeef5aa50eb5f3888cb67f8c40f0
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Wed Feb 6 12:54:30 2019 +0000
Bug 20581: (follow-up) Overload status_alias
We need Koha::Illrequest->status_alias to return the correct authorised value.
Since the foreign key uses a non-unique column, we need to take into
account the authorised value category too.
This patch overloads status_alias with some additional logic that
considers the request's branch and the authorised value category to
attempt to return the correct value.
The same logic is applied to the custom statusalias method, which
returns the entire AuthorisedValue object
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fb0bc2d18cc58a66df77a8779204f07c5dccae12
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Feb 5 15:19:12 2019 +0000
Bug 20581: (follow-up) Fix typo in DB upgrade
IN -> ON
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 39471ea91255b11cf238009f0a0576514d8774e9
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Feb 5 14:10:36 2019 +0000
Bug 20581: (follow-up) Do not use PK for AV FK
As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c133
We switch from using authorised_values.id when creating the foreign key
illrequests.status_alias, we now use authorised_values.authorised_value
I have added a migration from using id -> authorised_value, so when
existing users of this bug get this version, their DB migrates nicely
instead of just breaking.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c6f98aab5b0f8e3e09704e8513b6741cf0dd4e02
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Fri Jan 25 11:55:47 2019 +0000
Bug 20581: (follow-up) Fix dependency requirement
Since this bug is now dependent on Bug 20600 (Provide the ability for
users to filter ILL requests) we need to make the status filtering aware
of the custom statuses. This patch does that.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit bc05a8a6058625f939c6d31d046752ac570a7eec
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Fri Jan 18 15:31:25 2019 +0000
Bug 20581: (follow-up) Fix QA errors
This patch fixes the "missing_filter" errors on ill-requests.tt
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4758c2e234341342c1ff5e9fe07ad2a85db3b0c7
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Thu Nov 29 12:05:46 2018 +0000
Bug 20581: (follow-up) Fix typo in kohastructure
Fix the missing comma
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3921636e5a9b2689234310cb24e71dd1b1329fd6
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Mon Oct 15 14:23:02 2018 +0100
Bug 20581: (follow-up) Modify POD
As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c69
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5e0e8246be0f6dfcfb4870231bbdcfed4de0dbfa
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Mon Oct 15 14:46:21 2018 +0100
Bug 20581: (follow-up) Fix AV population
As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c72
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 06415f962cc463217f289805e8f4c57ac4980d58
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Mon Oct 15 14:17:30 2018 +0100
Bug 20581: (follow-up) Fix fallback status_alias
As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c68
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit de532ac80a31db83c2dabf45a65b9561733fceec
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Fri Oct 12 14:31:45 2018 +0100
Bug 20581: (follow-up) Fix statusalias return
As per
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c57
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1e98932b401110a0af1876ba29917285eae1fdd3
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Fri Oct 12 15:07:47 2018 +0100
Bug 20581: (follow-up) Allow for undefined lib
As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c59
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit aea77a61da806d1e221a2db7c525479d8c3f3409
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Jun 5 12:19:06 2018 +0100
Bug 20581: (follow-up) Display status name
Rather than display the status code for custom statuses, we should be
displaying the name
Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 790b365831c0c883853a4f4c2b7755f03d1d9dd6
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Apr 17 17:00:32 2018 +0100
Bug 20581: Unit tests for status_alias
This patch adds unit tests for the specific status_alias functionality
added in this bug
- Creation of the ILLSTATUS authorised value
- Illrequest->statusalias accessor
- Illrequest->status overloading to reset status_alias
To test:
1) Apply this patch
2) prove t/db_dependent/Illrequests.t
Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cc9c773c02c93e55447076a5d286d63f00204834
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Mon Sep 3 14:14:31 2018 +0100
Bug 20581: Fix display of status alias in OPAC
Fix for status alias display in OPAC, we should be displaying the status
name, not the status code.
Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 85c9b7fb3a3802a892e011437fada866383c71e1
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Apr 17 12:03:07 2018 +0100
Bug 20581: Add display of status_alias to staff vw
- This patch adds display of the new status_alias value, when set, in
favour of the request's status value.
- It also allows the user to set a status_alias for an existing request.
When set, this value will be displayed in preference to the status.
Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d8fd680d0ce034dbe1517c8e9a0642c967519a3c
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Apr 17 12:00:15 2018 +0100
Bug 20581: API provide status_alias embed
- This patch provides the illrequests API route with an additional embed,
called 'status_alias'. Requesting this embed returns an object for the
request's status_alias authorised value, or null if one is not set.
- This patch also adds the new status_alias as a default embed on the API
call made by the illlist view
Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f808923e67a5b79150f39a0b6c5d92a5ff73277c
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Apr 17 12:02:18 2018 +0100
Bug 20581: Provide status_alias on IllRequest
This patch provides status_alias support for the Koha::Illrequest
object.
- New 'statusalias' getter method, returns the request's status_alias
authorised value object if set, otherwise undef
- Overloads existing 'status' method, getter/setter accessors intact,
but setting the request's status now implicitly removes any status_alias
that has been set
Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e631207eaa7df02601353d34ade406ec9c8a5bc3
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Apr 17 11:57:09 2018 +0100
Bug 20581: Modifications to database schema
- This patch provides an illrequests.status_alias column that is a foreign key to
authorised_values.id. This provides the ability for an ILL request to
have an optional status alias that is defined as an authorised valued.
- A new ILLSTATUS authorised value category is also made available during install.
Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
Following commit was squashed into this one:
Bug 20581: (follow-up) Modify DB updgrade
As per
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c56
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a54eb7fd5cba95f6ef350fa50b7713c8c096a204
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sun Jan 27 00:53:05 2019 +0000
Bug 22261: Revise style of DataTables menus
This patch revises our custom DataTables CSS to give a more colorful
style to the columns configuration and export menus. The primary goal of
this change is to make it easier to tell which columns are visible and
which are hidden.
To test, apply the patch and clear your browser cache if necessary.
View a table with columns configuration and export options, e.e. Tools
-> Notices & slip. Test the DataTables menus and confirm that they work
as expected.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
This is a nice update to the styles.
Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 90b43c6e5fceda3d6bcc4fb24c99934331df1acc
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Tue Feb 5 21:44:58 2019 +0000
Bug 22170: Improve display of add/edit library group modal
Tries to bring the emodal for adding/editing library root
and sub groups more in line with the rest of Koha.
To test:
- Go to Administration > Library groups
- With and without patch test following actions:
- Add a new root group
- Edit root group
- Add sub-group entry
- Edit sub-group entry
- Verify that with the patch the display of the labels
is more standard (bold and aligned to the right) and
the input fields are a bit longer to allow for
easier data entry.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit abb1b4a75053aa026740e16cc0197d86f417818e
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Tue Feb 12 21:33:50 2019 +0000
Bug 22130: (follow-up) Show not for loan authorised values in batch checkout
TEST PLAN
1) In Koha administration, search "BatchCheckouts".
2) Make sure "BatchCheckouts" is set at "Allow".
3) Make sure "BatchCheckoutsValidCategories" contains at least one
patron category.
5) Copy the barcode of an item and change the status document so it
cannot be loaned.
4) Choose a patron which belongs to the patron category at 3).
(their account should not be expired and they should not have active
fees preferably)
5) Go to the patron details page.
6) Click on "Batch check out".
7) Enter the item barcode.
8) Notice a number is in brackets under the column "Information".
9) Apply patch.
10) Notice the status description has replaced the number.
11) Try it with both: AllowNotForLoanOverride on and off
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9d69a4238269073fd03961e091b5099b85fea6e6
Author: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Date: Mon Jan 14 14:02:49 2019 -0500
Bug 22130: Correct parameter to get authorized value description.
This patch corrects the error that shows an authorized value instead of the obvious description of the document status.
TEST PLAN
1) In Koha administration, search "BatchCheckouts".
2) Make sure "BatchCheckouts" is set at "Allow".
3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category.
5) Copy the barcode of an item and change the status document so it cannot be loaned.
4) Choose a patron which belongs to the patron category at 3).
(their account should not be expired and they should not have active fees preferably)
5) Go to the patron details page.
6) Click on "Batch check out".
7) Enter the item barcode.
8) Notice a number is in brackets under the column "Information".
9) Apply patch.
10) Notice the status description has replaced the number.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d90d7a6ce7187016698c280adedf1cb892d320cb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Feb 21 07:16:24 2019 -0500
Bug 22080: (QA follow-up) Add filters
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit da85289767975938e9e0778a8f64e6ef1eca8d97
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Jan 11 14:28:07 2019 +0100
Bug 22080: Easier translation of ElasticSearch mappings page
Actual translation of ElasticSearch mappings page contains a huge block with a lot of %s.
It makes translation hard.
This patch uses new method from Bug 15395 to split into several translation blocks.
Test plan :
1) Apply patch "Bug 22080: [DO NOT PUSH] test code"
2) Apply this patch
3) Enable ElasticSearch in SearchEngine preference
4) Go to Administration > Search engine configuration
5) Check page is OK
6) Update the PO files of a language : perl translate update xx-YY
7) Write translation strings in misc/translator/po/xx-YY-messages.po
8) Install translation : perl translate install xx-YY
9) Check translated page
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cdd14f05ae8672786e5306c41ff0f15ec9fed26f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Feb 6 04:31:28 2019 +0000
Bug 21335: Remove redundant includes of right-to-left.css
Fixes redundant includes of the right-to-left.css file.
There is no need to include it in the .tt files as it's part
of the doc-head-close.inc.
Note:
Make sure your *BaseURL preferences are correctly set as
this will make the switching between languages work
correctly and throw you back to the start page otherwise
every time you switch
Test:
- Install an RTL language like Arabic (ar-Arab)
- Test various pages with English and RTL language:
- Authorities home page
- Adding a new bibliographic record
- Adding a new item or editing items
- Advanced cataloguing (Rancor) editor
- Labels start page
- OPAC detail page
- Verify display is correct and right-to-left.css is available
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fe0a2474c9b6702e7d452032f7657da9b990e81a
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Feb 6 12:13:12 2019 +0000
Bug 18166: Show internal and vendor notes for receivied orders
This copies the logic for showing, adding and editing vendor
and internal notes from the pending orders to the received
orders.
To test:
- In acquisitions create a basket with orders
- Make your you have some internal and vendor notes
- Close the basket and receive shipment
- Create or reuse an invoice
- Receive some of your orders
- Verify that the notes don't show for received orders
- Apply patch
- Verify that the edit/change vendor/internal note links
work the same on pending and received orders
Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 55332977bf4d70de9d78c324ad88b302d2174c10
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Feb 22 13:28:50 2019 +0000
Bug 16276: (RM follow-up) Fix update statement output
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8211aad8c7ad772685b5e3624b3b55b738fe18a2
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Feb 6 12:27:53 2019 +0000
Bug 17236: Add minute and hours to last checked out item on circulation for hourly loans
This is a simple fix using the right TT filter:
[% issue.date_due | $KohaDates as_due_date => 1 %]
The time part of the due date will only display if it's an hourly loan (!=23:59)
To test:
- Check out 2 items
- One with a loan period in days
- One with a loan period in hours
- Verify the the due date only shows the date part
- Apply patch
- Return items and repeat
- Verify that now the time part will show for the hourly loan
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 569c64252eba27607deb9eccefe7d72678c7bbb9
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Feb 19 19:34:04 2019 +0000
Bug 21692: (QA follow-up) Enhance test for new
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 34c36a32a057c3a9be062e4ea8b6ec46c41859a0
Author: Jasmine Amohia <jasmineamohia.student at wegc.school.nz>
Date: Thu Jan 17 03:33:49 2019 +0000
Bug 21692: created a test for Koha::Account->new
Test plan:
1) Run test for /Koha/Account.t and confirm that all tests were
successful
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8083bc2ff0629dce8301330e144a61fee35d9836
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 29 11:07:06 2019 -0300
Bug 22216: Make GET /patrons/{patron_id} staff only
This patch removes the possibility to access the patron object
identified by patron_id by the patron itself, or a guarantor.
It does so by removing the permissions from the spec. The tests are
adjusted to remove that use case.
To test:
- Apply this patch
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
- Sign off :-D
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fac2c172143b31255767684e4b22c0ba1ae0aaaf
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Dec 13 14:56:22 2018 -0500
Bug 21997: SIP patron information requests can lock patron out of account
Many SIP services send an empty password field (AD). Even if allow_empty_passwords is enabled for the given SIP account, this empty password is run though Koha's password checker which increments the number of login attempts for a patron. Thus repeated patron information requests can lock a patron out! Empty password fields in SIP should not call for a password check if allow_empty_passwords is enabled.
Test Plan:
1) Enable a patron password attempt with a limit of 3
2) Send 4 patron information requests with an empty AD field
3) Note the patron's account is now locked
4) Apply this patch
5) Repeat step 2 with a different patron
6) Note the patron's account does not get locked!
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d0a6469ad58ccd6067bdfbb6cfb0e28dabc5862a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Feb 11 13:16:10 2019 -0500
Bug 21997: Unit tests
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2d904a55e7f0d5da23d61e5272e36a75e4b68af2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 19 12:18:19 2018 -0300
Bug 21622: Adjust incorrect GROUP BY clauses in acqui script
acqui/ordered.pl: GROUP BY aqorders.ordernumber
acqui/spent.pl: GROUP BY aqorders.ordernumbe
'koha_kohadev.aqorders.biblionumber' isn't in GROUP BY
Test plan:
- Create orders for different basket and using different funds
- Receive some of them
- Hit the ordered and spent pages (from the acqui home page)
=> The tables must contain the same data with and without this patch
Signed-off-by: Jasmine Amohia <jasmineamohia.student at wegc.school.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 25006c04da500078b2af1b14824b67076f2f9df5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 21 13:25:22 2019 -0300
Bug 22386: Remove debug statements
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8a9c82c3ec42fb5c2937fa523170b3710288d7fd
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Feb 21 14:30:22 2019 +0000
Bug 22386: Define patron variable when matchign on extended attributes
For all other methods we define a patron object and check the userid,
we just need to define the $patron here
To test:
0 - Apply unit test patch alone
1 - prove t/db_dependent/Koha/Patrons/Import.t
2 - It dies
3 - Apply this patch
4 - repeat tests
5 - It passes!
Signed-off-by: Devlyn Courtier <dcourtier at hccc.edu>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9f27a63b9ad770ac56e32a3e79d1ecb657534482
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Feb 21 14:29:59 2019 +0000
Bug 22386: Unit tests
Signed-off-by: Devlyn Courtier <dcourtier at hccc.edu>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 63c5a813c994a4893eaef2cb87fcd26bc594c3e4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 21 13:42:30 2019 -0300
Bug 22389: (bug 15836 follow-up) Add Delete regex links on creating splitting source
The "Delete" link does not exist when the form is empty.
Test plan:
Create a new classification splitting source
Select "Regex" for routine
=> The delete link does not appear (you cannot remove if there is only
one input)
=> It a regex
=> The 2 delete links appear
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ba7c3f51ccf72565fb721403e1b24c6a56284b49
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Feb 21 16:48:22 2019 +0000
Bug 22391: Remove group by clause in ajax-getauthvaluedropbox.pl
To test:
1 - Enable strict sql modes
2 - Tail the error log
3 - Add an item to a basket - note that when fund selected you get an error
4 - Apply patch
5 - Repeat, no error
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e429c4b84d662fcc9466a5ed4ee38ba704881507
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 21 12:23:05 2019 -0300
Bug 22388: Add missing +x flag to split_callnumbers
The following commit added this svc script but did not set the correct
permissions, +x was missing
commit 328046e59cbf7c858b9218ac2adf27bb42784776
Bug 15836: Add missing svc script
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/SIP/Sip/MsgType.pm | 3 +-
Koha.pm | 2 +-
Koha/Illrequest.pm | 89 +++++++++++++++++
Koha/Patrons/Import.pm | 1 +
Koha/REST/V1/Illrequests.pm | 3 +
Koha/Schema/Result/AuthorisedValue.pm | 19 +++-
Koha/Schema/Result/Illrequest.pm | 33 ++++++-
acqui/ajax-getauthvaluedropbox.pl | 1 -
acqui/ordered.pl | 8 +-
acqui/spent.pl | 14 ++-
api/v1/swagger/paths/patrons.json | 2 -
ill/ill-requests.pl | 8 +-
installer/data/mysql/kohastructure.sql | 7 +-
installer/data/mysql/mandatory/auth_val_cat.sql | 4 +
installer/data/mysql/updatedatabase.pl | 44 ++++++++-
koha-tmpl/intranet-tmpl/prog/css/datatables.css | 103 ++++++++++++++++++++
.../prog/en/includes/columns_settings.inc | 1 +
.../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 11 +++
.../prog/en/modules/admin/classsources.tt | 2 +
.../prog/en/modules/admin/library_groups.tt | 53 +++++-----
.../admin/searchengine/elasticsearch/mappings.tt | 23 ++---
.../prog/en/modules/authorities/authorities.tt | 3 -
.../prog/en/modules/cataloguing/addbiblio.tt | 3 -
.../prog/en/modules/cataloguing/additem.tt | 3 -
.../prog/en/modules/cataloguing/editor.tt | 3 -
.../prog/en/modules/circ/circulation.tt | 2 +-
.../en/modules/circ/circulation_batch_checkouts.tt | 6 +-
.../prog/en/modules/ill/ill-requests.tt | 61 +++++++++---
.../prog/en/modules/labels/label-home.tt | 3 -
.../bootstrap/en/modules/opac-illrequests.tt | 4 +-
t/db_dependent/Circulation/MarkIssueReturned.t | 4 +-
t/db_dependent/Illrequests.t | 57 ++++++++++-
t/db_dependent/Koha/Account.t | 19 +++-
t/db_dependent/Koha/Patrons/Import.t | 35 +++++--
t/db_dependent/SIP/Message.t | 10 +-
t/db_dependent/api/v1/patrons.t | 33 +------
36 files changed, 549 insertions(+), 128 deletions(-)
mode change 100644 => 100755 svc/split_callnumbers
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list