[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.03-71-gb5875c5
Git repo owner
gitmaster at git.koha-community.org
Tue Feb 26 11:10:28 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 18.11.x has been updated
via b5875c5f9c7889757a330c547abc565df1250e18 (commit)
via 684a1e7dc00b45d69a4c857bba5018991519fa44 (commit)
via f5d3814854ef265f04472e64717424f1e1a95743 (commit)
via f4a02e66d3d7485109116f6a9b9f9c33218a4d4a (commit)
via 6643dc2a94a1165a5c4ea77bdcf760385446944e (commit)
via d0b51ad0f47558b41208c7c7cbc19e1218cc0850 (commit)
via 9d811184fef4c7db64f616bd631991aef503a8a9 (commit)
via a72d11e55dc24764faa6717d3d130ca92777afd0 (commit)
via 7d30e64996100bf0fb5a803cd6e1dcdbd8f01e20 (commit)
via 111ddbfa573df0fd5d694f1a96a2a5063e8dfb47 (commit)
via 4771a7da8e30798d1d9e389db94e7efc3428a5e0 (commit)
via d6ca92031339629bfa50fdda3c8e1e46b5c33c89 (commit)
via e6cb954f7040de981548ae3502437699ea32c3b0 (commit)
via 4040b716d777aa267bccd510d3f77d67fc715714 (commit)
via 84e67818c57286722537e8c2e73d4587430ccd6c (commit)
via 854f1ca17a78c5b73c63cfd0b57bcf89108778b2 (commit)
via 65a6cd355ef227ab4e11b620f485f010b611e115 (commit)
via 1a703844dc2eee42c00c94a83d14df9fe00c371e (commit)
via 685b9cdec79b5d58e5a4ffdc148df1a182c401ea (commit)
via 71227300a3f367ef8b17572a419d24eeecea9ded (commit)
via 5054f1a1a30e4921d47941220786118c3a8575ee (commit)
via bda0f717cda8d57373b1619c17234ea9230dd416 (commit)
from 981031257c6dc5d094d1c8921c0b7c9de100d32f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b5875c5f9c7889757a330c547abc565df1250e18
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Feb 6 04:31:28 2019 +0000
Bug 21335: Remove redundant includes of right-to-left.css
Fixes redundant includes of the right-to-left.css file.
There is no need to include it in the .tt files as it's part
of the doc-head-close.inc.
Note:
Make sure your *BaseURL preferences are correctly set as
this will make the switching between languages work
correctly and throw you back to the start page otherwise
every time you switch
Test:
- Install an RTL language like Arabic (ar-Arab)
- Test various pages with English and RTL language:
- Authorities home page
- Adding a new bibliographic record
- Adding a new item or editing items
- Advanced cataloguing (Rancor) editor
- Labels start page
- OPAC detail page
- Verify display is correct and right-to-left.css is available
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit cdd14f05ae8672786e5306c41ff0f15ec9fed26f)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 684a1e7dc00b45d69a4c857bba5018991519fa44
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Feb 6 12:13:12 2019 +0000
Bug 18166: Show internal and vendor notes for receivied orders
This copies the logic for showing, adding and editing vendor
and internal notes from the pending orders to the received
orders.
To test:
- In acquisitions create a basket with orders
- Make your you have some internal and vendor notes
- Close the basket and receive shipment
- Create or reuse an invoice
- Receive some of your orders
- Verify that the notes don't show for received orders
- Apply patch
- Verify that the edit/change vendor/internal note links
work the same on pending and received orders
Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit fe0a2474c9b6702e7d452032f7657da9b990e81a)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f5d3814854ef265f04472e64717424f1e1a95743
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Feb 22 13:28:50 2019 +0000
Bug 16276: (RM follow-up) Fix update statement output
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 55332977bf4d70de9d78c324ad88b302d2174c10)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f4a02e66d3d7485109116f6a9b9f9c33218a4d4a
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Feb 6 12:27:53 2019 +0000
Bug 17236: Add minute and hours to last checked out item on circulation for hourly loans
This is a simple fix using the right TT filter:
[% issue.date_due | $KohaDates as_due_date => 1 %]
The time part of the due date will only display if it's an hourly loan (!=23:59)
To test:
- Check out 2 items
- One with a loan period in days
- One with a loan period in hours
- Verify the the due date only shows the date part
- Apply patch
- Return items and repeat
- Verify that now the time part will show for the hourly loan
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 8211aad8c7ad772685b5e3624b3b55b738fe18a2)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6643dc2a94a1165a5c4ea77bdcf760385446944e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Feb 19 19:34:04 2019 +0000
Bug 21692: (QA follow-up) Enhance test for new
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 569c64252eba27607deb9eccefe7d72678c7bbb9)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d0b51ad0f47558b41208c7c7cbc19e1218cc0850
Author: Jasmine Amohia <jasmineamohia.student at wegc.school.nz>
Date: Thu Jan 17 03:33:49 2019 +0000
Bug 21692: created a test for Koha::Account->new
Test plan:
1) Run test for /Koha/Account.t and confirm that all tests were
successful
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 34c36a32a057c3a9be062e4ea8b6ec46c41859a0)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9d811184fef4c7db64f616bd631991aef503a8a9
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Dec 13 14:56:22 2018 -0500
Bug 21997: SIP patron information requests can lock patron out of account
Many SIP services send an empty password field (AD). Even if allow_empty_passwords is enabled for the given SIP account, this empty password is run though Koha's password checker which increments the number of login attempts for a patron. Thus repeated patron information requests can lock a patron out! Empty password fields in SIP should not call for a password check if allow_empty_passwords is enabled.
Test Plan:
1) Enable a patron password attempt with a limit of 3
2) Send 4 patron information requests with an empty AD field
3) Note the patron's account is now locked
4) Apply this patch
5) Repeat step 2 with a different patron
6) Note the patron's account does not get locked!
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit fac2c172143b31255767684e4b22c0ba1ae0aaaf)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a72d11e55dc24764faa6717d3d130ca92777afd0
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Feb 11 13:16:10 2019 -0500
Bug 21997: Unit tests
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit d0a6469ad58ccd6067bdfbb6cfb0e28dabc5862a)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7d30e64996100bf0fb5a803cd6e1dcdbd8f01e20
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 19 12:18:19 2018 -0300
Bug 21622: Adjust incorrect GROUP BY clauses in acqui script
acqui/ordered.pl: GROUP BY aqorders.ordernumber
acqui/spent.pl: GROUP BY aqorders.ordernumbe
'koha_kohadev.aqorders.biblionumber' isn't in GROUP BY
Test plan:
- Create orders for different basket and using different funds
- Receive some of them
- Hit the ordered and spent pages (from the acqui home page)
=> The tables must contain the same data with and without this patch
Signed-off-by: Jasmine Amohia <jasmineamohia.student at wegc.school.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 2d904a55e7f0d5da23d61e5272e36a75e4b68af2)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 111ddbfa573df0fd5d694f1a96a2a5063e8dfb47
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 21 13:25:22 2019 -0300
Bug 22386: Remove debug statements
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 25006c04da500078b2af1b14824b67076f2f9df5)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 4771a7da8e30798d1d9e389db94e7efc3428a5e0
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Feb 21 14:30:22 2019 +0000
Bug 22386: Define patron variable when matchign on extended attributes
For all other methods we define a patron object and check the userid,
we just need to define the $patron here
To test:
0 - Apply unit test patch alone
1 - prove t/db_dependent/Koha/Patrons/Import.t
2 - It dies
3 - Apply this patch
4 - repeat tests
5 - It passes!
Signed-off-by: Devlyn Courtier <dcourtier at hccc.edu>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 8a9c82c3ec42fb5c2937fa523170b3710288d7fd)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d6ca92031339629bfa50fdda3c8e1e46b5c33c89
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Feb 21 14:29:59 2019 +0000
Bug 22386: Unit tests
Signed-off-by: Devlyn Courtier <dcourtier at hccc.edu>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 9f27a63b9ad770ac56e32a3e79d1ecb657534482)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e6cb954f7040de981548ae3502437699ea32c3b0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 21 13:42:30 2019 -0300
Bug 22389: (bug 15836 follow-up) Add Delete regex links on creating splitting source
The "Delete" link does not exist when the form is empty.
Test plan:
Create a new classification splitting source
Select "Regex" for routine
=> The delete link does not appear (you cannot remove if there is only
one input)
=> It a regex
=> The 2 delete links appear
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 63c5a813c994a4893eaef2cb87fcd26bc594c3e4)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 4040b716d777aa267bccd510d3f77d67fc715714
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Feb 21 16:48:22 2019 +0000
Bug 22391: Remove group by clause in ajax-getauthvaluedropbox.pl
To test:
1 - Enable strict sql modes
2 - Tail the error log
3 - Add an item to a basket - note that when fund selected you get an error
4 - Apply patch
5 - Repeat, no error
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit ba7c3f51ccf72565fb721403e1b24c6a56284b49)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 84e67818c57286722537e8c2e73d4587430ccd6c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 21 12:23:05 2019 -0300
Bug 22388: Add missing +x flag to split_callnumbers
The following commit added this svc script but did not set the correct
permissions, +x was missing
commit 328046e59cbf7c858b9218ac2adf27bb42784776
Bug 15836: Add missing svc script
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit e429c4b84d662fcc9466a5ed4ee38ba704881507)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 854f1ca17a78c5b73c63cfd0b57bcf89108778b2
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sat Feb 18 19:50:32 2017 -0500
Bug 18143: Silence ods MARC framework export flood
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 5b0eb51c8066abbd645731593572277ca5b46715)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 65a6cd355ef227ab4e11b620f485f010b611e115
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sat Feb 18 19:21:59 2017 -0500
Bug 18143: Silence XML MARC Framework export flood
TEST PLAN
---------
1) Log in to staff client
2) Click Koha administration
3) Click MARC bibliographic framework
4) export default as xml
5) Read the error log
-- it's floody and export is default framework
6) export another framework as xml
7) Read the error log
-- it's floody and export is the correct framework
8) apply the patch
9) repeat steps 4-7
-- expected frameworks exported, and no flooding.
10) run koha qa test tools
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 719153455c8c58fb8b1a8e9123acef5052dbd462)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 1a703844dc2eee42c00c94a83d14df9fe00c371e
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Nov 29 17:53:37 2018 +0000
Bug 20102: Remove attribute "text/css" for <style> element used in staff client templates
This patch modifies staff client templates to remove the "type"
attribute from <style> tags. The attribute is no longer valid.
To test, apply the patch and confirm the changes to the templates. The
appearance of the staff client should be unchanged.
Validating pages from the staff client should not return any errors
related to the <style> "type" attribute.
Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit e55d16f0da01dc474dc2f4541926c1daf609aff0)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 685b9cdec79b5d58e5a4ffdc148df1a182c401ea
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Feb 8 16:54:37 2019 +0000
Bug 21427: (QA follow-up) Fix for tabs
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit d220725694302f187b3ff92c0eedda583919b735)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 71227300a3f367ef8b17572a419d24eeecea9ded
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Jan 11 22:55:35 2019 +0100
Bug 21427: Format prices on ordered/spent lists consistently
Some price information on the spent and ordered list already
used the $Price filter. With this patch all amounts should be
formatted according to the CurrencyFormat system preference.
Signed-off-by: Jack Kelliher <jke0429 at stacmail.net>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 209570f89d050f22fa90eed6a8a70ad9eb56e8a2)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5054f1a1a30e4921d47941220786118c3a8575ee
Author: Jasmine Amohia <jasmineamohia.student at wegc.school.nz>
Date: Wed Jan 16 21:26:10 2019 +0000
Bug 22147: Hidden 'Batch modify' button on report print layout
Test plan:
1) Create or run a report that has an itemnumber column
2) Notice the Batch modify button under the itemnumber heading
3) Print the page
4) Notice the button no longer shows on the printed page
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 5ea9fb91632d712a6f70f4a3382ba96b4db74f69)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit bda0f717cda8d57373b1619c17234ea9230dd416
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Dec 6 15:17:37 2018 +0100
Bug 21966: Fix descriptions of acquisition permissions to be more clear (again)
This was already done and pushed on bug 3849, but some of it got
undone accidentally by a later patch.
To test:
- Check the acquisition permissions
- The *budget* permissions should clearly describe their
use for 'funds'.
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 940c5c0add3065d35f776a3a19ba87d936e84a0f)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/ImportExportFramework.pm | 4 ++
C4/SIP/Sip/MsgType.pm | 3 +-
Koha/Patrons/Import.pm | 1 +
acqui/ajax-getauthvaluedropbox.pl | 1 -
acqui/ordered.pl | 8 +++-
acqui/spent.pl | 14 +++++-
installer/data/mysql/updatedatabase.pl | 2 +-
koha-tmpl/intranet-tmpl/prog/css/print.css | 1 +
.../prog/en/includes/doc-head-close.inc | 2 +-
.../intranet-tmpl/prog/en/includes/permissions.inc | 8 ++--
.../intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 +-
.../prog/en/modules/acqui/basketgroup.tt | 2 +-
.../prog/en/modules/acqui/booksellers.tt | 2 +-
.../prog/en/modules/acqui/duplicate_orders.tt | 2 +-
.../prog/en/modules/acqui/edifactmsgs.tt | 2 +-
.../intranet-tmpl/prog/en/modules/acqui/ordered.tt | 46 ++++++++++----------
.../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 11 +++++
.../intranet-tmpl/prog/en/modules/acqui/spent.tt | 10 ++---
.../en/modules/admin/branch_transfer_limits.tt | 2 +-
.../prog/en/modules/admin/categories.tt | 2 +-
.../prog/en/modules/admin/classsources.tt | 4 +-
.../prog/en/modules/authorities/authorities.tt | 3 --
.../prog/en/modules/batch/print-notices.tt | 2 +-
.../prog/en/modules/catalogue/imageviewer.tt | 2 +-
.../prog/en/modules/catalogue/moredetail.tt | 2 +-
.../prog/en/modules/cataloguing/addbiblio.tt | 3 --
.../prog/en/modules/cataloguing/additem.tt | 3 --
.../prog/en/modules/cataloguing/editor.tt | 3 --
.../prog/en/modules/cataloguing/merge.tt | 2 +-
.../value_builder/unimarc_field_210c_bis.tt | 2 +-
.../en/modules/cataloguing/z3950_auth_search.tt | 2 +-
.../prog/en/modules/cataloguing/z3950_search.tt | 2 +-
.../prog/en/modules/circ/article-requests.tt | 2 +-
.../prog/en/modules/circ/circulation.tt | 2 +-
.../prog/en/modules/circ/view_holdsqueue.tt | 2 +-
.../prog/en/modules/clubs/templates-add-modify.tt | 2 +-
.../prog/en/modules/labels/label-home.tt | 3 --
.../en/modules/reports/guided_reports_start.tt | 2 +-
.../prog/en/modules/serials/serials-search.tt | 2 +-
.../prog/en/modules/tools/batchMod-del.tt | 2 +-
.../prog/en/modules/tools/batchMod-edit.tt | 4 +-
.../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/sci/sci-main.tt | 4 +-
t/db_dependent/Koha/Account.t | 20 ++++++++-
t/db_dependent/Koha/Patrons/Import.t | 35 ++++++++++++---
t/db_dependent/SIP/Message.t | 10 ++++-
46 files changed, 158 insertions(+), 89 deletions(-)
mode change 100644 => 100755 svc/split_callnumbers
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list