[koha-commits] main Koha release repository branch master updated. v18.11.00-603-g9143518
Git repo owner
gitmaster at git.koha-community.org
Wed Feb 27 15:31:25 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 91435189fee9d095677e6a0a0b9d8934823cba47 (commit)
via 1a385cae8d8e84cdf48824c8897545ff5e25471c (commit)
via b3969c52f8aaa956e4dc8d1f6ed15fc40003013b (commit)
via 8c2e03020dc02519dec70b9697794a3624c73937 (commit)
via 57f4c01b9a09d1c2e0fc8a3449ba86574775b840 (commit)
via 7c3a5c78c1aacbdb0ad7eb758cb9880ecefcce3a (commit)
via d441ce5cdadba7a87570162b9f54600c82f150e2 (commit)
via bc96fe5b4185e1d52ab7050c3c63802006fa35fd (commit)
via aae5e558465c365d9f857ad6f7b4aab46896a7da (commit)
via f9162c2e5e7cd8eff0a9e96572156309f296fd41 (commit)
via 3e63209fa828144099cfdde2a740e372c4722287 (commit)
via 08c83dbc6e5c57546c30ac76071e7a94891bacb9 (commit)
via 9cdac855c95d334b5119cf6f13c37354a1306722 (commit)
via 660d7bbd5e97de320d539bd6bd0e1b0334562b07 (commit)
via dae703cb792d031562f5c4a75eacd6a86c1f9087 (commit)
via ab1f9af117fa8e2d2ff143126b82b88a43ff6bf8 (commit)
from 6533f32c3a7acdaaa6769e6039472045add847e2 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 91435189fee9d095677e6a0a0b9d8934823cba47
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Feb 27 09:07:28 2019 -0500
Bug 21747: DBRev 18.12.00.017
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1a385cae8d8e84cdf48824c8897545ff5e25471c
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Feb 4 14:29:08 2019 +0000
Bug 21747: (follow-up) Intelligent rename of offsets
This patch intelligently renames the account_offset types for updateing
fines from `Fine Update` to `fine_increment` and `fine_decrement`
depending on the sign of the calculated difference of the adjustment.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b3969c52f8aaa956e4dc8d1f6ed15fc40003013b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Nov 1 14:55:15 2018 +0000
Bug 21747: Use Koha::Account:: routines in UpdateFine
Set to use Koha::Account->add_debit and Koha::Account::Line->adjust
Known Side Effect: The format of the FinesLog, if enabled, is changed
after this patch. Prior to this patch the $actionname was left undefined
and the $infos field contained the string:
`"due=".$due." amount=".$amount." itemnumber=".$itemnum`
After this patch, the logs are more consistent with other FINES logs,
with an $actionname of 'CREATE' or 'UPDATE' and the $infos field
containing a Dumper of fine data.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8c2e03020dc02519dec70b9697794a3624c73937
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Jan 8 13:10:53 2019 -0500
Bug 22084: Plugin upgrade method and database plugin version storage will never be triggered for existing installs
If an existing plugin begins using the upgrade() method, it will never actually get triggered because the installation has already occurred and no database plugin version was stored at the time. Without that database version, the upgrade method will never be triggered.
In addition, if the plugin has no upgrade method, the installed version is never updated in the database!
Lastly, when an upgrade succeeds it prints a warning that the upgrade failed.
Test Plan:
1) Install an older version of the Kitchen sink plugin:
* https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.0/koha-plugin-kitchen-sink-v2.1.0.kpz
2) Delete the "__INSTALLED_VERSION__" key, and the "last_upgraded" key from plugin_data for this plugin, to simulate having installed from an earlier version of Koha
3) Upgrade to the latest version of the Kitchen sink plugin:
* https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.22/koha-plugin-kitchen-sink-v2.1.22.kpz
4) Note "__INSTALLED_VERSION__" still doesn't exist for the plugin, in the plugin_data table
5) Apply this patch
6) Restart all the things
7) Browse to the Kitchen sink configuration page, this should trigger the upgrade method
8) Note the "__INSTALLED_VERSION__" and "last_upgraded" keys exist in plugin_data for the Kitchen Sink plugin
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 57f4c01b9a09d1c2e0fc8a3449ba86574775b840
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jan 9 07:33:15 2019 -0300
Bug 22084: Regression tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7c3a5c78c1aacbdb0ad7eb758cb9880ecefcce3a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Feb 11 16:05:23 2019 -0300
Bug 21765: Make AutoUnsuspendReserves call Koha::Hold->resume
This patch makes the mentioned method use the biult-in method for
resuming a suspended hold, instead of manually setting the specific
attributes using the accessors.
The side effect for this is that HoldsLog is now honoured.
This patchset also refactors the tests a bit so they rely on the exposed
methods and thus don't rely on specific implementation details (like
suspended hold means a date in suspended_until plus suspended=1).
To test:
- Apply the regression tests patch
- Run:
$ kshell
k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t
=> FAIL: It fails loudly because things are done manually
- Apply this patch
- Run:
k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t
=> SUCCESS: Tests pass!
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d441ce5cdadba7a87570162b9f54600c82f150e2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Feb 11 16:04:59 2019 -0300
Bug 21765: Regression tests
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit bc96fe5b4185e1d52ab7050c3c63802006fa35fd
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Feb 4 06:09:32 2019 +0000
Bug 12318: Show shelving location on subscription tab in OPAC and staff
The shelving location can be helpful to locate an item in the library.
Especially, if the library has decided not to create items for a
subscription this information is currently not visible to the patron.
To test:
- Apply patch
- Create a subscription, set location
- View the subscription tab in detail and staff
- Verify that the location now shows above the callnumber
- Unset location in the subscription
- Verify that the page still looks ok
Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit aae5e558465c365d9f857ad6f7b4aab46896a7da
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Nov 23 11:36:49 2018 +0100
Bug 21875: Handling subject line in Letters.pm
The variable name $utf8 is very misleading: it contains MIME-Header encoding.
$message->{subject} comes from the database and is in perl internal format;
it should NOT be decoded as a MIME-Header.
After encoding to MIME-Header, previously another (useless) encoding to
UTF-8 was done. Since the string is plain ASCII, this is useless and
theoretically wrong. We should stay in MIME-Header.
Test plan:
See Bugzilla comment5.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f9162c2e5e7cd8eff0a9e96572156309f296fd41
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Feb 19 12:46:38 2019 -0500
Bug 22016: Unit tests
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3e63209fa828144099cfdde2a740e372c4722287
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Dec 17 14:41:48 2018 -0500
Bug 22016: Always send CT field for SIP checkin, even if empty
Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a CT field to be sent, even if that field is empty. Koha should be able to support this behavior.
Test Plan:
1) Apply this patch
2) Enable the new option ct_always_send for a SIP2 account
3) Restart SIP
4) Check in an item successfully via SIP, which will not be transferred
5) Note the response contains a CT field with no value
Sponsored-by: Pueblo City-County Library District
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jill Kleven <jill.kleven at pueblolibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 08c83dbc6e5c57546c30ac76071e7a94891bacb9
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Feb 19 12:41:30 2019 -0500
Bug 22014: Unit tests
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9cdac855c95d334b5119cf6f13c37354a1306722
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Dec 17 12:34:14 2018 -0500
Bug 22014: Add ability to send "00" in SIP CV field on checkin success
Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior.
Test Plan:
1) Apply this patch
2) Enable the new option cv_send_00_on_success for a SIP2 account
3) Restart SIP
4) Check in an item successfully via SIP
5) Note the response contains a CV field with the value '00'
Sponsored-by: Pueblo City-County Library District
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jill Kleven <jill.kleven at pueblolibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 660d7bbd5e97de320d539bd6bd0e1b0334562b07
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Feb 13 20:00:17 2019 +0000
Bug 22337: Make it clearer that language preferences can be re-ordered
This patch makes markup and CSS changes to the system preference
interface so that it is visually clearer that language preferences
(language and opaclanguages) can be re-ordered by the user to control
the sequence of their appearance in language-selection menus.
This patch makes some minor markup changes (including some whitespace
fixes -- diff accordingly) in order to make it easier to apply these CSS
changes.
To test you should have more than one translation installed. Apply the
patch and clear your browser cache if necessary.
- Go to Administration -> System preferences -> I18N/L10N
- The 'language' and 'opaclanguages' system preferences should show the
new style.
- Each language should show a "move" cursor when the mouse hovers
over the "box."
- Dragging and dropping the languages should work correctly, and
changes should be reflected in language menus.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit dae703cb792d031562f5c4a75eacd6a86c1f9087
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Feb 15 14:40:34 2019 +0000
Bug 22349: Remove overzealous database deletions from test
For no apparent reason a whole lot of data was being deleted inside a
transaction for each of the subtests in Koha/Acquisitions/Booksellers.t
This patch simply remove the deletions. To test, run the test before and
after applying the patch and they should all continue to pass.. If you
have a large number of booksellers, baskets, orders or subscriptions in
your database you may also see an decrease in the time it takes to run
the test.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ab1f9af117fa8e2d2ff143126b82b88a43ff6bf8
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Feb 27 07:47:00 2019 -0500
Bug 21241: (RM follow-up) Fix error in update description
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Letters.pm | 7 +-
C4/Overdues.pm | 67 ++--------
C4/Reserves.pm | 2 +-
C4/SIP/Sip/MsgType.pm | 8 +-
Koha.pm | 2 +-
Koha/Account/Line.pm | 23 ++--
Koha/Plugins/Base.pm | 7 +-
catalogue/detail.pl | 1 +
etc/SIPconfig.xml | 2 +
installer/data/mysql/updatedatabase.pl | 21 ++-
koha-tmpl/intranet-tmpl/prog/css/preferences.css | 40 ++++++
.../prog/en/modules/admin/preferences.tt | 66 +++++-----
.../prog/en/modules/catalogue/detail.tt | 1 +
.../intranet-tmpl/prog/js/pages/preferences.js | 4 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 3 +
opac/opac-detail.pl | 1 +
t/db_dependent/Koha/Account/Lines.t | 18 +--
t/db_dependent/Koha/Acquisition/Booksellers.t | 17 ---
t/db_dependent/Plugins.t | 27 +++-
t/db_dependent/Reserves/AutoUnsuspendReserves.t | 135 +++++++++++++++++---
t/db_dependent/SIP/Message.t | 34 ++++-
21 files changed, 328 insertions(+), 158 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list