[koha-commits] main Koha release repository branch master updated. v18.11.00-122-g986a52d
Git repo owner
gitmaster at git.koha-community.org
Tue Jan 8 17:10:04 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 986a52d718d4219f32a79a045d5867a3d70092d5 (commit)
via 814078ab401900a118558b828a9dc796c9a81c87 (commit)
via 4c742b59f75cf56a844b0b8eed1b15a0313a7783 (commit)
via 55f042762939755537a3b9a4b578d55ff9c517ba (commit)
via a03eed982bdd28a49f688c742d9e28a780ef12a6 (commit)
via 3607fdfe7966b4db8cb69331f097278d09363fd2 (commit)
via b32756a5d7819e13290c2a145f3f0009280785c4 (commit)
via f44e37b201d0a8b95b1eee0ac0766bed9c386fc2 (commit)
via 70abd7698f02a7da791490607f43df9f781390d2 (commit)
via 96adab7af8999da7f351169e1265d4be5e59742f (commit)
via 482b323da1e18324941963359b9a1bd96f297c44 (commit)
via c9c3fc4368ee9d37a45c48167d25d5cee511898b (commit)
via 4d671103f420f1c0b80bcbf13be613b69e2aa4f9 (commit)
via 3ef3ecfe99e219fda854ca57c652e3c52a7f47d7 (commit)
from 224718b3adee28d33999379b0ebab1092ae88169 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 986a52d718d4219f32a79a045d5867a3d70092d5
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Dec 27 11:40:12 2018 -0300
Bug 21786: (QA follow-up) library_id can be null
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 814078ab401900a118558b828a9dc796c9a81c87
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Nov 9 16:29:43 2018 -0300
Bug 21786: Make balance and credits endpoints handle library_id
This patch:
- Adds the branchcode <-> library_id mapping in the controller
- Adds 'library_id' to the credit and account_line definitions
- Makes add_credit handle the library_id param, passing it to the
underlying $account->add_credit method.
To test:
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> FAIL: Tests fail, because library_id is not mapped
(balance) and because it is not handled when adding a credit.
- Apply this patch
- Run:
k$ prove t/db_dependent/api/v1/patrons_accounts.t
=> SUCCESS: Tests pass!
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4c742b59f75cf56a844b0b8eed1b15a0313a7783
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Nov 9 16:29:15 2018 -0300
Bug 21786: Unit tests
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 55f042762939755537a3b9a4b578d55ff9c517ba
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Nov 9 16:35:31 2018 -0300
Bug 21786: Add library_id to the spec definitions
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a03eed982bdd28a49f688c742d9e28a780ef12a6
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Jan 8 14:27:55 2019 +0000
Bug 21813: Compiled CSS
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3607fdfe7966b4db8cb69331f097278d09363fd2
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Nov 12 17:35:25 2018 +0000
Bug 21813: In-page JavaScript causes error on patron entry page
This patch removes a block of JavaScript from memberentrygen.tt which
was being included in the page before jQuery is loaded. This causes a
JavaScript error.
To test, apply the patch, regenerate CSS, and clear your browser cache
if necessary.
- In Administration -> Patron categories, confirm that you have two
patron categories with different default messaging preferences
defined.
- Go to Patrons -> New patron
- Create a new patron using one of the categories with messaging
preferences.
- Confirm that when you switch the category selection to the other
patron category, the patron messaging preference checkboxes are
changed to the default for that category.
- A "Loading" indicator should appear above the checkboxes to show
that an operation is in process. It should disappear when new
default prefs are loaded.
- Manually change one or more patron messaging preference checkboxes.
- Switch the patron category again and confirm that you are prompted
to confirm resetting the preferences to the default for that
category.
- Perform the same set of tests when editing a patron.
- Defaults should not be loaded during the edit process.
- Confirm that there are no other JavaScript errors in the console.
- Test again with EnhancedMessagingPreferences disabled.
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b32756a5d7819e13290c2a145f3f0009280785c4
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Dec 28 18:48:25 2018 +0000
Bug 22052: Refactor DeleteExpiredOpacReigstrations
This patch changes the sub to use Koha::Objects and updates the tests.
Previously the sub would die on borrowers with checkouts and would
delete borrowers if they had fines
To test:
1 - prove -v t/db_dependent/
2 - Set your selfreg preferences:
PatronSelfRegistration: Allow
PatronSelfRegistrationDefaultCategory: SELFREG (or of your choice)
PatronSelfRegistrationExpireTemporaryAccountsDelay: 30
3 - Register a patron into SELFREG or how you set above
4 - Set their date enrolled to two months ago
5 - Checkout an item to the patron
6 - Issue a fine to that patron
7 - perl misc/cronjobs/cleanup_database.pl --del-exp-selfreg -v
8 - The job should die with an error
9 - Check in the item
10 - run the corn again - patron is deleted, oops
11 - Apply patch
12 - Create another patron in the same way
13 - Checkout and fine the patron
14 - run the cron
15 - they are not deleted, and no error
16 - checkin the item
17 - run the cron
18 - they are not deleted and no error
19 - clear the fine
20 - run the cron
21 - patron is deleted, huzzah
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f44e37b201d0a8b95b1eee0ac0766bed9c386fc2
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Dec 28 18:48:15 2018 +0000
Bug 22052: Unit tests
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 70abd7698f02a7da791490607f43df9f781390d2
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Jan 8 14:01:45 2019 +0000
Bug 22030: DBRev 18.12.00.005
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 96adab7af8999da7f351169e1265d4be5e59742f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Dec 19 17:53:08 2018 +0000
Bug 22030: Use preference to determine username sent to overdrive
Overdrive configuration generally defaults to cardnumber, however, they
have confirmed that some libraries use usernames. We need to allow for
both scenarios.
To test:
1 - Have an OverDrive account setup with SIP authentication
Note: You can apply for a testing account at developer.overdrive.com
and setup an environment
2 - Fill in all your OverDrive system preferences
3 - Test with a patron whose username is their cardnumber
4 - Confirm their overdrive account tab on opac loads
5 - Change the username to be another value like "borked_wont_work"
6 - Note the overdrive account tab won't load
7 - Apply patch, update database, not new system preference
OverDriveUsername (default to 'cardnumber)
8 - Note the OD account loads successfully
9 - Change the system preference to 'user name' - the account load fails
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 482b323da1e18324941963359b9a1bd96f297c44
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Dec 13 14:59:38 2018 +0100
Bug 21605: (follow-up) Simple ternary boolean to number conversion
Imo it is much easier to do just "$a ? 1 : 0" than testing defined($a) etc.
in the additional loop.
Less code, more readable?
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c9c3fc4368ee9d37a45c48167d25d5cee511898b
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Fri Oct 26 10:42:13 2018 +0100
Bug 21605: Ensure EDI acct fields set to boolean val
Validate the input to the fields indicating account
functionality. The only valid values are 1 and 0
non-integer (or integers other than 0/1) are invalid
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4d671103f420f1c0b80bcbf13be613b69e2aa4f9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jan 2 09:56:52 2019 -0300
Bug 22059: Fix exception params in Koha::Patron->set_password
This simple patch fixes a wrong call to ->throw. Parameters shouldn't be
enclosed in curly brackets.
To test:
- Apply the tests patch
- Run:
$ kshell
k$ prove t/db_dependent/Koha/Patrons.t
=> FAIL: Tests fail because the throw call is wrong
- Apply this patch
- Run:
k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass!
-Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3ef3ecfe99e219fda854ca57c652e3c52a7f47d7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jan 2 09:56:21 2019 -0300
Bug 22059: regression tests
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Members.pm | 40 ++++++++--------
Koha.pm | 2 +-
Koha/Patron.pm | 2 +-
Koha/REST/V1/Patrons/Account.pm | 6 ++-
admin/edi_accounts.pl | 10 ++--
api/v1/swagger/definitions/account_line.json | 7 +++
.../swagger/definitions/patron_account_credit.json | 4 ++
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 10 ++++
.../intranet-tmpl/prog/css/src/staff-global.scss | 9 ++++
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../admin/preferences/enhanced_content.pref | 6 +++
.../prog/en/modules/members/memberentrygen.tt | 50 ++------------------
.../prog/js/messaging-preference-form.js | 48 +++++++++++++++++++
opac/svc/overdrive | 8 +++-
t/db_dependent/Koha/Patrons.t | 6 ++-
t/db_dependent/Members.t | 35 ++++++++++++--
t/db_dependent/api/v1/patrons_accounts.t | 18 +++++--
18 files changed, 180 insertions(+), 84 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list