[koha-commits] main Koha release repository branch master updated. v18.11.00-163-gd73b7a3
Git repo owner
gitmaster at git.koha-community.org
Fri Jan 11 14:46:38 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via d73b7a3890331076b926434db8fa60ef922e35d9 (commit)
via 1cf849eee0626ff2de4f193e5fb83a05671f6280 (commit)
via a4e699be60b1de9d2b7c5b0fda5f4d668fc45517 (commit)
via f8544ba5799c457057d42aefc63c88e15a08b096 (commit)
via eb979680d7600e8c7e71ddd71003692cff95f9c7 (commit)
via 81430cbcac161db449575b0506d7d7e6852fe9d0 (commit)
via 34677414d1094203a2a692d41feda1751858f890 (commit)
via 09042d0bbffac12c8f37c75b9c1f72590779256d (commit)
via 8e6c789255a60958ed12eb399b1acd21819fd40c (commit)
via 7669697732e3abf3b2c5a32446115d277be7342e (commit)
via cf483fd3758b2402d15245fe8b975cb9ee277e04 (commit)
via fff6777b35195dca489726875039c2bde6b52c2c (commit)
via f75897a9721ce695661bfabb2a6ae7d1f9c50fc3 (commit)
via 88cdccf6fcdf3f8d1bd3e570cf6a6c5ae2c12dc1 (commit)
via 472c576513674877b3f4eb57dca2eda948c25d78 (commit)
via 11c4cd73e19586ea74a7ac5ba7c88989dd8c4f21 (commit)
via 5994296aad5368440c1d901f42fdf3a1b50d62b9 (commit)
via 648808a33f6d482f082530526d2a8776dd88f5bd (commit)
via cd427190d0138fab9cef8aaf008c9705707da7dc (commit)
via 7ece45328481988b472cbd9f68bf412a36acd117 (commit)
via 89b8414d3fd8ce8426d9747ec2489f7abf5985a1 (commit)
from 4e6d64c16361ec3c00813c291b56ecf5657eff1f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d73b7a3890331076b926434db8fa60ef922e35d9
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Nov 7 19:01:16 2018 +0000
Bug 21785: Add columns configuration to hold ratios report
This patch adds column configuration to the hold ratios report
DataTable.
This patch also amends some JavaScript and markup related to some
obsolete jQuery syntax: A hover function was being used to change an
element's style on hover. It has been removed in favor of using a link
and CSS>
To test, apply the patch and view the hold ratios report using a ratio
which will return multiple results. Confirm that DataTables controls
work correctly: Paging, search, column visibility, export and print.
Click a number in the "hold ratio" column of the table and verify that
it populates the "hold ratio" field in the "refine results" form in the
sidebar.
Test setting default column configurations in Administration -> Columns
settings.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1cf849eee0626ff2de4f193e5fb83a05671f6280
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 2 15:14:03 2018 +0000
Bug 21442: Update two-column templates with Bootstrap grid: Circulation part 1
This patch modifies several circulation templates to use the
Bootstrap grid instead of YUI.
This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.
To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:
- Circulation -> Pending on-site checkouts (enable OnSiteCheckouts
preference).
- Test with the CircSidebar system preference both on and off
- Circulation -> Overdues
- Circulation -> Holds to pull
- Circulation -> Renew
- Test with the CircSidebar system preference both on and off
- Circulation -> Bibliographic detail page -> Request article (enable
ArticleRequests system preferences)
- Circulation -> Hold ratios
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a4e699be60b1de9d2b7c5b0fda5f4d668fc45517
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Nov 8 19:57:36 2018 +0000
Bug 21797: Update two-column templates with Bootstrap grid: Acquisitions part 5
This patch adds or corrects Bootstrap grids on three
acquisitions-related templates.
To test, apply the patch and confirm that these pages look correct and
adjust well to various browser widths:
- Acquisitions -> Vendor -> Basket -> View
- Acquisitions -> Vendor -> Details
- Acquisitions -> Vendor -> Basket -> Add to basket -> From a new
(empty) record
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f8544ba5799c457057d42aefc63c88e15a08b096
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 17 18:26:47 2018 -0300
Bug 21999: Move attributes to a variable to not dup them
Avoid c/p as much as possible :)
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit eb979680d7600e8c7e71ddd71003692cff95f9c7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 17 18:21:04 2018 -0300
Bug 21999: FIXMEs are fixed!
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 81430cbcac161db449575b0506d7d7e6852fe9d0
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Dec 14 15:03:46 2018 +0000
Bug 21999: Update Tests to reflect new return value of AddIssue
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 34677414d1094203a2a692d41feda1751858f890
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Dec 14 12:27:01 2018 +0000
Bug 21999: Use Koha::Checkout in C4::Circulation::AddIssue
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 09042d0bbffac12c8f37c75b9c1f72590779256d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 18 09:24:21 2016 -0400
Bug 21803: Redesign authorized values interface
This patch redesigns the authorized values management interface. The
primary change is that the initial view of authorized values is now a
table listing all authorized values categories and their descriptions.
Descriptions have been added or updated according to the text of the
manual.
To test, apply the patch and go to Administration -> Authorized values.
- You should see a table of authorized values displayed in a
DataTables-formatted table.
- Click a category. You should be taken to the list of authorized
values for that category. If there are none defined you should see
a message saying so, including a button to add one.
- Click the "Add" button next to an authorized value category. It
should take you to the form for adding an authorized value to that
category.
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8e6c789255a60958ed12eb399b1acd21819fd40c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 26 14:55:53 2018 -0300
Bug 21912: (QA follow-up) Do not delete existing patrons
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7669697732e3abf3b2c5a32446115d277be7342e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Nov 29 11:59:05 2018 -0300
Bug 21912: Add tests for Koha::Objects->search
This patch adds simple tests for the current behaviour. Specifically the
return values in both scalar and list context.
To test:
- Apply this patch
- Run:
$ prove t/db_dependent/Koha/Objects.t
=> SUCCESS: Tests pass
- Sign off :-D
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cf483fd3758b2402d15245fe8b975cb9ee277e04
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Thu Dec 13 20:01:24 2018 -0300
Bug 19458: (follow-up) Self-check module highlighting
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fff6777b35195dca489726875039c2bde6b52c2c
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Thu Dec 13 01:51:38 2018 -0300
Bug 19458: Self-check module highlighting
In SCO Module there is no difference on how new checkouts and renewals are shown from previous ones. This commit is done to address that issue.
How to test:
1. Go to /cgi-bin/koha/sco/sco-main.pl and login.
2. Checkout a new item.
3. In checkout's table new checkouts should be easily identifiable.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f75897a9721ce695661bfabb2a6ae7d1f9c50fc3
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 2 16:38:08 2018 +0000
Bug 21963: Update two-column templates with Bootstrap grid: Patrons part 1
This patch modifies several patron templates to use the
Bootstrap grid instead of YUI.
This patch also removes obsolete "text/javascript" attributes from
<script> tags in the modified templates.
To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:
- Patrons -> View patron
- Fines
- Account
- Create manual credit
- Delete
- Try to delete a patron with checkouts
- Discharges
- Housebound
- Files
- Holds history
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 88cdccf6fcdf3f8d1bd3e570cf6a6c5ae2c12dc1
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 2 15:51:21 2018 +0000
Bug 21569: Update two-column templates with Bootstrap grid: Circulation part 3
This patch modifies several circulation templates to use the
Bootstrap grid instead of YUI.
This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.
To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:
With each of these pages, test with CircSidebar preference both on
and off
- Circulation -> Returns
- Circulation -> Set library
- Circulation -> Transfers to receive
- Circulation -> Holds queue
- Circulation -> Holds awaiting pickup
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 472c576513674877b3f4eb57dca2eda948c25d78
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Fri Dec 14 16:50:39 2018 +0000
Bug 22003: Remove unused subroutines displaylog and GetLogStatus from C4::Log
These two routines are not used
Test plan:
0) Apply the patch
1) git grep GetLogStatus should return no occurence
2) git grep displaylog should return no occurence
3) prove t/Log.t should return green
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 11c4cd73e19586ea74a7ac5ba7c88989dd8c4f21
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Dec 12 12:09:46 2018 +0000
Bug 21727: Add handling for cases requireing patron refunds
As it is possible to partially pay off a fine that is still incrementing
we can end up in a position (when dropbox mode is enabled) where the
patron may be owed money by the library should they have paid off the
fine between dropping the item off in dropbox mode and the increment
that reverts the increase on the dropbox day.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5994296aad5368440c1d901f42fdf3a1b50d62b9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 12 10:49:18 2018 -0300
Bug 21727: Unit tests for the refund case
This patch introduces tests for the behaviour when the negative adjust
exceedes the amount that was already paid. In this case, the line amount
is expected to be set to 0, and a credit with the payed amount created.
To test:
- Apply this patch
- Run:
$ kshell
k$ prove t/db_dependent/Koha/Account/Lines.t
=> SUCCESS: tests pass!
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 648808a33f6d482f082530526d2a8776dd88f5bd
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Dec 11 17:45:15 2018 +0000
Bug 21727: Add clarifications to the POD of adjust
Sponsored-by: PTFS Europe
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cd427190d0138fab9cef8aaf008c9705707da7dc
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Dec 11 12:35:29 2018 -0300
Bug 21727: (QA follow-up) Test lastincrement changes
'adjust' changes the 'lastincrement column, and this behaviour should be
tested. This patch just adds tests for that.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7ece45328481988b472cbd9f68bf412a36acd117
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Nov 1 17:12:14 2018 +0000
Bug 21727: Add ->adjust to Koha::Account::Line
This patch introduces a high-level method for updating existing debits,
similar to Koha::Account::add_credit and Koha::Account::add_debit.
It updates the Koha::Account::Line object, and adds an offset. It also
logs if required.
It whitelists the account types that are allowed to be adjusted, just in
case some others require adjusting, having a single source for truth.
To test:
- Apply this patches
- Run:
$ kshell
k$ prove t/db_dependent/Koha/Account/Lines.t
=> SUCCESS: Tests pass!
Sponsored-by: PTFS Europe
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 89b8414d3fd8ce8426d9747ec2489f7abf5985a1
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Nov 30 11:52:12 2018 +0000
Bug 21727: Add tests for Koha::Account::Line->adjust
Sponsored-by: PTFS Europe
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 32 +-
C4/Log.pm | 107 +------
Koha/Account/Line.pm | 132 ++++++++
admin/columns_settings.yml | 23 ++
.../intranet-tmpl/prog/css/src/staff-global.scss | 4 -
.../intranet-tmpl/prog/en/modules/acqui/basket.tt | 58 ++--
.../prog/en/modules/acqui/neworderempty.tt | 2 +-
.../prog/en/modules/acqui/supplier.tt | 23 +-
.../prog/en/modules/admin/authorised_values.tt | 337 +++++++++++++-------
.../prog/en/modules/circ/on-site_checkouts.tt | 38 ++-
.../intranet-tmpl/prog/en/modules/circ/overdue.tt | 26 +-
.../prog/en/modules/circ/pendingreserves.tt | 25 +-
.../intranet-tmpl/prog/en/modules/circ/renew.tt | 56 ++--
.../prog/en/modules/circ/request-article.tt | 26 +-
.../prog/en/modules/circ/reserveratios.tt | 70 ++--
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 53 +--
.../prog/en/modules/circ/selectbranchprinter.tt | 40 ++-
.../prog/en/modules/circ/transferstoreceive.tt | 39 ++-
.../prog/en/modules/circ/view_holdsqueue.tt | 41 ++-
.../prog/en/modules/circ/waitingreserves.tt | 39 ++-
.../prog/en/modules/members/boraccount.tt | 25 +-
.../prog/en/modules/members/deletemem.tt | 26 +-
.../prog/en/modules/members/discharge.tt | 26 +-
.../intranet-tmpl/prog/en/modules/members/files.tt | 25 +-
.../prog/en/modules/members/holdshistory.tt | 29 +-
.../prog/en/modules/members/housebound.tt | 32 +-
.../prog/en/modules/members/mancredit.tt | 26 +-
.../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 11 +
opac/sco/sco-main.pl | 9 +-
t/Log.t | 19 +-
t/db_dependent/Circulation.t | 4 +-
t/db_dependent/Circulation/issue.t | 6 +-
t/db_dependent/Koha/Account/Lines.t | 119 ++++++-
t/db_dependent/Koha/Objects.t | 28 +-
t/db_dependent/Letters/TemplateToolkit.t | 14 +-
35 files changed, 993 insertions(+), 577 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list