[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.07-37-g08ab9cc

Fri Jan 11 21:33:14 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  08ab9cc291432fc34f950b7a266249af8607c610 (commit)
       via  053eb7a4e76a95da38c981b2f0371f92d4942bda (commit)
       via  8793c0e59180326c2859ac19d5fbec94b19e8cf7 (commit)
       via  be5c32a5b59fe54f9d8f50b81e0f20e059d048f2 (commit)
       via  85374828e93d5b978cd13bbbdc583ea2a077a3b3 (commit)
       via  dbef6e17de62cc7aa007c3881fe32e2985fabcd8 (commit)
       via  d95301763e8017d0db18cfd142e2227cbaafaf0c (commit)
       via  054819fb8ef14fd8164953577e562d0bf06da4a6 (commit)
       via  456bcee3563097a930d9f0487352fe3b915a8a98 (commit)
       via  eb13d9dccc30eb2873089b9786cebe02deaf0c4f (commit)
      from  e1050653fba9a2eb0af5926b8cc9326ca721f939 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 08ab9cc291432fc34f950b7a266249af8607c610
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jan 7 07:38:29 2019 -0300

    Bug 22071: (follow-up) Add POD for validate_query_parameters

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 551626ce1e82286414c4a77c83febdcfbc99741a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit f8bd298a0817bf6811c88fe7b441626c059b4f6f)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 053eb7a4e76a95da38c981b2f0371f92d4942bda
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jan 7 07:31:43 2019 -0300

    Bug 22071: (follow-up) Simplify code

    In order to add features to this method, the current code would force us
    to do it for each authentication method.

    There's duplicated code that could be simplified. This patch makes the
    authentication code just set $user on each block (oauth and cookie
    authentication) and moves the final permissions check to the end of the
    authenticate_api_request method.

    Overall, the behaviour remains unchanged.

    To test:
    - Run:
      $ kshell
     k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \
              t/db_dependent/api/v1/oauth.t
    => SUCCESS: Tests pass! Nothing changed!
    - Sign off :-D

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0d5058b7b29d90cc7c8e533ee56388fbb5a96d52)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a6dc145ce966338ec0ae96f7e32968149647c02f)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 8793c0e59180326c2859ac19d5fbec94b19e8cf7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jan 4 12:46:37 2019 -0300

    Bug 22071: Make authenticate_api_request stash koha.user in OAuth use case

    This patch makes the OAuth code stash the requestion Koha::Patron.

    To test:
    - Apply the tests patch:
    - Run:
      $ kshell
     k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
    => FAIL: Tests fail :-(
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
    => SUCCESS: Tests pass :-D
    - Sign off =D

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 613a0034e08af84af1e2198156bbfc6900ba6551)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 84ddb45e884394d08ba4dc836d3209e11e351048)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit be5c32a5b59fe54f9d8f50b81e0f20e059d048f2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jan 4 12:37:27 2019 -0300

    Bug 22071: Regression tests

    The authenticate_api_request() behaviour needs more tests. This patch
    adds tests for the stashed Koha::Patron object. It highlights the bug in
    the OAuth authentication case.

    To test:
    - Apply this patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
    => FAIL: Tests fail in the OAuth case, pass in the cookie-based auth
    case.

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 2067b8e3f8cb363370897ff179bcdbf5c97cbbbb)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d830a2f0973fa6ffd634a9665f93a53c325c2d7a)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 85374828e93d5b978cd13bbbdc583ea2a077a3b3
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Oct 31 12:50:27 2018 +0000

    Bug 22073: Add to diacritics mappings for Ž and ž

    To test:
    1 - Find or add a record by author Slavoj Žižek
    2 - Search for 'Zizek'
    3 - No results
    4 - Apply patch
    5 - Reindex
    6 - Search again
    7 - Success!

    https://bugs.koha-community.org/show_bug.cgi?id=22073

    Signed-off-by: Eric Phetteplace <ephetteplace at cca.edu>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5c313bc554a857da29f124957d58459c0ed4c03b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit aee127e6397db9594c97d06b684cdeabf6f50e0d)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit dbef6e17de62cc7aa007c3881fe32e2985fabcd8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 19 16:00:52 2018 -0300

    Bug 22020: (bug 21777 follow-up) Fix columns visibility for circulation.pl

    The table is used by circulation.pl and moremember.pl
    When it is modified we need to take care of the two view.

    Test plan:
    Use the columns settings to hide/show the "check in" and other columns
    Confirm the this patch fixes the display for moremember.pl

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 17a8eb187959625ef67eea9999588fe502443691)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a02a19ffea86e64b65164e7578b5d9b8f611a064)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit d95301763e8017d0db18cfd142e2227cbaafaf0c
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Dec 28 18:48:25 2018 +0000

    Bug 22052: Refactor DeleteExpiredOpacReigstrations

    This patch changes the sub to use Koha::Objects and updates the tests.
    Previously the sub would die on borrowers with checkouts and would
    delete borrowers if they had fines

    To test:
     1 - prove -v t/db_dependent/
     2 - Set your selfreg preferences:
        PatronSelfRegistration: Allow
        PatronSelfRegistrationDefaultCategory: SELFREG (or of your choice)
        PatronSelfRegistrationExpireTemporaryAccountsDelay: 30
     3 - Register a patron into SELFREG or how you set above
     4 - Set their date enrolled to two months ago
     5 - Checkout an item to the patron
     6 - Issue a fine to that patron
     7 - perl misc/cronjobs/cleanup_database.pl --del-exp-selfreg -v
     8 - The job should die with an error
     9 - Check in the item
    10 - run the corn again - patron is deleted, oops
    11 - Apply patch
    12 - Create another patron in the same way
    13 - Checkout and fine the patron
    14 - run the cron
    15 - they are not deleted, and no error
    16 - checkin the item
    17 - run the cron
    18 - they are not deleted and no error
    19 - clear the fine
    20 - run the cron
    21 - patron is deleted, huzzah

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b32756a5d7819e13290c2a145f3f0009280785c4)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 8102f6dc70623786c3247e008a0601cfd234d1e6)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 054819fb8ef14fd8164953577e562d0bf06da4a6
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Dec 28 18:48:15 2018 +0000

    Bug 22052: Unit tests

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f44e37b201d0a8b95b1eee0ac0766bed9c386fc2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 2bc4f25855819990f5d5fbcd244a0ef6dd3d89e6)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 456bcee3563097a930d9f0487352fe3b915a8a98
Author: Jesse Maseto <jesse at bywatersolutions.com>
Date:   Fri Jan 11 19:07:16 2019 +0000

    Bug 22030: DBRev 18.05.07.002

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit eb13d9dccc30eb2873089b9786cebe02deaf0c4f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Dec 19 17:53:08 2018 +0000

    Bug 22030: Use preference to determine username sent to overdrive

    Overdrive configuration generally defaults to cardnumber, however, they
    have confirmed that some libraries use usernames. We need to allow for
    both scenarios.

    To test:
    1 - Have an OverDrive account setup with SIP authentication
        Note: You can apply for a testing account at developer.overdrive.com
        and setup an environment
    2 - Fill in all your OverDrive system preferences
    3 - Test with a patron whose username is their cardnumber
    4 - Confirm their overdrive account tab on opac loads
    5 - Change the username to be another value like "borked_wont_work"
    6 - Note the overdrive account tab won't load
    7 - Apply patch, update database, not new system preference
    OverDriveUsername (default to 'cardnumber)
    8 - Note the OD account loads successfully
    9 - Change the system preference to 'user name' - the account load fails

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 96adab7af8999da7f351169e1265d4be5e59742f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 274271b59d5491dc44ebe7bbfb12da13e96d2ceb)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm                                      |   40 +++---
 Koha.pm                                            |    2 +-
 Koha/REST/V1/Auth.pm                               |  110 ++++++++-------
 admin/columns_settings.yml                         |    5 +
 etc/zebradb/etc/word-phrase-utf.chr                |    2 +
 installer/data/mysql/sysprefs.sql                  |    1 +
 installer/data/mysql/updatedatabase.pl             |   11 ++
 .../admin/preferences/enhanced_content.pref        |    6 +
 opac/svc/overdrive                                 |    8 +-
 t/db_dependent/Members.t                           |   35 ++++-
 .../api/v1/auth_authenticate_api_request.t         |  145 ++++++++++++++++++++
 11 files changed, 284 insertions(+), 81 deletions(-)
 create mode 100755 t/db_dependent/api/v1/auth_authenticate_api_request.t

hooks/post-receive
-- 
main Koha release repository