[koha-commits] main Koha release repository branch master updated. v18.11.00-191-g8ad2c20
Git repo owner
gitmaster at git.koha-community.org
Fri Jan 18 22:12:01 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 8ad2c206cba1b737e69393e2e3cd92076fb94e17 (commit)
via 03e5ec617070fdc31829f04612c821e4f83facc1 (commit)
via 45deff8b43d32865cfeeb516c8ffc1140f294c22 (commit)
via 95ce61fd3e2c7f41d14e570da3bb8bf05373c65e (commit)
via e0b1f945f9cdb4efd8b4403855cdc995023dc8be (commit)
via b608f548a894cb433c4218b94a33d6b8a824a4c4 (commit)
via 6c8089b40fef1b59ab056bae8817933afdb2fcc3 (commit)
via 58f04600f084e2bb5306f18bba1b9a0b22e1664b (commit)
via 8d2324e6de6f639904d188cd432e14add4874779 (commit)
via 1bdf69f49b11c67a751796b53bdad1edb8242eda (commit)
via 99a75aca903eb076d12b46c3546e86d917d1e244 (commit)
via 0d9a42b492ca21cc14fab69d0facb80aeb8dcff4 (commit)
via 9a8828850a23d592275ab4d48fae61b89c0a9868 (commit)
via 7028cb8aea3f03f120c54269554953ec7475cdd8 (commit)
via 76c10a5dcd37666f641fddd43231b32793f55b1b (commit)
via 824e9a7c9e3dc2f46043b5a4361d8beb57419d15 (commit)
from 2bab07458f37de6af078e27b95c4b85bc3422b22 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 8ad2c206cba1b737e69393e2e3cd92076fb94e17
Author: helene hickey <hickeyhe at wgc.school.nz>
Date: Tue Jan 15 23:07:34 2019 +0000
Bug 20274: Itemtypes report gives zero results if item-level_itypes set to bibliographic records
1) Go to reports then catalog by item types
2) Pick a location and look at table
3) Change the system prefernce of item-level_itypes
4) Verify a zero result
5) Apply patch and retry
6) Verify that result does not change to zero on either preference
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 03e5ec617070fdc31829f04612c821e4f83facc1
Author: Ethan Amohia <ethan.amohia at gmail.com>
Date: Wed Jan 16 03:26:36 2019 +0000
Bug 22122: Rearranged inputs from a patrons basket in Acquisitions.
Test Plan:
1. From home page, go to "Acquisitions"
2. Add a test vendor under "New vendor"
3. Give the vendor any name and click "Save"
4. Click "New Basket"
5. Give the basket a name and click "Save"
6. Click on "Add to basket"
7. Click on "From an external source"
8. Note the order of inputs (ISBN, ISSN, Title...)
9. Go back to the homepage
10. Go to "Cataloging"
11. Click on "New from Z39.50/SRU" button. A new window should open
12. The order of inputs under 'Z39.50/SRU Search' should all match the
order of inputs from step 8. (Except "Select MARC framework)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 45deff8b43d32865cfeeb516c8ffc1140f294c22
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jan 11 16:27:17 2019 +0000
Bug 22101: Ill Requests missing in menu on advanced search page
This patch adds [% USE Koha %] to header.inc so that Koha.Preference
calls will work correctly.
To test, apply the patch and log in to the staff client as a user who
has permission to access the ILL module.
- Go to the catalog's advanced search page
- Cnfirm there is a header menu item under "More" for
"ILL requests."
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 95ce61fd3e2c7f41d14e570da3bb8bf05373c65e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jan 14 08:04:51 2019 -0300
Bug 22125: branches.pickup_location should be flagged as boolean
This trivial patch just marks the mentioned column as a boolean.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
https://bugs.koha-community.org/show_bug.cgi?id=16497
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e0b1f945f9cdb4efd8b4403855cdc995023dc8be
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 13 12:55:55 2018 -0300
Bug 21192: Do not pick SelfRegistration hidden fields for SelfModification
There was a mix up between "modification" and "edit" for $action in
opac-memberentry.pl.
If a patron is logged into the OPAC and they attempt to submit changes to their
personal details without having actually changed anything, the page reloads with
a message stating 'No changes were made.' However, the fields that now appear
are those that have been allowed/hidden according to the preferences set for
patron self registration, even if patron self registration is disabled. This can
lead to problems if there are discrepancies between the fields allowed for self
register settings and those allowed for patron self modification settings.
To replicate:
1.) In Administration › System preferences > OPAC, set PatronSelfRegistration to
'don't allow'
2.) Modify the unwanted fields for PatronSelfModificationBorrowerUnwantedField
and PatronSelfRegistrationBorrowerUnwantedField so that at least one field is
different between the two settings and save (for example, specify 'mobile' to be
hidden in the former, but don't include in the list of fields to be hidden in
the latter).
3.) Log into the OPAC and navigate to the 'your personal details' tab. Notice
that the editable fields correspond to those not hidden by
PatronSelfModificationBorrowerUnwantedField
4.) Without making any changes, click on 'Submit update request'.
5.) Note that on this page the fields correspond to those not hidden by
PatronSelfRegistrationBorrowerUnwantedField and are now editable (including any
fields that would otherwise be hidden by the Self Modification settings).
Reported-By: Chris Slone <cslone at camdencountylibrary.org>
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b608f548a894cb433c4218b94a33d6b8a824a4c4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 17 12:55:34 2018 -0300
Bug 21170: Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail
Easily removed switching the two conditions.
Test plan:
Hit catalogue/MARCdetail.pl?biblionumber=1
=> Without this patch you will see in the log warnings like
Argument "ddc" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/catalogue/MARCdetail.pl line 277.
=> With this patch applied the warnings do no longer appear
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6c8089b40fef1b59ab056bae8817933afdb2fcc3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Dec 14 16:15:24 2018 -0300
Bug 22006: Handle undefined itemnumber for Koha::Account::Line->item
If there is no item linked to an account line, the ->item method should return undef.
Without this patch it explodes with:
Carp::croak('DBIC result _type isn\'t of the _type Item') called at /home/vagrant/kohaclone/Koha/Object.pm line 102
Exists since the introduction of this method by bug 12001
Reported on bug 19489 comment 18.
Test plan:
prove t/db_dependent/Koha/Account/Lines.t
must return green
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 58f04600f084e2bb5306f18bba1b9a0b22e1664b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Dec 14 16:14:42 2018 -0300
Bug 22006: Add tests
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8d2324e6de6f639904d188cd432e14add4874779
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Jan 8 14:32:19 2019 +0100
Bug 22082: ambiguous column in patron stats
In Reports > Patrons statistics, the combination of activity and extended attributes generates an invalid SQL query with error :
ERROR 1052 (23000): Column 'borrowernumber' in IN/ALL/ANY subquery is ambiguous
This is because FROM contains tables borrowers and borrower_attributes both containing borrowernumber column.
Test plan :
1) Be sure to have a patron extended attribute
2) Be sure you have some recent circulation activity
3) Go to Reports > Patrons statistics
4) Select 'active' in 'Patron activity' and 1 years of activity
5) Check 'Row' in 'Patron category'
6) Check 'Columns' in a extended attribute
7) Submit
8) Without patch you have no results, with patch you have exepected results
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1bdf69f49b11c67a751796b53bdad1edb8242eda
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Jan 13 21:26:12 2019 +0000
Bug 22002: (QA follow-up) Remove some debugging code from template
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 99a75aca903eb076d12b46c3546e86d917d1e244
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Dec 16 11:02:56 2018 -0300
Bug 22002: (bug 21621 follow-up) Re-add GROUP BY in letter.pl and fix it
Caused by
commit 0cffb0f7589aa52d65bda9a8a4934790a141f3a0
Bug 21621: Remove incorrect GROUP BY from tools/letter.pl
The test plan was not complete enough.
Test plan:
1) Go to Home › Tools › Notices & slips
2) Choose a letter to edit, e.g. PREDUE. Note that there is only a
single row.
3) Click the edit button on the notice.
4) Expand the 'Print' section. Put text into the Message subject and
Message body text areas.
5) Click save, this will take you back to the 'Notices & slips' page.
6) Clone PREDUE for a specific library
7) The 'all libraries' option must list the templates for all libraries,
but without duplicate
8) Select a library in the dropdown list: only the templates for the
given library is listed, without duplicate
Signed-off-by: Barton Chittenden <barton at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0d9a42b492ca21cc14fab69d0facb80aeb8dcff4
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date: Wed Dec 5 16:27:43 2018 +0200
Bug 21084: Fix automatic truncation in authority search
- Makes token splitting work like in biblio search
- Only adds right hand truncation since that's what Zebra also does
- Only adds truncation if the token is not a phrase and ends in a word character
- Adds tests to existing and new QueryBuilder functions
Test plan:
1. Create an authority record for "Duck, Donald"
2. Try contains type authority searches with the following terms and make sure they find the record:
Duck, Donald
donald duck
don duck
"Duck, Donald"
3. Make sure the following search works but does not find anything:
"Duck, Don"
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9a8828850a23d592275ab4d48fae61b89c0a9868
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Jan 2 06:23:57 2019 +0000
Bug 22058: Fix display of empty table cells in OPAC MARC view holdings
I compared the template logic to the MARC detail page in staff.
We use $raw there instead of html, which will also make notes and other
fields with HTML in them display correctly. I am proposing to use the
$raw filter in OPAC as well.
To test:
- Go to the OPAC
- Search for a record with items
- Switch to the MARC view
- Verify empty cells show (html entity for space)
- Apply patch
- Repeat test
- Verify empty table cells now show as empty
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7028cb8aea3f03f120c54269554953ec7475cdd8
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Nov 21 13:40:35 2018 +0000
Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set
To test:
1 - Delete all refund_lost_item_fee_rules form the db
delete from refund_lost_item_fee_rules;
2 - View the Standard circ rules - Default lost item fee refund shows as
'No'
3 - View circ rules for a single library, shows as 'Default (Yes)'
4 - Return a lost item, it actually does refund (this is in the
LostItemFeeRules code, default 1 if not set)
5 - Apply patch
6 - Rule shows as 'Yes'
7 - View a specifc rule, still says Default (Yes)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 76c10a5dcd37666f641fddd43231b32793f55b1b
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed Jan 9 15:51:48 2019 +0100
Bug 22085: fix UNIMARC default XSLT broken by Bug 14716
Bug 14716 added a call to encode-uri() and namespace str. This
namespace declaration is sometimes missing in UNIMARC default XSLT
files.
This patch adds namespace declaration also where encode-uri is not used
because it may be used in the future. And those files are the base for
home made custom files.
Test plan :
1) Use a UNIMARC DB
2) Use default in all XSLT sysprefs
3) Apply patch
4) Perform a search on OPAC
5) Check display is OK
6) Click on a record for detail page
7) Check display is OK
8) Perform a search on staff interface
9) Check display is OK
10) Click on a record for detail page
11) Check display is OK
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 824e9a7c9e3dc2f46043b5a4361d8beb57419d15
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 18 20:12:08 2019 +0000
Bug 7143: Fix typo in adding new dev
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/Account/Line.pm | 1 +
Koha/Schema/Result/Branch.pm | 5 +-
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 50 ++++++++----
catalogue/MARCdetail.pl | 4 +-
docs/history.txt | 2 +-
.../intranet-tmpl/prog/en/includes/header.inc | 1 +
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +-
.../prog/en/modules/acqui/z3950_search.tt | 8 +-
.../prog/en/modules/admin/smart-rules.tt | 4 +-
.../prog/en/xslt/UNIMARCslim2intranetDetail.xsl | 3 +-
.../prog/en/xslt/UNIMARCslim2intranetResults.xsl | 4 +-
.../bootstrap/en/modules/opac-MARCdetail.tt | 2 +-
.../bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 3 +-
.../bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl | 3 +-
opac/opac-memberentry.pl | 6 +-
reports/borrowers_stats.pl | 4 +-
reports/itemtypes.plugin | 4 +-
t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 86 ++++++++++++++++++++
t/db_dependent/Koha/Account/Lines.t | 5 +-
.../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 28 +++----
tools/letter.pl | 2 +
21 files changed, 173 insertions(+), 54 deletions(-)
create mode 100644 t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list