[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.08-14-g86cc395

Wed Jan 23 20:39:21 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  86cc395636c2f45e214c9fbae70d244b4bf6f338 (commit)
       via  51ffaa8a0c7278445a5b90e2269c09fd128bf4ef (commit)
       via  6d75a7cf36223f319bbe38fab30433fed272a7e8 (commit)
       via  1ec07aa782bd364465641e7948bf4bf2c9ccbdc0 (commit)
       via  910649769cd75698fb989351bce7479e39fa436a (commit)
       via  5622b66359474387395b8e607e4bbe12c1f4312a (commit)
       via  e4eb89d1f021568e74bee11dd33fcf65d3a3eecf (commit)
       via  c0b2ad7da5a7ea79dbb79ad1b57c96a01431bb3a (commit)
       via  d82228876363bbfa461f84b70a9078c48d292bb8 (commit)
       via  c6762426d47e1249c8707db0daab39bf5eca8439 (commit)
       via  7dda73dd26e9b34d4fb3fae1f5c88f76d42206db (commit)
       via  73147064bb563e6d0ad0d995cc2d39aee7634f6b (commit)
       via  91fbe63d18c7370a1105c21de890fc81c7583f3f (commit)
       via  dc096dafe6453bbb7412da799f5acc0fff5da781 (commit)
      from  34ddd742f92ae8e0525b7788f30eb4bc88e355c3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 86cc395636c2f45e214c9fbae70d244b4bf6f338
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Nov 21 13:40:35 2018 +0000

    Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set

    To test:
    1 - Delete all refund_lost_item_fee_rules form the db
        delete from refund_lost_item_fee_rules;
    2 - View the Standard circ rules - Default lost item fee refund shows as
    'No'
    3 - View circ rules for a single library, shows as 'Default (Yes)'
    4 - Return a lost item, it actually does refund (this is in the
            LostItemFeeRules code, default 1 if not set)
    5 - Apply patch
    6 - Rule shows as 'Yes'
    7 - View a specifc rule, still says Default (Yes)

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7028cb8aea3f03f120c54269554953ec7475cdd8)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit b940797800ae4546c455aba7fa6570918a97b6af)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 51ffaa8a0c7278445a5b90e2269c09fd128bf4ef
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Jan 9 15:51:48 2019 +0100

    Bug 22085: fix UNIMARC default XSLT broken by Bug 14716

    Bug 14716 added a call to encode-uri() and namespace str.  This
    namespace declaration is sometimes missing in UNIMARC default XSLT
    files.

    This patch adds namespace declaration also where encode-uri is not used
    because it may be used in the future. And those files are the base for
    home made custom files.

    Test plan :
    1) Use a UNIMARC DB
    2) Use default in all XSLT sysprefs
    3) Apply patch
    4) Perform a search on OPAC
    5) Check display is OK
    6) Click on a record for detail page
    7) Check display is OK
    8) Perform a search on staff interface
    9) Check display is OK
    10) Click on a record for detail page
    11) Check display is OK

    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 76c10a5dcd37666f641fddd43231b32793f55b1b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit c494f474ec23b29690ae3eb12310eb282d07c932)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 6d75a7cf36223f319bbe38fab30433fed272a7e8
Author: Jack Kelliher <jke0429 at stacmail.net>
Date:   Tue Jan 15 02:56:23 2019 +0000

    Bug 22011: Fixed Typo on batchMod-edit.tt

    1. Navigate to tools, then batch item modification.
    2. Input a valid barcode into the barcode list input field, and press
    continue.
    3. Under the Edit items heading, text should display "Checking the box
    right next the subfield ..."
    4. Apply patch and refresh page, text should now display "Checking the
    box right next to the subfield ..."

    Signed-off-by: David Nind <david at davidnind.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8ae738785d353e3e894259b2745c6168979359ca)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 2ae4cd4bc9f5faaff9fd8f2bf95bbe127163f4b7)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 1ec07aa782bd364465641e7948bf4bf2c9ccbdc0
Author: Mackey Johnstone <mackeyfj at gmail.com>
Date:   Tue Jan 15 02:56:25 2019 +0000

    Bug 21637: Fixed upercase letter in EasyAnalyticalRecords syspref

    Changed 'Don't Display' to 'Don't display' for the
    EasyAnalyticalRecords options.

    To find fix:

    1.Be loged in as a user who can access sys prefrences.

    2.Go to:
    Koha Administration > Global System Preferences > Cataloging >
    Interface.

    3.Confirm that the dropdown option for EasyAnalyticalRecords is now
    'Don't display'

    Signed-off-by: David Nind <david at davidnind.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7009ef624adb1d611c83690f3aa09bfb10cd9f23)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 266b3389b68dd02211a396d4dd16222a5ec3a9f2)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 910649769cd75698fb989351bce7479e39fa436a
Author: Jasmine Amohia <jasmineamohia.student at wegc.school.nz>
Date:   Tue Jan 15 03:30:52 2019 +0000

    Bug 22036: Indented code where '^I' was written rather than an indent.

    Code was previously written with '^I' where an indent was supposed to
    be. I deleted all '^I's and replaced them with indents.

    To find this change:
    Look at the tags/review.pl file and confirm indentation is correct

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit c29512266dd72991afb6f43e29e37f5db29d0c7b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit e97ce49ba7752b5278c2ea2262401ab6690f211e)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 5622b66359474387395b8e607e4bbe12c1f4312a
Author: Jasmine Amohia <jasmineamohia.student at wegc.school.nz>
Date:   Tue Jan 15 20:59:16 2019 +0000

    Bug 20865: Removed space before : on order receive filters

    I removed space before : on order receive filters

    To find this change:
    1. Create a vendor
    2. Create a basket and add an order to basket
    3. Close basket and select 'receive shipment'
    4. Check that filter options found on the left side of the page finish with a colon and that there is no space before the colon

    Signed-off-by: David Nind <david at davidnind.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3c328b9cf8d36e39b3c7b56226f746fd597362b0)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 2cfff2272e68f483a8054c4d0a96b5304d159d64)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit e4eb89d1f021568e74bee11dd33fcf65d3a3eecf
Author: Olivia Lu <olivialokm at gmail.com>
Date:   Tue Jan 15 03:15:37 2019 +0000

    Bug 20165: Changed uppercase letter to a lowercase letter in the patron search search fields under the plus option.

    Changed "Street Address" to "Street address" in the patron search search
    fields under the plus sign to fit Koha's capitalization rules.

    To find this change:

    1. Go to Patrons and switch in the search to search patrons
    2. Click on the plus sign
    3. Check "Search fields" pull down
    4. "Street Address" should now be "Street address"

    Signed-off-by: David Nind <david at davidnind.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f1748bda4281403629115635dc724e45964707e1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 59a38379b246fa3317d2cdea63f036dad0a5e5a3)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit c0b2ad7da5a7ea79dbb79ad1b57c96a01431bb3a
Author: helene hickey <hickeyhe at wgc.school.nz>
Date:   Tue Jan 15 03:47:58 2019 +0000

    Bug 22054: Updated the error message for attempting to renew an onsite checkout

    To test:

    1) Enable OnSiteCheckouts system preference
    2) Checkout an item checking the onsite checkout checkbos in more
    options
    3) Go to circulation > pending on-site checkouts
    4) Verify the checkout shows
    5) Go to circulation > renew
    6) Try to renew the on-site checkout using the barcode
    7) Verify display:

    onsite_checkout  Continue without renewing

    8) apply the patch and reload page with error message
    9) verify display:

    Item cannot be renewed because it's an onsite checkout

    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4eab8308353948c81d9a05978584073354cb43e5)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 3dd7d9dfad0052761e4a3e7a93fce6e7d8055c93)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit d82228876363bbfa461f84b70a9078c48d292bb8
Author: Ethan Amohia <ethan.amohia at gmail.com>
Date:   Tue Jan 15 21:45:01 2019 +0000

    Bug 22095: Replaced dead links with working links

    I have updated the broken link everywhere it occurs.

    Confirm that the new link works in the installer.

    Signed-off-by: David Nind <david at davidnind.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit dc8e663c9eeb54ebd26ecf9c7d5ef7c953db283c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 726c0e4bc4216c3c53780169635987bdc1071720)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit c6762426d47e1249c8707db0daab39bf5eca8439
Author: Olivia Lu <olivialokm at gmail.com>
Date:   Tue Jan 15 03:52:30 2019 +0000

    Bug 21866: Changed "report" to "plugins" for the warning "This report was written for an older version of Koha. Run at your own risk"

    To find this change:

    1. Enable use plugins in global system preferences
    2. Go to tools then click tool plugins
    3. Verify that this string now says plugins

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5e2e101037bb2bfb8579fcee331388e56658db84)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 2c6b8230b8fa7dd0a7746327c126565fc8b47dc9)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 7dda73dd26e9b34d4fb3fae1f5c88f76d42206db
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jan 11 15:14:04 2019 -0300

    Bug 22107: patrons.t doesn't need to delete existing data

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 21676d7b873fa1fdd2438f0972bf9f00f09c3474)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit fb455d9b8dc736c25618e0ecbbd7ff156c228baf)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 73147064bb563e6d0ad0d995cc2d39aee7634f6b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jan 11 15:13:27 2019 -0300

    Bug 22107: Make tests use a simpler class, with no FK

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 528e09cf15998744918833fb123a1d04d5762606)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a59826288b5c8706dbe7123bcb7df8707bfc1ce2)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 91fbe63d18c7370a1105c21de890fc81c7583f3f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Dec 26 14:55:53 2018 -0300

    Bug 21912: (QA follow-up) Do not delete existing patrons

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8e6c789255a60958ed12eb399b1acd21819fd40c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 9b6b80488a6b9315b201a3f6d11d0341e58122b5)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit dc096dafe6453bbb7412da799f5acc0fff5da781
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Nov 29 11:59:05 2018 -0300

    Bug 21912: Add tests for Koha::Objects->search

    This patch adds simple tests for the current behaviour. Specifically the
    return values in both scalar and list context.

    To test:
    - Apply this patch
    - Run:
      $ prove t/db_dependent/Koha/Objects.t
    => SUCCESS: Tests pass
    - Sign off :-D

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7669697732e3abf3b2c5a32446115d277be7342e)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 464dcd7d9e2e7ba4e604ef0e7b5665dd8cd8b9b3)

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../optional/marc21_holdings_coded_values.sql      |    2 +-
 .../optional/marc21_holdings_coded_values.txt      |    2 +-
 .../en/optional/marc21_holdings_coded_values.sql   |    2 +-
 .../en/optional/marc21_holdings_coded_values.txt   |    2 +-
 .../optional/marc21_holdings_coded_values.sql      |    2 +-
 .../optional/marc21_holdings_coded_values.txt      |    2 +-
 .../facultatif/marc21_holdings_coded_values.sql    |    2 +-
 .../facultatif/marc21_holdings_coded_values.txt    |    2 +-
 .../optional/marc21_holdings_coded_values.sql      |    2 +-
 .../optional/marc21_holdings_coded_values.txt      |    2 +-
 .../2-Valgfritt/marc21_holdings_coded_values.sql   |    2 +-
 .../2-Valgfritt/marc21_holdings_coded_values.txt   |    2 +-
 .../optional/marc21_holdings_coded_values.sql      |    2 +-
 .../optional/marc21_holdings_coded_values.txt      |    2 +-
 .../prog/en/includes/patron-search.inc             |    4 +-
 .../intranet-tmpl/prog/en/modules/acqui/parcel.tt  |   16 +-
 .../en/modules/admin/preferences/cataloguing.pref  |    2 +-
 .../prog/en/modules/admin/smart-rules.tt           |    4 +-
 .../intranet-tmpl/prog/en/modules/circ/renew.tt    |    3 +
 .../prog/en/modules/plugins/plugins-home.tt        |    2 +-
 .../prog/en/modules/tools/batchMod-edit.tt         |    2 +-
 .../prog/en/xslt/UNIMARCslim2intranetDetail.xsl    |    3 +-
 .../prog/en/xslt/UNIMARCslim2intranetResults.xsl   |    4 +-
 .../bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl   |    3 +-
 .../bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl  |    3 +-
 t/db_dependent/Koha/Objects.t                      |   28 ++-
 t/db_dependent/Koha/REST/Plugin/Objects.t          |  107 +++++-----
 t/db_dependent/api/v1/patrons.t                    |    2 -
 tags/review.pl                                     |  220 ++++++++++----------
 29 files changed, 232 insertions(+), 199 deletions(-)

hooks/post-receive
-- 
main Koha release repository