[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.08-15-gcf3df90

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  cf3df9058af418d70b02085f8bf724989567cee1 (commit)
      from  86cc395636c2f45e214c9fbae70d244b4bf6f338 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cf3df9058af418d70b02085f8bf724989567cee1
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Jan 8 14:32:19 2019 +0100

    Bug 22082: ambiguous column in patron stats
    
    In Reports > Patrons statistics, the combination of activity and extended attributes generates an invalid SQL query with error :
    ERROR 1052 (23000): Column 'borrowernumber' in IN/ALL/ANY subquery is ambiguous
    
    This is because FROM contains tables borrowers and borrower_attributes both containing borrowernumber column.
    
    Test plan :
    1) Be sure to have a patron extended attribute
    2) Be sure you have some recent circulation activity
    3) Go to Reports > Patrons statistics
    4) Select 'active' in 'Patron activity' and 1 years of activity
    5) Check 'Row' in 'Patron category'
    6) Check 'Columns' in a extended attribute
    7) Submit
    8) Without patch you have no results, with patch you have exepected results
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8d2324e6de6f639904d188cd432e14add4874779)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit bccbb54491d3722411cee786000959abade33aa7)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 reports/borrowers_stats.pl |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository