[koha-commits] main Koha release repository branch master updated. v18.11.00-249-g5e1fd62
Git repo owner
gitmaster at git.koha-community.org
Fri Jan 25 22:05:39 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 5e1fd6218c8c3ac991d7a04f1c0b6169b8b7743c (commit)
via a243104bf77e3a3905b6fc55bc9ee883826fc083 (commit)
via 603e619e0cdbe6ddbf39ed54adc5e2bda168ec6e (commit)
via 3cd669e527be0b6c32ce826e1c9cbec60bda10a7 (commit)
via 659253eef12bb213058a8aed835ba6789aa3d9f0 (commit)
via 0ce4ccdceea74fa8b26a2142deecaee3794f7228 (commit)
via 58cbba3c93fba35920d3257a31dea9c760b37330 (commit)
via bf6abd5750f1028e3d7c07a26e48c1966f36e32b (commit)
via a60abd7196dfe801f72628d7839e6549828e6c14 (commit)
via b990b953b324dc18c013f94d1828b61bb5118c60 (commit)
via c61dc7863d00072c7d438c5b4b504bfbe428b65d (commit)
via 454619be4023a379d3de848ddd735cb659a8d5be (commit)
via b4e613ac200f6411386693d45c5f7c7e7959cce8 (commit)
via 03ea0f0b37acdd6eab2374bebc845fcbe1c8eb13 (commit)
via 197a7029f63d1af6c8fbb520e31b946b55df1b9b (commit)
via 72d8a97116c90c1e33fcc7e1f065404fd232895a (commit)
via f822dee088b86edecd5d5c73718ad9f8a04c0664 (commit)
via aefd2bc2f643834a29b387bafbadefb1a5eb253d (commit)
via c425a003fdb347ff7e913e1ad310fd6e775df26a (commit)
via abea0ea9d209805e5a9932265fdd9a3ccdbdd53b (commit)
via 828ab70be705b5bc90d995dabf7787e608bd51e0 (commit)
via 7cb88d24a81f2f265d4f8aa745f20fe93f2384ad (commit)
via 06be533a5137a2f58a9fcc4fe30c769fe8a0f157 (commit)
via a0568daeefc5dddcd35294a1e8879bcdacd4c513 (commit)
via 441040264a74b99b557dbbef6a1714465d708b45 (commit)
via b2b7d376d4854394322310f28d2f5aa1560384e0 (commit)
via d4726c71328c156be519f0f5cf2190a5d6c5c900 (commit)
via 0f0e064a2b232949185a9ee7ef2c911325d15591 (commit)
via 983c1193fa5a5594f69e88fbbd2b2614a2763bc9 (commit)
from 9a9557a1b9d529a6cdd586d70599a39baf5fa961 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 5e1fd6218c8c3ac991d7a04f1c0b6169b8b7743c
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Thu Jan 3 10:05:37 2019 +0000
Bug 22049: (QA follow-up) update MarkIssueReturned call in process_koc.pl
Test plan:
Try to upload koc file with some returns
Success: the file should be correctly processed
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a243104bf77e3a3905b6fc55bc9ee883826fc083
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Dec 31 08:28:03 2018 -0300
Bug 22049: (follow-up) Remove leftover variable
The $circControlBranch variable was originally set to be used to pick
the right dropbox branch. It was only used in MarkIssueReturned, to get
the right Koha::Calendar object. As this responsability was moved top to
the AddReturn caller, and the fact that _GetCircControlBranch is
actually used for fines rules, there's no use for it in this context.
And it was left on the previous patch as a mistake.
To test:
- Make sure the variable is not actually used:
$ git grep '$circControlBranch'
=> SUCCESS: removed variable is not actually used.
- Sign off :-D
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 603e619e0cdbe6ddbf39ed54adc5e2bda168ec6e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Dec 28 15:23:38 2018 -0300
Bug 22049: Add tests
The current tests only check some failure use cases. This patch makes it cover more use cases
To test:
- Apply this patchset
- Run:
$ kshell
k$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> SUCCESS: Tests pass!
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3cd669e527be0b6c32ce826e1c9cbec60bda10a7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Dec 28 14:39:07 2018 -0300
Bug 22049: Make MarkIssueReturned rely on returndate only
This patch changes the params accepted by
C4::Circulation::MarkIssueReturned by removing the $dropbox_branch
param.
This passed branchcode was only used to initialize the Koha::Calendar
object, but the date arithmetic has already taken place in a couple
places before we reach this point. This logic needs to be simplified
(bug 14591), and this is the starting point.
To test:
- Apply this patch
- Run:
$ git grep MarkIssueReturned
=> SUCCESS: Check all the uses of the function either originally passed
undef, or now pass the same date that would've been calculated anyway,
in the returndate param.
- Run:
$ kshell
k$ prove t/db_dependent/Circulation/MarkIssueReturned.t
=> SUCCESS: Tests pass!
- Sign off :-D
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 659253eef12bb213058a8aed835ba6789aa3d9f0
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Dec 28 12:15:53 2018 -0300
Bug 22051: Make Koha::Object->store translate incorrect value exceptions
This patch adds a new condition to Koha::Object->store so it catches
incorrect value-related DBIC exceptions.
This DBIC exceptions get now translated into
Koha::Exceptions::Object::BadValue exceptions with relevant parameters
passed.
To test:
- Apply the exception and unit tests patches
- Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail because this exception handling code is not
implemented
- Apply this patch
- Run:
k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
- Sign off :-D
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0ce4ccdceea74fa8b26a2142deecaee3794f7228
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Dec 28 12:15:36 2018 -0300
Bug 22051: Unit tests
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 58cbba3c93fba35920d3257a31dea9c760b37330
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Dec 28 11:33:13 2018 -0300
Bug 22051: Add Koha::Exceptions::Object::WrongValue
This patch adds a new exception to be thrown in Koha::Object->store when
a DBIC exception is thrown regarding bad data format.
To test:
- Apply this patch
- Run:
$ kshell
k$ prove t/Koha/Exceptions.t
=> SUCCESS: Tests pass!
- Sign off :-D
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit bf6abd5750f1028e3d7c07a26e48c1966f36e32b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Dec 12 08:54:01 2018 +0000
Bug 21002: Add ->add_debit method to Koha::Account
Sponsored-by: PTFS Europe
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a60abd7196dfe801f72628d7839e6549828e6c14
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Dec 12 08:53:37 2018 +0000
Bug 21002: Add tests for Koha::Account::add_debit
Sponsored-by: PTFS Europe
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b990b953b324dc18c013f94d1828b61bb5118c60
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 12 14:59:54 2018 -0300
Bug 21993: Display a user-friendly message when the CSRF token is wrong
Instead of dying!
Test plan:
Assuming you have a patron with borrowernumber=51 and another one that
can be deleted with borrowernumber=42
- authorities-home.pl
* Delete an authority record
* hit /cgi-bin/koha/authorities/authorities-home.pl?op=delete
- basket/sendbasket.pl
* Send a basket to someone
* hit /cgi-bin/koha/basket/sendbasket.pl?email_add=1
- members/apikeys.pl
* Generate and delete an API key for a patron
* hit /cgi-bin/koha/members/apikeys.pl?patron_id=51&op=delete
- members/deletemem.pl
* Delete a patron
* hit /cgi-bin/koha/members/deletemem.pl?member=42&op=delete_confirmed
- members/mancredit.pl
* Add a manual credit
* hit /cgi-bin/koha/members/mancredit.pl?borrowernumber=51&add=1
- members/maninvoice.pl
* Add a manual invoice
* hit /cgi-bin/koha/members/maninvoice.pl?borrowernumber=51&add=1
- members/member-flags.pl
* Change permissions for a patron
* hit /cgi-bin/koha/members/member-flags.pl?member=51&newflags=1
- members/member-password.pl
* Change the password for a patron (from the staff interface)
* hit /cgi-bin/koha/members/member-password.pl?member=51&newpassword=aA1
- members/memberentry.pl
* Edit some patron's info
* hit /cgi-bin/koha/members/memberentry.pl?borrowernumber=51&op=save
- members/paycollect.pl
* Pay an individual fine
* hit something like /cgi-bin/koha/members/paycollect.pl?borrowernumber=51&pay_individual=1&accounttype=L&amount=1.00&amountoutstanding=1.00&accountlines_id=157&paid=1
You may need to edit some values
- tools/import_borrowers.pl
* Import some patrons
* hit /cgi-bin/koha/tools/import_borrowers.pl?uploadborrowers=1
- tools/picture-upload.pl
* Upload an image for a patron
* You will need to edit the html content
hit Home › Tools › Upload patron images
then locate the csrf_token input and modify its value
Note for QA:
- Opac is not done as blocking_errors.inc does not exist for this
interface
- ill/ill-requests.pl
I did not manage to replace this occurrence
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c61dc7863d00072c7d438c5b4b504bfbe428b65d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 2 18:13:33 2018 +0000
Bug 21965: Update two-column templates with Bootstrap grid: Patrons part 3
This patch modifies several patron templates to use the Bootstrap grid
instead of YUI.
This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.
Markup has been corrected in paycollect.tt and readingrec.tt where a
table row lacked <tr>.
To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:
- Patron -> Notices
- Patron -> Purchase suggestions
- Patron -> Circulation history
- Patron -> Routing lists
- Patron -> Statistics
- Patron -> Fines
-> Pay
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 454619be4023a379d3de848ddd735cb659a8d5be
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 2 18:33:04 2018 +0000
Bug 21438: Update two-column templates with Bootstrap grid: Patron card creator
This patch modifies the patron card creator templates to use the
Bootstrap grid instead of YUI.
To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:
- Tools -> patron card creator
- Manage -> Card batches
- Edit card batch
- Manage -> Layouts
- Edit layout
- Manage -> Images
- Manage -> Card templates
- Edit template
- Manage -> Printer profiles
- Edit profile
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b4e613ac200f6411386693d45c5f7c7e7959cce8
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Nov 8 17:10:00 2018 +0000
Bug 21792: Switch two-column templates to Bootstrap grid: Serials part 3
This patch modifies several serials templates to use the
Bootstrap grid instead of YUI.
This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.
To test, apply the patch and go to Serials.
- Add or edit a new subscription. The "create an item..." and "do not
create an item..." labels should look correct.
- Search for subscriptions
- Select two or more subscriptions to batch edit.
- The subscription batch edit page should look correct and adjust
well to various browser widths.
- View a subscription and click the "Renew" button. The subscription
renewal pop-up window should look correct.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 03ea0f0b37acdd6eab2374bebc845fcbe1c8eb13
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 26 13:22:55 2018 -0300
Bug 21992: Remove unused Koha::Patron->update_password method
This patch removes the no longer used method.
To test:
- Apply this patch
- Run:
$ git grep update_password
=> SUCCESS: Only references are in Auth_with_ldap.pm and not related
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 197a7029f63d1af6c8fbb520e31b946b55df1b9b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 26 13:19:05 2018 -0300
Bug 22048: Use set_password in Auth_with_ldap.pm
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 72d8a97116c90c1e33fcc7e1f065404fd232895a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 26 10:59:55 2018 -0300
Bug 22048: Use set_password in tests
To test:
- Apply this patch
- Run:
$ kshell
k$ prove t/db_dependent/Auth.t \
t/db_dependent/Koha/Patrons.t \
t/db_dependent/Search/History.t \
t/db_dependent/selenium/authentication.t \
t/db_dependent/selenium/regressions.t
=> SUCCESS: Tests pass!
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f822dee088b86edecd5d5c73718ad9f8a04c0664
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Dec 13 12:56:42 2018 -0300
Bug 22048: Use set_password opac/opac-password-recovery.pl
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit aefd2bc2f643834a29b387bafbadefb1a5eb253d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Dec 13 12:34:20 2018 -0300
Bug 22048: Use set_password in create_superlibrarian.pl
Use $patron->set_password instead of update_password. In this case the
'skip_validation' param needs to be set as no password strength checks
are expected.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c425a003fdb347ff7e913e1ad310fd6e775df26a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Dec 13 12:21:02 2018 -0300
Bug 22048: Use set_password in memberentry.pl
To test:
- Verify that changing the password and userid of a patron by globally
editing they works,
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit abea0ea9d209805e5a9932265fdd9a3ccdbdd53b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 12 14:43:36 2018 -0300
Bug 22048: Use set_password in member-password.pl
This patch makes member-password.pl use $patron->set_password instead of
update_password. The side effect is that setting password and userid
become separate steps in the code.
For the password all the initial checks are the same, but password
strength is checked on calling set_password and an exception is thrown.
So instead of checking the password quality, we just wait for exceptions
and behave the same as before.
Bonus: you will notice I reused the initially fetched $patron object.
Things get simpler :-D
To test:
- Verify that changing the password / userid for a patron works as usual
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 828ab70be705b5bc90d995dabf7787e608bd51e0
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 12 13:40:54 2018 -0300
Bug 22048: Use set_password in onboarding.pl
To test, verify the onboarding process sets the password correctly.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7cb88d24a81f2f265d4f8aa745f20fe93f2384ad
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date: Thu Nov 22 11:25:20 2018 +0200
Bug 21826: Remove strict and warning from Heading.pm
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 06be533a5137a2f58a9fcc4fe30c769fe8a0f157
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date: Thu Nov 22 11:23:57 2018 +0200
Bug 21826: Move Heading tests to db_dependent since they require database connection
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a0568daeefc5dddcd35294a1e8879bcdacd4c513
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date: Mon Nov 19 14:26:00 2018 +0200
Bug 21826: Add tests
Adds tests for new Heading::valid_bib_heading_subfield and ModBiblio with auto-created authorities.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 441040264a74b99b557dbbef6a1714465d708b45
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Nov 13 16:02:40 2018 +0000
Bug 21826: (QA follow-up) Add UNIMARC support
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b2b7d376d4854394322310f28d2f5aa1560384e0
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date: Tue Nov 13 16:43:50 2018 +0000
Bug 21826: Use subfield map in LinkBibHeadingsToAuthorities
Use only allowable subfields when creating authorities from
bibliographic records.
Sponsored-by: National Library of Finland
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d4726c71328c156be519f0f5cf2190a5d6c5c900
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 26 12:42:28 2018 -0300
Bug 22047: Fix opac/opac-passwd.pl call
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0f0e064a2b232949185a9ee7ef2c911325d15591
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 26 12:37:07 2018 -0300
Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password
This patch makes Koha::Patron->set_password expect a hashref as param
and adds support for an 'skip_validation' param to be passed. Its purpose is to
make the method skip the relevant password strength checks if required.
It targets the Auth_with_ldap.pm usage when the 'update_password' flag
is set in the configuration.
The tests on this bug cover this use case so, to test:
- Apply the tests patch
- Run:
$ kshell
k$ prove t/db_dependent/Koha/Patrons.t
=> FAIL: Tests fail, code doesn't work as expected
- Apply this patch
- Run:
k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass! Yay!
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 983c1193fa5a5594f69e88fbbd2b2614a2763bc9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 26 12:37:00 2018 -0300
Bug 22047: Unit tests
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth_with_ldap.pm | 2 +-
C4/Biblio.pm | 7 +-
C4/Circulation.pm | 69 +++-----
C4/Heading.pm | 20 ++-
C4/Heading/MARC21.pm | 15 ++
C4/Heading/UNIMARC.pm | 15 ++
Koha/Account.pm | 162 ++++++++++++++++-
Koha/Exceptions/Object.pm | 12 ++
Koha/Object.pm | 7 +
Koha/Patron.pm | 69 +++-----
authorities/authorities-home.pl | 9 +-
basket/sendbasket.pl | 9 +-
installer/onboarding.pl | 2 +-
.../prog/en/includes/blocking_errors.inc | 2 +
.../prog/en/modules/basket/sendbasketform.tt | 1 +
.../prog/en/modules/members/member-password.tt | 1 -
.../prog/en/modules/members/notices.tt | 28 +--
.../intranet-tmpl/prog/en/modules/members/pay.tt | 25 +--
.../prog/en/modules/members/paycollect.tt | 29 +--
.../en/modules/members/purchase-suggestions.tt | 28 +--
.../prog/en/modules/members/readingrec.tt | 29 +--
.../prog/en/modules/members/routing-lists.tt | 24 +--
.../prog/en/modules/members/statistics.tt | 26 +--
.../prog/en/modules/patroncards/edit-batch.tt | 30 ++--
.../prog/en/modules/patroncards/edit-layout.tt | 37 ++--
.../prog/en/modules/patroncards/edit-profile.tt | 34 ++--
.../prog/en/modules/patroncards/edit-template.tt | 56 +++---
.../prog/en/modules/patroncards/home.tt | 36 ++--
.../prog/en/modules/patroncards/image-manage.tt | 37 ++--
.../prog/en/modules/patroncards/manage.tt | 30 ++--
.../prog/en/modules/serials/subscription-add.tt | 7 +-
.../en/modules/serials/subscription-batchedit.tt | 24 ++-
.../prog/en/modules/serials/subscription-renew.tt | 2 +-
.../prog/en/modules/tools/import_borrowers.tt | 1 +
.../prog/en/modules/tools/picture-upload.tt | 1 +
members/apikeys.pl | 10 +-
members/deletemem.pl | 2 +-
members/mancredit.pl | 2 +-
members/maninvoice.pl | 20 +--
members/member-flags.pl | 2 +-
members/member-password.pl | 61 ++++---
members/memberentry.pl | 5 +-
members/paycollect.pl | 2 +-
misc/cronjobs/longoverdue.pl | 2 +-
misc/devel/create_superlibrarian.pl | 2 +-
offline_circ/process_koc.pl | 1 -
opac/opac-passwd.pl | 2 +-
opac/opac-password-recovery.pl | 21 ++-
t/Heading.t | 14 --
t/Koha/Exceptions.t | 21 ++-
t/db_dependent/Auth.t | 40 +++--
t/db_dependent/Biblio.t | 81 ++++++++-
t/db_dependent/Circulation/MarkIssueReturned.t | 184 +++++++++++++++-----
t/db_dependent/Heading.t | 61 +++++++
t/db_dependent/Koha/Account.t | 114 +++++++++++-
t/db_dependent/Koha/Object.t | 19 +-
t/db_dependent/Koha/Patrons.t | 51 ++----
t/db_dependent/Search/History.t | 3 +-
t/db_dependent/selenium/authentication.t | 7 +-
t/db_dependent/selenium/regressions.t | 4 +-
tools/import_borrowers.pl | 2 +-
tools/picture-upload.pl | 4 +-
62 files changed, 1096 insertions(+), 527 deletions(-)
delete mode 100755 t/Heading.t
create mode 100755 t/db_dependent/Heading.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list