[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.02-47-gc6170da
Git repo owner
gitmaster at git.koha-community.org
Thu Jan 31 18:17:05 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 18.11.x has been updated
via c6170daba8d754c1e4bf8f3d7dadc8ae75ca08d8 (commit)
via 571ef9e6d297f60a68aa933f0518795e7b94cadb (commit)
via 170ac6bbf37df2f0c0c4567bdf00ebedcdcb1439 (commit)
via 78e617b201402b5e551ba79131b362b2ef7f0bee (commit)
via da8e5fcd2447aad751e511adac4d29bac7cec82c (commit)
via 3f4b04852780e946c2fbc64ae4599058699a941d (commit)
via 35fc9c10032a4b130d9861efb36f112112294e57 (commit)
via b8527c5057ddac6f956d102efa27ef95cd5d3051 (commit)
via 9f2110cbbedb2c5f13f915fc496bc2156a08d0ac (commit)
via a41ee8ad18acafde0a045b4908ecfc90118bdf0a (commit)
via cabf7be3246fcd2248fcbbed497524c3cfa07980 (commit)
via 85bca71c640e1261d74d8c433f620f821b5d5f3d (commit)
via dc762c7d30ffeb6843d82d03a2daf3e538a4b20d (commit)
via 84c45c8c21be6e1bb53701b25f758abaf2d96883 (commit)
via cfdd743b0bcb35554ced8d59ac3d76a9a106463a (commit)
via 01515938d945f7a495af24d41af1de2e2eb5f452 (commit)
via cd95cea044d3e9dbbf6b1f5d58c9655417c92bd7 (commit)
via 053a07734c97b6daaff8d37fd8fd3a9c1b25af26 (commit)
via 9415fde807f6d8c1873f0580c8deed11808cb089 (commit)
via e7aee400d11d075f5e2c0028d9ed981541d3c60d (commit)
via f02dbfe16552b534f8239579c016cc78f1aeb943 (commit)
via 71495e2f6f633fe2c7bd3a74a70cfd13b0ec67c9 (commit)
via d8194f17e43da3b17a6b9dc3c8643a471a748c36 (commit)
via 16ad847fa68f64c29d7e10c75a00c163ad81ffff (commit)
via 7b456961a667ec7a8dbed0176ef6aebb942988e2 (commit)
via 92cd2f8ca6ee06a05d2b6511ad75533bbf619773 (commit)
via 63ebdb815987f0072587b7e3df5dc54cada1accd (commit)
via 2cceecd43866efd56d84ab45c6b4e9f10895533f (commit)
from 07cd6560b5d8334b11ac8c998c1d1156d01a4bcb (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c6170daba8d754c1e4bf8f3d7dadc8ae75ca08d8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 26 12:42:28 2018 -0300
Bug 22047: Fix opac/opac-passwd.pl call
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit d4726c71328c156be519f0f5cf2190a5d6c5c900)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 571ef9e6d297f60a68aa933f0518795e7b94cadb
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 26 12:37:07 2018 -0300
Bug 22047: Add 'skip_validation' param to Koha::Patron->set_password
This patch makes Koha::Patron->set_password expect a hashref as param
and adds support for an 'skip_validation' param to be passed. Its purpose is to
make the method skip the relevant password strength checks if required.
It targets the Auth_with_ldap.pm usage when the 'update_password' flag
is set in the configuration.
The tests on this bug cover this use case so, to test:
- Apply the tests patch
- Run:
$ kshell
k$ prove t/db_dependent/Koha/Patrons.t
=> FAIL: Tests fail, code doesn't work as expected
- Apply this patch
- Run:
k$ prove t/db_dependent/Koha/Patrons.t
=> SUCCESS: Tests pass! Yay!
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 0f0e064a2b232949185a9ee7ef2c911325d15591)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 170ac6bbf37df2f0c0c4567bdf00ebedcdcb1439
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 26 12:37:00 2018 -0300
Bug 22047: Unit tests
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 983c1193fa5a5594f69e88fbbd2b2614a2763bc9)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 78e617b201402b5e551ba79131b362b2ef7f0bee
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Jan 5 03:50:36 2019 +0000
Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff)
Displays amount outstanding correctly when holds are blocked
by maxoutstanding.
To test:
- Check maxoutstanding system preference value
- Add a fine to a patron account exceeding maxoutstanding
- Try to place a hold for this patron from staff
- Verify this message is shown:
Patron has outstanding fines: 6.00
- Toggle CurrencyFormat system preference and verify display
changes according to setting
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois at inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit c37ded96714409cd572c79f3c9cd69694e0e71de)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit da8e5fcd2447aad751e511adac4d29bac7cec82c
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Jan 5 05:41:48 2019 +0000
Bug 22113: Add price formatting on item lost report
The item lost report displays the price and replacement
price for lost items. With the patch they will display
according to the CurrencyFormat system preference.
To test:
- Mark 1 or more items lost
- Make sure that replacement cost and purchase price are set
- Go to Reports > Items lost
- Search for your lost items
- Verify price and replacement price display
- Apply patch and toggle CurrencyFormat to different settings
- Refresh lost items report
- Verify prices are always displayed according to syspref setting
Signed-off-by: Olivia Lu <olivialokm at gmail.com>
Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit c3fb484fe2922d2a97053b3fde4fb433c5aa0c4f)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3f4b04852780e946c2fbc64ae4599058699a941d
Author: Olivia Lu <olivialokm at gmail.com>
Date: Wed Jan 16 03:54:25 2019 +0000
Bug 21855: Changed "deprecated delete_unverified_opac_registrations.pl cronjob" to "cleanup_database"
To Find Fix:
1. Go to Koha Administration
2. Search PatronSelfRegistrationVerifyByEmail
3. Verify that NOTE now says "system preference requires the
cleanup_database ..."
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit b93c5dcbfdeafc2758cb880bea02ca91c0ef4e67)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 35fc9c10032a4b130d9861efb36f112112294e57
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Tue Mar 6 13:29:22 2018 -0500
Bug 18909: Enable the maximum zebra records size to be specified per instance
The default for Zebra is to not return results where the record size is
greater than 1045 KB ( 1 MB ). Some libraries need to increase this
ceiling, but it may come at a cost with z39.50 compatibility with other
services. For that reason, we should make this setting configurable on a
per-instance basis.
Test plan for kohadevbox:
1) Apply this patch
2) Run:
$ reset_all
3) Restart Zebra:
$ sudo koha-zebra --restart kohadev
4) Check how zebrasrv was called:
$ ps waux | grep zebrasrv
=> SUCCESS: Looks like
... /usr/bin/zebrasrv -v none,fatal,warn -k 1024
5) Edit /etc/koha/sites/kohadev/koha-conf.xml, add:
<zebra_max_record_size>2048</zebra_max_record_size>
6) Repeat (3) and (4)
=> SUCCESS: Looks like
... /usr/bin/zebrasrv -v none,fatal,warn -k 2048
7) Sign off :-D
General test plan:
1) Apply this patch
2) Build a Debian package
3) Specify a zebra_max_record_size of 2048 in your koha_conf.xml
4) Restart zebra
5) Index a record greater than 1 MB but smaller than 2 MB
6) Note that it is searchable!
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 8c0c6be7488e0543662e47006ded12e74ae4eb8d)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b8527c5057ddac6f956d102efa27ef95cd5d3051
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Jan 12 09:21:38 2019 +0100
Bug 22118: Format hold fee when placing holds in OPAC
When Koha charges for holds, a message with the fee is
shown before the patron places the hold. The amount needs
to be formatted according to CurrencyFormat system preference.
To test:
- Add a hold fee to your patron category
- Log into the OPAC
- Search for a record to place a hold on
- Click Place hold
- Verify there is a note showing about the hold fee
- Toggle CurrencyFormat and HoldFeeMode and verify
that the formatting is always correct
Signed-off-by: Jack Kelliher <jke0429 at stacmail.net>
Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois at inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 4f0618a8888dff72b15dfe9193259c1bc5d06b5f)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9f2110cbbedb2c5f13f915fc496bc2156a08d0ac
Author: Jasmine Amohia <jasmineamohia.student at wegc.school.nz>
Date: Thu Jan 17 02:32:08 2019 +0000
Bug 11922: Add SHOW_BCODE patron attribute for Norwegian web installer
Test plan:
1. Notice that /patron_attributes.sql and /patron_attributes.txt can be
located in 2-Valgfritt
2. Confirm that the SHOW_BCODE patron attribute in the English web
installers .sql and .txt file is also in the Norwegian web installers
.sql and .txt file
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 495619649b329ce52b86998668461ca72827c6ab)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a41ee8ad18acafde0a045b4908ecfc90118bdf0a
Author: Jasmine Amohia <jasmineamohia.student at wegc.school.nz>
Date: Wed Jan 16 02:11:42 2019 +0000
Bug 19920: Removed unnecessary code from C4/Members.pm
A seperate bug (Bug 16853) removed the subroutine used in this file. I removed the code as it had become unnecessary.
Test plan:
1. Confirm that &changepassword can't be found in C4/Members.pm
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 9f446de79128352fe5138bb22260a49254c65450)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cabf7be3246fcd2248fcbbed497524c3cfa07980
Author: helene hickey <hickeyhe at wgc.school.nz>
Date: Wed Jan 16 22:06:15 2019 +0000
Bug 20491: Updating the MARC subfield desciption of 952q
Test plan:
1) Go to admin, then to MARC frameworks, then to default
frameworks structure, then subfield stucture for 952
2) Verify that 'q'
is described as 'checked out'
3) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x
4) Verify
that 'q' is also descirbed as 'Checked out' in
5) Apply patch and update
your database
6) Verify that the description of 'q' has changed to 'Date
due'
7) Go to <intranet>/cgi-bin/koha/cataloguing/additem.pl?biblionumber=x
6) Verify that it has changed to 'Date due'
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Bug 20491: (QA follow-up) Remove atomic update
We should not update existing installations, especially
since this would not work for translated frameworks.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 6e4e4c9cbc04b42653599b4ddea35cbaa57e42f3)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 85bca71c640e1261d74d8c433f620f821b5d5f3d
Author: helene hickey <hickeyhe at wgc.school.nz>
Date: Wed Jan 16 02:16:26 2019 +0000
Bug 7403: Shorten CataloguingLog preference description
To test:
1) Look at value of CataloguingLog prefernce
2) Apply the patch and the value should change
3) Verify that the warning has been removed
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 90a43b1868a068b54e398c1df2227a6b6cf93875)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dc762c7d30ffeb6843d82d03a2daf3e538a4b20d
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Jan 22 13:54:59 2019 -0500
Bug 7614: (QA follow-up) Remove unused variable
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 6764bda2a9eaba37c2eeaf635165b5f0c9abd530)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 84c45c8c21be6e1bb53701b25f758abaf2d96883
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Jan 22 13:50:39 2019 -0500
Bug 7614: (QA follow-up) Tidy code to remove tab characters
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 874479a474d9a3fe451c22b8d73b5d4995024363)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cfdd743b0bcb35554ced8d59ac3d76a9a106463a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Jan 22 13:49:13 2019 -0500
Bug 7614: (QA follow-up) Fix POD merge missed in rebase
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 2c2d0cd6993561d9b3efa8aa5843200f31b29094)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 01515938d945f7a495af24d41af1de2e2eb5f452
Author: Kyle M Hall <kyle at bywatersolutiosn.com>
Date: Mon Aug 20 10:48:07 2018 -0400
Bug 7614: Don't allow un-usable pickup locations in the opac pickup locations pulldown
Also fully qualifies some subroutine calls that fail for reasons unkown.
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 2cd3a7187175390258572954685f1475a3e12ecd)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cd95cea044d3e9dbbf6b1f5d58c9655417c92bd7
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Thu Dec 21 16:55:58 2017 +0200
Bug 7614: (follow-up) If patron's home library is not a pickup library, let them choose another one
This patch fixes an issue where patron is not allowed to place a hold in OPAC
while their home library is not a pickup library.
Instead, they should be presented with a list of other available pickup locations.
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 3a69ec5e050cb7a00fa98e360235941ccc3eb4a1)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 053a07734c97b6daaff8d37fd8fd3a9c1b25af26
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Thu Mar 9 13:06:20 2017 +0200
Bug 7614: Fix my variable earlier declaration bug.
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 07c91b2116ebb991ff064f26a0a700d6bca43362)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9415fde807f6d8c1873f0580c8deed11808cb089
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Fri Feb 10 17:10:49 2017 +0200
Bug 7614: Build a list of pickup locations in OPAC considering transfer limits
This patch enables the checks for transfer limits for given biblionumber in
OPAC when patron proceeds to place a hold. In case none of the items of that
biblio can be transferred to a library, that library will not be included in
the list of pickup locations.
To test:
1. Make sure you meet the following requirements:
1.1: You are able to make holds in OPAC
1.2: System preference UseBranchTransferLimits set to "Enforce"
1.3: System preference BranchTransferLimitsType set to "item type"
(for the sake of simplicity of this test plan, but you may also
set it to "collection code" and deal with ccodes instead)
1.4: System preference item-level_itypes set to "specific item"
1.5: You have the default libraries and item types, otherwise replace
the branchcodes and itemtypes in this test plan with your own
2. Make sure 'Fairfield' in cgi-bin/koha/admin/branches.pl has not disabled
its ability to act as a "Pickup location"
3. Have a biblio with exactly one item of item-level itemtype 'BK'
4. Set item holdingbranch as 'CPL'
5. Go to cgi-bin/koha/admin/branch_transfer_limits.pl (keep this page open in
a second tab for faster testing)
6. Select library 'Centerville'
7. Uncheck the checkbox 'FFL - Fairfield' and click Save
8. Go to OPAC and find your biblio, and start placing a hold on it
9. Click at the list of "Pick up location"s.
10. Observe that it is missing 'Fairfield'
11. Go back to cgi-bin/koha/admin/branch_transfer_limits.pl
12. Repeat step 6 and this time, check the checkbox 'FFL - Fairfield'
13. Refresh the page you arrived at step 8
14. Observe that it now includes 'Fairfield'
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 68803f3ddb64006b4eadbb4aa9669ad40187d0fb)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e7aee400d11d075f5e2c0028d9ed981541d3c60d
Author: Kyle M Hall <kyle at bywatersolutiosn.com>
Date: Wed Aug 15 14:27:45 2018 -0400
Bug 7614: Consider transfer limits in Koha::Template::Plugin::Branches
Consider transfer limits in Koha::Template::Plugin::Branches->pickup_locations.
This patch modified the mentioned method to consider branch transfer limits and
does not include any library in the returned list of libraries in case a branch
transfer limit applies for a given book or item.
To be tested in following patches.
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 02d3d4a8f55e5164f7bb2b87fe1cbbb6b607355d)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f02dbfe16552b534f8239579c016cc78f1aeb943
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Tue Feb 7 17:51:18 2017 +0200
Bug 7614: Check transfer limit in CanBookBeReserved and CanItemBeReserved
This patch adds $branchcode_to parameter to CanBookBeReserved and
CanItemBeReserved. It represents the pickup location for the hold. This patch
checks if the library is configured to be a pickup location (see Bug 7534), and
also if the item can be transferred into the given library (see Bug 18072).
To test:
1. prove t/db_dependent/Holds.t
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit b028a2d1a53a7106a00a7ec6a860e813c0781342)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 71495e2f6f633fe2c7bd3a74a70cfd13b0ec67c9
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Thu Feb 9 19:21:32 2017 +0200
Bug 7614: Add a new method Koha::Libraries->pickup_locations
This patch adds a new method, Koha::Libraries->pickup_locations. This method
takes either an item or a biblio as a parameter, and returns the list of
acceptable pickup locations by considering libraries' configuration to act
as a pickup location as well as any branch transfer limits that may apply.
To test:
1. prove t/db_dependent/Koha/Libraries.t
Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 2101d0af0034bf8278893b4d4ca7d80c29b3bc75)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d8194f17e43da3b17a6b9dc3c8643a471a748c36
Author: helene hickey <hickeyhe at wgc.school.nz>
Date: Tue Jan 15 23:07:34 2019 +0000
Bug 20274: Itemtypes report gives zero results if item-level_itypes set to bibliographic records
1) Go to reports then catalog by item types
2) Pick a location and look at table
3) Change the system prefernce of item-level_itypes
4) Verify a zero result
5) Apply patch and retry
6) Verify that result does not change to zero on either preference
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 8ad2c206cba1b737e69393e2e3cd92076fb94e17)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 16ad847fa68f64c29d7e10c75a00c163ad81ffff
Author: Ethan Amohia <ethan.amohia at gmail.com>
Date: Wed Jan 16 03:26:36 2019 +0000
Bug 22122: Rearranged inputs from a patrons basket in Acquisitions.
Test Plan:
1. From home page, go to "Acquisitions"
2. Add a test vendor under "New vendor"
3. Give the vendor any name and click "Save"
4. Click "New Basket"
5. Give the basket a name and click "Save"
6. Click on "Add to basket"
7. Click on "From an external source"
8. Note the order of inputs (ISBN, ISSN, Title...)
9. Go back to the homepage
10. Go to "Cataloging"
11. Click on "New from Z39.50/SRU" button. A new window should open
12. The order of inputs under 'Z39.50/SRU Search' should all match the
order of inputs from step 8. (Except "Select MARC framework)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 03e5ec617070fdc31829f04612c821e4f83facc1)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7b456961a667ec7a8dbed0176ef6aebb942988e2
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jan 11 16:27:17 2019 +0000
Bug 22101: Ill Requests missing in menu on advanced search page
This patch adds [% USE Koha %] to header.inc so that Koha.Preference
calls will work correctly.
To test, apply the patch and log in to the staff client as a user who
has permission to access the ILL module.
- Go to the catalog's advanced search page
- Cnfirm there is a header menu item under "More" for
"ILL requests."
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 45deff8b43d32865cfeeb516c8ffc1140f294c22)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 92cd2f8ca6ee06a05d2b6511ad75533bbf619773
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jan 14 08:04:51 2019 -0300
Bug 22125: branches.pickup_location should be flagged as boolean
This trivial patch just marks the mentioned column as a boolean.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
https://bugs.koha-community.org/show_bug.cgi?id=16497
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 95ce61fd3e2c7f41d14e570da3bb8bf05373c65e)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 63ebdb815987f0072587b7e3df5dc54cada1accd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 13 12:55:55 2018 -0300
Bug 21192: Do not pick SelfRegistration hidden fields for SelfModification
There was a mix up between "modification" and "edit" for $action in
opac-memberentry.pl.
If a patron is logged into the OPAC and they attempt to submit changes to their
personal details without having actually changed anything, the page reloads with
a message stating 'No changes were made.' However, the fields that now appear
are those that have been allowed/hidden according to the preferences set for
patron self registration, even if patron self registration is disabled. This can
lead to problems if there are discrepancies between the fields allowed for self
register settings and those allowed for patron self modification settings.
To replicate:
1.) In Administration › System preferences > OPAC, set PatronSelfRegistration to
'don't allow'
2.) Modify the unwanted fields for PatronSelfModificationBorrowerUnwantedField
and PatronSelfRegistrationBorrowerUnwantedField so that at least one field is
different between the two settings and save (for example, specify 'mobile' to be
hidden in the former, but don't include in the list of fields to be hidden in
the latter).
3.) Log into the OPAC and navigate to the 'your personal details' tab. Notice
that the editable fields correspond to those not hidden by
PatronSelfModificationBorrowerUnwantedField
4.) Without making any changes, click on 'Submit update request'.
5.) Note that on this page the fields correspond to those not hidden by
PatronSelfRegistrationBorrowerUnwantedField and are now editable (including any
fields that would otherwise be hidden by the Self Modification settings).
Reported-By: Chris Slone <cslone at camdencountylibrary.org>
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit e0b1f945f9cdb4efd8b4403855cdc995023dc8be)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2cceecd43866efd56d84ab45c6b4e9f10895533f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Dec 17 12:55:34 2018 -0300
Bug 21170: Remove "isn't numeric in numeric eq (==)" warnings in MARCdetail
Easily removed switching the two conditions.
Test plan:
Hit catalogue/MARCdetail.pl?biblionumber=1
=> Without this patch you will see in the log warnings like
Argument "ddc" isn't numeric in numeric eq (==) at /home/vagrant/kohaclone/catalogue/MARCdetail.pl line 277.
=> With this patch applied the warnings do no longer appear
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit b608f548a894cb433c4218b94a33d6b8a824a4c4)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Items.pm | 20 +-
C4/Members.pm | 5 -
C4/Reserves.pm | 5 +
Koha/Libraries.pm | 71 ++++
Koha/Patron.pm | 38 ++-
Koha/Schema/Result/Branch.pm | 5 +-
Koha/Template/Plugin/Branches.pm | 21 ++
catalogue/MARCdetail.pl | 4 +-
debian/scripts/koha-functions.sh | 11 +
debian/scripts/koha-zebra | 2 +
debian/templates/koha-conf-site.xml.in | 1 +
.../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 +-
.../Obligatoire/marc21_framework_DEFAULT.sql | 2 +-
.../Optionnel/marc21_simple_bib_frameworks.sql | 16 +-
.../2-Valgfritt/patron_attributes.sql} | 0
.../2-Valgfritt/patron_attributes.txt} | 0
.../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 +-
.../optional/marc21_simple_bib_frameworks.sql | 16 +-
.../marc21/mandatory/marc21_framework_DEFAULT.sql | 2 +-
.../optional/marc21_simple_bib_frameworks.sql | 16 +-
.../intranet-tmpl/prog/en/includes/header.inc | 1 +
.../prog/en/modules/acqui/z3950_search.tt | 8 +-
.../prog/en/modules/admin/preferences/logs.pref | 2 +-
.../prog/en/modules/admin/preferences/opac.pref | 2 +-
.../prog/en/modules/reports/itemslost.tt | 5 +-
.../prog/en/modules/reserve/request.tt | 3 +-
.../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 12 +-
.../delete_unverified_opac_registrations.pl | 66 ----
opac/opac-memberentry.pl | 6 +-
opac/opac-passwd.pl | 2 +-
opac/opac-reserve.pl | 19 +-
reports/itemtypes.plugin | 4 +-
t/db_dependent/Holds.t | 25 +-
t/db_dependent/Koha/Libraries.t | 347 +++++++++++++++++++-
t/db_dependent/Koha/Patrons.t | 21 +-
35 files changed, 597 insertions(+), 165 deletions(-)
copy installer/data/mysql/{en/optional/patron_atributes.sql => nb-NO/2-Valgfritt/patron_attributes.sql} (100%)
copy installer/data/mysql/{en/optional/patron_atributes.txt => nb-NO/2-Valgfritt/patron_attributes.txt} (100%)
delete mode 100755 misc/cronjobs/delete_unverified_opac_registrations.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list