[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.02-51-g2b8ba2e

Thu Jan 31 18:43:42 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  2b8ba2e55874d2837c98a213afca0f4458767b05 (commit)
       via  18d934799f5d03d7ecbc694351e85776a4a248c8 (commit)
       via  36de61a4aff78a0ee91fd0127ae9f57b57a4497e (commit)
       via  0420bc9a53bde1fc686fc4b078cbce595bff8b95 (commit)
      from  c6170daba8d754c1e4bf8f3d7dadc8ae75ca08d8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2b8ba2e55874d2837c98a213afca0f4458767b05
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Dec 28 12:15:53 2018 -0300

    Bug 22051: Make Koha::Object->store translate incorrect value exceptions

    This patch adds a new condition to Koha::Object->store so it catches
    incorrect value-related DBIC exceptions.

    This DBIC exceptions get now translated into
    Koha::Exceptions::Object::BadValue exceptions with relevant parameters
    passed.

    To test:
    - Apply the exception and unit tests patches
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Object.t
    => FAIL: Tests fail because this exception handling code is not
    implemented
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Koha/Object.t
    => SUCCESS: Tests pass!
    - Sign off :-D

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 659253eef12bb213058a8aed835ba6789aa3d9f0)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 18d934799f5d03d7ecbc694351e85776a4a248c8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Dec 28 12:15:36 2018 -0300

    Bug 22051: Unit tests

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 0ce4ccdceea74fa8b26a2142deecaee3794f7228)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 36de61a4aff78a0ee91fd0127ae9f57b57a4497e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Dec 28 11:33:13 2018 -0300

    Bug 22051: Add Koha::Exceptions::Object::WrongValue

    This patch adds a new exception to be thrown in Koha::Object->store when
    a DBIC exception is thrown regarding bad data format.

    To test:
    - Apply this patch
    - Run:
      $ kshell
     k$ prove t/Koha/Exceptions.t
    => SUCCESS: Tests pass!
    - Sign off :-D

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 58cbba3c93fba35920d3257a31dea9c760b37330)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0420bc9a53bde1fc686fc4b078cbce595bff8b95
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 12 14:59:54 2018 -0300

    Bug 21993: Display a user-friendly message when the CSRF token is wrong

    Instead of dying!

    Test plan:
    Assuming you have a patron with borrowernumber=51 and another one that
    can be deleted with borrowernumber=42

    - authorities-home.pl
     * Delete an authority record
     * hit /cgi-bin/koha/authorities/authorities-home.pl?op=delete

    - basket/sendbasket.pl
     * Send a basket to someone
     * hit /cgi-bin/koha/basket/sendbasket.pl?email_add=1

    - members/apikeys.pl
      * Generate and delete an API key for a patron
      * hit /cgi-bin/koha/members/apikeys.pl?patron_id=51&op=delete

    - members/deletemem.pl
      * Delete a patron
      * hit /cgi-bin/koha/members/deletemem.pl?member=42&op=delete_confirmed

    - members/mancredit.pl
      * Add a manual credit
      * hit /cgi-bin/koha/members/mancredit.pl?borrowernumber=51&add=1

    - members/maninvoice.pl
      * Add a manual invoice
      * hit /cgi-bin/koha/members/maninvoice.pl?borrowernumber=51&add=1

    - members/member-flags.pl
      * Change permissions for a patron
      * hit /cgi-bin/koha/members/member-flags.pl?member=51&newflags=1

    - members/member-password.pl
      * Change the password for a patron (from the staff interface)
      * hit /cgi-bin/koha/members/member-password.pl?member=51&newpassword=aA1

    - members/memberentry.pl
      * Edit some patron's info
      * hit /cgi-bin/koha/members/memberentry.pl?borrowernumber=51&op=save

    - members/paycollect.pl
      * Pay an individual fine
      * hit something like /cgi-bin/koha/members/paycollect.pl?borrowernumber=51&pay_individual=1&accounttype=L&amount=1.00&amountoutstanding=1.00&accountlines_id=157&paid=1
      You may need to edit some values

    - tools/import_borrowers.pl
      * Import some patrons
      * hit /cgi-bin/koha/tools/import_borrowers.pl?uploadborrowers=1

    - tools/picture-upload.pl
      * Upload an image for a patron
      * You will need to edit the html content
      hit Home › Tools › Upload patron images
      then locate the csrf_token input and modify its value

    Note for QA:
    - Opac is not done as blocking_errors.inc does not exist for this
    interface
    - ill/ill-requests.pl
    I did not manage to replace this occurrence

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b990b953b324dc18c013f94d1828b61bb5118c60)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Exceptions/Object.pm                          |   12 +++++++++++
 Koha/Object.pm                                     |    7 +++++++
 authorities/authorities-home.pl                    |    9 +++++----
 basket/sendbasket.pl                               |    9 +++++----
 .../prog/en/includes/blocking_errors.inc           |    2 ++
 .../prog/en/modules/basket/sendbasketform.tt       |    1 +
 .../prog/en/modules/tools/import_borrowers.tt      |    1 +
 .../prog/en/modules/tools/picture-upload.tt        |    1 +
 members/apikeys.pl                                 |   10 +++++-----
 members/deletemem.pl                               |    2 +-
 members/mancredit.pl                               |    2 +-
 members/maninvoice.pl                              |   20 +++++++++----------
 members/member-flags.pl                            |    2 +-
 members/member-password.pl                         |    2 +-
 members/memberentry.pl                             |    2 +-
 members/paycollect.pl                              |    2 +-
 t/Koha/Exceptions.t                                |   21 +++++++++++++++++++-
 t/db_dependent/Koha/Object.t                       |   19 +++++++++++++++++-
 tools/import_borrowers.pl                          |    2 +-
 tools/picture-upload.pl                            |    4 ++--
 20 files changed, 96 insertions(+), 34 deletions(-)

hooks/post-receive
-- 
main Koha release repository