[koha-commits] main Koha release repository branch master updated. v19.05.00-268-g288cc50

Git repo owner gitmaster at git.koha-community.org
Wed Jul 3 15:28:49 CEST 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  288cc505557fdcb167737f1894cee581526b4741 (commit)
       via  90acef7a9b860e70631ff243c21b435a7d081a16 (commit)
       via  2ff5f9fb633e6f3786b093d2a2f202a66db7b3d0 (commit)
      from  b171c1645ae08321c2747d1059bf15fd02f84935 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 288cc505557fdcb167737f1894cee581526b4741
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Jul 3 02:35:16 2019 +0000

    Bug 23230: (follow-up) Fix broken tests
    
    Before patch, the new tests don't run.
    After patch, they do.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 90acef7a9b860e70631ff243c21b435a7d081a16
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jul 1 11:42:51 2019 -0300

    Bug 23230: Make _version_compare OO context aware
    
    On using _version_compare in plugins development, it would be nice if it
    was able to be called as an object method. This way we don't need to
    fully qualify it like this:
    
        Koha::Plugins::Base::_version_compare
    
    and we can do
    
        $self->_version_compare
    
    instead.
    
    This patch implements this behavior change. It is backwards compatible
    so plugins using the 'old way' don't break.
    
    To test:
    - Apply the unit tests patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Plugins.t
    => FAIL: Tests fail
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Plugins.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2ff5f9fb633e6f3786b093d2a2f202a66db7b3d0
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jul 1 11:33:41 2019 -0300

    Bug 23230: Unit tests
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Plugins/Base.pm     |   10 ++++++++--
 t/db_dependent/Plugins.t |   25 ++++++++++++++++++-------
 2 files changed, 26 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list