[koha-commits] main Koha release repository branch master updated. v19.05.00-342-g68eeefa
Git repo owner
gitmaster at git.koha-community.org
Mon Jul 15 13:43:17 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 68eeefa07edfd7f45546b9ad5eb72627502fc5e0 (commit)
via fc53c88ad4bda3810a1f4c0a7582fec8b3a10383 (commit)
via a43cf374aefe2052c3c241be4455a903429bd8c2 (commit)
via 59bbcb1d37361cd8e675fa48492cec3b4659edcf (commit)
via 414ab9b166a0f4d18138f6129ccb73a7806976cf (commit)
via f41533c49d487406621ee651d992e44b89e7e14a (commit)
via 4068484650cb76d0fa3d801a4a5f49bd65cffb0b (commit)
via cd66074205b571d1db6acbb57d8d8554d3d4fe85 (commit)
via b59dc761d77d8d1af8f1e2afb58b51f5252ed506 (commit)
via 0f54a1f8c654e911c9e6254762586e3eeb786528 (commit)
via 92bf8082c372d4cf055336da7539bf214847249f (commit)
via 9b4da7594f7422a244c0dc0b6ef6dff85f083a40 (commit)
via 6f356cecc35fa3b1b2a730703fa2d7fbeaddf0d7 (commit)
via dd63cb6b8ee5b3324c8902b7f189b22a03b0a335 (commit)
via c437f84a65237a1b4eabbb2b5c1b8f661649a1d0 (commit)
via 40c0ebb21955a237686504aef1aad43563bbf107 (commit)
via d2c76ac420bf8270f98f076bda2aa823b2b00847 (commit)
via f4f608faa6fa94f02de284118830e90042406474 (commit)
via de29f6b4a202b454b090e20b499b01b39b2fc2f7 (commit)
via e1e0cb67d06a49760808797ce30434c0fa2d0432 (commit)
via b954dce9dd2c25c8659aec78154a127b468999fd (commit)
via e3c5892f52d3d59d9aa03667d990110e3587ca6b (commit)
via 6ec92845c7458bfe8fdc8071138aba4d4bb8418c (commit)
via 2ba0d3e6271eb0e311f90994c2c64f43fbe23a37 (commit)
via 282f5d288df62d18fad47d7674a20e39483e03c2 (commit)
via 9dbaefddb8ab2cf13805ae5bc7b1038091a740cb (commit)
via ace2651aa7f516e0dbfdcdaaffec815df4bb2f16 (commit)
via 780b377db2cb3c693e7f94ff8d9eccc4e8711a85 (commit)
via 5512f945059d1369e75c1952b5cb40b56fca0e80 (commit)
via fd63fe7d126986b1ab72d70ec2b35e05ef7cddea (commit)
via fcc22df8ff277ac7041d5eb72e83821fb1ef1f37 (commit)
via e269d6e6e6c9d1e3e11ae43a7773f3026f4d801a (commit)
via fd5686b156ceb10958cab728b7695aa2b39b9933 (commit)
via f45516e73ab6ac8c2240f206bd11a88e4935359c (commit)
via 076d5be767d0b6667ce8aab0ae7b56116e48d48f (commit)
via f447658f850bca5ebcdb6f29a5572c1c1707f942 (commit)
via 3f40c32cbbc63dbc5f00d127edfeaa0732f4ab23 (commit)
via d88709ec2d45df6f2a8e90ae7a94f9724b7e8e7e (commit)
via 0658d84732cadb3bec44126d9efbd12a87547228 (commit)
via 178a805a5d3055dd17050111c1227a9d5cef1b96 (commit)
via e0991ae2358224a15b6880c96b8472a3cd814b1b (commit)
via 5c5d158b1bc37c63196be9ae405e4a2563315dbc (commit)
via d4f41cc8aafbb9854b20d1de7115a81e1eb73b9c (commit)
via 67f86868155725b3fec29d38a54e8c161dd72c78 (commit)
from d25f3e84374ec8d7c85f8ed805102f67c0a73d77 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 68eeefa07edfd7f45546b9ad5eb72627502fc5e0
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Wed Apr 17 06:02:59 2019 +0000
Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls
Test plan:
Run tests, at least:
t/db_dependent/Biblio.t
t/db_dependent/Biblio/TransformHtmlToMarc.t
t/db_dependent/Charset.t
t/db_dependent/Circulation/GetTopIssues.t
t/db_dependent/Filter_MARC_ViewPolicy.t
t/db_dependent/ImportBatch.t
t/db_dependent/Items.t
t/db_dependent/Items/AutomaticItemModificationByAge.t
t/db_dependent/Items/GetItemsForInventory.t
t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
t/db_dependent/Serials.t
t/db_dependent/XISBN.t
t/db_dependent/FrameworkPlugin.t
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fc53c88ad4bda3810a1f4c0a7582fec8b3a10383
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date: Fri Mar 9 11:05:52 2018 +0200
Bug 20364: Show languages from MARC21 field 041 in intranet
Show the language names coded in field 041, in intranet search
results and in detail view.
Test plan:
1) Apply patch
2) Do a search, and check the results look correct
3) Check some biblio detail pages that they look correct
4) Add some 041 subfields (a, b, d, h, j) in any combinations
5) Repeat 2 and 3
Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a43cf374aefe2052c3c241be4455a903429bd8c2
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jul 11 16:18:51 2019 +0100
Bug 23259: Compiled CSS
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 59bbcb1d37361cd8e675fa48492cec3b4659edcf
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jul 3 18:30:38 2019 +0000
Bug 23259: Remove reset-fonts-grids.css
This patch removes the CSS file reset-fonts-grids.css which was required
when the staff client templates used YUI grids. Now that all staff
client templates have been converted to Bootstrap grid markup the file
can be deleted.
Because the YUI CSS also did set some baseline properties for different
tags the global SCSS file is modified in this patch in order to keep
things looking consistent. Most of these updates change font-size
declarations to preserve the previous appearance.
Some styling has been added to (non Bootstrap-classed) <input> and
<button> tags in order to keep button style consistent.
Removed from staff-global.scss: YUI-specific CSS which has been made
obsolete by the template conversions.
To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Clear your browser cache if necessary.
Browse through various pages of thes staff client to confirm that the
changes work well.
Signed-off-by: Nadine Pierre <nadine.pierre at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 414ab9b166a0f4d18138f6129ccb73a7806976cf
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Jun 24 18:48:29 2019 +0000
Bug 23197: Add more batch operation options to SQL report results
This patch extends the feature which allows the user to send item
numbers from a page of report results to batch item modification. For
biblionumbers: Batch record modification, batch record deletion, and
add to list are now available. For item numbers: batch item deletion is
added.
A new menu button is added for these options at the top of report
results, removing the button from the item number column header.
Corresponding CSS has been removed.
To test, apply the patch and create a report which includes both
biblionumber and itemnumber columns in the results.
- Run the report and confirm that a new "Batch operations" button
appears at the top of the results. Test each option:
- Batch record modification
- Batch record deletion
- Add to list
- Batch item modification
- Batch item deletion
In each case the correct set of parameters should be passed to the batch
operations. Test with reports which return only biblionumbers, only
itemnumbers, and neither.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f41533c49d487406621ee651d992e44b89e7e14a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jun 26 14:57:18 2019 +0000
Bug 23094: Use Bootstrap-style pagination on staged MARC records page
This patch makes markup changes in order to make the pagination links on
the staged MARC records page consistent with the links on the catalog
search results page.
To test properly you should have enough staged marc record batches that
there are multiple pages to list.
Go to Tools -> Manage staged MARC records. Test that the pagination
links look consistent with the catalog search results page and that they
work correctly.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 4068484650cb76d0fa3d801a4a5f49bd65cffb0b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jun 26 17:52:52 2019 +0000
Bug 23221: (follow-up) Add comments on markup structure
This patch adds a few comments to the markup in order to highlight the
structure of the page.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cd66074205b571d1db6acbb57d8d8554d3d4fe85
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jun 26 14:29:24 2019 +0000
Bug 23221: Reindent tools/manage-marc-import.tt
This patch reformats the template for the Manage staged MARC records
page. It makes only whitespace changes. It should have no effect on the
behavior of the page.
In addition to re-indentation, some lines have been broken up. These
should be the only changes highlighted when using diff while ignoring
whitespace.
To test, apply the patch and view the Manage staged MARC records page.
The page should look correct and work correctly:
- Paging through results
- Viewing batches
- Cleaning batches
- Deleting batches
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b59dc761d77d8d1af8f1e2afb58b51f5252ed506
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu May 16 08:49:22 2019 +0100
Bug 19919: Unit Tests
This patch adds unit tests for the addition of a patron accessor to the
Koha::Account::Line object.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0f54a1f8c654e911c9e6254762586e3eeb786528
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri May 3 15:44:35 2019 +0100
Bug 19919: Stop using paidfor altogether
This patch removed references to setting and getting the items.paidfor
field. Where it was used for display, in moredetail.pl, we replace it
with a query on the accountlines.
Test plan:
1) Apply patch
2) Pay off a LOST item
3) Check for the associated display of 'Paidfor?:' on the itemdetails
page
4) Writeoff a LOST item
5) Check that a 'Paidfor?:' is not displayed on the itemdetails page.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 92bf8082c372d4cf055336da7539bf214847249f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jul 11 16:29:48 2019 +0100
Bug 22563: DBRev 19.06.00.012
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9b4da7594f7422a244c0dc0b6ef6dff85f083a40
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Jul 5 14:55:34 2019 -0300
Bug 22563: (follow-up) Fix tests in Koha/Account.t
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6f356cecc35fa3b1b2a730703fa2d7fbeaddf0d7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Jul 5 14:47:09 2019 -0300
Bug 22563: Typo in query (manualinvoice)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit dd63cb6b8ee5b3324c8902b7f189b22a03b0a335
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Jun 17 15:01:11 2019 +0100
Bug 22563: (QA follow-up) Correction to DB update
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c437f84a65237a1b4eabbb2b5c1b8f661649a1d0
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Sat Jun 15 07:17:46 2019 +0100
Bug 22563: (QA follow-up) Catch LOST maninvoice cases
One could add a manual invoice of type LOST but we would not associate
it with an issue_id. This patch tries to catch such cases and
extrapolate an issue_id to add to the accountline.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 40c0ebb21955a237686504aef1aad43563bbf107
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Jun 14 20:05:27 2019 +0100
Bug 22563: (QA follow-up) Use issue_id in chargelostitem
C4::Accounts::chargelostitem contained a FIXME which asked if an item
should be charged for it lost, returned and then lost again. We add
handling for that case here.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d2c76ac420bf8270f98f076bda2aa823b2b00847
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Apr 18 12:53:42 2019 +0100
Bug 22563: (follow-up) Clean up remaing L, LR and CR cases in the database
Test plan:
1) Confirm that after the DB update there are no L, LR or CR
accountlines present.
2) Read the db update and confirm is makes sense.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f4f608faa6fa94f02de284118830e90042406474
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Apr 18 15:47:24 2019 +0100
Bug 22563: (follow-up) Corrections for overdue tests
Updates to unit tests to reflect the accounttype changes and introduction of
status usage for _FixOverduesOnReturn.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit de29f6b4a202b454b090e20b499b01b39b2fc2f7
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Apr 18 08:45:54 2019 +0100
Bug 22563: (follow-up) Items LOST should not be RETURNED
Up until now we marked lost items as returned in the accountlines, now
we have the oportunity to mark these distinctly with an appropriate
status we should.
Test Plan
1) Find an overdue with fines
2) Ensure you are not forgiving fines when an item is marked as lost
3) Mark the item as lost
4) Confirm the Fine is given a status of 'Lost'
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e1e0cb67d06a49760808797ce30434c0fa2d0432
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Mar 27 14:56:52 2019 +0000
Bug 22563: (follow-up) Corrections for tests
Updates to unit tests to reflect the accounttype changes and
introduction of status usage.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b954dce9dd2c25c8659aec78154a127b468999fd
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Mar 22 16:28:52 2019 +0000
Bug 22563: Update lost handling to use accountline.status
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e3c5892f52d3d59d9aa03667d990110e3587ca6b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Mar 22 15:25:16 2019 +0000
Bug 22563: Be more descriptive with accountypes
Convert 'L' to 'LOST' to become more descriptive in it's use.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6ec92845c7458bfe8fdc8071138aba4d4bb8418c
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Jul 11 16:24:16 2019 +0100
Bug 18930: DBRev 19.06.00.011
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 2ba0d3e6271eb0e311f90994c2c64f43fbe23a37
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Wed Jul 3 22:04:19 2019 +0000
Bug 18930: (QA follow-up) Remove debug code
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 282f5d288df62d18fad47d7674a20e39483e03c2
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Tue May 7 00:19:31 2019 -0300
Bug 18930: (follow-up) Change variable used in refund select for default options
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 9dbaefddb8ab2cf13805ae5bc7b1038091a740cb
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Mon May 6 23:14:04 2019 -0300
Bug 18930: (follow-up) Amend search parameter in Koha::RefundLostItemFeeRules->_default_rule
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit ace2651aa7f516e0dbfdcdaaffec815df4bb2f16
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Mon May 6 23:11:09 2019 -0300
Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 780b377db2cb3c693e7f94ff8d9eccc4e8711a85
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Mar 6 10:41:17 2019 -0300
Bug 18930: (follow-up) Make DB update idempotent
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5512f945059d1369e75c1952b5cb40b56fca0e80
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Oct 25 10:16:20 2018 -0300
Bug 18930: Do not insert '*' in circulation_rules
We must insert NULL instead, otherwise the FK constraint will fail
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fd63fe7d126986b1ab72d70ec2b35e05ef7cddea
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Jul 12 10:55:08 2017 -0400
Bug 18930: Move lost item refund rules to circulation_rules table
This patch will move the list item refund rules from a dedicated table to the circulation_rules table.
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Verify lost item refund rules remain unchanged
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fcc22df8ff277ac7041d5eb72e83821fb1ef1f37
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Jul 1 11:45:14 2019 +0000
Bug 13597: Make staff client Amazon no image results match OPAC
The point is to make staff client HTML for missing Amazon cover
images more equivalent to that of the OPAC
To test:
1 - Enable Amazon images everywhere
2 - Search on the staff and OPAC to get some results without
Amazon covers (missing ISBNs and bad ISBNs)
3 - Note OPAC missing images are like:
<span class="no-image">No cover image available</span>
4 - Note staff client are like:
<img src="https://images-na.ssl-images-amazon.com/images/G/01/x-site/icons/no-img-sm.gif" alt="" class="thumbnail" />
5 - The staff links do not lend themselves to easy CSS hiding/styling
6 - Apply patch
7 - Repeat
8 - Note increased consistency
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e269d6e6e6c9d1e3e11ae43a7773f3026f4d801a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed May 31 16:24:51 2017 +0200
Bug 18707: Background jobs post disabled inputs
For example, in Tools > Batch item modification input of deleted subfields are disabled.
This form is posted using background job via JS code.
Looks like this JS code converts a POST form into a GET URL, including inputs that are disabled :
koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js
function submitBackgroundJob(f) {
...
$(':input', f).each(function() {
...
This patch add a :enabled to selector
Test plan :
<to define>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit fd5686b156ceb10958cab728b7695aa2b39b9933
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Jun 10 18:54:30 2019 +0000
Bug 12537: Don't retrieve XISBN results for the same biblionumber
For a biblio with multiple ISBNS we sometimes get our own record back when
check XISBN, we should test for this
To test:
1 - Edit a record in the catalogue, add two isbns:
0521240670
0521284198
2 - Enable ThingISBN and FRBRizeEditions and OPACFRBRizeEditions
3 - View the record in staff and OPAC
4 - You should see editions tab pointing to the same record
5 - Apply patch
6 - Reload the record details, you should no longer see editions tab
7 - Add the second ISBN to another record
8 - Reload details for original record, you shoudl see editions linking to the record with second ISBN
9 - prove -v t/db_dependent/XISBN.t
NOTE: Current tests don't work under elasticsearch, but the code does, tests should be rewritten on another bug
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Arthur Bousquet <arthur.bousquet at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f45516e73ab6ac8c2240f206bd11a88e4935359c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Jun 24 11:54:56 2019 +0000
Bug 23192: Correct tab input on waiting_holds.inc
To test:
1 - Place 2 holds
2 - Confirm the holds
3 - In the db change the expiration date:
UPDATE reserves SET expirationdate = '2019-01-01';
4 - Go to Home->Circulation->Holds awaiting pickup
5 - View your holds on the 'Holds waiting over' tab
6 - Inspect the cancel button for one of the holds, note tab = "holdswaiting"
7 - Apply patch
8 - Refresh the page
9 - Inspect the buttton, note tab = "holdsover"
10 - Cancel the hold
11 - Note you return to the holds over tab
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 076d5be767d0b6667ce8aab0ae7b56116e48d48f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Jul 4 12:57:17 2019 +0000
Bug 23266: Add to cart fires twice on shelf page
Remove some duplicate functionality between opac-bottom and opac-shelves.
Test plan:
[1] Before this patch, add to cart from a shelf page. Observe that the
basket count is incremented with 2.
[2] After this patch, it should be incremented with 1.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f447658f850bca5ebcdb6f29a5572c1c1707f942
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Jun 25 11:44:12 2019 +0000
Bug 23194: Fix other occurences
Throughout staff client and course reserves we also show the field with HTML filter, maybe we shouldn't?
The items lost report also included the note as a title element on title and barcode links, I removed this
as the note displays in that table
To test:
1 - Add a link to publicnotes for an item
<a href="www.google.com">Cats!</a>
2 - View opac details, confirm the note is a link
3 - Same for staff side
4 - Add item to a course reserve
UseCourseReserves preference must be set to 'Use'
From the course reserves module you will need to add a course (and possibly a department first)
Adding should be intuitive
5 - Confirm note is a link in course details on staff and opac
6 - Perform a batch checkout, confirm the itemnote shows as a link
You will need to enable the system preference: BatchCheckouts and add a patron category to: BatchCheckoutsValidCategories
Then a link should be available from checkout for a patron in that category
7 - Mark the item as lost
8 - Go to Reports->Items lost
9 - Confirm the note is a URL and that title and barcode links don't show the note
10 - Click the barcode to go to moredetails for the item - in this case note should display as editable text, not a link
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: frederik chenier <frederik.chenier at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3f40c32cbbc63dbc5f00d127edfeaa0732f4ab23
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Jun 25 11:39:54 2019 +0000
Bug 23194: Allow HTML in item public notes to be processed on OPAC details
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: frederik chenier <frederik.chenier at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d88709ec2d45df6f2a8e90ae7a94f9724b7e8e7e
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jun 27 13:38:50 2019 +0000
Bug 23227: Remove type attribute from script tags: Reports
This patch removes the "type" attribute from <script> tags in two
reports templates.
To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:
- Reports -> Dictionary
- Delete
- Specifying a date range for a date column
- Reports -> Items lost
- Report results
-> Datatables functionality
-> Selection tools for export
Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: frederik chenier <frederik.chenier at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 0658d84732cadb3bec44126d9efbd12a87547228
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue May 21 18:25:39 2019 +0000
Bug 22957: Remove type attribute from script tags: Staff client includes 1/2
This patch removes the "type" attribute from <script> tags in several
staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>"
markers.
This patch also makes minor indentation changes, so diff using the "-w"
flag.
To test, apply the patch and confirm that examples of affected pages
work properly without any JavaScript errors in the browser console:
- Acquisitions -> Vendor (uses acuisitions-toolbar.inc)
- Acquisitions -> Vendor -> Add to basket -> From a new (empty) record
(uses additem.js.inc)
- Catalog -> Search results -> Bibliographic detail view. (uses
browser-strings.inc, catalog-strings.inc, datatables.inc, and
format_price.inc )
- Tools -> Label creator -> Manage -> Label batches -> Export batch
(uses greybox.inc)
Validating the HTML source of any of these pages should return no errors
related to the "type" attribute.
Signed-off-by: Nadine Pierre <nadine.pierre at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 178a805a5d3055dd17050111c1227a9d5cef1b96
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jun 26 12:39:59 2019 +0000
Bug 22951: (follow-up) Fix indentation
This patch fixes indentation related to the markup corrections in the
previous patch. It contains no textual changes.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nadine Pierre <nadine.pierre at inLibro.com>
Signed-off-by: frederik chenier <frederik.chenier at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit e0991ae2358224a15b6880c96b8472a3cd814b1b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jun 26 12:43:36 2019 +0000
Bug 22951: Markup error in OPAC holds template
This patch makes minor markup changes to the OPAC holds template in
order to fix validation errors.
To test, apply the patch and go through the process of placing a
hold in the OPAC. Test various aspects of the process, including cases
where the hold is blocked and an error message is displayed (for
instance, when there are no items to be placed on hold).
The page should work correctly and validating the source should
return no relevant errors.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Frederik Chenier <frederik.chenier at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5c5d158b1bc37c63196be9ae405e4a2563315dbc
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Jun 27 20:45:27 2019 -0400
Bug 21000: Force case sensitivity on Getopt::Long
Before patch: -D and -d are mistaken for --debug
$ sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -r ~/debian -v 19.06~git --autoversion -d -D="stretch"
Option d does not take an argument
git status --porcelain -unormal
git rev-parse --short=8 HEAD
dch --force-distribution -D "squeeze-dev" -v "19.06~git+20190627205913.466f99e4-1" "Building git snapshot."
dch warning: Recognised distributions are:
experimental, unstable, testing, stable, oldstable, oldoldstable,
{bullseye,buster,stretch,jessie,wheezy}-proposed-updates,
{testing,stable,oldstable,oldoldstable}-proposed-updates,
{bullseye,buster,stretch,jessie,wheezy}-security,
{testing,stable,oldstable,oldoldstable}}-security, jessie-backports, stretch-backports and UNRELEASED.
Using your request anyway.
NOTE: squeeze-dev in the first dch line and warning about Option d.
Apply patch: -D and -d are differentiated correctly.
$ sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -r ~/debian -v 19.06~git --autoversion -d -D="stretch"
git status --porcelain -unormal
git rev-parse --short=8 HEAD
dch --force-distribution -D "stretch" -v "19.06~git+20190627210316.b3f919a7-1" "Building git snapshot."
dch warning: Previous package version was Debian native whilst new version is not
dch -r "Building git snapshot."
NOTE: No more 'Option d' error, and "stretch" in the first dch line.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d4f41cc8aafbb9854b20d1de7115a81e1eb73b9c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu May 30 14:15:52 2019 -0400
Bug 23018: Refunding a lost item fee may trigger error if any fee has been written off related to that item
If a lost item fee is written off, it creates a writeoff with the same itemnumber but the amount column is a negative number.
Now, when the lost item is returned, it calls _FixAccountForLostAndReturned which searchs for all accountlines with an account type of 'L' or 'W'.
Then, if the *first* of those lines has an outstanding balance, a credit is created and *all* the lines found are passed to $credit->apply. The apply method then calls is_debit on each line and when it hits the writeoff, it throws an exception ( Koha::Exceptions::Account::IsNotDebit ).
When this happens, the credit is creating but not applied the the outstanding lost item fee, and the librarian is presented with an error page.
It seems like the solution is to only fetch the first result since it seems like that is the only one we should be operating on.
Test Plan:
1) Create a lost item with a fee
2) Create a manual debit using the barcode of the item
3) Write off that manual debit
4) Check in the item, note the error
5) Apply this patch
6) Repeat steps 1-3
7) Check in the item, no error!
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 67f86868155725b3fec29d38a54e8c161dd72c78
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Jul 31 16:13:20 2017 +0000
Bug 19012: Note additional columns that are required during patron import
This adds surname and cardnumber to the list of required columns on the
import tool screen and help page
To test:
Read the updated notes, verify it is true and understandable
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Accounts.pm | 28 +-
C4/Acquisition.pm | 4 +-
C4/Biblio.pm | 14 +-
C4/Charset.pm | 2 +-
C4/Circulation.pm | 40 +-
C4/ImportBatch.pm | 8 +-
C4/Items.pm | 13 +-
C4/Labels/Label.pm | 2 +-
C4/Matcher.pm | 3 +-
C4/Search.pm | 8 +-
C4/Serials.pm | 2 +-
C4/XISBN.pm | 6 +-
Koha.pm | 2 +-
Koha/Account.pm | 14 +-
Koha/Account/Line.pm | 15 +-
Koha/Exporter/Record.pm | 2 +-
Koha/Filter/MARC/EmbedItemsAvailability.pm | 2 +-
Koha/Filter/MARC/EmbedSeeFromHeadings.pm | 2 +-
Koha/FrameworkPlugin.pm | 1 -
Koha/RefundLostItemFeeRule.pm | 45 -
Koha/RefundLostItemFeeRules.pm | 44 +-
Koha/Schema/Result/RefundLostItemFeeRule.pm | 66 --
Koha/SearchEngine/Search.pm | 2 +-
acqui/addorderiso2709.pl | 2 +-
acqui/finishreceive.pl | 2 +-
acqui/neworderempty.pl | 8 +-
admin/columns_settings.yml | 2 -
admin/smart-rules.pl | 38 +-
catalogue/MARCdetail.pl | 2 +-
catalogue/detail.pl | 2 +-
catalogue/moredetail.pl | 38 +
cataloguing/addbiblio.pl | 20 +-
cataloguing/additem.pl | 20 +-
cataloguing/value_builder/barcode.pl | 5 +-
cataloguing/value_builder/barcode_manual.pl | 4 +-
circ/branchoverdues.pl | 2 +-
debian/build-git-snapshot | 2 +-
installer/data/mysql/updatedatabase.pl | 98 +++
.../intranet-tmpl/lib/yui/reset-fonts-grids.css | 9 -
koha-tmpl/intranet-tmpl/prog/css/reports.css | 11 -
.../intranet-tmpl/prog/css/src/staff-global.scss | 230 +----
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
koha-tmpl/intranet-tmpl/prog/en/columns.def | 1 -
.../intranet-tmpl/prog/en/includes/accounts.inc | 42 +-
.../prog/en/includes/acquisitions-toolbar.inc | 12 +-
.../intranet-tmpl/prog/en/includes/additem.js.inc | 28 +-
.../prog/en/includes/browser-strings.inc | 4 +-
.../prog/en/includes/catalog-strings.inc | 2 +-
.../intranet-tmpl/prog/en/includes/datatables.inc | 4 +-
.../prog/en/includes/format_price.inc | 2 +-
.../intranet-tmpl/prog/en/includes/greybox.inc | 2 +-
.../prog/en/includes/waiting_holds.inc | 2 +-
.../prog/en/modules/admin/smart-rules.tt | 8 +-
.../prog/en/modules/catalogue/detail.tt | 2 +-
.../prog/en/modules/catalogue/results.tt | 8 +-
.../en/modules/circ/circulation_batch_checkouts.tt | 2 +-
.../prog/en/modules/circ/on-site_checkouts.tt | 2 +-
.../prog/en/modules/circ/waitingreserves.tt | 4 +-
.../en/modules/course_reserves/course-details.tt | 2 +-
.../prog/en/modules/members/maninvoice.tt | 4 +-
.../prog/en/modules/reports/cash_register_stats.tt | 2 +-
.../prog/en/modules/reports/dictionary.tt | 2 +-
.../en/modules/reports/guided_reports_start.tt | 159 +++-
.../prog/en/modules/reports/itemslost.tt | 8 +-
.../prog/en/modules/tools/import_borrowers.tt | 2 +-
.../prog/en/modules/tools/manage-marc-import.tt | 922 +++++++++++---------
.../intranet-tmpl/prog/en/xslt/MARC21Languages.xsl | 498 +++++++++++
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 1 +
.../prog/en/xslt/MARC21slim2intranetResults.xsl | 2 +
.../intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl | 54 +-
.../prog/js/background-job-progressbar.js | 2 +-
.../bootstrap/en/includes/account-table.inc | 3 +-
.../bootstrap/en/modules/opac-course-details.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 620 ++++++-------
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 4 +-
misc/batchImportMARCWithBiblionumbers.pl | 2 +-
misc/batchRebuildBiblioTables.pl | 2 +-
misc/batchRebuildItemsTables.pl | 2 +-
misc/maintenance/generate_MARC21Languages.pl | 142 +++
misc/migration_tools/22_to_30/missing090field.pl | 4 +-
misc/migration_tools/bulkmarcimport.pl | 4 +-
misc/migration_tools/rebuild_zebra.pl | 6 +-
opac/opac-MARCdetail.pl | 6 +-
opac/opac-detail.pl | 2 +-
opac/opac-user.pl | 2 +-
reports/cash_register_stats.pl | 4 +-
serials/serials-edit.pl | 8 +-
svc/bib | 2 +-
svc/new_bib | 2 +-
t/db_dependent/Accounts.t | 65 +-
t/db_dependent/Biblio.t | 2 +-
t/db_dependent/Biblio/TransformHtmlToMarc.t | 2 +-
t/db_dependent/Charset.t | 2 +-
t/db_dependent/Circulation.t | 93 +-
t/db_dependent/Circulation/GetTopIssues.t | 4 +-
.../Circulation/NoIssuesChargeGuarantees.t | 2 +-
t/db_dependent/Filter_MARC_ViewPolicy.t | 6 +-
t/db_dependent/ImportBatch.t | 2 +-
t/db_dependent/Items.t | 4 +-
.../Items/AutomaticItemModificationByAge.t | 2 +-
t/db_dependent/Items/GetItemsForInventory.t | 2 +-
t/db_dependent/Koha/Account.t | 6 +-
t/db_dependent/Koha/Account/Lines.t | 31 +-
.../Koha/Filter/EmbedItemsAvailability.t | 4 +-
t/db_dependent/RefundLostItemFeeRule.t | 328 +++++--
t/db_dependent/Serials.t | 4 +-
t/db_dependent/XISBN.t | 24 +-
tools/batchMod.pl | 8 +-
109 files changed, 2498 insertions(+), 1517 deletions(-)
delete mode 100644 Koha/RefundLostItemFeeRule.pm
delete mode 100644 Koha/Schema/Result/RefundLostItemFeeRule.pm
delete mode 100644 koha-tmpl/intranet-tmpl/lib/yui/reset-fonts-grids.css
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21Languages.xsl
create mode 100755 misc/maintenance/generate_MARC21Languages.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list