[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.01-25-g4b0602e

Tue Jul 16 08:44:39 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  4b0602e77044f280982c8dcb07b3ca33a0f29b4f (commit)
       via  6151e1a613260f759c2017df2307cd99bab76d10 (commit)
       via  4d6f85b7ef98e980ee332b56f56f88a83377e0ce (commit)
       via  eb1017fa8ff51599ec94eb50724c738da2fbf9d5 (commit)
       via  20e0d798ac229e9bae3cb996055a95efc4d68fe6 (commit)
       via  20dd0b9ee950d539bdf62555f3dfec81e0379f51 (commit)
       via  82130e73860a96025f4cfbeb7dd0bc4d091d6e33 (commit)
       via  b68f2aab6e7c33a26cf9568cca3b75ea30f0a014 (commit)
      from  9b1f593f50575df2b849863acf6ad83b3587feeb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4b0602e77044f280982c8dcb07b3ca33a0f29b4f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Jun 21 12:28:48 2019 +0100

    Bug 23177: (RM follow-up) Further test clarifications

    This patch makes a few minor improvements to Circulation.t
    1) Adds a name to some of the scoped blocks by converting them to
       subtests.
    2) Adds output messages to some tests where they were missing.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 90d4e3a672e8778e30058fe691f83d94b6d379ce)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 6151e1a613260f759c2017df2307cd99bab76d10
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jun 21 09:15:18 2019 +0000

    Bug 23177: (QA follow-up) Remove subtest txn_begin and rollback

    This resolves:
    DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1)
    Removing unneeded subtest txn's. We should probably add them everywhere or
    just at global level.

    Test plan:
    With all three patches applied, run Circulation.t a few times.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit c7a707d60b187fa2c18c4bacd3a6b472de25da98)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 4d6f85b7ef98e980ee332b56f56f88a83377e0ce
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jun 21 09:03:27 2019 +0000

    Bug 23177: (QA follow-up) Move rollback to the end

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 95a303c8f351bdd926136b5e9110ba9957df52f1)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit eb1017fa8ff51599ec94eb50724c738da2fbf9d5
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jun 21 09:00:27 2019 +0000

    Bug 23177: (QA follow-up) Move three subs from the middle to the top in Circulation.t

    Removed trailing comma for last sub too.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 568d3f82cba2aef475e71624c7eaec2054d234ef)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 20e0d798ac229e9bae3cb996055a95efc4d68fe6
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Jun 17 17:58:56 2019 +0000

    Bug 23140: Fix typo in branchcode parameters for print slip

    To test:
    1 - Have [% branch.branchcode %] in your TRANSFERSLIP
    2 - Checkin an item from another branch (with AutomaticItemReturn = do )
    3 - Inspect the button in the browser to see the typo
    4 - Click 'Print slip'
    5 - Note the branchcode is not populated
    6 - Clear the transfer
    7 - Apply patch
    8 - Repeat
    9 - Note typo is fixed and slip correctly populated

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 2af415a866d5ce46c6c243dfc6380b002e323db6)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 20dd0b9ee950d539bdf62555f3dfec81e0379f51
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jun 21 07:08:39 2019 +0000

    Bug 13640: (QA follow-up) Allow NULL values for default_branch_item_rules.holdallowed

    If a rule has not been defined for an itemtype or you submit a biblio level
    hold, you cannot filter on holdallowed<>0.

    Test plan:
    Test with a biblio level hold. Have two items; one item should be blocked
    with a policy.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 82130e73860a96025f4cfbeb7dd0bc4d091d6e33
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 13 09:57:52 2019 -0500

    Bug 13640: Do not display unreserveable items on the Holds to pull screen

    We should only display the items that meet the hold policies

    Test plan:
    It would be good to have a huge list of holds displayed on the "Holds to
    pull" and confirm that the display is now correct.

    One of the possible test plan has been let in a comment on the bug
    report:
    Bib Record A has 2 items:

    Item Record X (can be placed on hold)
    Item Record Y (cannot be placed on hold)

    If you place a bib-level hold on Bib Record A, both Item Record X and
    Item Record Y show up as available items in the Holds To Pull List.

    With this patch applied you must not see Y

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit b68f2aab6e7c33a26cf9568cca3b75ea30f0a014
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Mon Jun 10 14:36:49 2019 -0400

    Bug 23090: Add some special characters

    TEST PLAN
    ---------

    $ sudo mysql -u root
    > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'badpassword';
    [Magical MySQL Error]
    > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'GoodP at ssw0rd';
    [Should be okay]
    > DROP USER 'bug23090_test1'@'localhost';
    > QUIT
    $ sudo koha-create --create-db fail23090
    [Magical MySQL Error]
    [Apply this patch and put it (debian/scripts/koha-create) into place in
    /usr/sbin/koha-create]
    $ sudo koha-create --create-db pass23090

    (Clean up and databases made)

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    (cherry picked from commit f56bba9297087eaeaeefb2aba546c9f107bfad6e)

    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 circ/pendingreserves.pl                            |    2 +
 debian/scripts/koha-create                         |    5 +-
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |    4 +-
 t/db_dependent/Circulation.t                       |  159 ++++++++++----------
 4 files changed, 86 insertions(+), 84 deletions(-)

hooks/post-receive
-- 
main Koha release repository