[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.07-20-gae7f79b

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  ae7f79b9035d86ae25dc47751ea98d9041ff2ef0 (commit)
      from  a02c645fe08aa6070d1b960e2b1d81a067757fe3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ae7f79b9035d86ae25dc47751ea98d9041ff2ef0
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Jun 13 06:34:38 2019 -0400

    Bug 23116: AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold
    
    A library appears to be able to place a second item level hold on an item a patron already has on hold if
    A) AllowHoldPolicyOverride is enabled
    and
    B) the circ rule allow for multple item level holds.
    
    Once the patron submits the hold requests though, the hold does not get stored in the database.
    
    Because allowing two item level holds for the same item makes no sense, we should not allow
    this attempt to take place, even if AllowHoldPolicyOverride is enabled.
    
    Test Plan:
     1) Enable AllowHoldPolicyOverride
     2) Set up circ rules to allow for multiple item level holds on one record
     3) Place an item level hold on a record
     4) Note you can force placing a second item hold on that reocrd
     5) Attempt to do so, it will not actually work
     6) Apply this patch
     7) Note you can no longer place another item level hold for the same item
       you just placed an item-level hold on
     8) Note you can still force holds that contravene the circ rules for
       any and all other reasons
     9) Test with record level holds
    10) Test by placing multiple holds from search results
    
    Signed-off-by: Martha Fuerst <mfurest at hmcpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Simple fix for a regression. Works as expected.
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 2c5e9bed7de83d01be755475b96a3cf439e0126c)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    
    (cherry picked from commit d0186dd176c86e1175c80db9e5d38db1d6a9e2b2)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 reserve/placerequest.pl |   19 +++++++++++++------
 reserve/request.pl      |    7 +++++--
 2 files changed, 18 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
main Koha release repository