[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.02-49-g75e886e

Thu Jul 25 15:59:52 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  75e886e31e61646e7e1ee34a93d065528f560382 (commit)
       via  dd850bdd07f7adc52abdf330c334c4c31b3a1176 (commit)
       via  646072e1cf3759aa9ffc676cdb153aaf0758292d (commit)
       via  af7c25d2493bb3ef4f3f198c1181b98e8f1025f6 (commit)
       via  6c208a09619d2326bfa608cd3afee343cd4f4c33 (commit)
       via  5232a6263932556eaa3220f4b771c16c7a735b3c (commit)
       via  f410a8220db0a6c8408c832628acab4831c15b27 (commit)
       via  b19aa25f60c79f728626a9d346c9c70b928eb636 (commit)
       via  d83fb48e7ee6f27beaff958dfec388a2df7ff38e (commit)
       via  a0fbbc63db466635f46a21a54a4fca4e65bb7e23 (commit)
       via  1e2dc2340105b35355d29ad5eda1d74a83375a4e (commit)
       via  2340df6f7c85c48a2ae68292204e9f16d485e7b9 (commit)
      from  8c72eaaf86ee0d4d43e8d12b0f7b98992cd4d7a1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 75e886e31e61646e7e1ee34a93d065528f560382
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 19 20:08:04 2019 -0500

    Bug 23083: Fix course reserve item editing if one of the value is set to UNCHANGED

    Test plan:
    0: Do not apply the patches
    1: Create an item with itype, ccode, location, and holding branch set
    2: Create a course
    3: Add item to course, changing the values for itype, ccode, and location
    4: Click Edit for that item on course-details.pl
    5: Assign new values for itype, ccode, and location but leave the holding library dropdown set to LEAVE UNCHANGED
    6: Hit Save
    7: Back on course-details.pl, observe that the item is still showing the values set in step 3
    8: Apply this patch
    9: Repeat 4 to 6
    10: Back on course-details.pl, observe that the item is now showing the correct values
    11: Edit the course reserve again, setting new values for itype, ccode, and location and setting the holding library dropdown to whatever the holding library for the item is currently
    12: hit save
    13: On course-details.pl, see that the change actually happened, the item is now showing the values set in step 9

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit e4ee3636304d06a0492fee6a1fcd9e4c65a17be6)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit dd850bdd07f7adc52abdf330c334c4c31b3a1176
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 19 20:12:14 2019 -0500

    Bug 23083: Add tests

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 44469cf4c3e9fa690b2247324b1922fdde207f9f)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 646072e1cf3759aa9ffc676cdb153aaf0758292d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Jul 2 16:10:10 2019 +0000

    Bug 23255: Correct HomeOrHoldingBranch descriptions

    To test:
    1 - Apply patch
    2 - View 'HomeOrHoldingBranch' system preference
    3 - Confirm the options make sense

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit cbf605539ad90e18a0325b1d06e43b8b71b655e9)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit af7c25d2493bb3ef4f3f198c1181b98e8f1025f6
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Jul 3 02:35:16 2019 +0000

    Bug 23230: (follow-up) Fix broken tests

    Before patch, the new tests don't run.
    After patch, they do.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 288cc505557fdcb167737f1894cee581526b4741)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 6c208a09619d2326bfa608cd3afee343cd4f4c33
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jul 1 11:42:51 2019 -0300

    Bug 23230: Make _version_compare OO context aware

    On using _version_compare in plugins development, it would be nice if it
    was able to be called as an object method. This way we don't need to
    fully qualify it like this:

        Koha::Plugins::Base::_version_compare

    and we can do

        $self->_version_compare

    instead.

    This patch implements this behavior change. It is backwards compatible
    so plugins using the 'old way' don't break.

    To test:
    - Apply the unit tests patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Plugins.t
    => FAIL: Tests fail
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Plugins.t
    => SUCCESS: Tests pass!
    - Sign off :-D

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 90acef7a9b860e70631ff243c21b435a7d081a16)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 5232a6263932556eaa3220f4b771c16c7a735b3c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jul 1 11:33:41 2019 -0300

    Bug 23230: Unit tests

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 2ff5f9fb633e6f3786b093d2a2f202a66db7b3d0)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit f410a8220db0a6c8408c832628acab4831c15b27
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Jun 28 15:27:27 2019 +0000

    Bug 17003: (QA follow-up) Fix the number of tests

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 162ea12db99e3ad2face427548a1f4e6f469ef77)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit b19aa25f60c79f728626a9d346c9c70b928eb636
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Mar 29 07:53:27 2019 +0000

    Bug 17003: (follow-up) Update definitions according to voted RFC

    Test plan:
    1) Have some patrons with checkouts, some renewable and some not
    renewable
    2) Use your favorite API tester and access GET
    http://koha.url/api/v1/checkouts/{checkout_id}/allows_renewal
    3) Check the response is OK according to voted RFC:
    https://wiki.koha-community.org/wiki/Checkouts_endpoint_RFC#Checkout_renewability_2
    4) prove t/db_dependent/api/v1/checkouts.t

    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 0619aab9971c7f4d4859620abbac7ad2bfe93364)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit d83fb48e7ee6f27beaff958dfec388a2df7ff38e
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Feb 21 02:30:00 2019 +0000

    Bug 17003: Adapt to OpenAPI

    Test plan:
    prove t/db_dependent/api/v1/checkouts.t

    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 0404ecec4b619ebe14ac262332870004bb88878c)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit a0fbbc63db466635f46a21a54a4fca4e65bb7e23
Author: Lari Taskula <larit at student.uef.fi>
Date:   Mon Aug 22 17:35:44 2016 +0300

    Bug 17003: Add API route to get checkout's renewability

    Signed-off-by: Johanna Raisa <johanna.raisa at gmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 563458f20e413388d11cf92ea36d2867f488416f)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 1e2dc2340105b35355d29ad5eda1d74a83375a4e
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jun 7 10:14:36 2019 +0000

    Bug 23045: Return record along with errors

    We don't seem to directly handle the errors in most cases, let's always return the record

    To test:
    1 - Add some blank lines to editor, previous patch is okay with this
    2 - Add a line with just 'e' or some other incomplete field
    3 - Try to save
    4 - Note JS leader error
    5 - Apply this patch
    6 - No errors

    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit f927d801121f9d7b291516649cf3b55be49b8e3d)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 2340df6f7c85c48a2ae68292204e9f16d485e7b9
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Jun 4 14:25:53 2019 +0000

    Bug 23045: TextMarc errors on blank lines

    Since bug 16251 we use TextMarc to get some record fields, however, it throws an error when
    processing blank lines.

    We should just pass on these rather then erroring

    To test:
    1 - Define a new macro that delete more fields than it adds
      delete 245
    2 - Run it
    3 - Note an error in JS console, and helpers will not load
    4 - Apply patch
    5 - Reload, try again
    6 - No error

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 545f38d13c210e4cb173e67d2578d825a9ffeb47)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/CourseReserves.pm                               |   11 ++---
 Koha/Plugins/Base.pm                               |   10 ++++-
 Koha/REST/V1/Checkouts.pm                          |   45 ++++++++++++++++++++
 api/v1/swagger/definitions.json                    |    3 ++
 api/v1/swagger/definitions/allows_renewal.json     |   21 +++++++++
 api/v1/swagger/paths.json                          |    3 ++
 api/v1/swagger/paths/checkouts.json                |   30 +++++++++++++
 .../intranet-tmpl/lib/koha/cateditor/text-marc.js  |    6 +--
 .../prog/en/includes/cateditor-widgets-marc21.inc  |    1 +
 .../en/modules/admin/preferences/circulation.pref  |    4 +-
 t/db_dependent/CourseReserves/CourseItems.t        |   14 +++++-
 t/db_dependent/Plugins.t                           |   27 ++++++++----
 t/db_dependent/api/v1/checkouts.t                  |   19 ++++++++-
 13 files changed, 171 insertions(+), 23 deletions(-)
 create mode 100644 api/v1/swagger/definitions/allows_renewal.json

hooks/post-receive
-- 
main Koha release repository