From gitmaster at git.koha-community.org Mon Jun 3 12:22:56 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Jun 2019 10:22:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-1-g4f81a25 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4f81a252ddceaf2cd964aa0cfb95d0966b781dd8 (commit) from 1b5635bebd75c418fdda68036e1e91f857cb1e4d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4f81a252ddceaf2cd964aa0cfb95d0966b781dd8 Author: Martin Renvoize Date: Mon Jun 3 10:50:50 2019 +0100 Koha 19.06 - Wingardium Leviosa! ?Hermione rolled up the sleeves of her gown, flicked her wand and said, 'Wingardium Leviosa!' The feather rose off the desk and hovered about four feet above their heads. ?Oh, well done!? cried Professor Flitwick, clapping. ?Everyone see here, Miss Granger?s done it!?? Together, let's make Koha fly to new heights, ? Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 3 14:04:15 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Jun 2019 12:04:15 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x created. v19.05.00 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been created at 1b5635bebd75c418fdda68036e1e91f857cb1e4d (commit) - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 3 17:47:27 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Jun 2019 15:47:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-2-ga4844b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a4844b85eed809c20053adb7862c21601d6cf148 (commit) from 4f81a252ddceaf2cd964aa0cfb95d0966b781dd8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a4844b85eed809c20053adb7862c21601d6cf148 Author: Owen Leonard Date: Tue May 21 16:29:06 2019 +0000 Bug 22953: Markup warning in OPAC user summary template This patch makes a minor markup change to the OPAC user summary template (opac-user.tt) in order to quiet warnings from the HTML validator. The obsolete name attribute on two links is removed in favor of class names. The JavaScript has been modified accordingly. To reproduce the problem you should have the AllowCheckoutNotes system preference enabled. Log in to the OPAC as a user who has checkouts and view the "your summary" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses this warning: - "The name attribute is obsolete. Consider putting an id attribute on the nearest container instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the process of adding or editing an note on a checkout. It should work correctly. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 3 19:01:12 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Jun 2019 17:01:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-4-g83af64f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 83af64f59fdc02c470f6e9754cbc922862aa1d18 (commit) via e9294c3cc20584adebb6d38451ebccce86a8f1aa (commit) from a4844b85eed809c20053adb7862c21601d6cf148 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 83af64f59fdc02c470f6e9754cbc922862aa1d18 Author: Martin Renvoize Date: Mon Jun 3 17:40:38 2019 +0100 Bug 22906: Compiled CSS Signed-off-by: Martin Renvoize commit e9294c3cc20584adebb6d38451ebccce86a8f1aa Author: Owen Leonard Date: Tue May 14 13:10:32 2019 +0000 Bug 22906: Minor corrections to plugins home page This patch makes a few minor markup improvements to the plugins home page and corrects some CSS introduced by Bug 22053 which was having unintended consequences elsewhere. To test, apply the patch and rebuild the staff client CSS. - You should have one or more plugins installed. - Go to Administration -> Manage plugins. - The "badges" for disabled and enabled should look correct. - Go to Tools -> Staged MARC management and click on an batch. - In the information about the batch, the labels should be bold. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/css/src/staff-global.scss | 18 +++++++++++++----- koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../prog/en/modules/plugins/plugins-home.tt | 14 +++++++------- 3 files changed, 21 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 3 20:12:15 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Jun 2019 18:12:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-12-gd26991c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d26991cf4cc298fc3900b8133ff9b40cd061fb96 (commit) via 87cbb27826a9d03a424e8c944293669157924a01 (commit) via 1653ae887103d783b91e00775f60e80041fd9860 (commit) via 457000102e7e2228c6bd834283a9e58f32bb2104 (commit) via fa411c2f80d3464c9205f49fc31de492bc265c57 (commit) via 55289562468f77e6f6a2c1671d8a3ec472a50f99 (commit) via d1b6e320860060ffe35e7df7f3df1b8c10517a73 (commit) via 01c4ee5703af156e2bb2057da83e156f9090be40 (commit) from 83af64f59fdc02c470f6e9754cbc922862aa1d18 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d26991cf4cc298fc3900b8133ff9b40cd061fb96 Author: Owen Leonard Date: Tue May 21 17:14:36 2019 +0000 Bug 22955: Markup error in OPAC lists template This patch makes a minor correction to the template for OPAC lists. This correction fixes an error returned by the HTML validator by adding an empty "alt" attribute to an image tag. To reproduce the problem you should have at least one list available in the OPAC with one or more items on it. View the contents of that list in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "An img element must have an alt attribute, except under certain conditions." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Click "Download list." A modal window should appear with a "Loading" message, followed by a form for selecting a download format. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 87cbb27826a9d03a424e8c944293669157924a01 Author: Owen Leonard Date: Tue May 21 13:19:17 2019 +0000 Bug 22947: Markup error in OPAC preferences file This patch corrects a markup error in the OPAC .pref file which can cause display problems. The patch also corrects a validator warning by changing at to a . To reproduce the problem, go to Administration -> Global system preferences -> OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Unclosed element code." - "The tt element is obsolete. Use CSS instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the display. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 1653ae887103d783b91e00775f60e80041fd9860 Author: Martin Renvoize Date: Mon Jun 3 18:46:40 2019 +0100 Bug 22950: Compiled CSS Signed-off-by: Martin Renvoize commit 457000102e7e2228c6bd834283a9e58f32bb2104 Author: Owen Leonard Date: Tue May 21 15:04:33 2019 +0000 Bug 22950: Markup error in OPAC recent comment template This patch makes minor corrections to the template for the OPAC's recent comments view. These corrections fix errors returned by the HTML validator. The patch moves some inline CSS into a class in the global OPAC CSS. Some minor reindentation has also been done, so use diff with the '-w' flag. To reproduce the problem you should have the 'reviewson' system preference turned on, and your system should have one or more approved comments. View the "Recent comments" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "CSS: font-color: Property font-color doesn't exist." To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit fa411c2f80d3464c9205f49fc31de492bc265c57 Author: Martin Renvoize Date: Thu May 9 16:34:09 2019 +0100 Bug 22877: (QA follow-up) Clarify intent of tests and remove one. This patch embelishes the existing comments slightly and removes a test which had a FIXME, but was in fact just a duplicate of the test directly above it. I beleive it became a duplicate after the subroutine signature changed at some point recently. I also move the bug 22877 specific test into a subtest. Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 55289562468f77e6f6a2c1671d8a3ec472a50f99 Author: Martin Renvoize Date: Thu May 9 16:00:59 2019 +0100 Bug 22877: (follow-up) Fix test plan count Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit d1b6e320860060ffe35e7df7f3df1b8c10517a73 Author: Martin Renvoize Date: Thu May 9 15:53:56 2019 +0100 Bug 22877: Prevent double overdue processing for lost and returned Test plan: 1 - Issue an item to a patron with a backdated due date 2 - Run fines.pl - note you generate a fine for the patron 3 - Run longoverdue.pl - make sure MarkLostItemsAsReturned is turned off and to charge 4 - Confirm the patron has a lost fee and an overdue 5 - Return the item 6 - With patch applied, patron should now have 1 overdue fine and 1 lost fine Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 01c4ee5703af156e2bb2057da83e156f9090be40 Author: Nick Clemens Date: Thu May 9 12:32:38 2019 +0000 Bug 22877: Unit test to highlight problem Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- .../prog/en/modules/admin/preferences/opac.pref | 4 +- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 5 ++ .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- .../bootstrap/en/modules/opac-showreviews.tt | 41 +++++++------ t/db_dependent/Circulation.t | 63 ++++++++++++++++---- 7 files changed, 84 insertions(+), 35 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 3 20:16:51 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 03 Jun 2019 18:16:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-13-g66877b7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 66877b780a775daf135ef1137364d76f67166e61 (commit) from d26991cf4cc298fc3900b8133ff9b40cd061fb96 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 66877b780a775daf135ef1137364d76f67166e61 Author: Hayley Mapley Date: Thu Mar 21 14:39:59 2019 +1300 Bug 22099: Fixed ILL toolbar to say Refresh when displaying requests On the ILL requests page that lists all requests, the List Request button is displayed as part of the ILL toolbar. This patch fixes this by instead changing the wording of the button to Refresh when on the main page. Test plan: 1) More -> ILL Requests, note that the List Requests button displays while all the requests are already displayed 2) Apply the patch and restart things 3) More -> ILL Requests, note that the button now says Refresh, and clicking it refreshes the page 4) Check that on all the other functions of the ILLs the button says List Requests 5) Sign off! Sponsored-by: Catalyst IT Signed-off-by: Magnus Enger Small conflict resolved. Works as advertised. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 4 11:27:39 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 04 Jun 2019 09:27:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-22-g4ae8542 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4ae854242839ebe9871b65fe0add2241eb4ae0b7 (commit) via f6f86a79d623ac478e2636e2d0cc2272006fe5f0 (commit) via 76a64f8046af820b8be57fbc8d65483259a63f6c (commit) via 2b0347084ce8daa0a11ff4bdfd2e9f8442e65ffb (commit) via d5520510602c123d1ea8d7dc9a9d874995d200c3 (commit) via 851d41ab6b9ec28901086d6a6ce15b3fd589182a (commit) via b40e58343ef65aabe0a575a0b3f842b5e22a3600 (commit) via ac423d5dcf2c7503a8ca78cbafdb94dfc43dfdb6 (commit) via 2c25016a8e17b52e23c3d9806264e141b6426254 (commit) from 66877b780a775daf135ef1137364d76f67166e61 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4ae854242839ebe9871b65fe0add2241eb4ae0b7 Author: Martin Renvoize Date: Tue Jun 4 10:06:46 2019 +0100 Bug 22960: DBRev 19.06.00.001 Signed-off-by: Martin Renvoize commit f6f86a79d623ac478e2636e2d0cc2272006fe5f0 Author: Martin Renvoize Date: Tue Jun 4 09:48:59 2019 +0100 Bug 22960: (RM follow-up) Correct a further typo "This a list" changed to "This is a list" Signed-off-by: Martin Renvoize commit 76a64f8046af820b8be57fbc8d65483259a63f6c Author: Katrin Fischer Date: Sun Jun 2 09:18:00 2019 +0000 Bug 22960: (QA follow-up) Fix another tiny typo This only seems to appear in the .pref file: ...pairs. the => ... pairs. The Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 2b0347084ce8daa0a11ff4bdfd2e9f8442e65ffb Author: Katrin Fischer Date: Mon May 27 20:34:33 2019 +0000 Bug 22960: Fix the same typo on db level for existing and new installations Seriously trying to kill the typo everywhere: - Check your DB with a report: select * from systempreferences where variable = 'UpdateItemLocationOnCheckin'; - Verify the typo in the explanation column: locaiton - Apply patch and run database update - Verify the typo is fixed Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit d5520510602c123d1ea8d7dc9a9d874995d200c3 Author: Owen Leonard Date: Wed May 22 12:23:47 2019 +0000 Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference This patch corrects a typo in circulation.pref in the description of the UpdateItemLocationOnCheckin preference. To see the problem, go to Administration -> System preferences -> Circulation and look at the description for the UpdateItemLocationOnCheckin preference: "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned." Note the misspelling "locaiton." To test, apply the patch and refresh the circulation preferences page. The typo should be fixed. Signed-off-by: Bin Wen Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit 851d41ab6b9ec28901086d6a6ce15b3fd589182a Author: Marcel de Rooy Date: Wed May 29 13:46:15 2019 +0000 Bug 23006: Cannot use inventory with barcodes containing special chars If a barcode contains special characters like $, the regex in inventory does no longer work. This fix (as suggested by Jonathan) replaces the regex by a eq compare. Test plan: Pick one barcode and add a $ somewhere in the middle, say 123$456. Include this barcode in a barcode file for inventory. Run inventory on that file and verify that barcode was read and datelastseen was updated. The barcode should not be reported as missing (not scanned). Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit b40e58343ef65aabe0a575a0b3f842b5e22a3600 Author: Jonathan Druart Date: Wed Sep 12 09:38:39 2018 -0700 Bug 19457: Handle 'PREVISSUE' return by CanBookBeIssued from SIP (CheckPrevCheckout) If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer To test: - Do not apply this patch - Set CheckPrevCheckout to "Do", or "Unless overridden, do" Verify the SIP server is blocking checkouts with this setting set - Apply this patch - Note that the checkout is now allowed, with a screen message telling the borrower they've issued the item before. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit ac423d5dcf2c7503a8ca78cbafdb94dfc43dfdb6 Author: Aleisha Amohia Date: Fri Dec 14 02:05:36 2018 +0000 Bug 11492: (follow-up) Don't pass publisheddatetext param to NewIssue I have removed publisheddatetext as a param from my patch, but only in the places where my patch added it. Any other instance already existed before my patch. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 2c25016a8e17b52e23c3d9806264e141b6426254 Author: Aleisha Amohia Date: Fri Dec 7 01:03:42 2018 +0000 Bug 11492: Keep routing notes when receiving next serial This patch ensures the routing notes are carried over when generating the next serial. To test: 1) Create a routing list for a subscription 2) Add a borrower and a note to the routing list 3) Generate the next serial (serials-collection.pl) 4) Edit the routing list to see the notes 5) Note that the notes have disappeared 6) Apply patch 7) Edit the routing list, add a note 8) Generate the next serial 9) Edit the routing list and confirm the note is still there 10) Confirm you are still able to edit serials (serials-edit.pl) and routing notes stay Sponsored-by: Plant and Food Research Limited Signed-off-by: Nazl? ?etin Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Transaction/Checkout.pm | 3 +++ C4/Serials.pm | 18 ++++++++---------- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 12 +++++++++++- .../en/modules/admin/preferences/circulation.pref | 4 ++-- serials/serials-collection.pl | 5 +++-- serials/serials-edit.pl | 3 ++- t/db_dependent/Serials.t | 2 +- tools/inventory.pl | 2 +- 10 files changed, 33 insertions(+), 20 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 4 11:41:54 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 04 Jun 2019 09:41:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-27-g9a58871 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9a58871503caa1b48e4e5c3cc0f565fa583f3e9d (commit) via 4903cee9e937c970c6d3d15fd78d82189d8705eb (commit) via d5a8a424203cd426f7d0bd64597a6ac95536ef9c (commit) via e72a9c91485c6e68819f3bb76d326f0a1a84dcd9 (commit) via a3da6d6825f686099d8e23a1abff061071d679ad (commit) from 4ae854242839ebe9871b65fe0add2241eb4ae0b7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9a58871503caa1b48e4e5c3cc0f565fa583f3e9d Author: Nazl? ?etin Date: Tue Nov 27 15:24:38 2018 +0000 Bug 21887: (For OPAC) 856 link problem in XSLT result lists and detail page Signed-off-by: Liz Rea Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize commit 4903cee9e937c970c6d3d15fd78d82189d8705eb Author: Nazl? ?etin Date: Tue Nov 27 14:15:33 2018 +0000 Bug 21887: 856 link problem in XSLT result lists and detail page Signed-off-by: Nazl? ?etin Signed-off-by: Liz Rea Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize commit d5a8a424203cd426f7d0bd64597a6ac95536ef9c Author: Owen Leonard Date: Tue May 21 16:59:38 2019 +0000 Bug 22954: Minor markup error in OPAC messaging template This patch corrects a minor error in opac-messaging.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have the EnhancedMessagingPreferencesOPAC system preference enabled. Log in to the OPAC and go to the "your messaging" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses this error: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit e72a9c91485c6e68819f3bb76d326f0a1a84dcd9 Author: Owen Leonard Date: Tue May 21 16:00:18 2019 +0000 Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit a3da6d6825f686099d8e23a1abff061071d679ad Author: Owen Leonard Date: Tue May 21 14:27:40 2019 +0000 Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 75 +++++++++++------- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 82 ++++++++++++-------- .../bootstrap/en/includes/opac-detail-sidebar.inc | 2 +- .../bootstrap/en/modules/opac-messaging.tt | 2 +- .../bootstrap/en/modules/opac-suggestions.tt | 8 +- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 17 +++- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 17 +++- 7 files changed, 134 insertions(+), 69 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 5 10:03:57 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Jun 2019 08:03:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-28-g72d4b10 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 72d4b10bf4abcfc36a9f3bac263ad182b6512088 (commit) from 9a58871503caa1b48e4e5c3cc0f565fa583f3e9d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 72d4b10bf4abcfc36a9f3bac263ad182b6512088 Author: Martin Renvoize Date: Mon Jun 3 17:32:10 2019 +0100 Bug 23037: Add Henry Bolshaw to contributors We missed Henry from the release notes and about page.. sorry Henry! Signed-off-by: Magnus Enger Not really tested, just had a look and checked the changes look sane. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: docs/contributors.yaml | 3 +++ docs/history.txt | 1 + 2 files changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 5 15:04:04 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Jun 2019 13:04:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-31-gf417c15 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f417c15e499745a7cd35fd1c8c5ae79888857199 (commit) via 986629b29f8651a99f877444c69dec2838f513d8 (commit) via 20dde4cc4acf35ba9f5edc76c5271198217994e6 (commit) from 72d4b10bf4abcfc36a9f3bac263ad182b6512088 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f417c15e499745a7cd35fd1c8c5ae79888857199 Author: Kyle M Hall Date: Tue May 28 07:54:58 2019 -0400 Bug 22982: (QA follow-up) Add behavior to Koha::Account::Line::apply and unit test Signed-off-by: Nadine Pierre Signed-off-by: Martin Renvoize commit 986629b29f8651a99f877444c69dec2838f513d8 Author: Kyle M Hall Date: Thu May 23 14:14:06 2019 -0400 Bug 22982: Add unit tests Signed-off-by: Liz Rea Signed-off-by: Nadine Pierre Signed-off-by: Martin Renvoize commit 20dde4cc4acf35ba9f5edc76c5271198217994e6 Author: Kyle M Hall Date: Thu May 23 11:27:23 2019 -0400 Bug 22982: Paying lost fee does not always remove lost item from checkouts Depending on how a lost fee is paid, it may or may not be removed from the patrons current checkouts. The current expected behavior is for the lost item to be removed from the patrons checkouts when the lost fee is paid in full. This is due to the subroutine for handling of lost fees being included in the 'pay specific lines' code but not in the 'pay by amount' code. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account.t Signed-off-by: Liz Rea Signed-off-by: Nadine Pierre Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Account.pm | 8 +- Koha/Account/Line.pm | 10 ++ t/db_dependent/Koha/Account.t | 227 ++++++++++++++++++++++++++++++++++++++++- 3 files changed, 243 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 6 16:52:43 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Jun 2019 14:52:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-38-gc3346b5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c3346b50bd00778c2e8364b40a7dd7a891c713b4 (commit) via 117061d88420231d709515f4702446e60f7de4b6 (commit) via 9713e13893c9f2d2b12cea29b23b72a25170462e (commit) via 8592474c3fe6af408c7265a50bd1776a76942397 (commit) via 703ec1e2f24345146c997398b9c0cc492016455d (commit) via 3f93acbc6c0344151da794a73476de1f91000502 (commit) via e825751cda6a920aa2455908970a3f8e85c1a4e8 (commit) from f417c15e499745a7cd35fd1c8c5ae79888857199 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c3346b50bd00778c2e8364b40a7dd7a891c713b4 Author: Martin Renvoize Date: Thu Jun 6 15:32:14 2019 +0100 Bug 10215: DBRev 19.06.00.002 Signed-off-by: Martin Renvoize commit 117061d88420231d709515f4702446e60f7de4b6 Author: Martin Renvoize Date: Wed Jun 5 12:58:20 2019 +0100 Bug 10215: (follow-up) Fix the failing test We now handle NULL values at the database end and do not expect empty strings. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 9713e13893c9f2d2b12cea29b23b72a25170462e Author: Martin Renvoize Date: Wed Jun 5 12:54:30 2019 +0100 Bug 10215: (follow-up) Correct existing data This patch adds the correction of data ('' => NULL) during the DB update. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 8592474c3fe6af408c7265a50bd1776a76942397 Author: Kyle M Hall Date: Tue May 7 12:49:03 2013 -0400 Bug 10215: Increase the size of opacnote and librariannote for table subscriptionhistory We have librarians that are regularly hitting the maximum number of characters for the note fields in subscription history. They would like to be able to store at least 1000 characters here. Converting the varchar(150) to text should do it. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add public and private notes to a subscription history entry where each note is greater than 150 characters. 4) Save and view the notes, the notes should not be truncated. Rescued-by: Martin Renvoize Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 703ec1e2f24345146c997398b9c0cc492016455d Author: Jonathan Druart Date: Thu May 30 09:36:31 2019 -0500 Bug 22919: Fix insert of authorities_normal_marc21.sql with strict SQL modes If strict SQL modes are set, the insert of authorities_normal_marc21.sql will fail. Test plan: DELETE FROM auth_subfield_structure; DELETE FROM auth_tag_structure; DELETE FROM auth_types; SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'; source /home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql You should not see any errors. Without this patch you see: ERROR 1366 (22007) at line 280 in file: '/home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql': Incorrect integer value: ' for column 'linkid' at row 148 ' Signed-off-by: nabila Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 3f93acbc6c0344151da794a73476de1f91000502 Author: Katrin Fischer Date: Sun Jun 2 08:58:50 2019 +0000 Bug 22958: Fix help link on the SMS providers page The help link on the SMS providers page didn't link to the according chapter in the manual. To test: - Enter Email in SMSSendDriver system preference to make the configuration page appear - Go to Administration > SMS cellular providers - Click on the help link - Verify it leads to the manual start page - Apply patch - Repeat and verify the link now leads to the correct section in the manual Signed-off-by: Liz Rea Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit e825751cda6a920aa2455908970a3f8e85c1a4e8 Author: Jonathan Druart Date: Fri May 31 11:41:22 2019 -0500 Bug 23027: Make Suggestions.t pass even if no biblio in DB There are biblionumbers 1 and 2 hardcoded Test plan: MariaDB [koha_kohadev]> delete from biblioitems; delete from items; delete from biblio; % prove t/db_dependent/Suggestions.t Must return green with this patch applied Signed-off-by: Liz Rea Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 1 + Koha.pm | 2 +- Koha/Manual.pm | 1 + .../marc21/mandatory/authorities_normal_marc21.sql | 2 +- installer/data/mysql/kohastructure.sql | 4 ++-- installer/data/mysql/updatedatabase.pl | 14 ++++++++++++++ t/db_dependent/Serials.t | 4 ++-- t/db_dependent/Suggestions.t | 18 +++++++++--------- 8 files changed, 31 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 6 17:30:19 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Jun 2019 15:30:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-47-g33660ea Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 33660ea283a007b668d9f230994be1869b0ac629 (commit) via a268487d4e52fea538b9bbe6d2f0efad2fda50a1 (commit) via b97acab4d368ccbced7d99b21fdf371f8c51f1ba (commit) via 8c3890462750eb2b874da8afbd0e4899b11e3c42 (commit) via f3358e97c8a1f9edf1c4de6dea46f70366237699 (commit) via 65de22a6ef928bd6074e9a4d6a1e1351d0e1de9b (commit) via c23276324c4da519130f35cb7c471402965b3e1b (commit) via 6d046c2e3d301a7e1d37b376b49a0db516e67bda (commit) via e4d1318550af78f76b7a43757bbdc4c5bddb4d5f (commit) from c3346b50bd00778c2e8364b40a7dd7a891c713b4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 33660ea283a007b668d9f230994be1869b0ac629 Author: Martin Renvoize Date: Thu Jun 6 16:07:39 2019 +0100 Bug 22867: DBRev 19.06.00.003 Signed-off-by: Martin Renvoize commit a268487d4e52fea538b9bbe6d2f0efad2fda50a1 Author: Jonathan Druart Date: Mon May 13 08:39:05 2019 -0500 Bug 22867: Update the syspref's description in sysprefs.sql Signed-off-by: Martin Renvoize commit b97acab4d368ccbced7d99b21fdf371f8c51f1ba Author: Marcel de Rooy Date: Fri May 10 08:49:26 2019 +0000 Bug 22867: (QA follow-up) Build items.json for UniqueItemFields Adding items.json, built from latest kohastructure.sql. Control UniqueItemFields with this source file. And add StatisticsFields. Test plan: Go to Preferences, play with UniqueItemFields. Adjust StatisticsFields and look at patron record, statistics tab. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 8c3890462750eb2b874da8afbd0e4899b11e3c42 Author: Owen Leonard Date: Wed May 8 13:21:24 2019 +0000 Bug 22867: UniqueItemFields preference value should be pipe-delimited This patch updates the UniqueItemFields system preference so that it contains pipe-delimited data instead of space-delimited data. This makes it consistent with other system preferences which contain lists of database column names, and enables the selection process provided by Bug 22844. This patch includes a database update to convert space-delimited values in UniqueItemFields to pipe-delimited. To test you should have two or more space-delimited items table columns saved in the UniqueItemFields system preference. Apply the patch and run the database update. - Go to Administration -> System preferences -> Acquisitions and confirm that the value of UniqueItemFields is now pipe-delimited. - Set the AcqCreateItem system preference to "placing an order." - Go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a new (empty) record. - Fill out the item add form, including those fields specified in UniqueItemFields. - Click the "Add multiple items" button and specify one or more items. - Click "Add" and verify that in the table of items added, the fields specified in UniqueItemFields were not duplicated. - Edit one or more of those items and add duplicate values to one or more of the fields specified in UniqueItemFields. - Click "Save" and confirm that you are presented with an error highlighting the duplicated data. - Correct the data to remove the duplicates and click "Save" again. It should save correctly. - Set the AcqCreateItem system preference to "receiving an order." - Repeat the test above during the process of receiving an order. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit f3358e97c8a1f9edf1c4de6dea46f70366237699 Author: Pasi Kallinen Date: Wed May 29 09:20:43 2019 +0300 Bug 22910: Do not copy unique patron attributes to duplicated patron When creating a new patron by duplicating another, all of the patron attributes are also copied into the form. Some of those value may be unique, so don't copy those. 1) Create patron attribute types, one with "unique identifier", one without. 2) Create or a patron so it has values in both of those attributes. 3) Duplicate the patron 4) The edit form should retain the values from the "original" patron. 5) Apply patch. 6) Duplicate the patron - this time the attributes with unique values are cleared. Signed-off-by: Pasi Kallinen Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 65de22a6ef928bd6074e9a4d6a1e1351d0e1de9b Author: Katrin Fischer Date: Thu Sep 27 19:49:27 2018 +0200 Bug 20986: (follow-up) Avoid br tags, but allow for line breaks to be added easily with CSS This patch removes the br tags from the XSLT in favor of some more spans and classes. This will allow to add the line breaks with one line of CSS: span.holdings_note_data { display:block; } Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit c23276324c4da519130f35cb7c471402965b3e1b Author: Joy Nelson Date: Fri Jun 22 15:22:40 2018 -0700 Bug 20986: Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. Signed-off-by: Ed Veal Signed-off-by: Katrin Fischer Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 6d046c2e3d301a7e1d37b376b49a0db516e67bda Author: Liz Rea Date: Thu May 9 02:02:55 2019 +0000 Bug 8558: (QA follow-up) a little more text clean up You can take or leave it, honestly, I just thought we could be a little more explicit about what we were overwriting. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit e4d1318550af78f76b7a43757bbdc4c5bddb4d5f Author: Aleisha Amohia Date: Mon Apr 29 03:30:30 2019 +0000 Bug 8558: Improve confirmation message for importing frameworks This patch updates the confirmation message from: "Do you really want to import the framework fields and subfields? This will overwrite the current configuration. For safety reasons please use the export option to make a backup" to: "Are you sure you want to import the [% frameworkcode %] framework structure? This will overwrite the current configuration. For safety reasons, it is recommended to use the export option to make a backup first." To test: 1) Go to Administration -> MARC bibliographic frameworks 2) Export one of the frameworks 3) Create a new test framework 4) Import the new test framework structure using the exported file 5) Upon clicking Confirm, confirm the message is improved and makes sense. Sponsored-by: Catalyst IT Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 9 +++- .../prog/en/modules/admin/biblio_framework.tt | 3 +- .../en/modules/admin/preferences/acquisitions.pref | 3 +- .../prog/en/modules/admin/preferences/items.json | 47 ++++++++++++++++++++ .../prog/en/modules/admin/preferences/patrons.pref | 5 ++- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 41 ++++++++++++++--- koha-tmpl/intranet-tmpl/prog/js/additem.js | 4 +- .../intranet-tmpl/prog/js/biblio_framework.js | 3 +- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 40 ++++++++++++++--- members/memberentry.pl | 4 +- 12 files changed, 141 insertions(+), 22 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/items.json hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 6 18:49:20 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Jun 2019 16:49:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-48-ge90086f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e90086fe78dcf6d2aad590f30cb81f255f4104d7 (commit) from 33660ea283a007b668d9f230994be1869b0ac629 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e90086fe78dcf6d2aad590f30cb81f255f4104d7 Author: Martin Renvoize Date: Thu Jun 6 17:27:42 2019 +0100 Revert "Bug 22867: (QA follow-up) Build items.json for UniqueItemFields" This reverts commit b97acab4d368ccbced7d99b21fdf371f8c51f1ba which should have really been attached to bug 22844 and the dependancies reversed. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../en/modules/admin/preferences/acquisitions.pref | 3 +- .../prog/en/modules/admin/preferences/items.json | 47 -------------------- .../prog/en/modules/admin/preferences/patrons.pref | 5 +-- 3 files changed, 3 insertions(+), 52 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/items.json hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 7 10:48:10 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 07 Jun 2019 08:48:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-49-g8427b68 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8427b684148944b9306fd4786c75c53527037024 (commit) from e90086fe78dcf6d2aad590f30cb81f255f4104d7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8427b684148944b9306fd4786c75c53527037024 Author: Alex Arnaud Date: Fri Jun 7 10:18:05 2019 +0200 Bug 22915: fix Mana URL in etc/koha-conf.xml Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: etc/koha-conf.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 10 17:03:26 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Jun 2019 15:03:26 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.00-16-g67bddf7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 67bddf78e245e5ef2dfe1c3040e5c820124a3b99 (commit) via 6b44e314577ade8b92ae330668510ae94f2f6469 (commit) via 93cc499ed786630840845df21b4f52a2da4e6ea8 (commit) via 6dd6ce120ad28f16fcddfb8acc94a019a7c34509 (commit) via 483f94e7202bfa14ed8e910e0f2b4db229b8d8c5 (commit) via 327977abd6fe95ff8ee8f743d690e3efc45501d5 (commit) via f59aff442748b447caab068743f011f94ff3ad29 (commit) via 43e16861da807876e2b041c6a5bc78fdebefbbee (commit) via 50eaced45a52615d4125726e146552ac54ac2594 (commit) via 3b805b8b81af5faf31e0f71472cce541961fcba0 (commit) via 76074180ead15621b63ac84cedc43f3df151ca1c (commit) via b551b502f768317ff01323ba24c4e9bee0a3b74f (commit) via 39bb183f5387fedc01428e08d8633bf6bf666c81 (commit) via f9f8c1e3831b87dd2747605008e798f9d4d09f7f (commit) via f2bbefc4038598137d5a3eab60d9ffaa5142b0ef (commit) via 9cf37c375a0dacf63baff16b5211b8dfac493691 (commit) from 1b5635bebd75c418fdda68036e1e91f857cb1e4d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 67bddf78e245e5ef2dfe1c3040e5c820124a3b99 Author: Jonathan Druart Date: Wed Sep 12 09:38:39 2018 -0700 Bug 19457: Handle 'PREVISSUE' return by CanBookBeIssued from SIP (CheckPrevCheckout) If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer To test: - Do not apply this patch - Set CheckPrevCheckout to "Do", or "Unless overridden, do" Verify the SIP server is blocking checkouts with this setting set - Apply this patch - Note that the checkout is now allowed, with a screen message telling the borrower they've issued the item before. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit b40e58343ef65aabe0a575a0b3f842b5e22a3600) Signed-off-by: Fridolin Somers commit 6b44e314577ade8b92ae330668510ae94f2f6469 Author: Aleisha Amohia Date: Fri Dec 14 02:05:36 2018 +0000 Bug 11492: (follow-up) Don't pass publisheddatetext param to NewIssue I have removed publisheddatetext as a param from my patch, but only in the places where my patch added it. Any other instance already existed before my patch. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit ac423d5dcf2c7503a8ca78cbafdb94dfc43dfdb6) Signed-off-by: Fridolin Somers commit 93cc499ed786630840845df21b4f52a2da4e6ea8 Author: Aleisha Amohia Date: Fri Dec 7 01:03:42 2018 +0000 Bug 11492: Keep routing notes when receiving next serial This patch ensures the routing notes are carried over when generating the next serial. To test: 1) Create a routing list for a subscription 2) Add a borrower and a note to the routing list 3) Generate the next serial (serials-collection.pl) 4) Edit the routing list to see the notes 5) Note that the notes have disappeared 6) Apply patch 7) Edit the routing list, add a note 8) Generate the next serial 9) Edit the routing list and confirm the note is still there 10) Confirm you are still able to edit serials (serials-edit.pl) and routing notes stay Sponsored-by: Plant and Food Research Limited Signed-off-by: Nazl? ?etin Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 2c25016a8e17b52e23c3d9806264e141b6426254) Signed-off-by: Fridolin Somers commit 6dd6ce120ad28f16fcddfb8acc94a019a7c34509 Author: Hayley Mapley Date: Thu Mar 21 14:39:59 2019 +1300 Bug 22099: Fixed ILL toolbar to say Refresh when displaying requests On the ILL requests page that lists all requests, the List Request button is displayed as part of the ILL toolbar. This patch fixes this by instead changing the wording of the button to Refresh when on the main page. Test plan: 1) More -> ILL Requests, note that the List Requests button displays while all the requests are already displayed 2) Apply the patch and restart things 3) More -> ILL Requests, note that the button now says Refresh, and clicking it refreshes the page 4) Check that on all the other functions of the ILLs the button says List Requests 5) Sign off! Sponsored-by: Catalyst IT Signed-off-by: Magnus Enger Small conflict resolved. Works as advertised. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 66877b780a775daf135ef1137364d76f67166e61) Signed-off-by: Fridolin Somers commit 483f94e7202bfa14ed8e910e0f2b4db229b8d8c5 Author: Owen Leonard Date: Tue May 21 17:14:36 2019 +0000 Bug 22955: Markup error in OPAC lists template This patch makes a minor correction to the template for OPAC lists. This correction fixes an error returned by the HTML validator by adding an empty "alt" attribute to an image tag. To reproduce the problem you should have at least one list available in the OPAC with one or more items on it. View the contents of that list in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "An img element must have an alt attribute, except under certain conditions." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Click "Download list." A modal window should appear with a "Loading" message, followed by a form for selecting a download format. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit d26991cf4cc298fc3900b8133ff9b40cd061fb96) Signed-off-by: Fridolin Somers commit 327977abd6fe95ff8ee8f743d690e3efc45501d5 Author: Owen Leonard Date: Tue May 21 13:19:17 2019 +0000 Bug 22947: Markup error in OPAC preferences file This patch corrects a markup error in the OPAC .pref file which can cause display problems. The patch also corrects a validator warning by changing at to a . To reproduce the problem, go to Administration -> Global system preferences -> OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Unclosed element code." - "The tt element is obsolete. Use CSS instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the display. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 87cbb27826a9d03a424e8c944293669157924a01) Signed-off-by: Fridolin Somers commit f59aff442748b447caab068743f011f94ff3ad29 Author: Fridolin Somers Date: Mon Jun 10 16:01:28 2019 +0200 Bug 22950: Compiled CSS Signed-off-by: Fridolin Somers commit 43e16861da807876e2b041c6a5bc78fdebefbbee Author: Owen Leonard Date: Tue May 21 15:04:33 2019 +0000 Bug 22950: Markup error in OPAC recent comment template This patch makes minor corrections to the template for the OPAC's recent comments view. These corrections fix errors returned by the HTML validator. The patch moves some inline CSS into a class in the global OPAC CSS. Some minor reindentation has also been done, so use diff with the '-w' flag. To reproduce the problem you should have the 'reviewson' system preference turned on, and your system should have one or more approved comments. View the "Recent comments" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "CSS: font-color: Property font-color doesn't exist." To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 457000102e7e2228c6bd834283a9e58f32bb2104) Signed-off-by: Fridolin Somers commit 50eaced45a52615d4125726e146552ac54ac2594 Author: Fridolin Somers Date: Mon Jun 10 15:50:57 2019 +0200 Bug 22906: Compiled CSS commit 3b805b8b81af5faf31e0f71472cce541961fcba0 Author: Owen Leonard Date: Tue May 14 13:10:32 2019 +0000 Bug 22906: Minor corrections to plugins home page This patch makes a few minor markup improvements to the plugins home page and corrects some CSS introduced by Bug 22053 which was having unintended consequences elsewhere. To test, apply the patch and rebuild the staff client CSS. - You should have one or more plugins installed. - Go to Administration -> Manage plugins. - The "badges" for disabled and enabled should look correct. - Go to Tools -> Staged MARC management and click on an batch. - In the information about the batch, the labels should be bold. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit e9294c3cc20584adebb6d38451ebccce86a8f1aa) Signed-off-by: Fridolin Somers commit 76074180ead15621b63ac84cedc43f3df151ca1c Author: Martin Renvoize Date: Thu May 9 16:34:09 2019 +0100 Bug 22877: (QA follow-up) Clarify intent of tests and remove one. This patch embelishes the existing comments slightly and removes a test which had a FIXME, but was in fact just a duplicate of the test directly above it. I beleive it became a duplicate after the subroutine signature changed at some point recently. I also move the bug 22877 specific test into a subtest. Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit fa411c2f80d3464c9205f49fc31de492bc265c57) Signed-off-by: Fridolin Somers commit b551b502f768317ff01323ba24c4e9bee0a3b74f Author: Martin Renvoize Date: Thu May 9 16:00:59 2019 +0100 Bug 22877: (follow-up) Fix test plan count Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 55289562468f77e6f6a2c1671d8a3ec472a50f99) Signed-off-by: Fridolin Somers commit 39bb183f5387fedc01428e08d8633bf6bf666c81 Author: Martin Renvoize Date: Thu May 9 15:53:56 2019 +0100 Bug 22877: Prevent double overdue processing for lost and returned Test plan: 1 - Issue an item to a patron with a backdated due date 2 - Run fines.pl - note you generate a fine for the patron 3 - Run longoverdue.pl - make sure MarkLostItemsAsReturned is turned off and to charge 4 - Confirm the patron has a lost fee and an overdue 5 - Return the item 6 - With patch applied, patron should now have 1 overdue fine and 1 lost fine Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit d1b6e320860060ffe35e7df7f3df1b8c10517a73) Signed-off-by: Fridolin Somers commit f9f8c1e3831b87dd2747605008e798f9d4d09f7f Author: Nick Clemens Date: Thu May 9 12:32:38 2019 +0000 Bug 22877: Unit test to highlight problem Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 01c4ee5703af156e2bb2057da83e156f9090be40) Signed-off-by: Fridolin Somers commit f2bbefc4038598137d5a3eab60d9ffaa5142b0ef Author: Nightly Build Bot Date: Tue Jun 4 14:44:58 2019 +0200 Bug 17108- Automatic debian/control updates (stable/19.05.x) commit 9cf37c375a0dacf63baff16b5211b8dfac493691 Author: Owen Leonard Date: Tue May 21 16:29:06 2019 +0000 Bug 22953: Markup warning in OPAC user summary template This patch makes a minor markup change to the OPAC user summary template (opac-user.tt) in order to quiet warnings from the HTML validator. The obsolete name attribute on two links is removed in favor of class names. The JavaScript has been modified accordingly. To reproduce the problem you should have the AllowCheckoutNotes system preference enabled. Log in to the OPAC as a user who has checkouts and view the "your summary" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses this warning: - "The name attribute is obsolete. Consider putting an id attribute on the nearest container instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the process of adding or editing an note on a checkout. It should work correctly. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit a4844b85eed809c20053adb7862c21601d6cf148) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- C4/SIP/ILS/Transaction/Checkout.pm | 3 + C4/Serials.pm | 18 +++--- debian/control | 4 +- .../intranet-tmpl/prog/css/src/staff-global.scss | 18 ++++-- koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../intranet-tmpl/prog/en/includes/ill-toolbar.inc | 12 +++- .../prog/en/modules/admin/preferences/opac.pref | 4 +- .../prog/en/modules/plugins/plugins-home.tt | 14 ++--- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 5 ++ .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- .../bootstrap/en/modules/opac-showreviews.tt | 41 +++++++------ .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 8 +-- serials/serials-collection.pl | 5 +- serials/serials-edit.pl | 3 +- t/db_dependent/Circulation.t | 63 ++++++++++++++++---- t/db_dependent/Serials.t | 2 +- 18 files changed, 137 insertions(+), 71 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 10 17:26:07 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Jun 2019 15:26:07 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.00-25-gfeb8f84 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via feb8f84ef7a92038a544aaa2f44584ee848451fd (commit) via ecfe5811c8b49135b4e0ddee1db5e24d6a854940 (commit) via 1baddd190fe1ed72e66298a6b01394e86e58d0fe (commit) via a4dea8c8b802bf5e1b4985762885565ad7c49e75 (commit) via cb081b9fdcf2a5d05feeae3253b0dab7690daf77 (commit) via be00559e0c3db37fd776946a8d83de1a58db7a9e (commit) via 7d82e8104b2a23e7329ac72d5867306f0004d9bf (commit) via 412578e2d65e4fd797dc743b3de2fb6544b14022 (commit) via c868ccc360189d0b5ea5b7c096ba325a304070d0 (commit) from 67bddf78e245e5ef2dfe1c3040e5c820124a3b99 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit feb8f84ef7a92038a544aaa2f44584ee848451fd Author: Owen Leonard Date: Tue May 21 16:59:38 2019 +0000 Bug 22954: Minor markup error in OPAC messaging template This patch corrects a minor error in opac-messaging.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have the EnhancedMessagingPreferencesOPAC system preference enabled. Log in to the OPAC and go to the "your messaging" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses this error: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit d5a8a424203cd426f7d0bd64597a6ac95536ef9c) Signed-off-by: Fridolin Somers commit ecfe5811c8b49135b4e0ddee1db5e24d6a854940 Author: Owen Leonard Date: Tue May 21 16:00:18 2019 +0000 Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit e72a9c91485c6e68819f3bb76d326f0a1a84dcd9) Signed-off-by: Fridolin Somers commit 1baddd190fe1ed72e66298a6b01394e86e58d0fe Author: Owen Leonard Date: Tue May 21 14:27:40 2019 +0000 Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit a3da6d6825f686099d8e23a1abff061071d679ad) Signed-off-by: Fridolin Somers commit a4dea8c8b802bf5e1b4985762885565ad7c49e75 Author: Martin Renvoize Date: Tue Jun 4 10:06:46 2019 +0100 Bug 22960: DBRev 19.05.00.001 Signed-off-by: Martin Renvoize (cherry picked from commit 4ae854242839ebe9871b65fe0add2241eb4ae0b7) Signed-off-by: Fridolin Somers commit cb081b9fdcf2a5d05feeae3253b0dab7690daf77 Author: Martin Renvoize Date: Tue Jun 4 09:48:59 2019 +0100 Bug 22960: (RM follow-up) Correct a further typo "This a list" changed to "This is a list" Signed-off-by: Martin Renvoize (cherry picked from commit f6f86a79d623ac478e2636e2d0cc2272006fe5f0) Signed-off-by: Fridolin Somers commit be00559e0c3db37fd776946a8d83de1a58db7a9e Author: Katrin Fischer Date: Sun Jun 2 09:18:00 2019 +0000 Bug 22960: (QA follow-up) Fix another tiny typo This only seems to appear in the .pref file: ...pairs. the => ... pairs. The Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 76a64f8046af820b8be57fbc8d65483259a63f6c) Signed-off-by: Fridolin Somers commit 7d82e8104b2a23e7329ac72d5867306f0004d9bf Author: Katrin Fischer Date: Mon May 27 20:34:33 2019 +0000 Bug 22960: Fix the same typo on db level for existing and new installations Seriously trying to kill the typo everywhere: - Check your DB with a report: select * from systempreferences where variable = 'UpdateItemLocationOnCheckin'; - Verify the typo in the explanation column: locaiton - Apply patch and run database update - Verify the typo is fixed Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize (cherry picked from commit 2b0347084ce8daa0a11ff4bdfd2e9f8442e65ffb) Signed-off-by: Fridolin Somers commit 412578e2d65e4fd797dc743b3de2fb6544b14022 Author: Owen Leonard Date: Wed May 22 12:23:47 2019 +0000 Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference This patch corrects a typo in circulation.pref in the description of the UpdateItemLocationOnCheckin preference. To see the problem, go to Administration -> System preferences -> Circulation and look at the description for the UpdateItemLocationOnCheckin preference: "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned." Note the misspelling "locaiton." To test, apply the patch and refresh the circulation preferences page. The typo should be fixed. Signed-off-by: Bin Wen Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize (cherry picked from commit d5520510602c123d1ea8d7dc9a9d874995d200c3) Signed-off-by: Fridolin Somers commit c868ccc360189d0b5ea5b7c096ba325a304070d0 Author: Marcel de Rooy Date: Wed May 29 13:46:15 2019 +0000 Bug 23006: Cannot use inventory with barcodes containing special chars If a barcode contains special characters like $, the regex in inventory does no longer work. This fix (as suggested by Jonathan) replaces the regex by a eq compare. Test plan: Pick one barcode and add a $ somewhere in the middle, say 123$456. Include this barcode in a barcode file for inventory. Run inventory on that file and verify that barcode was read and datelastseen was updated. The barcode should not be reported as missing (not scanned). Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit 851d41ab6b9ec28901086d6a6ce15b3fd589182a) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 12 +++++++++++- .../prog/en/modules/admin/preferences/circulation.pref | 4 ++-- .../bootstrap/en/includes/opac-detail-sidebar.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 8 +++++--- tools/inventory.pl | 2 +- 8 files changed, 23 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 10 23:28:29 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Jun 2019 21:28:29 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-1-ge8e83db Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via e8e83db8587fc484f149d576933c0a61dd1c4354 (commit) from 63a2fe541a4ef87378df55ab3dde5a3688159854 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e8e83db8587fc484f149d576933c0a61dd1c4354 Author: Owen Leonard Date: Tue May 21 16:29:06 2019 +0000 Bug 22953: Markup warning in OPAC user summary template This patch makes a minor markup change to the OPAC user summary template (opac-user.tt) in order to quiet warnings from the HTML validator. The obsolete name attribute on two links is removed in favor of class names. The JavaScript has been modified accordingly. To reproduce the problem you should have the AllowCheckoutNotes system preference enabled. Log in to the OPAC as a user who has checkouts and view the "your summary" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses this warning: - "The name attribute is obsolete. Consider putting an id attribute on the nearest container instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the process of adding or editing an note on a checkout. It should work correctly. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit a4844b85eed809c20053adb7862c21601d6cf148) Signed-off-by: Fridolin Somers (cherry picked from commit 9cf37c375a0dacf63baff16b5211b8dfac493691) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 09:57:44 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 07:57:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-52-g2e8a6a4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2e8a6a4b097f7ed7bb33efe819693752abba33cb (commit) via 82dcb5cf546c881af0003c272d9326e12fb5f1ce (commit) via 88cfa94ea4fbbc4c264695bc77a1c72cee0aefda (commit) from 8427b684148944b9306fd4786c75c53527037024 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2e8a6a4b097f7ed7bb33efe819693752abba33cb Author: Nick Clemens Date: Wed Jun 5 13:55:10 2019 +0000 Bug 23053: Add phrase index to authority Local-Number To test: 1 - Define a matching rule for authorities on field 001 index Local-Number 2 - In koha-conf.xml raise the zebra_loglevels none,fatal,warn,request,info 3 - Export some authorities using the tools->export data 4 - Import those authorities 5 - Note no matches found 6 - View the zebra output log, you should see lots of error 114 7 - Apply patch 8 - Copy the indexdefs files to the installed versions 9 - Reapply matchign rules to staged files 10 - Matches should now be found 11 - Logs should not have errors Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 82dcb5cf546c881af0003c272d9326e12fb5f1ce Author: Owen Leonard Date: Fri Jun 7 12:10:01 2019 +0000 Bug 23076: Include OpacUserJS on OPAC maintenance page This patch coverts the syntax for embedding OpacUserJS in the global include file so that it uses 'Koha.Preference' syntax. This makes the data available in templates, like the OPAC maintenance page, to which the preference data has not been explicitly provided. To reproduce: Add some JavaScript to the OPACUserJS system preference which will let you know it's working. For instance: alert("OPACUserJS!"); Turn on the OPAC maintenance message using the OpacMaintenance system preference. Navigate to the OPAC. You should see the system maintenance page but you should not see an alert. To test, apply the patch and reload the OPAC page. Your alert should show. Signed-off-by: Maryse Simard Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 88cfa94ea4fbbc4c264695bc77a1c72cee0aefda Author: Pasi Kallinen Date: Fri Jun 7 09:44:32 2019 +0300 Bug 23074: Holds table sort does not understand dateformat Holds table does not sort correctly when the dateformat is eg. DD.MM.YYYY. Test plan: 1) Create multiple holds for a patron with different hold creation and expiration dates, with different years, months and days. 2) Change the dateformat to DD.MM.YYYY. 3) Resort the holds table (in circ/circulation or members/moremember) by the hold date or expiration date. The table sorts the date by the day number. 4) Apply patch 5) Redo 3 - the table now sorts correctly. Signed-off-by: Pasi Kallinen Signed-off-by: Owen Leonard Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../marc_defs/marc21/authorities/authority-koha-indexdefs.xml | 1 + .../marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl | 2 +- koha-tmpl/intranet-tmpl/prog/js/holds.js | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 6 ++---- 4 files changed, 6 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 11:43:56 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 09:43:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-55-g39e4c6c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 39e4c6c5d791853985773e4032357372f77d7587 (commit) via 60e24be115539daedc4172099eec9cc5dd5bc813 (commit) via e702ff89f77e50b1bcef1cdc1548627957251df0 (commit) from 2e8a6a4b097f7ed7bb33efe819693752abba33cb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 39e4c6c5d791853985773e4032357372f77d7587 Author: Katrin Fischer Date: Mon Mar 11 08:33:13 2019 +0000 Bug 13094: Make it easy to hide 'Cancel all' button on holds over report This patch makes some small modifications to the 'Holds awaiting pickup' report: - Fixes typo sypref - Fixes 'Home branch' to 'Home library' - Adds a span to easily hide the cancel all button with CSS To test: - Make sure you have a hold appearing on the awaiting pickup list second tab: Holds waiting over... - Verify the 'cancel all' button on top shows - Verify syspref and Home library changes mentioned above - Add #holdsover-cancel-all { display:none; } to IntrentUserCSS - Verify that the button and the text have vanished Note: If the text doesn't display next to the button, try toggling the TransferWhenCancelAllWaitingHolds system preference. Signed-off-by: Liz Rea Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize commit 60e24be115539daedc4172099eec9cc5dd5bc813 Author: Kyle M Hall Date: Mon Mar 25 13:55:43 2019 -0400 Bug 18344: Add unit tests Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit e702ff89f77e50b1bcef1cdc1548627957251df0 Author: Kyle M Hall Date: Tue Mar 28 11:05:28 2017 +0000 Bug 18344: Allow overdue fines cap at replacement price, and cap by amount to work together There is no reason that a library shouldn't be able to use the monetary fines cap and the replacement price cap at the same time. The code is written in such a way that they already work harmoniously. We have librarians who wish to use both so they can set a high cap of $10.00 but also use the replacement price cap so that a $20.00 book would only get a fine of $10.00, but a $5.00 paperback will only get a fine of $5.00 Test Plan: 1) Apply this patch 2) Create a rule with a fines cap of $10, *and* a cap at replacement price, and a daily fine of $1 3) Create two items, one with a replacement price of $5 and one with a replacement price of $15 4) Check out these items to a patron, backdate the checkouts so they are already overdue by a couple months 5) Check the items in ( make sure calc fine at checkin is enabled for you ) 6) Note the one item has a fine of $5 and the other has a fine of $10! Signed-off-by: David Kuhn Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/waiting_holds.inc | 2 +- .../prog/en/modules/admin/smart-rules.tt | 3 -- .../prog/en/modules/circ/waitingreserves.tt | 37 ++++++++-------- t/db_dependent/Circulation/CalcFine.t | 46 +++++++++++++++++++- 4 files changed, 65 insertions(+), 23 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 16:12:17 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 14:12:17 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.00-34-ge697441 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via e69744172a33165758562c6c786a1135361c7509 (commit) via 203ae6e8ecf2606922490fe0433e5eccfc8d95c5 (commit) via 1d27e1b4163573f314ea153fc091298229f15e80 (commit) via e09c4a2cb1cc37ef167a952231a6103dec150c68 (commit) via dfc86527ab0f258dd4b6c2c07b24dd890c70681b (commit) via c4f81ea8f9d165a1cdfa1e5f4a80983f480befc7 (commit) via 997ad5043d25e8c32508ba655319cb4836126f80 (commit) via 75da739b1bf3bdb22f30e1e41da65c7a713c8036 (commit) via a61323998313092385db7e94f177068463fca8ec (commit) from feb8f84ef7a92038a544aaa2f44584ee848451fd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e69744172a33165758562c6c786a1135361c7509 Author: Jonathan Druart Date: Thu May 30 09:36:31 2019 -0500 Bug 22919: Fix insert of authorities_normal_marc21.sql with strict SQL modes If strict SQL modes are set, the insert of authorities_normal_marc21.sql will fail. Test plan: DELETE FROM auth_subfield_structure; DELETE FROM auth_tag_structure; DELETE FROM auth_types; SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'; source /home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql You should not see any errors. Without this patch you see: ERROR 1366 (22007) at line 280 in file: '/home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql': Incorrect integer value: ' for column 'linkid' at row 148 ' Signed-off-by: nabila Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 703ec1e2f24345146c997398b9c0cc492016455d) Signed-off-by: Fridolin Somers commit 203ae6e8ecf2606922490fe0433e5eccfc8d95c5 Author: Katrin Fischer Date: Sun Jun 2 08:58:50 2019 +0000 Bug 22958: Fix help link on the SMS providers page The help link on the SMS providers page didn't link to the according chapter in the manual. To test: - Enter Email in SMSSendDriver system preference to make the configuration page appear - Go to Administration > SMS cellular providers - Click on the help link - Verify it leads to the manual start page - Apply patch - Repeat and verify the link now leads to the correct section in the manual Signed-off-by: Liz Rea Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize (cherry picked from commit 3f93acbc6c0344151da794a73476de1f91000502) Signed-off-by: Fridolin Somers commit 1d27e1b4163573f314ea153fc091298229f15e80 Author: Jonathan Druart Date: Fri May 31 11:41:22 2019 -0500 Bug 23027: Make Suggestions.t pass even if no biblio in DB There are biblionumbers 1 and 2 hardcoded Test plan: MariaDB [koha_kohadev]> delete from biblioitems; delete from items; delete from biblio; % prove t/db_dependent/Suggestions.t Must return green with this patch applied Signed-off-by: Liz Rea Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize (cherry picked from commit e825751cda6a920aa2455908970a3f8e85c1a4e8) Signed-off-by: Fridolin Somers commit e09c4a2cb1cc37ef167a952231a6103dec150c68 Author: Kyle M Hall Date: Tue May 28 07:54:58 2019 -0400 Bug 22982: (QA follow-up) Add behavior to Koha::Account::Line::apply and unit test Signed-off-by: Nadine Pierre Signed-off-by: Martin Renvoize (cherry picked from commit f417c15e499745a7cd35fd1c8c5ae79888857199) Signed-off-by: Fridolin Somers commit dfc86527ab0f258dd4b6c2c07b24dd890c70681b Author: Kyle M Hall Date: Thu May 23 14:14:06 2019 -0400 Bug 22982: Add unit tests Signed-off-by: Liz Rea Signed-off-by: Nadine Pierre Signed-off-by: Martin Renvoize (cherry picked from commit 986629b29f8651a99f877444c69dec2838f513d8) Signed-off-by: Fridolin Somers commit c4f81ea8f9d165a1cdfa1e5f4a80983f480befc7 Author: Kyle M Hall Date: Thu May 23 11:27:23 2019 -0400 Bug 22982: Paying lost fee does not always remove lost item from checkouts Depending on how a lost fee is paid, it may or may not be removed from the patrons current checkouts. The current expected behavior is for the lost item to be removed from the patrons checkouts when the lost fee is paid in full. This is due to the subroutine for handling of lost fees being included in the 'pay specific lines' code but not in the 'pay by amount' code. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account.t Signed-off-by: Liz Rea Signed-off-by: Nadine Pierre Signed-off-by: Martin Renvoize (cherry picked from commit 20dde4cc4acf35ba9f5edc76c5271198217994e6) Signed-off-by: Fridolin Somers commit 997ad5043d25e8c32508ba655319cb4836126f80 Author: Martin Renvoize Date: Mon Jun 3 17:32:10 2019 +0100 Bug 23037: Add Henry Bolshaw to contributors We missed Henry from the release notes and about page.. sorry Henry! Signed-off-by: Magnus Enger Not really tested, just had a look and checked the changes look sane. Signed-off-by: Martin Renvoize (cherry picked from commit 72d4b10bf4abcfc36a9f3bac263ad182b6512088) Signed-off-by: Fridolin Somers commit 75da739b1bf3bdb22f30e1e41da65c7a713c8036 Author: Nazl? ?etin Date: Tue Nov 27 15:24:38 2018 +0000 Bug 21887: (For OPAC) 856 link problem in XSLT result lists and detail page Signed-off-by: Liz Rea Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize (cherry picked from commit 9a58871503caa1b48e4e5c3cc0f565fa583f3e9d) Signed-off-by: Fridolin Somers commit a61323998313092385db7e94f177068463fca8ec Author: Nazl? ?etin Date: Tue Nov 27 14:15:33 2018 +0000 Bug 21887: 856 link problem in XSLT result lists and detail page Signed-off-by: Nazl? ?etin Signed-off-by: Liz Rea Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize (cherry picked from commit 4903cee9e937c970c6d3d15fd78d82189d8705eb) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha/Account.pm | 8 +- Koha/Account/Line.pm | 10 + Koha/Manual.pm | 1 + docs/contributors.yaml | 3 + docs/history.txt | 1 + .../marc21/mandatory/authorities_normal_marc21.sql | 2 +- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 75 ++++--- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 82 ++++--- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 17 +- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 17 +- t/db_dependent/Koha/Account.t | 227 +++++++++++++++++++- t/db_dependent/Suggestions.t | 18 +- 12 files changed, 385 insertions(+), 76 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 17:54:17 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 15:54:17 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.00-49-gff651b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via ff651b84e8d99496bc330c4e8e0925234f30def9 (commit) via 8981df1cf0c2761dc891870aa780716f30d4be1f (commit) via 9ea56e1cd958d225be0ba7e1861804b7ce7e8542 (commit) via 3cd32c995e7fc2caeee3a3eed63b426226524057 (commit) via c6464d55601f98746ac7327141e538484a8842f2 (commit) via 21cff327830a04f51dd568b63013b0a53a725f7a (commit) via 2f9ec9c61fabd7595da594c02a55395564cb2330 (commit) via 2900debc65318237ee95fa6c5dbbbd69c8a7e6c4 (commit) via fb362dfd795080a6bcb547e5bc1d87d18bc7ffdf (commit) via cf681f6682eee0aea6ae647835a628d88fa180b9 (commit) via f8b24adc75ef145b96556893d555de4971b8251d (commit) via a249ed65075958772f28b0fb7f9f0b2755e41f5d (commit) via 5d0f6f8cbb42ac85d6648f1e0d45af359604021f (commit) via 648587b19c7e8ca4a91b9930c7d6c78fbeb2da0f (commit) via c42c44e932133e6df6c3b9ccda30932d2835f5ee (commit) from e69744172a33165758562c6c786a1135361c7509 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ff651b84e8d99496bc330c4e8e0925234f30def9 Author: Katrin Fischer Date: Mon Mar 11 08:33:13 2019 +0000 Bug 13094: Make it easy to hide 'Cancel all' button on holds over report This patch makes some small modifications to the 'Holds awaiting pickup' report: - Fixes typo sypref - Fixes 'Home branch' to 'Home library' - Adds a span to easily hide the cancel all button with CSS To test: - Make sure you have a hold appearing on the awaiting pickup list second tab: Holds waiting over... - Verify the 'cancel all' button on top shows - Verify syspref and Home library changes mentioned above - Add #holdsover-cancel-all { display:none; } to IntrentUserCSS - Verify that the button and the text have vanished Note: If the text doesn't display next to the button, try toggling the TransferWhenCancelAllWaitingHolds system preference. Signed-off-by: Liz Rea Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize (cherry picked from commit 39e4c6c5d791853985773e4032357372f77d7587) Signed-off-by: Fridolin Somers commit 8981df1cf0c2761dc891870aa780716f30d4be1f Author: Kyle M Hall Date: Mon Mar 25 13:55:43 2019 -0400 Bug 18344: Add unit tests Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 60e24be115539daedc4172099eec9cc5dd5bc813) Signed-off-by: Fridolin Somers commit 9ea56e1cd958d225be0ba7e1861804b7ce7e8542 Author: Kyle M Hall Date: Tue Mar 28 11:05:28 2017 +0000 Bug 18344: Allow overdue fines cap at replacement price, and cap by amount to work together There is no reason that a library shouldn't be able to use the monetary fines cap and the replacement price cap at the same time. The code is written in such a way that they already work harmoniously. We have librarians who wish to use both so they can set a high cap of $10.00 but also use the replacement price cap so that a $20.00 book would only get a fine of $10.00, but a $5.00 paperback will only get a fine of $5.00 Test Plan: 1) Apply this patch 2) Create a rule with a fines cap of $10, *and* a cap at replacement price, and a daily fine of $1 3) Create two items, one with a replacement price of $5 and one with a replacement price of $15 4) Check out these items to a patron, backdate the checkouts so they are already overdue by a couple months 5) Check the items in ( make sure calc fine at checkin is enabled for you ) 6) Note the one item has a fine of $5 and the other has a fine of $10! Signed-off-by: David Kuhn Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit e702ff89f77e50b1bcef1cdc1548627957251df0) Signed-off-by: Fridolin Somers commit 3cd32c995e7fc2caeee3a3eed63b426226524057 Author: Nick Clemens Date: Wed Jun 5 13:55:10 2019 +0000 Bug 23053: Add phrase index to authority Local-Number To test: 1 - Define a matching rule for authorities on field 001 index Local-Number 2 - In koha-conf.xml raise the zebra_loglevels none,fatal,warn,request,info 3 - Export some authorities using the tools->export data 4 - Import those authorities 5 - Note no matches found 6 - View the zebra output log, you should see lots of error 114 7 - Apply patch 8 - Copy the indexdefs files to the installed versions 9 - Reapply matchign rules to staged files 10 - Matches should now be found 11 - Logs should not have errors Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 2e8a6a4b097f7ed7bb33efe819693752abba33cb) Signed-off-by: Fridolin Somers commit c6464d55601f98746ac7327141e538484a8842f2 Author: Owen Leonard Date: Fri Jun 7 12:10:01 2019 +0000 Bug 23076: Include OpacUserJS on OPAC maintenance page This patch coverts the syntax for embedding OpacUserJS in the global include file so that it uses 'Koha.Preference' syntax. This makes the data available in templates, like the OPAC maintenance page, to which the preference data has not been explicitly provided. To reproduce: Add some JavaScript to the OPACUserJS system preference which will let you know it's working. For instance: alert("OPACUserJS!"); Turn on the OPAC maintenance message using the OpacMaintenance system preference. Navigate to the OPAC. You should see the system maintenance page but you should not see an alert. To test, apply the patch and reload the OPAC page. Your alert should show. Signed-off-by: Maryse Simard Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 82dcb5cf546c881af0003c272d9326e12fb5f1ce) Signed-off-by: Fridolin Somers commit 21cff327830a04f51dd568b63013b0a53a725f7a Author: Alex Arnaud Date: Fri Jun 7 10:18:05 2019 +0200 Bug 22915: fix Mana URL in etc/koha-conf.xml Signed-off-by: Martin Renvoize (cherry picked from commit 8427b684148944b9306fd4786c75c53527037024) Signed-off-by: Fridolin Somers commit 2f9ec9c61fabd7595da594c02a55395564cb2330 Author: Pasi Kallinen Date: Wed May 29 09:20:43 2019 +0300 Bug 22910: Do not copy unique patron attributes to duplicated patron When creating a new patron by duplicating another, all of the patron attributes are also copied into the form. Some of those value may be unique, so don't copy those. 1) Create patron attribute types, one with "unique identifier", one without. 2) Create or a patron so it has values in both of those attributes. 3) Duplicate the patron 4) The edit form should retain the values from the "original" patron. 5) Apply patch. 6) Duplicate the patron - this time the attributes with unique values are cleared. Signed-off-by: Pasi Kallinen Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit f3358e97c8a1f9edf1c4de6dea46f70366237699) Signed-off-by: Fridolin Somers commit 2900debc65318237ee95fa6c5dbbbd69c8a7e6c4 Author: Katrin Fischer Date: Thu Sep 27 19:49:27 2018 +0200 Bug 20986: (follow-up) Avoid br tags, but allow for line breaks to be added easily with CSS This patch removes the br tags from the XSLT in favor of some more spans and classes. This will allow to add the line breaks with one line of CSS: span.holdings_note_data { display:block; } Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 65de22a6ef928bd6074e9a4d6a1e1351d0e1de9b) Signed-off-by: Fridolin Somers commit fb362dfd795080a6bcb547e5bc1d87d18bc7ffdf Author: Joy Nelson Date: Fri Jun 22 15:22:40 2018 -0700 Bug 20986: Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. Signed-off-by: Ed Veal Signed-off-by: Katrin Fischer Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit c23276324c4da519130f35cb7c471402965b3e1b) Signed-off-by: Fridolin Somers commit cf681f6682eee0aea6ae647835a628d88fa180b9 Author: Liz Rea Date: Thu May 9 02:02:55 2019 +0000 Bug 8558: (QA follow-up) a little more text clean up You can take or leave it, honestly, I just thought we could be a little more explicit about what we were overwriting. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 6d046c2e3d301a7e1d37b376b49a0db516e67bda) Signed-off-by: Fridolin Somers commit f8b24adc75ef145b96556893d555de4971b8251d Author: Aleisha Amohia Date: Mon Apr 29 03:30:30 2019 +0000 Bug 8558: Improve confirmation message for importing frameworks This patch updates the confirmation message from: "Do you really want to import the framework fields and subfields? This will overwrite the current configuration. For safety reasons please use the export option to make a backup" to: "Are you sure you want to import the [% frameworkcode %] framework structure? This will overwrite the current configuration. For safety reasons, it is recommended to use the export option to make a backup first." To test: 1) Go to Administration -> MARC bibliographic frameworks 2) Export one of the frameworks 3) Create a new test framework 4) Import the new test framework structure using the exported file 5) Upon clicking Confirm, confirm the message is improved and makes sense. Sponsored-by: Catalyst IT Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit e4d1318550af78f76b7a43757bbdc4c5bddb4d5f) Signed-off-by: Fridolin Somers commit a249ed65075958772f28b0fb7f9f0b2755e41f5d Author: Martin Renvoize Date: Thu Jun 6 15:32:14 2019 +0100 Bug 10215: DBRev 19.05.00.002 Signed-off-by: Martin Renvoize (cherry picked from commit c3346b50bd00778c2e8364b40a7dd7a891c713b4) Signed-off-by: Fridolin Somers commit 5d0f6f8cbb42ac85d6648f1e0d45af359604021f Author: Martin Renvoize Date: Wed Jun 5 12:58:20 2019 +0100 Bug 10215: (follow-up) Fix the failing test We now handle NULL values at the database end and do not expect empty strings. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 117061d88420231d709515f4702446e60f7de4b6) Signed-off-by: Fridolin Somers commit 648587b19c7e8ca4a91b9930c7d6c78fbeb2da0f Author: Martin Renvoize Date: Wed Jun 5 12:54:30 2019 +0100 Bug 10215: (follow-up) Correct existing data This patch adds the correction of data ('' => NULL) during the DB update. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 9713e13893c9f2d2b12cea29b23b72a25170462e) Signed-off-by: Fridolin Somers commit c42c44e932133e6df6c3b9ccda30932d2835f5ee Author: Kyle M Hall Date: Tue May 7 12:49:03 2013 -0400 Bug 10215: Increase the size of opacnote and librariannote for table subscriptionhistory We have librarians that are regularly hitting the maximum number of characters for the note fields in subscription history. They would like to be able to store at least 1000 characters here. Converting the varchar(150) to text should do it. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add public and private notes to a subscription history entry where each note is greater than 150 characters. 4) Save and view the notes, the notes should not be truncated. Rescued-by: Martin Renvoize Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 8592474c3fe6af408c7265a50bd1776a76942397) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 1 + Koha.pm | 2 +- etc/koha-conf.xml | 2 +- .../authorities/authority-koha-indexdefs.xml | 1 + .../authorities/authority-zebra-indexdefs.xsl | 2 +- installer/data/mysql/kohastructure.sql | 4 +- installer/data/mysql/updatedatabase.pl | 13 ++++++ .../prog/en/includes/waiting_holds.inc | 2 +- .../prog/en/modules/admin/biblio_framework.tt | 3 +- .../prog/en/modules/admin/smart-rules.tt | 3 -- .../prog/en/modules/circ/waitingreserves.tt | 37 ++++++++-------- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 41 ++++++++++++++--- .../intranet-tmpl/prog/js/biblio_framework.js | 3 +- .../bootstrap/en/includes/opac-bottom.inc | 6 +-- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 40 ++++++++++++++--- members/memberentry.pl | 4 +- t/db_dependent/Circulation/CalcFine.t | 46 +++++++++++++++++++- t/db_dependent/Serials.t | 4 +- 18 files changed, 166 insertions(+), 48 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 18:01:00 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 16:01:00 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-3-g12b38e8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 12b38e85e541f50aa1ea2ccee86f4239396a9b54 (commit) via e33f91d3bd38f14b2bbb034adf71b7ab4b4ef777 (commit) from e8e83db8587fc484f149d576933c0a61dd1c4354 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 12b38e85e541f50aa1ea2ccee86f4239396a9b54 Author: Lucas Gass Date: Tue Jun 11 13:40:03 2019 +0000 Bug 22950: Compiled CSS Signed-off-by: Lucas Gass commit e33f91d3bd38f14b2bbb034adf71b7ab4b4ef777 Author: Owen Leonard Date: Tue May 21 15:04:33 2019 +0000 Bug 22950: Markup error in OPAC recent comment template This patch makes minor corrections to the template for the OPAC's recent comments view. These corrections fix errors returned by the HTML validator. The patch moves some inline CSS into a class in the global OPAC CSS. Some minor reindentation has also been done, so use diff with the '-w' flag. To reproduce the problem you should have the 'reviewson' system preference turned on, and your system should have one or more approved comments. View the "Recent comments" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "CSS: font-color: Property font-color doesn't exist." To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 457000102e7e2228c6bd834283a9e58f32bb2104) Signed-off-by: Fridolin Somers (cherry picked from commit 43e16861da807876e2b041c6a5bc78fdebefbbee) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 5 +++ .../bootstrap/en/modules/opac-showreviews.tt | 41 +++++++++++--------- 3 files changed, 28 insertions(+), 20 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 18:19:55 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 16:19:55 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-4-gb0b4973 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via b0b4973bdc622f3913bbde9f9acf57826e82c906 (commit) from 12b38e85e541f50aa1ea2ccee86f4239396a9b54 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b0b4973bdc622f3913bbde9f9acf57826e82c906 Author: Owen Leonard Date: Tue May 21 13:19:17 2019 +0000 Bug 22947: Markup error in OPAC preferences file This patch corrects a markup error in the OPAC .pref file which can cause display problems. The patch also corrects a validator warning by changing at to a . To reproduce the problem, go to Administration -> Global system preferences -> OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Unclosed element code." - "The tt element is obsolete. Use CSS instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the display. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 87cbb27826a9d03a424e8c944293669157924a01) Signed-off-by: Fridolin Somers (cherry picked from commit 327977abd6fe95ff8ee8f743d690e3efc45501d5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 18:22:51 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 16:22:51 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-5-gaee7027 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via aee7027adbda26ed4df832d2870562c40ad6897b (commit) from b0b4973bdc622f3913bbde9f9acf57826e82c906 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit aee7027adbda26ed4df832d2870562c40ad6897b Author: Owen Leonard Date: Tue May 21 17:14:36 2019 +0000 Bug 22955: Markup error in OPAC lists template This patch makes a minor correction to the template for OPAC lists. This correction fixes an error returned by the HTML validator by adding an empty "alt" attribute to an image tag. To reproduce the problem you should have at least one list available in the OPAC with one or more items on it. View the contents of that list in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "An img element must have an alt attribute, except under certain conditions." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Click "Download list." A modal window should appear with a "Loading" message, followed by a form for selecting a download format. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit d26991cf4cc298fc3900b8133ff9b40cd061fb96) Signed-off-by: Fridolin Somers (cherry picked from commit 483f94e7202bfa14ed8e910e0f2b4db229b8d8c5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 18:27:47 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 16:27:47 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-6-g94b15df Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 94b15df0d4c4a99378ce0f24e21e98f8e4f573cf (commit) from aee7027adbda26ed4df832d2870562c40ad6897b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 94b15df0d4c4a99378ce0f24e21e98f8e4f573cf Author: Hayley Mapley Date: Thu Mar 21 14:39:59 2019 +1300 Bug 22099: Fixed ILL toolbar to say Refresh when displaying requests On the ILL requests page that lists all requests, the List Request button is displayed as part of the ILL toolbar. This patch fixes this by instead changing the wording of the button to Refresh when on the main page. Test plan: 1) More -> ILL Requests, note that the List Requests button displays while all the requests are already displayed 2) Apply the patch and restart things 3) More -> ILL Requests, note that the button now says Refresh, and clicking it refreshes the page 4) Check that on all the other functions of the ILLs the button says List Requests 5) Sign off! Sponsored-by: Catalyst IT Signed-off-by: Magnus Enger Small conflict resolved. Works as advertised. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 66877b780a775daf135ef1137364d76f67166e61) Signed-off-by: Fridolin Somers (cherry picked from commit 6dd6ce120ad28f16fcddfb8acc94a019a7c34509) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 18:33:32 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 16:33:32 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-8-g6a63b21 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 6a63b21c9f0c7abf516757e27395a5b347d1c4b6 (commit) via f4e55bbfd7faec45053395dc35135de855e6eaaa (commit) from 94b15df0d4c4a99378ce0f24e21e98f8e4f573cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6a63b21c9f0c7abf516757e27395a5b347d1c4b6 Author: Aleisha Amohia Date: Fri Dec 14 02:05:36 2018 +0000 Bug 11492: (follow-up) Don't pass publisheddatetext param to NewIssue I have removed publisheddatetext as a param from my patch, but only in the places where my patch added it. Any other instance already existed before my patch. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit ac423d5dcf2c7503a8ca78cbafdb94dfc43dfdb6) Signed-off-by: Fridolin Somers (cherry picked from commit 6b44e314577ade8b92ae330668510ae94f2f6469) Signed-off-by: Lucas Gass commit f4e55bbfd7faec45053395dc35135de855e6eaaa Author: Aleisha Amohia Date: Fri Dec 7 01:03:42 2018 +0000 Bug 11492: Keep routing notes when receiving next serial This patch ensures the routing notes are carried over when generating the next serial. To test: 1) Create a routing list for a subscription 2) Add a borrower and a note to the routing list 3) Generate the next serial (serials-collection.pl) 4) Edit the routing list to see the notes 5) Note that the notes have disappeared 6) Apply patch 7) Edit the routing list, add a note 8) Generate the next serial 9) Edit the routing list and confirm the note is still there 10) Confirm you are still able to edit serials (serials-edit.pl) and routing notes stay Sponsored-by: Plant and Food Research Limited Signed-off-by: Nazl? ?etin Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit 2c25016a8e17b52e23c3d9806264e141b6426254) Signed-off-by: Fridolin Somers (cherry picked from commit 93cc499ed786630840845df21b4f52a2da4e6ea8) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 18 ++++++++---------- serials/serials-collection.pl | 5 +++-- serials/serials-edit.pl | 3 ++- t/db_dependent/Serials.t | 2 +- 4 files changed, 14 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 18:42:09 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 16:42:09 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-9-g9c4c9d1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 9c4c9d17e4c48db760d0f75e01f0a85c9c443e11 (commit) from 6a63b21c9f0c7abf516757e27395a5b347d1c4b6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9c4c9d17e4c48db760d0f75e01f0a85c9c443e11 Author: Marcel de Rooy Date: Wed May 29 13:46:15 2019 +0000 Bug 23006: Cannot use inventory with barcodes containing special chars If a barcode contains special characters like $, the regex in inventory does no longer work. This fix (as suggested by Jonathan) replaces the regex by a eq compare. Test plan: Pick one barcode and add a $ somewhere in the middle, say 123$456. Include this barcode in a barcode file for inventory. Run inventory on that file and verify that barcode was read and datelastseen was updated. The barcode should not be reported as missing (not scanned). Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize (cherry picked from commit 851d41ab6b9ec28901086d6a6ce15b3fd589182a) Signed-off-by: Fridolin Somers (cherry picked from commit c868ccc360189d0b5ea5b7c096ba325a304070d0) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: tools/inventory.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 18:54:45 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 16:54:45 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-10-g5a930cc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 5a930ccf299c7f7aeeac9d8de185fb1d8d24e9c9 (commit) from 9c4c9d17e4c48db760d0f75e01f0a85c9c443e11 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5a930ccf299c7f7aeeac9d8de185fb1d8d24e9c9 Author: Owen Leonard Date: Tue May 21 14:27:40 2019 +0000 Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit a3da6d6825f686099d8e23a1abff061071d679ad) Signed-off-by: Fridolin Somers (cherry picked from commit 1baddd190fe1ed72e66298a6b01394e86e58d0fe) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 18:59:07 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 16:59:07 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-11-g96aa933 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 96aa9338e8fc2e792c27428a5b13d5cc0355ee37 (commit) from 5a930ccf299c7f7aeeac9d8de185fb1d8d24e9c9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 96aa9338e8fc2e792c27428a5b13d5cc0355ee37 Author: Owen Leonard Date: Tue May 21 16:00:18 2019 +0000 Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit e72a9c91485c6e68819f3bb76d326f0a1a84dcd9) Signed-off-by: Fridolin Somers (cherry picked from commit ecfe5811c8b49135b4e0ddee1db5e24d6a854940) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 11 19:01:40 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jun 2019 17:01:40 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-12-g98fe673 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 98fe6739e4b7018ab002455559c9d0454edef6b5 (commit) from 96aa9338e8fc2e792c27428a5b13d5cc0355ee37 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 98fe6739e4b7018ab002455559c9d0454edef6b5 Author: Owen Leonard Date: Tue May 21 16:59:38 2019 +0000 Bug 22954: Minor markup error in OPAC messaging template This patch corrects a minor error in opac-messaging.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have the EnhancedMessagingPreferencesOPAC system preference enabled. Log in to the OPAC and go to the "your messaging" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses this error: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit d5a8a424203cd426f7d0bd64597a6ac95536ef9c) Signed-off-by: Fridolin Somers (cherry picked from commit feb8f84ef7a92038a544aaa2f44584ee848451fd) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 13 00:02:14 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jun 2019 22:02:14 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-14-ge5d2322 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via e5d232239d9c869fd1fddb885cc59f4ee6308cdc (commit) via b678c8806437299427f7078c2d218cec1f30a5e9 (commit) from 98fe6739e4b7018ab002455559c9d0454edef6b5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e5d232239d9c869fd1fddb885cc59f4ee6308cdc Author: Nazl? ?etin Date: Tue Nov 27 15:24:38 2018 +0000 Bug 21887: (For OPAC) 856 link problem in XSLT result lists and detail page Signed-off-by: Liz Rea Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize (cherry picked from commit 9a58871503caa1b48e4e5c3cc0f565fa583f3e9d) Signed-off-by: Fridolin Somers (cherry picked from commit 75da739b1bf3bdb22f30e1e41da65c7a713c8036) Signed-off-by: Lucas Gass commit b678c8806437299427f7078c2d218cec1f30a5e9 Author: Nazl? ?etin Date: Tue Nov 27 14:15:33 2018 +0000 Bug 21887: 856 link problem in XSLT result lists and detail page Signed-off-by: Nazl? ?etin Signed-off-by: Liz Rea Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize (cherry picked from commit 4903cee9e937c970c6d3d15fd78d82189d8705eb) Signed-off-by: Fridolin Somers (cherry picked from commit a61323998313092385db7e94f177068463fca8ec) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 75 +++++++++++------- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 82 ++++++++++++-------- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 17 +++- .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 17 +++- 4 files changed, 127 insertions(+), 64 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 13 00:33:17 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jun 2019 22:33:17 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-15-ge248c81 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via e248c81b1ae14e8ee8766b41d5cd7f11c7098e91 (commit) from e5d232239d9c869fd1fddb885cc59f4ee6308cdc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e248c81b1ae14e8ee8766b41d5cd7f11c7098e91 Author: Katrin Fischer Date: Sun Jun 2 08:58:50 2019 +0000 Bug 22958: Fix help link on the SMS providers page The help link on the SMS providers page didn't link to the according chapter in the manual. To test: - Enter Email in SMSSendDriver system preference to make the configuration page appear - Go to Administration > SMS cellular providers - Click on the help link - Verify it leads to the manual start page - Apply patch - Repeat and verify the link now leads to the correct section in the manual Signed-off-by: Liz Rea Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize (cherry picked from commit 3f93acbc6c0344151da794a73476de1f91000502) Signed-off-by: Fridolin Somers (cherry picked from commit 203ae6e8ecf2606922490fe0433e5eccfc8d95c5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Manual.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 13 00:38:13 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jun 2019 22:38:13 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-16-g76b797b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 76b797bb5fc8ea1d7b7af06406ad0787fc3941c9 (commit) from e248c81b1ae14e8ee8766b41d5cd7f11c7098e91 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 76b797bb5fc8ea1d7b7af06406ad0787fc3941c9 Author: Jonathan Druart Date: Thu May 30 09:36:31 2019 -0500 Bug 22919: Fix insert of authorities_normal_marc21.sql with strict SQL modes If strict SQL modes are set, the insert of authorities_normal_marc21.sql will fail. Test plan: DELETE FROM auth_subfield_structure; DELETE FROM auth_tag_structure; DELETE FROM auth_types; SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'; source /home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql You should not see any errors. Without this patch you see: ERROR 1366 (22007) at line 280 in file: '/home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql': Incorrect integer value: ' for column 'linkid' at row 148 ' Signed-off-by: nabila Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 703ec1e2f24345146c997398b9c0cc492016455d) Signed-off-by: Fridolin Somers (cherry picked from commit e69744172a33165758562c6c786a1135361c7509) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 13 00:58:51 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jun 2019 22:58:51 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-20-g8001aae Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 8001aae5039d5a95d4c100437f4ec47255921616 (commit) via a3469609fcc0366302d350af7548872f04bdf790 (commit) via 52e3d51c8b206130522b92cbba2be1aad9196d9d (commit) via 0caaa8e88457c65fdf303fa4a49f361ab07e67cc (commit) from 76b797bb5fc8ea1d7b7af06406ad0787fc3941c9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8001aae5039d5a95d4c100437f4ec47255921616 Author: Lucas Gass Date: Wed Jun 12 22:37:43 2019 +0000 Bug 10215: DBRev 18.11.06.001 Signed-off-by: Lucas Gass commit a3469609fcc0366302d350af7548872f04bdf790 Author: Martin Renvoize Date: Wed Jun 5 12:58:20 2019 +0100 Bug 10215: (follow-up) Fix the failing test We now handle NULL values at the database end and do not expect empty strings. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 117061d88420231d709515f4702446e60f7de4b6) Signed-off-by: Fridolin Somers (cherry picked from commit 5d0f6f8cbb42ac85d6648f1e0d45af359604021f) Signed-off-by: Lucas Gass commit 52e3d51c8b206130522b92cbba2be1aad9196d9d Author: Martin Renvoize Date: Wed Jun 5 12:54:30 2019 +0100 Bug 10215: (follow-up) Correct existing data This patch adds the correction of data ('' => NULL) during the DB update. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 9713e13893c9f2d2b12cea29b23b72a25170462e) Signed-off-by: Fridolin Somers (cherry picked from commit 648587b19c7e8ca4a91b9930c7d6c78fbeb2da0f) Signed-off-by: Lucas Gass commit 0caaa8e88457c65fdf303fa4a49f361ab07e67cc Author: Kyle M Hall Date: Tue May 7 12:49:03 2013 -0400 Bug 10215: Increase the size of opacnote and librariannote for table subscriptionhistory We have librarians that are regularly hitting the maximum number of characters for the note fields in subscription history. They would like to be able to store at least 1000 characters here. Converting the varchar(150) to text should do it. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add public and private notes to a subscription history entry where each note is greater than 150 characters. 4) Save and view the notes, the notes should not be truncated. Rescued-by: Martin Renvoize Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 8592474c3fe6af408c7265a50bd1776a76942397) Signed-off-by: Fridolin Somers (cherry picked from commit c42c44e932133e6df6c3b9ccda30932d2835f5ee) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 1 + Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 4 ++-- installer/data/mysql/updatedatabase.pl | 13 +++++++++++++ t/db_dependent/Serials.t | 4 ++-- 5 files changed, 19 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 13 01:02:01 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jun 2019 23:02:01 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-22-g132f143 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 132f143a9ddef1369bae07235e9151a4e6977f2b (commit) via ca0d9d0e84ba5db57130890a8197e97a35b8c32b (commit) from 8001aae5039d5a95d4c100437f4ec47255921616 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 132f143a9ddef1369bae07235e9151a4e6977f2b Author: Liz Rea Date: Thu May 9 02:02:55 2019 +0000 Bug 8558: (QA follow-up) a little more text clean up You can take or leave it, honestly, I just thought we could be a little more explicit about what we were overwriting. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 6d046c2e3d301a7e1d37b376b49a0db516e67bda) Signed-off-by: Fridolin Somers (cherry picked from commit cf681f6682eee0aea6ae647835a628d88fa180b9) Signed-off-by: Lucas Gass commit ca0d9d0e84ba5db57130890a8197e97a35b8c32b Author: Aleisha Amohia Date: Mon Apr 29 03:30:30 2019 +0000 Bug 8558: Improve confirmation message for importing frameworks This patch updates the confirmation message from: "Do you really want to import the framework fields and subfields? This will overwrite the current configuration. For safety reasons please use the export option to make a backup" to: "Are you sure you want to import the [% frameworkcode %] framework structure? This will overwrite the current configuration. For safety reasons, it is recommended to use the export option to make a backup first." To test: 1) Go to Administration -> MARC bibliographic frameworks 2) Export one of the frameworks 3) Create a new test framework 4) Import the new test framework structure using the exported file 5) Upon clicking Confirm, confirm the message is improved and makes sense. Sponsored-by: Catalyst IT Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit e4d1318550af78f76b7a43757bbdc4c5bddb4d5f) Signed-off-by: Fridolin Somers (cherry picked from commit f8b24adc75ef145b96556893d555de4971b8251d) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt | 3 +-- koha-tmpl/intranet-tmpl/prog/js/biblio_framework.js | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 13 01:04:40 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jun 2019 23:04:40 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-24-g2aa3360 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 2aa3360ec6ccb90f34dfd58dea7c9fac1601b875 (commit) via 827e60e3d864461fe87877b7b0ccb7a4315818b4 (commit) from 132f143a9ddef1369bae07235e9151a4e6977f2b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2aa3360ec6ccb90f34dfd58dea7c9fac1601b875 Author: Katrin Fischer Date: Thu Sep 27 19:49:27 2018 +0200 Bug 20986: (follow-up) Avoid br tags, but allow for line breaks to be added easily with CSS This patch removes the br tags from the XSLT in favor of some more spans and classes. This will allow to add the line breaks with one line of CSS: span.holdings_note_data { display:block; } Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 65de22a6ef928bd6074e9a4d6a1e1351d0e1de9b) Signed-off-by: Fridolin Somers (cherry picked from commit 2900debc65318237ee95fa6c5dbbbd69c8a7e6c4) Signed-off-by: Lucas Gass commit 827e60e3d864461fe87877b7b0ccb7a4315818b4 Author: Joy Nelson Date: Fri Jun 22 15:22:40 2018 -0700 Bug 20986: Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. Signed-off-by: Ed Veal Signed-off-by: Katrin Fischer Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit c23276324c4da519130f35cb7c471402965b3e1b) Signed-off-by: Fridolin Somers (cherry picked from commit fb362dfd795080a6bcb547e5bc1d87d18bc7ffdf) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 41 +++++++++++++++++--- .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 40 ++++++++++++++++--- 2 files changed, 71 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 13 13:27:26 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Jun 2019 11:27:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-62-g15dcde2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 15dcde21fe9b34d287844aab75426e6387c7b4cf (commit) via a3e047f638ac7e6095d56c064f0e6cb8038a8524 (commit) via 7d7c8c12e70295f4dd15a3435235c81539c333f5 (commit) via ac41566cddb737c19282bc577cf31882f168384b (commit) via 07d6e9f142a588f26c52582d9b5d99b714fa1fd7 (commit) via 3de89b98ce373818c4b6f5a0a90b8786996e6cfe (commit) via 18f2074f8df8598527ae8e126c4efc7f3be000e0 (commit) from 39e4c6c5d791853985773e4032357372f77d7587 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 15dcde21fe9b34d287844aab75426e6387c7b4cf Author: Nick Clemens Date: Mon Jun 10 13:42:18 2019 +0000 Bug 22585: (follow-up) Fix additional occurences Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit a3e047f638ac7e6095d56c064f0e6cb8038a8524 Author: Justin Rittenhouse Date: Fri May 31 16:37:11 2019 +0000 Bug 22585: remove double-escape for CAS URL The return URL that is part of the link to CAS login is double-escaped on the staff login page. It appears that this is the same issue as bug 21973 but in the staff intranet template. I have attached an identical patch for the intranet auth.tt file. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 7d7c8c12e70295f4dd15a3435235c81539c333f5 Author: Kyle M Hall Date: Thu Jun 16 11:08:59 2016 +0000 Bug 16750: Redirect from selectbranchprinter.pl to additem.pl causes software error How to reproduce: 1) Edit and save an item in the items editor 2) You should be redirected back to the items editor, note that the biblionumber is passed in the url 3) Choose "set library" from the upper right hand pulldown on the page 4) Choose a different library, click submit 5) You should get the error message: Software error: Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test Plan: 1) Apply this patch 2) Follow plan above 3) No software error should occur at step 5 Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit ac41566cddb737c19282bc577cf31882f168384b Author: Nick Clemens Date: Mon Jun 10 13:34:18 2019 +0000 Bug 14794: (follow-up) Add tooltip to filter box Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 07d6e9f142a588f26c52582d9b5d99b714fa1fd7 Author: Nick Clemens Date: Fri Jun 7 14:53:16 2019 +0000 Bug 14794: Display JS tooltip whenever dateofbirth is being searched This updates the code that adds a tooltip for the correct date format to display after the initial search To test: 1 - Do a patron search, choosing date of birth as the search field 2 - Note on choosing that field you get a tooltip defining the format 3 - Do a search 4 - Note tooltip is gone, but date fo birth is still selected as the field to search 5 - Apply patch, reload 6 - Note tooltip shows after initial search and until field is changed Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 3de89b98ce373818c4b6f5a0a90b8786996e6cfe Author: Jonathan Druart Date: Tue Jun 11 10:44:25 2019 -0500 Bug 23095: Correctly display circulation rules (0 vs undef) From the following commit: commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165 Bug 18925: (follow-up) Fix null/empty behavior The global test must have been adjusted as well to catch empty strings. Actually we are expecting the plugin to return undef but the template variable contains an empty string. So the test should only be [% IF var != '' %] instead of [% IF var.defined && var != '' %] but I prefer to keep it as it for now. Test plan: In the section "Default checkout, hold policy by patron category" Set total checkouts = blank total on-site checkouts = blank total holds = 0 Save => Without this patch the line will not appear => With this patch applied there must be "unlimited, unlimited, 0" Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 18f2074f8df8598527ae8e126c4efc7f3be000e0 Author: Jonathan Druart Date: Tue Jun 11 09:24:28 2019 -0500 Bug 23093: (bug 22318 follow-up) Use placeholders in query moving OpacNavRight Placeholders must be used (!) in all SQL queries. Test plan: 1/ % git checkout 0c95e22afe13349b60d134217fce6718bfa9727f # commit before bug 22318 2/ Edit the pref OpacNavRight with something with " just a " and more ' 3/ git checkout master 4/ restart_all 5/ run updatedatabase.pl => Boom and the content of the pref has been lost 6/ Repeat 1 to 3 7/ Apply this patch 8/ run updatedatabase.pl => The pref has been correctly moved to opac_news Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- .../prog/en/modules/admin/smart-rules.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 4 +- .../prog/en/modules/cataloguing/additem.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/members-menu.js | 43 +++++++++++++------- .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 +- 6 files changed, 35 insertions(+), 22 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 13 14:10:31 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Jun 2019 12:10:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-63-g93c9b5d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 93c9b5d553261acda55f1f29f8687c5f4c276e04 (commit) from 15dcde21fe9b34d287844aab75426e6387c7b4cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 93c9b5d553261acda55f1f29f8687c5f4c276e04 Author: Owen Leonard Date: Tue Mar 5 18:56:55 2019 +0000 Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required." Signed-off-by: Maryse Simard Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 13 14:11:36 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Jun 2019 12:11:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-65-gad9338e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ad9338e419ee04c38f5e7fdc918ce1a4d177cee0 (commit) via b2be5b0c65ddf992e451e5b8c12cf0994038186e (commit) from 93c9b5d553261acda55f1f29f8687c5f4c276e04 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ad9338e419ee04c38f5e7fdc918ce1a4d177cee0 Author: Katrin Fischer Date: Wed Apr 3 21:47:09 2019 +0200 Bug 22633: Link barcodes in hold summary in patron account to moredetail page Bug 21070 links the barcode on holds to the item on moredetail.pl. This patch makes the same change to the hold lists in the staff patron account. To test: - Create some holds, have at least - one item level hold - one hold waiting for pick-up - Take a look at the details and checkouts tabs in the patron account on staff side - Verify that the barcodes link to the record detail page - Apply patch - Verify the barcodes now link to the moredetail page Signed-off-by: Axel Amghar Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit b2be5b0c65ddf992e451e5b8c12cf0994038186e Author: Jonathan Druart Date: Sat Jun 8 13:29:24 2019 -0500 Bug 23065: Rename "New subscription" button when default to current serial To make it explicite that the "New subscription" button will create a subscription based on the current serial it is now labeled "New subscription for this serial" Test plan: 1 - Go to Serials module in Koha 2 - Click 'New subscription' 3 - You get a blank form 4 - Fill it out, save it 5 - You are viewing the subscription you created => The button is now labeled "New subscription for this serial" Signed-off-by: Michal Denar Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/js/holds.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 13 14:31:02 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Jun 2019 12:31:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-67-g510cf51 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 510cf514a342cb9062d1c51cdf1d41b6772ad90a (commit) via 2a3454b4b28596c7b49224a75d02ec97a7b815a7 (commit) from ad9338e419ee04c38f5e7fdc918ce1a4d177cee0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 510cf514a342cb9062d1c51cdf1d41b6772ad90a Author: Martin Renvoize Date: Thu Jun 13 13:08:58 2019 +0100 Bug 21662: (RM follow-up) Final followup corrections to history Minor update to ensure we're using commit dates and not author dates Signed-off-by: Martin Renvoize commit 2a3454b4b28596c7b49224a75d02ec97a7b815a7 Author: Martin Renvoize Date: Thu Jun 13 13:05:32 2019 +0100 Bug 22585: Add Justin Rittenhouse to contributors Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: docs/contributors.yaml | 7 +++++-- docs/history.txt | 12 +++++++----- 2 files changed, 12 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 13 15:58:10 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Jun 2019 13:58:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-68-gef0c31f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ef0c31f735cf68a3b004c706e274ede4bb883940 (commit) from 510cf514a342cb9062d1c51cdf1d41b6772ad90a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ef0c31f735cf68a3b004c706e274ede4bb883940 Author: Nick Clemens Date: Wed Jun 12 12:39:29 2019 +0000 Bug 23053: [follow-up] Same changes for UNIMARC Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../marc_defs/unimarc/authorities/authority-koha-indexdefs.xml | 1 + .../marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 14 23:01:17 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Jun 2019 21:01:17 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-25-g40b4e68 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 40b4e68ee3ea6631d20644a128b9f215557c2b9a (commit) from 2aa3360ec6ccb90f34dfd58dea7c9fac1601b875 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 40b4e68ee3ea6631d20644a128b9f215557c2b9a Author: Jonathan Druart Date: Wed Sep 12 09:38:39 2018 -0700 Bug 19457: Handle 'PREVISSUE' return by CanBookBeIssued from SIP (CheckPrevCheckout) If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer To test: - Do not apply this patch - Set CheckPrevCheckout to "Do", or "Unless overridden, do" Verify the SIP server is blocking checkouts with this setting set - Apply this patch - Note that the checkout is now allowed, with a screen message telling the borrower they've issued the item before. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit b40e58343ef65aabe0a575a0b3f842b5e22a3600) Signed-off-by: Fridolin Somers (cherry picked from commit 67bddf78e245e5ef2dfe1c3040e5c820124a3b99) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Transaction/Checkout.pm | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 14 23:08:17 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Jun 2019 21:08:17 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-26-g4912b87 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 4912b870932029a18f3eab52a144f4e6ec960b53 (commit) from 40b4e68ee3ea6631d20644a128b9f215557c2b9a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4912b870932029a18f3eab52a144f4e6ec960b53 Author: Pasi Kallinen Date: Wed May 29 09:20:43 2019 +0300 Bug 22910: Do not copy unique patron attributes to duplicated patron When creating a new patron by duplicating another, all of the patron attributes are also copied into the form. Some of those value may be unique, so don't copy those. 1) Create patron attribute types, one with "unique identifier", one without. 2) Create or a patron so it has values in both of those attributes. 3) Duplicate the patron 4) The edit form should retain the values from the "original" patron. 5) Apply patch. 6) Duplicate the patron - this time the attributes with unique values are cleared. Signed-off-by: Pasi Kallinen Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit f3358e97c8a1f9edf1c4de6dea46f70366237699) Signed-off-by: Fridolin Somers (cherry picked from commit 2f9ec9c61fabd7595da594c02a55395564cb2330) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: members/memberentry.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 14 23:12:49 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 14 Jun 2019 21:12:49 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-27-g1a23c04 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 1a23c045dea4744c86e0e9cb47f129737cb8843f (commit) from 4912b870932029a18f3eab52a144f4e6ec960b53 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1a23c045dea4744c86e0e9cb47f129737cb8843f Author: Owen Leonard Date: Fri Jun 7 12:10:01 2019 +0000 Bug 23076: Include OpacUserJS on OPAC maintenance page This patch coverts the syntax for embedding OpacUserJS in the global include file so that it uses 'Koha.Preference' syntax. This makes the data available in templates, like the OPAC maintenance page, to which the preference data has not been explicitly provided. To reproduce: Add some JavaScript to the OPACUserJS system preference which will let you know it's working. For instance: alert("OPACUserJS!"); Turn on the OPAC maintenance message using the OpacMaintenance system preference. Navigate to the OPAC. You should see the system maintenance page but you should not see an alert. To test, apply the patch and reload the OPAC page. Your alert should show. Signed-off-by: Maryse Simard Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 82dcb5cf546c881af0003c272d9326e12fb5f1ce) Signed-off-by: Fridolin Somers (cherry picked from commit c6464d55601f98746ac7327141e538484a8842f2) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Jun 15 09:22:53 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 15 Jun 2019 07:22:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-83-g62ae7ac Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 62ae7ac7275329f6396d656a216ffc95b4f9494a (commit) via 001d433b427731a6efd55208ac3169107c830730 (commit) via d2dc504ec1d87b74ea424d27462a214e7027385c (commit) via fd5d274d3a351e70ed2008dccaf9b40905910390 (commit) via 3820d708a6e3b0a4920f96937fbfdcfaf5ee4d92 (commit) via 1171a20d05db2d7c66f9294863146becc938d6c3 (commit) via 0e8a95b4bdcde76646ad3a45a2022d82e6da277e (commit) via a72feaa40cbcf34f8f77ecac58ca6b269e9b95c9 (commit) via 5438355b1d016b2699ea2efc5367eaa8d807496d (commit) via c6540d1b72d45b2682860fc50716b0d74e3f5e2c (commit) via 77716188757d11e2a9fa79788ce99982e3c39839 (commit) via adb30fb8a0347ab6ff391238a8bd1ce4b6931fcd (commit) via 4452273669c98bcbaf409dc653d01d5596ca415a (commit) via eba980b3519263856c725cd42d4ff151d7822205 (commit) via f8db499f4a9c71e7a2ffef0fadaecddb938330d4 (commit) from ef0c31f735cf68a3b004c706e274ede4bb883940 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 62ae7ac7275329f6396d656a216ffc95b4f9494a Author: Jonathan Druart Date: Thu Jun 13 11:06:29 2019 -0500 Bug 23117: Shortcut additem.pl on nonexistent biblionumber To prevent additem.pl to crash when called with a nonexistent biblionumber we are here implementing the blocking_error.inc trick to display a friendly message instead. Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test plan: hit /cataloguing/additem.pl?biblionumber= /cataloguing/additem.pl?biblionumber=424242 You will get a friendly "Bibliographic record not found." message, instead of a 500 Signed-off-by: Bin Wen Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 001d433b427731a6efd55208ac3169107c830730 Author: Fridolin Somers Date: Wed May 29 15:20:41 2019 +0200 Bug 21534: Always compute wildcards You get no results when searching with an hyphen + with * in query string (or with preference QueryAutoTruncate) : ie /cgi-bin/koha/opac-search.pl?q=saints-anges* Looks like query-string by default does not compute wildcards, see analyze_wildcard in : https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html Test plan : 1) Use Elasticsearch 2) Create a record with "saints-anges" 3) Search for "saints-anges" => you get results 4) Search for "saints-anges*" => you get results 5) Search for "saints-ang*" => you get results Signed-off-by: Michal Denar Signed-off-by: Arthur Bousquet Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit d2dc504ec1d87b74ea424d27462a214e7027385c Author: Martin Renvoize Date: Sat Jun 15 07:58:29 2019 +0100 Bug 9834: DBRev 19.06.00.005 Signed-off-by: Martin Renvoize commit fd5d274d3a351e70ed2008dccaf9b40905910390 Author: Jonathan Druart Date: Thu Jun 6 14:50:05 2019 -0500 Bug 9834: Preserve biblio level hold preference on reverting waiting status When the waiting status of a hold is revert we want to preserve the level hold preference of the user. Test plan: Place a hold at biblio level Confirm the hold Revert the waiting hold => The hold must still be considered as a biblio level hold ("next available item") Signed-off-by: Liz Rea Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 3820d708a6e3b0a4920f96937fbfdcfaf5ee4d92 Author: Jonathan Druart Date: Thu Jun 6 14:49:43 2019 -0500 Bug 9834: Add tests Signed-off-by: Liz Rea Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 1171a20d05db2d7c66f9294863146becc938d6c3 Author: Jonathan Druart Date: Thu Jun 6 14:49:18 2019 -0500 Bug 9834: Add DB changes Signed-off-by: Liz Rea Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 0e8a95b4bdcde76646ad3a45a2022d82e6da277e Author: Martin Renvoize Date: Sat Jun 15 07:55:35 2019 +0100 Bug 22358: (RM follow-up) Typo fix Signed-off-by: Martin Renvoize commit a72feaa40cbcf34f8f77ecac58ca6b269e9b95c9 Author: Nick Clemens Date: Fri Jun 14 17:40:52 2019 +0000 Bug 22358: (QA follow-up) Clear up phrasing Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 5438355b1d016b2699ea2efc5367eaa8d807496d Author: Alex Arnaud Date: Thu Jun 6 12:00:22 2019 +0200 Bug 22358: fix POD header and typo Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit c6540d1b72d45b2682860fc50716b0d74e3f5e2c Author: Alex Arnaud Date: Wed Mar 13 15:14:31 2019 +0100 Bug 22358: Add POD to Koha::SharedContent Signed-off-by: Liz Rea Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 77716188757d11e2a9fa79788ce99982e3c39839 Author: Jonathan Druart Date: Wed Jun 5 19:11:59 2019 -0500 Bug 23022: Remove the SQl mode NO_AUTO_CREATE_USER To make our sql mode list compatible with MySQL 8.0.11 NO_AUTO_CREATE_USER has been removed in MySQL 8.0.11 https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-11.html I do not think we needed it. Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit adb30fb8a0347ab6ff391238a8bd1ce4b6931fcd Author: Jonathan Druart Date: Sat Jun 8 13:57:05 2019 -0500 Bug 23075: Better error handling in Mana config Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. This patch makes it display a more friendly message. Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 4452273669c98bcbaf409dc653d01d5596ca415a Author: Martin Renvoize Date: Sat Jun 15 07:50:43 2019 +0100 Bug 22770: DBRev 19.06.00.004 Signed-off-by: Martin Renvoize commit eba980b3519263856c725cd42d4ff151d7822205 Author: Katrin Fischer Date: Sun Jun 2 10:48:00 2019 +0200 Bug 22770: Fix typo in German language description of el Fixes: Griechisch (Moern [1453- ] ==> Griechisch (Modern 1453-) To test: - Install de-DE language and activate it - Check the language pull down on advanced search has the typo - Apply patch and run database update - Check advanced search again - Verify the description now shows correctly Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Martin Renvoize commit f8db499f4a9c71e7a2ffef0fadaecddb938330d4 Author: Jonathan Druart Date: Sat Jun 8 14:45:33 2019 -0500 Bug 22941: Do not return 500 if sortfield contain parenthesis Test plan: Hit /virtualshelves/shelves.pl?op=view&shelfnumber=1&sortfield=author( You must not get: Unmatched ( in regex; marked by <-- HERE in m/^author( <-- HERE $/ at /home/vagrant/kohaclone/virtualshelves/shelves.pl line 236 Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Output.pm | 4 ++ C4/Reserves.pm | 8 +++ Koha.pm | 2 +- Koha/Database.pm | 4 +- Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 1 + Koha/SharedContent.pm | 68 ++++++++++++++++---- cataloguing/additem.pl | 4 ++ installer/data/mysql/kohastructure.sql | 2 + installer/data/mysql/mandatory/subtag_registry.sql | 2 +- installer/data/mysql/updatedatabase.pl | 21 ++++++ .../prog/en/modules/admin/share_content.tt | 2 +- .../prog/en/modules/cataloguing/additem.tt | 2 +- t/db_dependent/Reserves.t | 62 +++++++++++++++++- virtualshelves/shelves.pl | 2 +- 14 files changed, 165 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 17 09:50:21 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 17 Jun 2019 07:50:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-85-ga3cf29c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a3cf29c5f714b5888718885f5a0cf2576a6cb5be (commit) via e865b181b3a2448b23c5cca60c2c25063ca4a8fe (commit) from 62ae7ac7275329f6396d656a216ffc95b4f9494a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a3cf29c5f714b5888718885f5a0cf2576a6cb5be Author: Martin Renvoize Date: Mon Jun 17 08:30:13 2019 +0100 Bug 10215: (RM follow-up) Rebuid DBIC classes Signed-off-by: Martin Renvoize commit e865b181b3a2448b23c5cca60c2c25063ca4a8fe Author: Martin Renvoize Date: Mon Jun 17 08:26:44 2019 +0100 Bug 9834: (RM follow-up) Rebuild DBIC classes Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/OldReserve.pm | 12 ++++++++++-- Koha/Schema/Result/Reserve.pm | 12 ++++++++++-- Koha/Schema/Result/Subscriptionhistory.pm | 20 ++++++++------------ 3 files changed, 28 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 17 09:50:36 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 17 Jun 2019 07:50:36 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.00-50-gae0bda4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via ae0bda4f70a48ef9a2b0f62c6b1aeb7f305fbe66 (commit) from ff651b84e8d99496bc330c4e8e0925234f30def9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ae0bda4f70a48ef9a2b0f62c6b1aeb7f305fbe66 Author: Nick Clemens Date: Wed Jun 12 12:39:29 2019 +0000 Bug 23053: [follow-up] Same changes for UNIMARC Signed-off-by: Martin Renvoize (cherry picked from commit ef0c31f735cf68a3b004c706e274ede4bb883940) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../marc_defs/unimarc/authorities/authority-koha-indexdefs.xml | 1 + .../marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 17 12:24:51 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 17 Jun 2019 10:24:51 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.00-58-g8710c15 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 8710c15c8aa074d54d6a04f6cbd2d8c0a3796d67 (commit) via 518856e59405eeeac4bc9d7cff10cc0666664446 (commit) via d782843a71caa60409807b01bb971c2805a6218c (commit) via a539d9c4b6e88d290136b5218ea0ac3c982a39f5 (commit) via c41379c0b8a1aab0802c3acde94bd071b57a296d (commit) via a0d2e4582c9351cd33196e061ed1414dc6ceac09 (commit) via e0a93f14c96e80da3880ef1907f68d37c9413eab (commit) via 3e31200f29b7c26a2d0e1d0fa311fc1bdcc70cb3 (commit) from ae0bda4f70a48ef9a2b0f62c6b1aeb7f305fbe66 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8710c15c8aa074d54d6a04f6cbd2d8c0a3796d67 Author: Owen Leonard Date: Tue Mar 5 18:56:55 2019 +0000 Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required." Signed-off-by: Maryse Simard Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize (cherry picked from commit 93c9b5d553261acda55f1f29f8687c5f4c276e04) Signed-off-by: Fridolin Somers commit 518856e59405eeeac4bc9d7cff10cc0666664446 Author: Nick Clemens Date: Mon Jun 10 13:42:18 2019 +0000 Bug 22585: (follow-up) Fix additional occurences Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 15dcde21fe9b34d287844aab75426e6387c7b4cf) Signed-off-by: Fridolin Somers commit d782843a71caa60409807b01bb971c2805a6218c Author: Justin Rittenhouse Date: Fri May 31 16:37:11 2019 +0000 Bug 22585: remove double-escape for CAS URL The return URL that is part of the link to CAS login is double-escaped on the staff login page. It appears that this is the same issue as bug 21973 but in the staff intranet template. I have attached an identical patch for the intranet auth.tt file. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit a3e047f638ac7e6095d56c064f0e6cb8038a8524) Signed-off-by: Fridolin Somers commit a539d9c4b6e88d290136b5218ea0ac3c982a39f5 Author: Kyle M Hall Date: Thu Jun 16 11:08:59 2016 +0000 Bug 16750: Redirect from selectbranchprinter.pl to additem.pl causes software error How to reproduce: 1) Edit and save an item in the items editor 2) You should be redirected back to the items editor, note that the biblionumber is passed in the url 3) Choose "set library" from the upper right hand pulldown on the page 4) Choose a different library, click submit 5) You should get the error message: Software error: Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test Plan: 1) Apply this patch 2) Follow plan above 3) No software error should occur at step 5 Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 7d7c8c12e70295f4dd15a3435235c81539c333f5) Signed-off-by: Fridolin Somers commit c41379c0b8a1aab0802c3acde94bd071b57a296d Author: Nick Clemens Date: Mon Jun 10 13:34:18 2019 +0000 Bug 14794: (follow-up) Add tooltip to filter box Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit ac41566cddb737c19282bc577cf31882f168384b) Signed-off-by: Fridolin Somers commit a0d2e4582c9351cd33196e061ed1414dc6ceac09 Author: Nick Clemens Date: Fri Jun 7 14:53:16 2019 +0000 Bug 14794: Display JS tooltip whenever dateofbirth is being searched This updates the code that adds a tooltip for the correct date format to display after the initial search To test: 1 - Do a patron search, choosing date of birth as the search field 2 - Note on choosing that field you get a tooltip defining the format 3 - Do a search 4 - Note tooltip is gone, but date fo birth is still selected as the field to search 5 - Apply patch, reload 6 - Note tooltip shows after initial search and until field is changed Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 07d6e9f142a588f26c52582d9b5d99b714fa1fd7) Signed-off-by: Fridolin Somers commit e0a93f14c96e80da3880ef1907f68d37c9413eab Author: Jonathan Druart Date: Tue Jun 11 10:44:25 2019 -0500 Bug 23095: Correctly display circulation rules (0 vs undef) From the following commit: commit d1303ca834dd0b08fc1d44476cfbbb8b729b6165 Bug 18925: (follow-up) Fix null/empty behavior The global test must have been adjusted as well to catch empty strings. Actually we are expecting the plugin to return undef but the template variable contains an empty string. So the test should only be [% IF var != '' %] instead of [% IF var.defined && var != '' %] but I prefer to keep it as it for now. Test plan: In the section "Default checkout, hold policy by patron category" Set total checkouts = blank total on-site checkouts = blank total holds = 0 Save => Without this patch the line will not appear => With this patch applied there must be "unlimited, unlimited, 0" Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize (cherry picked from commit 3de89b98ce373818c4b6f5a0a90b8786996e6cfe) Signed-off-by: Fridolin Somers commit 3e31200f29b7c26a2d0e1d0fa311fc1bdcc70cb3 Author: Jonathan Druart Date: Tue Jun 11 09:24:28 2019 -0500 Bug 23093: (bug 22318 follow-up) Use placeholders in query moving OpacNavRight Placeholders must be used (!) in all SQL queries. Test plan: 1/ % git checkout 0c95e22afe13349b60d134217fce6718bfa9727f # commit before bug 22318 2/ Edit the pref OpacNavRight with something with " just a " and more ' 3/ git checkout master 4/ restart_all 5/ run updatedatabase.pl => Boom and the content of the pref has been lost 6/ Repeat 1 to 3 7/ Apply this patch 8/ run updatedatabase.pl => The pref has been correctly moved to opac_news Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 18f2074f8df8598527ae8e126c4efc7f3be000e0) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- .../prog/en/modules/admin/smart-rules.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 4 +- .../prog/en/modules/cataloguing/addbiblio.tt | 7 ++-- .../prog/en/modules/cataloguing/additem.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/members-menu.js | 43 +++++++++++++------- .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 +- 7 files changed, 39 insertions(+), 25 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 17 18:14:12 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 17 Jun 2019 16:14:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-86-ga45eb60 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a45eb6082bb99973b6c56600acdcbf41529ac2f3 (commit) from a3cf29c5f714b5888718885f5a0cf2576a6cb5be (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a45eb6082bb99973b6c56600acdcbf41529ac2f3 Author: Martin Renvoize Date: Mon Jun 17 16:53:17 2019 +0100 Revert "Bug 23075: Better error handling in Mana config" This reverts commit adb30fb8a0347ab6ff391238a8bd1ce4b6931fcd. We missed some cases that means this handling was throwing out perfectly accepable requests. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/SharedContent.pm | 7 ------- koha-tmpl/intranet-tmpl/prog/en/modules/admin/share_content.tt | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 18 11:28:25 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 18 Jun 2019 09:28:25 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-95-g7b0dbb1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7b0dbb136310028e756f22b73745dbd9c542a271 (commit) via 1efe0d4606f844c28e2524d0341779381fc4980b (commit) via cc26fefeebc7ad5af08a087d6dd57c1eb9a6d5b4 (commit) via b86766a3e2148582a2c191e168ad4a65e5d8d0be (commit) via 42a26a758079830758a51845b4526e681b75d434 (commit) via 6a75f99200f6659d09e46ce9e11c5ded11020d89 (commit) via 5b7e563f4e923bb5cf9f6b1f6ecef3bdc8b77f52 (commit) via 8c8e36cf7abf51113654c5e1c0497f918a1cd56c (commit) via 1521a5567ea17c8adf5339249251bb275b5109de (commit) from a45eb6082bb99973b6c56600acdcbf41529ac2f3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7b0dbb136310028e756f22b73745dbd9c542a271 Author: Nick Clemens Date: Fri Jun 14 12:02:25 2019 +0000 Bug 23120: Pass necessary inputs through when transferring item automatically To test: 1 - Find an item in you system 2 - Have syspref AutomaticItemReturn = Do 3 - Check in the item at a branch that is not its homebranch 4 - Click 'Print slip' on the modal popup 5 - Error! 6 - Apply patch 7 - Check the item in at its homebranch (to clear transfers) 8 - Check it in at another branch again 9 - Print slip 10 - Success! Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize commit 1efe0d4606f844c28e2524d0341779381fc4980b Author: Owen Leonard Date: Tue May 21 12:07:10 2019 +0000 Bug 22945: Markup error in OPAC search results around lists display This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, perform a search in the OPAC which will return results which are on one or more lists. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Text not allowed in element ul in this context." - "Stray end tag span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit cc26fefeebc7ad5af08a087d6dd57c1eb9a6d5b4 Author: Mark Tompsett Date: Mon Jun 17 14:59:03 2019 +0000 Bug 22783: (follow up) not SET for anonymous BLOCK Fixed syntax. http://www.template-toolkit.org/docs/manual/Directives.html#section_BLOCK Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit b86766a3e2148582a2c191e168ad4a65e5d8d0be Author: Martin Renvoize Date: Fri Apr 26 14:52:39 2019 +0100 Bug 22783: Make 'OPAC News' string translatable The idea was to use an anonymous block Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 42a26a758079830758a51845b4526e681b75d434 Author: Mark Tompsett Date: Thu Jun 13 19:27:00 2019 +0000 Bug 17526: Change grep to deal with malformed sortfield Giving sortfield a malformed value when viewing lists results in Internal Server Error. eg. http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=1&sortfield=title( Note the trailing ( Before Patch: kaboom apply patch restart After Patch: No kaboom Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 6a75f99200f6659d09e46ce9e11c5ded11020d89 Author: Mark Tompsett Date: Mon Jun 17 13:54:39 2019 +0000 Bug 23104: (follow-up) fix display for 0/Unlimited Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 5b7e563f4e923bb5cf9f6b1f6ecef3bdc8b77f52 Author: Jonathan Druart Date: Thu Jun 13 11:28:40 2019 -0500 Bug 23104: Add tests for maxonsiteissueqty Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 8c8e36cf7abf51113654c5e1c0497f918a1cd56c Author: Jonathan Druart Date: Wed Jun 12 09:12:27 2019 -0500 Bug 23104: (bug 18925 follow-up): Fix null/empty behavior, again Not kidding, it's again, and will certainly appear more. The problem is that we should have a NULL value in DB to make things more readable and logical. Now we need a quick fix. Test plan: Set "Current checkouts allowed" to unlimited (empty string) Try to check an item out => Without this patch we are blocked with a "too many" message => With this patch applied the correct behavior is back! Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 1521a5567ea17c8adf5339249251bb275b5109de Author: Jonathan Druart Date: Wed Jun 12 09:12:23 2019 -0500 Bug 23104: Add tests Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- .../prog/en/modules/admin/smart-rules.tt | 4 +-- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- .../prog/en/modules/tools/koha-news.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 13 ++++----- opac/opac-shelves.pl | 2 +- t/db_dependent/Circulation/TooMany.t | 28 +++++++++++++++++++- 7 files changed, 40 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 18 13:43:09 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 18 Jun 2019 11:43:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-97-g6dd4071 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6dd40712c1c20af3408c50546d9b97560082ce2c (commit) via a7513c0dc69f3a9bff55c77495389cb73be50965 (commit) from 7b0dbb136310028e756f22b73745dbd9c542a271 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6dd40712c1c20af3408c50546d9b97560082ce2c Author: Martin Renvoize Date: Fri Jun 14 12:33:08 2019 +0100 Bug 22210: (QA follow-up) Tiny gramatical correction Signed-off-by: Martin Renvoize commit a7513c0dc69f3a9bff55c77495389cb73be50965 Author: Alex Arnaud Date: Thu May 16 18:07:12 2019 +0200 Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org", - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: admin/share_content.pl | 6 ++---- .../intranet-tmpl/prog/en/modules/admin/share_content.tt | 11 ++++------- 2 files changed, 6 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 18 19:26:58 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 18 Jun 2019 17:26:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-118-g60ba3e8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 60ba3e8c639bf4ade1b3d837250468b979da4728 (commit) via c3cc7c06b39f1a47238dc50175de07668e5c2668 (commit) via 688967e6eaab4c1f5670cbef254cb4a7101c4e18 (commit) via 0cca2795cdae643a6a94b95ad7879c363006cfed (commit) via 4adb1791c66a3577d32f10c417e4953a86f5769f (commit) via c13eb384b3db124611bbe1c8d49df3017bfe86f9 (commit) via 3175eebdfcb9a8bd0c7fa3cfd456e928c081976f (commit) via 0bdb41bf1a7aaec3cbcde969527113b59b72144a (commit) via 493292b36c1513a90415d144ec72c10e36ff7968 (commit) via 22aa6ecd478c1c5a08eecb2780f5c0b1b7589b99 (commit) via 81186ea2696dd23f37e539cc25b73e6355ffddc0 (commit) via f380a06cb99c99f74c3475a3b93f18ca9883a8b1 (commit) via 50bdd416e68e76c573932b01ea97e4b241171d87 (commit) via a080ffdf76bf3056f0c422d632f87bb2b8a92d92 (commit) via e42b571269dfb737ec7184f67ff95b7a6ff3a692 (commit) via b4088b93a4fc26b442d43eafad98025ca11441d0 (commit) via 96c0c7d0bd7326809de4929e52b6c98c525e8cff (commit) via 3f16d3b8e5d9f5deed2705d2de684b2e5850e210 (commit) via 2270ab4056972b669ab24189979924a0243fa282 (commit) via 9d81b1dd7ad1bb2957630e1ec40d636d8839bb16 (commit) via 1ed59cbe5565ca493702691d3a8811f4ebc4da17 (commit) from 6dd40712c1c20af3408c50546d9b97560082ce2c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 60ba3e8c639bf4ade1b3d837250468b979da4728 Author: Agustin Moyano Date: Thu May 16 00:09:38 2019 -0300 Bug 22835: (follow-up) Remove comented code Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit c3cc7c06b39f1a47238dc50175de07668e5c2668 Author: Agustin Moyano Date: Fri May 3 00:15:12 2019 -0300 Bug 22835: (follow-up) Remove unwanted warn Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 688967e6eaab4c1f5670cbef254cb4a7101c4e18 Author: Agustin Moyano Date: Thu Apr 25 02:13:37 2019 -0300 Bug 22835: Serve plugin static files through API This patch serves static files declared within plugins. To declare static files the plugin must implement the method 'static_routes' which retrieves the spec of static file routes to add to the API. Once those routes are added to the API, the become available through the /api/v1/contrib//static//// endpoint. To test: 1) Install bug-22835-plugin.kpz 2) Point your browser to /api/v1/contrib/kitchensink/static/static_files/mm.gif CHECK => No file is served 3) Apply this patch 4) restart_all 5) Repeat step 2. SUCCESS => File is served! 6) Sign off Sponsored-by: Theke Solutions Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 0cca2795cdae643a6a94b95ad7879c363006cfed Author: Tomas Cohen Arazi Date: Thu May 2 15:51:30 2019 -0300 Bug 22834: Add Koha::Plugins::Base->bundle_path This patch adds a 'bundle_path' method that return the base path for assets included in the plugin. The idea is that it will be used for calculation of the absolute path in the filesystem for static content. To test: - Apply the unit tests patch - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: The method is not implemented - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 4adb1791c66a3577d32f10c417e4953a86f5769f Author: Tomas Cohen Arazi Date: Thu May 2 15:51:17 2019 -0300 Bug 22834: Add tests for Koha::Plugins::Base->bundle_path Signed-off-by: Arthur Suzuki Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit c13eb384b3db124611bbe1c8d49df3017bfe86f9 Author: Martin Renvoize Date: Tue Jun 18 17:23:15 2019 +0100 Bug 21073: DBRev 19.06.00.006 Signed-off-by: Martin Renvoize commit 3175eebdfcb9a8bd0c7fa3cfd456e928c081976f Author: Tomas Cohen Arazi Date: Mon Jun 17 08:18:48 2019 -0300 Bug 21073: (QA follow-up) Avoid unnecessary unless/else construct Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 0bdb41bf1a7aaec3cbcde969527113b59b72144a Author: Tomas Cohen Arazi Date: Mon Jun 17 08:17:43 2019 -0300 Bug 21073: (QA follow-up) Don't call -> twice! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 493292b36c1513a90415d144ec72c10e36ff7968 Author: Tomas Cohen Arazi Date: Mon Jun 17 08:07:03 2019 -0300 Bug 21073: (QA follow-up) Simplify logic This patch simplifies the logic inside GetPlugins so: - It uses Koha::Plugins::Methods instead of plain SQL - It doesn't do more DB calls than needed, by filtering on method in the initial query to Koha::Plugins::Methods. It also relies on the (newly introduced) ->is_enabled method in Koha::Plugins::Base, for better readability. To test: - Run the tests and notice no behaviour changes are introduced. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 22aa6ecd478c1c5a08eecb2780f5c0b1b7589b99 Author: Tomas Cohen Arazi Date: Mon Jun 17 08:06:23 2019 -0300 Bug 21073: (QA follow-up) Add ->is_enabled and tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 81186ea2696dd23f37e539cc25b73e6355ffddc0 Author: Tomas Cohen Arazi Date: Fri Jun 14 16:51:07 2019 -0300 Bug 21073: (QA follow-up) Only public subs should be considered Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit f380a06cb99c99f74c3475a3b93f18ca9883a8b1 Author: Tomas Cohen Arazi Date: Fri Jun 14 16:38:15 2019 -0300 Bug 21073: (follow-up) Add Class::Inspector to PerlDependencies Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 50bdd416e68e76c573932b01ea97e4b241171d87 Author: Agustin Moyano Date: Wed May 15 20:49:08 2019 -0300 Bug 21073: (follow-up) QA fixes after rebase Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit a080ffdf76bf3056f0c422d632f87bb2b8a92d92 Author: Tomas Cohen Arazi Date: Thu May 2 13:15:49 2019 -0300 Bug 21073: Restore filtering by metadata This patch restores filtering the plugins by metadata. That got lost on rebase at some point. Regression tests are added on a prior patch. To test: - Have the 'regression tests for GetPlugins' patch applied - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit e42b571269dfb737ec7184f67ff95b7a6ff3a692 Author: Tomas Cohen Arazi Date: Thu May 2 14:00:52 2019 -0300 Bug 21073: Regression tests for GetPlugins Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit b4088b93a4fc26b442d43eafad98025ca11441d0 Author: Tomas Cohen Arazi Date: Thu May 2 12:12:10 2019 -0300 Bug 21073: (QA follow-up) Remove unused libraries Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 96c0c7d0bd7326809de4929e52b6c98c525e8cff Author: Tomas Cohen Arazi Date: Thu May 2 12:14:50 2019 -0300 Bug 21073: (QA follow-up) Restore check on template Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 3f16d3b8e5d9f5deed2705d2de684b2e5850e210 Author: Tomas Cohen Arazi Date: Thu May 2 11:42:18 2019 -0300 Bug 21073: (QA follow-up) Atomic update shouldn't fail if plugins are disabled Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 2270ab4056972b669ab24189979924a0243fa282 Author: Kyle M Hall Date: Mon Apr 22 09:58:18 2019 -0400 Bug 21073: Upgrade the kitchen sink plugin to get rid of warnings Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 9d81b1dd7ad1bb2957630e1ec40d636d8839bb16 Author: Kyle M Hall Date: Fri Jul 13 12:40:52 2018 -0400 Bug 21073: Improve plugin performance Right now, to check if a plugin is functional and what methods it exposes we load the module and test for a given method at run time. This is highly inefficient. It makes far more sense to do this at install time and store the data in the db. I believe we should store a table of methods that each plugin exposes and check that instead. Then, at install time we can test that a) the plugin can be loaded and b) add the available methods to the plugin_methods table. Test Plan: 1) Apply this patch 2) Restart all the things 3) Run updatedatabase.pl 4) Verify you can use existing plugins 5) Verify you can install new plugins Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 1ed59cbe5565ca493702691d3a8811f4ebc4da17 Author: Kyle M Hall Date: Fri Jul 13 08:55:32 2018 -0400 Bug 21073: Add new table, schema and classes Signed-off-by: Agustin Moyano Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 5 + Koha.pm | 2 +- Koha/Plugins.pm | 83 +++++++++-- Koha/Plugins/Base.pm | 30 ++++ Koha/Plugins/Handler.pm | 17 +-- Koha/{FieldMapping.pm => Plugins/Method.pm} | 6 +- Koha/{BiblioFrameworks.pm => Plugins/Methods.pm} | 14 +- Koha/REST/Plugin/PluginRoutes.pm | 42 ++++-- Koha/REST/V1/Static.pm | 84 +++++++++++ Koha/Schema/Result/PluginMethod.pm | 67 +++++++++ installer/data/mysql/kohastructure.sql | 11 ++ installer/data/mysql/updatedatabase.pl | 20 +++ plugins/plugins-upload.pl | 6 +- t/db_dependent/KitchenSinkPlugin.kpz | Bin 75857 -> 81187 bytes t/db_dependent/Plugins.t | 168 ++++++++++++++++++---- t/lib/Koha/Plugin/Test.pm | 4 + 16 files changed, 482 insertions(+), 77 deletions(-) copy Koha/{FieldMapping.pm => Plugins/Method.pm} (88%) copy Koha/{BiblioFrameworks.pm => Plugins/Methods.pm} (81%) create mode 100644 Koha/REST/V1/Static.pm create mode 100644 Koha/Schema/Result/PluginMethod.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 19 11:15:21 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 19 Jun 2019 09:15:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-119-ga2d38d7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a2d38d7c301eeb31226a6549b429fe80f34d8283 (commit) from 60ba3e8c639bf4ade1b3d837250468b979da4728 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a2d38d7c301eeb31226a6549b429fe80f34d8283 Author: Tomas Cohen Arazi Date: Tue Jun 18 16:36:42 2019 -0300 Bug 21073: (QA follow-up) Fix typo in class name Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Plugins/Methods.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 19 14:42:15 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 19 Jun 2019 12:42:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-125-gb40cc9d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b40cc9d7ac3e78fc948ca79ba0c537e4cf6c5618 (commit) via 313a92324ab892179ca774742e336dc156b30a4a (commit) via 34fc14772643a9c9e2868785dbb424a36d26be61 (commit) via ce8169fc214f68f46c30dbd7ea3fbd3950a68bc7 (commit) via e6e6867ed67d794d334933a13575734c72d0c58f (commit) via 453b7b354f78513cdbdd6a0897f53b3b89b168b9 (commit) from a2d38d7c301eeb31226a6549b429fe80f34d8283 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b40cc9d7ac3e78fc948ca79ba0c537e4cf6c5618 Author: Owen Leonard Date: Mon Jun 10 16:49:36 2019 +0000 Bug 22851: Style navigation links in serials modules like same links in other modules This patch makes minor markup changes to the serials sidebar menu include so that links are displayed in a style consistent with similar menus in other areas of the staff client. This patch contains whitespace changes, so please use the "-w" flag when viewing the diff. To test, apply the patch and go to the Serials module. The links in the sidebar menu should be displayed in the same style as the corresponding menu on the Acquisitions home page. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 313a92324ab892179ca774742e336dc156b30a4a Author: Owen Leonard Date: Fri Jun 14 14:59:34 2019 +0000 Bug 23122: When searching callnumber in simple search, search option is not retained This patch copies some code and markup from the staff client where call number phrase searches are correctly handled. A check for 'ms_callnumcommaphr' is copied from search_indexes.inc. Handling of commas and dashes is copied from search.pl. To test, apply the patch and make sure the OpacAddMastheadLibraryPulldown system preference is enabled. - From the OPAC main page, select "Call number" from the search pull down at the top of the page. - Perform any search (it need not return results). - Verify that the search option retains the "Call number" selection. - Repeat the test with and without the OPACNumbersPreferPhrase system preference enabled. Signed-off-by: Maryse Simard Signed-off-by: Nadine Pierre Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 34fc14772643a9c9e2868785dbb424a36d26be61 Author: Owen Leonard Date: Thu Jun 6 12:24:41 2019 +0000 Bug 23061: Add column/print/export feature on checkout history page This patch adds columns configuration and export features to the checkout history page. This patch also removes some inline CSS: "overflow:hidden" from both the checkout and holds history pages. This was breaking the table controls tooltips, and didn't appear to me to be necessary. To test, apply the patch and restart Plack (or restart_all on kohadevbox). - Open a patron's checkout history page in the staff client. - The table of checkouts should have controls at the top. for columns configuration and export/print. - These controls should work correctly. Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit ce8169fc214f68f46c30dbd7ea3fbd3950a68bc7 Author: Petter von Krogh Date: Wed May 22 15:38:21 2019 +0000 Bug 22966: Add Norwegian library and patron names for installer THe Norwegian installer had reused english smaple atrons and libraries, this patch fixes this. test plan: empty database install norwegian translation run the web-installer and choose norwegian language select sample libraries and patrons make sure there are no errors Signed-off-by: Chris Cormack I trust Petter with Norwegian names, so I didn't spell check them :) Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit e6e6867ed67d794d334933a13575734c72d0c58f Author: Martin Renvoize Date: Wed Jun 19 13:07:23 2019 +0100 Bug 22653: DBRev 19.06.00.007 Signed-off-by: Martin Renvoize commit 453b7b354f78513cdbdd6a0897f53b3b89b168b9 Author: Katrin Fischer Date: Mon Jun 17 21:12:25 2019 +0000 Bug 22653: Remove unimplemented RotationPreventTransfers system preference This removes the RotationPreventTransfers system preference from updated and new installations. To test: - Verify you have the RotationPreventTransfers pref - Apply patch and run database update - Verify the preference no longer exists in your system - in the sys pref editor - in your database: SELECT * from systempreferences WHERE variable = "RotationPreventTransfers"; Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- admin/columns_settings.yml | 27 ++++++ .../mysql/nb-NO/2-Valgfritt/sample_libraries.sql | 24 ++--- .../mysql/nb-NO/2-Valgfritt/sample_libraries.txt | 2 +- .../mysql/nb-NO/2-Valgfritt/sample_patrons.sql | 100 ++++++++++---------- .../mysql/nb-NO/2-Valgfritt/sample_patrons.txt | 2 +- installer/data/mysql/sysprefs.sql | 1 - installer/data/mysql/updatedatabase.pl | 7 ++ .../prog/en/includes/serials-menu.inc | 72 +++++++------- .../en/modules/admin/preferences/circulation.pref | 6 -- .../prog/en/modules/members/holdshistory.tt | 2 +- .../prog/en/modules/members/readingrec.tt | 13 ++- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 6 +- opac/opac-search.pl | 5 +- 14 files changed, 154 insertions(+), 115 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 19 21:39:35 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 19 Jun 2019 19:39:35 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-28-g8351bfe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 8351bfeb5f0916835ba1e0328990c27986efb373 (commit) from 1a23c045dea4744c86e0e9cb47f129737cb8843f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8351bfeb5f0916835ba1e0328990c27986efb373 Author: Nick Clemens Date: Wed Jun 5 13:55:10 2019 +0000 Bug 23053: Add phrase index to authority Local-Number To test: 1 - Define a matching rule for authorities on field 001 index Local-Number 2 - In koha-conf.xml raise the zebra_loglevels none,fatal,warn,request,info 3 - Export some authorities using the tools->export data 4 - Import those authorities 5 - Note no matches found 6 - View the zebra output log, you should see lots of error 114 7 - Apply patch 8 - Copy the indexdefs files to the installed versions 9 - Reapply matchign rules to staged files 10 - Matches should now be found 11 - Logs should not have errors Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 2e8a6a4b097f7ed7bb33efe819693752abba33cb) Signed-off-by: Fridolin Somers (cherry picked from commit 3cd32c995e7fc2caeee3a3eed63b426226524057) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../marc_defs/marc21/authorities/authority-koha-indexdefs.xml | 1 + .../marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 19 21:43:47 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 19 Jun 2019 19:43:47 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-30-gd16af25 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via d16af2544c62552ac6e8c96b18bb4cd4eb6fe1cb (commit) via 3133d4e46b023cac18ab37abfb81b77d18a5f53b (commit) from 8351bfeb5f0916835ba1e0328990c27986efb373 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d16af2544c62552ac6e8c96b18bb4cd4eb6fe1cb Author: Kyle M Hall Date: Mon Mar 25 13:55:43 2019 -0400 Bug 18344: Add unit tests Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 60e24be115539daedc4172099eec9cc5dd5bc813) Signed-off-by: Fridolin Somers (cherry picked from commit 8981df1cf0c2761dc891870aa780716f30d4be1f) Signed-off-by: Lucas Gass commit 3133d4e46b023cac18ab37abfb81b77d18a5f53b Author: Kyle M Hall Date: Tue Mar 28 11:05:28 2017 +0000 Bug 18344: Allow overdue fines cap at replacement price, and cap by amount to work together There is no reason that a library shouldn't be able to use the monetary fines cap and the replacement price cap at the same time. The code is written in such a way that they already work harmoniously. We have librarians who wish to use both so they can set a high cap of $10.00 but also use the replacement price cap so that a $20.00 book would only get a fine of $10.00, but a $5.00 paperback will only get a fine of $5.00 Test Plan: 1) Apply this patch 2) Create a rule with a fines cap of $10, *and* a cap at replacement price, and a daily fine of $1 3) Create two items, one with a replacement price of $5 and one with a replacement price of $15 4) Check out these items to a patron, backdate the checkouts so they are already overdue by a couple months 5) Check the items in ( make sure calc fine at checkin is enabled for you ) 6) Note the one item has a fine of $5 and the other has a fine of $10! Signed-off-by: David Kuhn Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit e702ff89f77e50b1bcef1cdc1548627957251df0) Signed-off-by: Fridolin Somers (cherry picked from commit 9ea56e1cd958d225be0ba7e1861804b7ce7e8542) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/smart-rules.tt | 3 -- t/db_dependent/Circulation/CalcFine.t | 46 +++++++++++++++++++- 2 files changed, 45 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 20 09:55:29 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 20 Jun 2019 07:55:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-126-gef92de0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ef92de033d37b0a5d10ff4f309e71e9dd9e38039 (commit) from b40cc9d7ac3e78fc948ca79ba0c537e4cf6c5618 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ef92de033d37b0a5d10ff4f309e71e9dd9e38039 Author: Tomas Cohen Arazi Date: Wed Jun 19 15:38:20 2019 -0300 Bug 21073: (QA follow-up) Fix plugin-related tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/ImportBatch.t | 5 ++++- t/db_dependent/Koha/REST/Plugin/PluginRoutes.t | 10 ++++++++-- t/db_dependent/Koha/Template/Plugin/KohaPlugins.t | 4 +++- 3 files changed, 15 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 20 11:15:29 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 20 Jun 2019 09:15:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-132-gc67ce9c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c67ce9cc9b492e2eaaaaf951a555e59d3cba69fd (commit) via 42b1e5e8805027b0c4bc9830c1cc2f45a6f46374 (commit) via b976bad50a03ca4d4fa369e2c5371ec35dfb0d5f (commit) via 054094835d586e06e0d116c02deb310030b30f09 (commit) via 8bf07f36085741443962a5637c1afdb7c0822d19 (commit) via 5168edaf1e7742b28d256e3b5c8530da410d142c (commit) from ef92de033d37b0a5d10ff4f309e71e9dd9e38039 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c67ce9cc9b492e2eaaaaf951a555e59d3cba69fd Author: Martin Renvoize Date: Thu Jun 20 09:46:50 2019 +0100 Bug 23130: Add David Nind to contributors Signed-off-by: Martin Renvoize commit 42b1e5e8805027b0c4bc9830c1cc2f45a6f46374 Author: Martin Renvoize Date: Thu Jun 20 09:44:26 2019 +0100 Bug 22966: Add Petter von Krogh to contributors Signed-off-by: Martin Renvoize commit b976bad50a03ca4d4fa369e2c5371ec35dfb0d5f Author: Fridolin Somers Date: Mon Jun 17 16:28:22 2019 +0200 Bug 23132: Fix encoding issues in facets with show more link When one uses characters like ?, ? ... the first searcshow up correctly but when you refine your search with "Show more", the encoding becomes bad and so, results of the search too. Test plan : Without the patch: - check if you have your SysPref SearchEngine with Elasticsearch as value, - put your SysPref FacetMaxCount at 10, - search in the catalog "a" and then in Refine your search click on show more (just to see how it works), - then search with special characters like "?", ?" ... and make the same test, the research should be wrong when you click on show more and the page is realoaded. Then apply the patch: - and make the same with a classic reasearch, then with special characters, - verify that when you click on show more the page isn't realoded and the reasearch is correct. - same with show less - and finnaly, add some facets and test show more/less Signed-off-by: Jonathan Druart Signed-off-by: Julian Maurice Signed-off-by: Martin Renvoize commit 054094835d586e06e0d116c02deb310030b30f09 Author: David Nind Date: Sat Jun 15 01:43:39 2019 +0000 Bug 23130: Fix alternative mana server URL in etc/koha-conf.xml If the alternative mana KB server URL in etc/koha-conf.xml is used it causes an error message like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "\r\nhttp://mana-test.koha-community.org to /etc/koha/sites//koha-conf.xml (see etc/koha-conf.xml in the Koha code repository for an example of where to add this; if using koha-testing-docker is kohadev). 2) Clear memcached and restart services so that the changes to your Koha instance configuration are recognised (if using koha-testing-docker run flush_memcached and then restart_all). 3) From the staff client home page go to Koha administration > Additional parameters > Share content with Mana KB. 4) Enable content sharing: change 'Use Mana KB for sharing content' to Yes and press Save. 5) Enter your first name, last name and email address in the Configure Mana KB section of the page and then click on 'Send to Mana KB'. 6) An error message is displayed, this may be something like: 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "\r\n Signed-off-by: Julian Maurice Signed-off-by: Martin Renvoize commit 8bf07f36085741443962a5637c1afdb7c0822d19 Author: Julian Maurice Date: Wed Jun 19 14:22:00 2019 +0200 Bug 23144: (QA follow-up) Fix another POD error in svc/barcode Signed-off-by: Julian Maurice Signed-off-by: Martin Renvoize commit 5168edaf1e7742b28d256e3b5c8530da410d142c Author: Nick Clemens Date: Mon Jun 17 19:20:55 2019 +0000 Bug 23144: Replace missing =cut in svc/header Signed-off-by: Mark Tompsett Signed-off-by: Julian Maurice Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: docs/contributors.yaml | 7 ++++++- docs/history.txt | 2 ++ etc/koha-conf.xml | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 2 +- svc/barcode | 4 +++- 5 files changed, 13 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 20 14:50:10 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 20 Jun 2019 12:50:10 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.00-63-gb728906 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via b728906d349a901e4ca443c2dcea9815020b3a9f (commit) via 9aac2c9051922d16c7f726dc72ed6c95c3c932a5 (commit) via 5a1a3f0161ae15536137454dc1affb1724e9b58b (commit) via 62532449a70ff00649862f69cbc10d97903b0eca (commit) via b9131f2763223f29bf6a1960257d8a499290619b (commit) from 8710c15c8aa074d54d6a04f6cbd2d8c0a3796d67 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b728906d349a901e4ca443c2dcea9815020b3a9f Author: Martin Renvoize Date: Sat Jun 15 07:50:43 2019 +0100 Bug 22770: DBRev 19.05.00.003 Signed-off-by: Martin Renvoize (cherry picked from commit 4452273669c98bcbaf409dc653d01d5596ca415a) Signed-off-by: Fridolin Somers commit 9aac2c9051922d16c7f726dc72ed6c95c3c932a5 Author: Katrin Fischer Date: Sun Jun 2 10:48:00 2019 +0200 Bug 22770: Fix typo in German language description of el Fixes: Griechisch (Moern [1453- ] ==> Griechisch (Modern 1453-) To test: - Install de-DE language and activate it - Check the language pull down on advanced search has the typo - Apply patch and run database update - Check advanced search again - Verify the description now shows correctly Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Martin Renvoize (cherry picked from commit eba980b3519263856c725cd42d4ff151d7822205) Signed-off-by: Fridolin Somers commit 5a1a3f0161ae15536137454dc1affb1724e9b58b Author: Jonathan Druart Date: Sat Jun 8 14:45:33 2019 -0500 Bug 22941: Do not return 500 if sortfield contain parenthesis Test plan: Hit /virtualshelves/shelves.pl?op=view&shelfnumber=1&sortfield=author( You must not get: Unmatched ( in regex; marked by <-- HERE in m/^author( <-- HERE $/ at /home/vagrant/kohaclone/virtualshelves/shelves.pl line 236 Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize Signed-off-by: Martin Renvoize (cherry picked from commit f8db499f4a9c71e7a2ffef0fadaecddb938330d4) Signed-off-by: Fridolin Somers commit 62532449a70ff00649862f69cbc10d97903b0eca Author: Martin Renvoize Date: Thu Jun 13 13:08:58 2019 +0100 Bug 21662: (RM follow-up) Final followup corrections to history Minor update to ensure we're using commit dates and not author dates Signed-off-by: Martin Renvoize (cherry picked from commit 510cf514a342cb9062d1c51cdf1d41b6772ad90a) Signed-off-by: Fridolin Somers commit b9131f2763223f29bf6a1960257d8a499290619b Author: Katrin Fischer Date: Wed Apr 3 21:47:09 2019 +0200 Bug 22633: Link barcodes in hold summary in patron account to moredetail page Bug 21070 links the barcode on holds to the item on moredetail.pl. This patch makes the same change to the hold lists in the staff patron account. To test: - Create some holds, have at least - one item level hold - one hold waiting for pick-up - Take a look at the details and checkouts tabs in the patron account on staff side - Verify that the barcodes link to the record detail page - Apply patch - Verify the barcodes now link to the moredetail page Signed-off-by: Axel Amghar Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize (cherry picked from commit ad9338e419ee04c38f5e7fdc918ce1a4d177cee0) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- docs/contributors.yaml | 4 ++-- docs/history.txt | 11 ++++++----- installer/data/mysql/mandatory/subtag_registry.sql | 2 +- installer/data/mysql/updatedatabase.pl | 8 ++++++++ koha-tmpl/intranet-tmpl/prog/js/holds.js | 4 ++-- virtualshelves/shelves.pl | 2 +- 7 files changed, 21 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 20 16:29:11 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 20 Jun 2019 14:29:11 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.00-77-g0529975 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0529975851150363a64e1528c84db29d0872ada9 (commit) via bf11cd06c556322fe0ed52c3cbf0352ff0bdcc5f (commit) via cf1c06e8f059b6ac017132fa451d9e5df0d6c4f2 (commit) via aeb70dd2d280d6dd912bebdfa2202c86723dd72e (commit) via 1f0c8fd9bdd819f872a287538de976ccbea0cbda (commit) via 2def4aee187eeaf3fb48b3ebfaa85ce6c48f2fe6 (commit) via b57aaed3fffeb4017dbde770bd30cb4ea5a74097 (commit) via 8c8d86ef30f38d13f75d7ed1600b3d27b70a6568 (commit) via a8cc9d5f49f36a5bf69265f3062f1a7a8ee0fdf4 (commit) via 16858fd5d5b14680bce00a5c7c85c62c9584980e (commit) via 6a3c93eeeba7d6457af22cb31c6464e3ac5786f9 (commit) via eecce39379b590aa6615d63da109431358d03846 (commit) via d017e2f7c412001677b2cec08781977d5935e8ee (commit) via 7bd5324c58181323a665aa2cf036de0f933b8f49 (commit) from b728906d349a901e4ca443c2dcea9815020b3a9f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0529975851150363a64e1528c84db29d0872ada9 Author: Owen Leonard Date: Tue May 21 12:07:10 2019 +0000 Bug 22945: Markup error in OPAC search results around lists display This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, perform a search in the OPAC which will return results which are on one or more lists. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Text not allowed in element ul in this context." - "Stray end tag span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 1efe0d4606f844c28e2524d0341779381fc4980b) Signed-off-by: Fridolin Somers commit bf11cd06c556322fe0ed52c3cbf0352ff0bdcc5f Author: Mark Tompsett Date: Thu Jun 13 19:27:00 2019 +0000 Bug 17526: Change grep to deal with malformed sortfield Giving sortfield a malformed value when viewing lists results in Internal Server Error. eg. http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=1&sortfield=title( Note the trailing ( Before Patch: kaboom apply patch restart After Patch: No kaboom Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 42a26a758079830758a51845b4526e681b75d434) Signed-off-by: Fridolin Somers commit cf1c06e8f059b6ac017132fa451d9e5df0d6c4f2 Author: Mark Tompsett Date: Mon Jun 17 13:54:39 2019 +0000 Bug 23104: (follow-up) fix display for 0/Unlimited Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 6a75f99200f6659d09e46ce9e11c5ded11020d89) Signed-off-by: Fridolin Somers commit aeb70dd2d280d6dd912bebdfa2202c86723dd72e Author: Jonathan Druart Date: Thu Jun 13 11:28:40 2019 -0500 Bug 23104: Add tests for maxonsiteissueqty Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 5b7e563f4e923bb5cf9f6b1f6ecef3bdc8b77f52) Signed-off-by: Fridolin Somers commit 1f0c8fd9bdd819f872a287538de976ccbea0cbda Author: Jonathan Druart Date: Wed Jun 12 09:12:27 2019 -0500 Bug 23104: (bug 18925 follow-up): Fix null/empty behavior, again Not kidding, it's again, and will certainly appear more. The problem is that we should have a NULL value in DB to make things more readable and logical. Now we need a quick fix. Test plan: Set "Current checkouts allowed" to unlimited (empty string) Try to check an item out => Without this patch we are blocked with a "too many" message => With this patch applied the correct behavior is back! Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 8c8e36cf7abf51113654c5e1c0497f918a1cd56c) Signed-off-by: Fridolin Somers commit 2def4aee187eeaf3fb48b3ebfaa85ce6c48f2fe6 Author: Jonathan Druart Date: Wed Jun 12 09:12:23 2019 -0500 Bug 23104: Add tests Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 1521a5567ea17c8adf5339249251bb275b5109de) Signed-off-by: Fridolin Somers commit b57aaed3fffeb4017dbde770bd30cb4ea5a74097 Author: Martin Renvoize Date: Mon Jun 17 08:30:13 2019 +0100 Bug 10215: (RM follow-up) Rebuid DBIC classes Signed-off-by: Martin Renvoize (cherry picked from commit a3cf29c5f714b5888718885f5a0cf2576a6cb5be) Signed-off-by: Fridolin Somers commit 8c8d86ef30f38d13f75d7ed1600b3d27b70a6568 Author: Jonathan Druart Date: Thu Jun 13 11:06:29 2019 -0500 Bug 23117: Shortcut additem.pl on nonexistent biblionumber To prevent additem.pl to crash when called with a nonexistent biblionumber we are here implementing the blocking_error.inc trick to display a friendly message instead. Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test plan: hit /cataloguing/additem.pl?biblionumber= /cataloguing/additem.pl?biblionumber=424242 You will get a friendly "Bibliographic record not found." message, instead of a 500 Signed-off-by: Bin Wen Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 62ae7ac7275329f6396d656a216ffc95b4f9494a) Signed-off-by: Fridolin Somers commit a8cc9d5f49f36a5bf69265f3062f1a7a8ee0fdf4 Author: Fridolin Somers Date: Wed May 29 15:20:41 2019 +0200 Bug 21534: Always compute wildcards You get no results when searching with an hyphen + with * in query string (or with preference QueryAutoTruncate) : ie /cgi-bin/koha/opac-search.pl?q=saints-anges* Looks like query-string by default does not compute wildcards, see analyze_wildcard in : https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html Test plan : 1) Use Elasticsearch 2) Create a record with "saints-anges" 3) Search for "saints-anges" => you get results 4) Search for "saints-anges*" => you get results 5) Search for "saints-ang*" => you get results Signed-off-by: Michal Denar Signed-off-by: Arthur Bousquet Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 001d433b427731a6efd55208ac3169107c830730) Signed-off-by: Fridolin Somers commit 16858fd5d5b14680bce00a5c7c85c62c9584980e Author: Martin Renvoize Date: Sat Jun 15 07:55:35 2019 +0100 Bug 22358: (RM follow-up) Typo fix Signed-off-by: Martin Renvoize (cherry picked from commit 0e8a95b4bdcde76646ad3a45a2022d82e6da277e) Signed-off-by: Fridolin Somers commit 6a3c93eeeba7d6457af22cb31c6464e3ac5786f9 Author: Nick Clemens Date: Fri Jun 14 17:40:52 2019 +0000 Bug 22358: (QA follow-up) Clear up phrasing Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit a72feaa40cbcf34f8f77ecac58ca6b269e9b95c9) Signed-off-by: Fridolin Somers commit eecce39379b590aa6615d63da109431358d03846 Author: Alex Arnaud Date: Thu Jun 6 12:00:22 2019 +0200 Bug 22358: fix POD header and typo Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 5438355b1d016b2699ea2efc5367eaa8d807496d) Signed-off-by: Fridolin Somers commit d017e2f7c412001677b2cec08781977d5935e8ee Author: Alex Arnaud Date: Wed Mar 13 15:14:31 2019 +0100 Bug 22358: Add POD to Koha::SharedContent Signed-off-by: Liz Rea Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit c6540d1b72d45b2682860fc50716b0d74e3f5e2c) Signed-off-by: Fridolin Somers commit 7bd5324c58181323a665aa2cf036de0f933b8f49 Author: Jonathan Druart Date: Wed Jun 5 19:11:59 2019 -0500 Bug 23022: Remove the SQl mode NO_AUTO_CREATE_USER To make our sql mode list compatible with MySQL 8.0.11 NO_AUTO_CREATE_USER has been removed in MySQL 8.0.11 https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-11.html I do not think we needed it. Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 77716188757d11e2a9fa79788ce99982e3c39839) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 2 +- C4/Output.pm | 4 ++ Koha/Database.pm | 4 +- Koha/Schema/Result/Subscriptionhistory.pm | 20 +++---- Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 1 + Koha/SharedContent.pm | 61 ++++++++++++++++---- cataloguing/additem.pl | 4 ++ .../prog/en/modules/admin/smart-rules.tt | 4 +- .../prog/en/modules/cataloguing/additem.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 13 +++-- opac/opac-shelves.pl | 2 +- t/db_dependent/Circulation/TooMany.t | 28 ++++++++- 12 files changed, 108 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 20 18:01:14 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 20 Jun 2019 16:01:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-133-g5be6c78 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5be6c78e6e78bfa34877e5732b61c2f881245edd (commit) from c67ce9cc9b492e2eaaaaf951a555e59d3cba69fd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5be6c78e6e78bfa34877e5732b61c2f881245edd Author: Tomas Cohen Arazi Date: Thu Jun 20 12:03:30 2019 -0300 Bug 23168: Enable plugins using plain SQL To test: - On a clean 18.11.x, install a plugin [1] - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin - Checkout latest master, restart all the things - Run: $ updatedatabase => FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't exist - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => FAIL: No __ENABLED__ line for your plugin - Apply the patch - Run: $ updatedatabase => SUCCESS: Update passes the 18.12.00.069 step correctly - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: There's an __ENABLED__ line for your plugin - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 20 18:32:08 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 20 Jun 2019 16:32:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-134-g5aaae31 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5aaae31a78db533e998044d9f0bc16f7dfda06b1 (commit) from 5be6c78e6e78bfa34877e5732b61c2f881245edd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5aaae31a78db533e998044d9f0bc16f7dfda06b1 Author: Tomas Cohen Arazi Date: Mon Jun 17 12:16:53 2019 -0300 Bug 9834: (QA follow-up) API Corrections Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1/Holds.pm | 2 ++ Koha/Schema/Result/Reserve.pm | 5 +++-- api/v1/swagger/definitions/hold.json | 4 ++++ 3 files changed, 9 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 21 11:36:08 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Jun 2019 09:36:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-138-g2af415a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2af415a866d5ce46c6c243dfc6380b002e323db6 (commit) via 1b24cf26de54a31699b26174a25dfff509651ecc (commit) via 0fd6250ae198dddf09071912e3eb87f7e0702bfd (commit) via f56bba9297087eaeaeefb2aba546c9f107bfad6e (commit) from 5aaae31a78db533e998044d9f0bc16f7dfda06b1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2af415a866d5ce46c6c243dfc6380b002e323db6 Author: Nick Clemens Date: Mon Jun 17 17:58:56 2019 +0000 Bug 23140: Fix typo in branchcode parameters for print slip To test: 1 - Have [% branch.branchcode %] in your TRANSFERSLIP 2 - Checkin an item from another branch (with AutomaticItemReturn = do ) 3 - Inspect the button in the browser to see the typo 4 - Click 'Print slip' 5 - Note the branchcode is not populated 6 - Clear the transfer 7 - Apply patch 8 - Repeat 9 - Note typo is fixed and slip correctly populated Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 1b24cf26de54a31699b26174a25dfff509651ecc Author: Marcel de Rooy Date: Fri Jun 21 07:08:39 2019 +0000 Bug 13640: (QA follow-up) Allow NULL values for default_branch_item_rules.holdallowed If a rule has not been defined for an itemtype or you submit a biblio level hold, you cannot filter on holdallowed<>0. Test plan: Test with a biblio level hold. Have two items; one item should be blocked with a policy. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 0fd6250ae198dddf09071912e3eb87f7e0702bfd Author: Jonathan Druart Date: Mon May 13 09:57:52 2019 -0500 Bug 13640: Do not display unreserveable items on the Holds to pull screen We should only display the items that meet the hold policies Test plan: It would be good to have a huge list of holds displayed on the "Holds to pull" and confirm that the display is now correct. One of the possible test plan has been let in a comment on the bug report: Bib Record A has 2 items: Item Record X (can be placed on hold) Item Record Y (cannot be placed on hold) If you place a bib-level hold on Bib Record A, both Item Record X and Item Record Y show up as available items in the Holds To Pull List. With this patch applied you must not see Y Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit f56bba9297087eaeaeefb2aba546c9f107bfad6e Author: Mark Tompsett Date: Mon Jun 10 14:36:49 2019 -0400 Bug 23090: Add some special characters TEST PLAN --------- $ sudo mysql -u root > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'badpassword'; [Magical MySQL Error] > CREATE USER 'bug23090_test1'@'localhost' IDENTIFIED BY 'GoodP at ssw0rd'; [Should be okay] > DROP USER 'bug23090_test1'@'localhost'; > QUIT $ sudo koha-create --create-db fail23090 [Magical MySQL Error] [Apply this patch and put it (debian/scripts/koha-create) into place in /usr/sbin/koha-create] $ sudo koha-create --create-db pass23090 (Clean up and databases made) Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: circ/pendingreserves.pl | 2 ++ debian/scripts/koha-create | 5 ++++- koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 4 ++-- 3 files changed, 8 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 21 13:53:47 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Jun 2019 11:53:47 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-142-g90d4e3a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 90d4e3a672e8778e30058fe691f83d94b6d379ce (commit) via c7a707d60b187fa2c18c4bacd3a6b472de25da98 (commit) via 95a303c8f351bdd926136b5e9110ba9957df52f1 (commit) via 568d3f82cba2aef475e71624c7eaec2054d234ef (commit) from 2af415a866d5ce46c6c243dfc6380b002e323db6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 90d4e3a672e8778e30058fe691f83d94b6d379ce Author: Martin Renvoize Date: Fri Jun 21 12:28:48 2019 +0100 Bug 23177: (RM follow-up) Further test clarifications This patch makes a few minor improvements to Circulation.t 1) Adds a name to some of the scoped blocks by converting them to subtests. 2) Adds output messages to some tests where they were missing. Signed-off-by: Martin Renvoize commit c7a707d60b187fa2c18c4bacd3a6b472de25da98 Author: Marcel de Rooy Date: Fri Jun 21 09:15:18 2019 +0000 Bug 23177: (QA follow-up) Remove subtest txn_begin and rollback This resolves: DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) Removing unneeded subtest txn's. We should probably add them everywhere or just at global level. Test plan: With all three patches applied, run Circulation.t a few times. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 95a303c8f351bdd926136b5e9110ba9957df52f1 Author: Marcel de Rooy Date: Fri Jun 21 09:03:27 2019 +0000 Bug 23177: (QA follow-up) Move rollback to the end Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 568d3f82cba2aef475e71624c7eaec2054d234ef Author: Marcel de Rooy Date: Fri Jun 21 09:00:27 2019 +0000 Bug 23177: (QA follow-up) Move three subs from the middle to the top in Circulation.t Removed trailing comma for last sub too. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Circulation.t | 159 +++++++++++++++++++++--------------------- 1 file changed, 78 insertions(+), 81 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 21 13:57:48 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Jun 2019 11:57:48 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-144-g3bf26cf Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3bf26cfb934cb699839aabb136df09ea97c030bb (commit) via d2a2e4a8d52c2098dd183e6714b03aed5b6a84bb (commit) from 90d4e3a672e8778e30058fe691f83d94b6d379ce (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3bf26cfb934cb699839aabb136df09ea97c030bb Author: Kyle M Hall Date: Wed Jun 19 07:00:01 2019 -0400 Bug 23103: (QA follow-up) Return undef implicitly Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit d2a2e4a8d52c2098dd183e6714b03aed5b6a84bb Author: Kyle M Hall Date: Wed Jun 12 15:08:08 2019 -0400 Bug 23103: Cannot checkin items lost by deleted patrons with fines attached Test Plan: 1) Checkout an item to a patron 2) Ensure the item has a replacement cost (or itemtype has default) 3) Ensure patrons are charged when items lost 4) Mark the item lost 5) Confirm patron has a fine 6) Write off the fine 7) Delete the patron 8) Check in the item 9) Note the internal server error 10) Apply this patch 11) Repeat steps 1-8 12) Note there is no internal server error! 13) prove t/db_dependent/Circulation.t Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 7 ++++++- t/db_dependent/Circulation.t | 44 +++++++++++++++++++++++++++++++++++++++++- 2 files changed, 49 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 21 14:33:51 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 21 Jun 2019 12:33:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-155-gd08e776 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d08e776cf1e25ffa407bb3a5d668c1b140be6ec2 (commit) via c59586aebe1d8eab56d3cd32b5156fc1a61f11ec (commit) via f6009342a95575dc6b1157c953f5e6e8c249b6d0 (commit) via 206498dc5585fbd555181a1b241d5049632870df (commit) via 49e0384f10f659e337fac1b08e6bdd2c163151ae (commit) via 12a9dfb6593c4d5ccc6936b85c82479c12337309 (commit) via 7a80483a1358a7bc3e516a8fbc92d34b6559dcac (commit) via 6dc8306b58bc1207f396d2df919a3daf4712e8e5 (commit) via 3b14f7d636fea4425b2f6eab922be9aa2a9eed1d (commit) via 48259267f6830b2e388b2a91268117645bda80f3 (commit) via d018953ca1947649c35df8670a385a942c80c134 (commit) from 3bf26cfb934cb699839aabb136df09ea97c030bb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d08e776cf1e25ffa407bb3a5d668c1b140be6ec2 Author: Mark Tompsett Date: Mon Jun 17 17:57:46 2019 +0000 Bug 22571: (follow up) fix Donald cut-&-paste error Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit c59586aebe1d8eab56d3cd32b5156fc1a61f11ec Author: Jonathan Druart Date: Sun May 5 12:41:46 2019 -0500 Bug 22571: Handle control fields in MMT for conditionals Control fields are not handled correctly by Koha::SimpleMARC when comparaison (with or without regex) is done. Which means we did not support something like: Do something if control field 008 equals or matches "a string" Test plan: Create a new MARC modification template and a new action, like: Add new field 100$a with value "foo bar" if 008 (or any other control fields) matches (or equals) a regex Then use the record mofication tool and confirm that the new field is create if the regex matches 008 of the bib record Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit f6009342a95575dc6b1157c953f5e6e8c249b6d0 Author: Jonathan Druart Date: Sun May 5 12:41:43 2019 -0500 Bug 22571: Add tests Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 206498dc5585fbd555181a1b241d5049632870df Author: Fridolin Somers Date: Fri Jun 14 10:43:15 2019 +0200 Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage When logged into the staff client with an account with full circulate permissions (and therefore including the manage_checkout_notes permission) an error occurs when clicking on the Checkout notes pending link. The account is logged out automatically with the message: "Error: you do not have permission to view this page. Log in as a different user". The same error occurs for both the link on the home page dashboard and from the Circulation module button. Works as expected if Superlibrarian permission is set. This is just a typo in perl script : circulation instead of circulate Test plan : 1) Set preference "AllowCheckoutNotes" to "Allow" 2) Create a user with only permissions "catalogue" and "circulate > manage_checkout_notes" 3) Loggin with this user 4) Go to "Circulation" home page 5) Click on "Checkout notes" 6) You should be allowed to access Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 49e0384f10f659e337fac1b08e6bdd2c163151ae Author: Fridolin Somers Date: Wed Jun 19 07:04:25 2019 +0200 Bug 23153: In framework management action subfields must not go directly to edition Since 18.11, when viewing a framework field clicking on Actions > Subfields goes to subfields edition instead of subfields table view. This is because link contains op=add_form. This is is also missing /cgi-bin/koha/admin. Test plan : 1) Go to Administration > MARC bibliographic framework 2) On a line click Actions > MARC structure 3) On a line click Actions > Subfields 4) You see subfields table 5) Click on Edit subfields 6) You see subfields edition tabs Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 12a9dfb6593c4d5ccc6936b85c82479c12337309 Author: Jonathan Druart Date: Mon Jun 17 20:07:29 2019 -0500 Bug 15814: Add missing filters Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 7a80483a1358a7bc3e516a8fbc92d34b6559dcac Author: Jonathan Druart Date: Wed May 29 21:28:23 2019 -0500 Bug 15814: Handle correctly MMTA edit button The MARC modification template action edit buton does not correctly handle variable escaping. Assigning a JS variable containing the JSON representation of the hashref will make the processing much more easier. Test plan: Create a MARC Modification Template with several actions. In the description you should use the following characters, to try to break this patch: \ ' " \n \r (not sure what we handled \n and \r) Then edit the action, modify and save again. Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 6dc8306b58bc1207f396d2df919a3daf4712e8e5 Author: Marcel de Rooy Date: Thu Jun 20 12:37:27 2019 +0000 Bug 23150: (follow-up) Make gdpr_proc_consent mandatory for create When updating (patron modification), the field should not be required. Test plan: Check patron modification on opac. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 3b14f7d636fea4425b2f6eab922be9aa2a9eed1d Author: Jonathan Druart Date: Wed Jun 19 14:49:15 2019 -0500 Bug 23150: Do not consider gdpr_proc_consent a mandatory field It introduced a regression in the patron's self modification feature. Patron's details are no longer modificable, the screen displays "You have not filled out all required fields. Please fill in all missing fields and resubmit." Test plan: - Set GDPR_Policy to either Enforced or Permissive - Set PatronSelfRegistrationBorrowerMandatoryField to empty - Set OPACPatronDetails to Allow - Log into the OPAC - Accept the GDPR screen - Go to opac-memberentry.pl, change something, submit modification request Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 48259267f6830b2e388b2a91268117645bda80f3 Author: Owen Leonard Date: Tue May 21 12:39:09 2019 +0000 Bug 22946: Markup error in OPAC search results around selection links This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, make sure holds and/or tags are enabled in the OPAC. Perform a search in the OPAC which will return multiple results. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "Element div not allowed as child of element span in this context." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit d018953ca1947649c35df8670a385a942c80c134 Author: Katrin Fischer Date: Mon Jun 17 21:35:19 2019 +0000 Bug 23097: Fix regression on overdues report and link patrons to moremember The link from the patron name in the circulation > overdues report shouldn't point to the reserves tab, as this report is about checkouts. The patch restores the behaviour as it was in 17.11. To test: - Make sure you have a patron account with overdue items - If you don't have one, check out an item with specified due date in the past - Go to Circulation > Overdues - Veriy the overdue shows - Click on the patron name that is linked - Verify you go to the checkouts tab in patron account with holds tab selected - Apply patch - Reload Overdues report - Verify the link now leads to the Details tab with the checkouts tab in front Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/SimpleMARC.pm | 12 +++-- circ/checkout-notes.pl | 2 +- .../prog/en/modules/admin/marctagstructure.tt | 2 +- .../intranet-tmpl/prog/en/modules/circ/overdue.tt | 2 +- .../modules/tools/marc_modification_templates.tt | 24 ++------- .../prog/js/marc_modification_templates.js | 53 +++++++++++--------- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 8 +-- opac/opac-memberentry.pl | 2 +- t/SimpleMARC.t | 49 +++++++++++++++++- 9 files changed, 97 insertions(+), 57 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 24 16:11:24 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Jun 2019 14:11:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-166-g4dc64b4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4dc64b4b124abf4bd2437004879e083972e20492 (commit) via 0df3fc3dae575ceb16b85de6c201f5e82d01059c (commit) via 286f151009f778d6d4d0890b1a8bead1a6e62bde (commit) via ed7b3760965ec5a52783efe64bcba13b45b3725a (commit) via 66975364b672ea5f362d49f6e5fca8c9a0e8326c (commit) via 48e5713e6ff78d7aad7eff9e239ec8779d62655c (commit) via f1bb6178e5bfe990da747c9d5b0e7a4f04148a55 (commit) via c3ced5d89320f85774d945957b2b4e68d0336016 (commit) via efc21e6f47801503e55e3ba709a48c3f426f90ac (commit) via 49275f27d43990746b4af5c6335d4fe7f38de7b4 (commit) via 7c5e7ca9c47ac6c8a8b7d89da46e7354d8fea69d (commit) from d08e776cf1e25ffa407bb3a5d668c1b140be6ec2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4dc64b4b124abf4bd2437004879e083972e20492 Author: Martin Renvoize Date: Mon Jun 24 14:48:27 2019 +0100 Bug 23034: (RM follow-up) Consistent coding style We had a mix of q||, q{} and '' in this one script. This followup just makes them all conform to our standard style of q{}. Signed-off-by: Martin Renvoize commit 0df3fc3dae575ceb16b85de6c201f5e82d01059c Author: Joonas Kylm?l? Date: Mon Jun 3 14:58:34 2019 +0000 Bug 23034: Remove uninitialized value warning in Mana KB settings This gets rid of the warning "Use of uninitialized value $auto_share in string ne at [...]" by initializing the variable with empty string. Test plan: 1) Go to page cgi-bin/koha/admin/share_content.pl and unselect "Auto subscription sharing". Click "Save". 2) Check plack-error.log and notice the warning "Use of uninitialized value $auto_share [...]" 3) Apply the patch and repeat the previous steps but now this time the warning is gone in plack-error.log. 4) Make sure the AutoShareWithMana syspref with and without the patch is in unselected state after clicking "Save". Sponsored-by: The National Library of Finland Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 286f151009f778d6d4d0890b1a8bead1a6e62bde Author: Katrin Fischer Date: Mon Jun 17 23:20:41 2019 +0200 Bug 23098: Reword success message of KOC upload process When uploading KOC files the processing of transactions needs to happen in a separate second step. This is why the success message "Your file was processed" was found to be misleading. This patch changes it to the wording suggested by Benjamin Daeuber in the original bug report. Thx! To test: - Create a KOC file either manually or by downloading it from the plugin - Upload the KOC file into Koha using Circulation > Upload offline circulation file (.koc) - Verify the new message is clear and has no typos :) Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit ed7b3760965ec5a52783efe64bcba13b45b3725a Author: Fridolin Somers Date: Tue Jun 11 15:31:45 2019 +0200 Bug 22944: remove obsolete unit test Test 'AnonymiseIssueHistory should not return any error if success' is obsolete, previous statement will explode if something went wrong. Test plan : Run t/db_dependent/Koha/Patrons.t Signed-off-by: Arthur Bousquet Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 66975364b672ea5f362d49f6e5fca8c9a0e8326c Author: Fridolin Somers Date: Tue May 21 11:55:40 2019 +0200 Bug 22944: avoid AnonymousPatron in search_patrons_to_anonymise In Koha::Patrons::search_patrons_to_anonymise() old issues already affected to the anonymous patron should be avoided. It is useless and can impact performance. It is already working if AnymousPatron is not defined or 0 because of : 'old_issues.borrowernumber' => { 'not' => undef } In theory the anymous patron should have privacy=0 but in case its not it should be explicitly avoided. Test plan : Run t/db_dependent/Koha/Patrons.t Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 48e5713e6ff78d7aad7eff9e239ec8779d62655c Author: Fridolin Somers Date: Tue May 21 11:17:11 2019 +0200 Bug 22944: change unit tests Add a dedicated UT and correct a test return value Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit f1bb6178e5bfe990da747c9d5b0e7a4f04148a55 Author: Martin Renvoize Date: Mon Jun 24 14:24:26 2019 +0100 Bug 23115: Compiled CSS Signed-off-by: Martin Renvoize commit c3ced5d89320f85774d945957b2b4e68d0336016 Author: Nick Clemens Date: Fri Jun 21 16:20:28 2019 +0000 Bug 23115: (QA follow-up) Address QA tools complaints Signed-off-by: Martin Renvoize commit efc21e6f47801503e55e3ba709a48c3f426f90ac Author: Nick Clemens Date: Fri Jun 21 16:18:15 2019 +0000 Bug 23115: (follow-up) Move switches to a TT block Signed-off-by: Martin Renvoize commit 49275f27d43990746b4af5c6335d4fe7f38de7b4 Author: Martin Renvoize Date: Thu Jun 13 11:42:02 2019 +0100 Bug 23115: Tweak display of totals on 'Fines and charges' page This patch tweaks the display of totals on the OPAC 'Fines and charges' page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the 'Fines and charges' page before applying the patch 3) Look at the 'Fines and charges' page after applying the patch 4) Varify the new layout is an improvment or not Signed-off-by: Martin Renvoize Signed-off-by: Nadine Pierre Signed-off-by: Maryse Simard Signed-off-by: Martin Renvoize commit 7c5e7ca9c47ac6c8a8b7d89da46e7354d8fea69d Author: Martin Renvoize Date: Thu Jun 13 10:02:35 2019 +0100 Bug 23106: Tweak display of totals on payment page This patch tweaks the display of totals on the fines payments page to clarify between the totals before and after applying credits. Test Plan: 1) Add some debts and credits to a patrons account 2) Look at the pay page before applying the patch 3) Look at the pay page after applying the patch 4) Verify the new layout is an improvment or not Signed-off-by: Martin Renvoize Signed-off-by: Owen Leonard Signed-off-by: Maryse Simard Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Patrons.pm | 2 + admin/share_content.pl | 6 +- .../intranet-tmpl/prog/en/modules/members/pay.tt | 16 ++-- .../prog/en/modules/offline_circ/enqueue_koc.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 8 +- .../bootstrap/en/includes/account-table.inc | 79 +++++++++++++------- opac/opac-account.pl | 20 ++--- t/db_dependent/Koha/Patrons.t | 9 ++- 9 files changed, 91 insertions(+), 53 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 24 17:08:28 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Jun 2019 15:08:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-181-g535925e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 535925e23f58d654ddd3a1da62d6bf2572aca0a2 (commit) via 33b70b798d4cc2bc6d6db43a40d006dd8c1109b8 (commit) via 14af35852edf33f05883184cc451662438114c12 (commit) via 0141b797d7f495bbcea350c14e3b6aae635ce7cf (commit) via 0b783783706f88d04225c0a42759798ae14c9755 (commit) via da12cf7551dd1bd533b7cbcf5a679ea58f6a0f4e (commit) via 7f3c98478ab63e834d7787c1ce6ab06e46d44395 (commit) via e8a4f97e95c8206c2cc60ba81d953ae1c4c12963 (commit) via e54e887b58d7daa0309d16923cce4419aee6314b (commit) via 982fd9fecbe6777805d2d0d3f977f10c522b86c5 (commit) via 115f4f2045a6c695d1eed47cd401b7759630ac4d (commit) via cc9d167af6081009bd3c41c7dd91f90c76c6ca1b (commit) via a1083587b235ac0d85e85a625944179e2c087785 (commit) via a6d732f563bfcd19691decbb9968dc1f4b25c07c (commit) via 3599e57bf67a1357c13903fbf07f07cb2c94e756 (commit) from 4dc64b4b124abf4bd2437004879e083972e20492 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 535925e23f58d654ddd3a1da62d6bf2572aca0a2 Author: Martin Renvoize Date: Mon Jun 24 15:42:04 2019 +0100 Bug 22935: Compiled CSS Signed-off-by: Martin Renvoize commit 33b70b798d4cc2bc6d6db43a40d006dd8c1109b8 Author: Owen Leonard Date: Fri May 17 15:03:24 2019 +0000 Bug 22935: Improve style of Bootstrap pagination This patch makes some updates to the staff client CSS and adds Font Awesome icons to the Bootstrap pagination include. To test, apply the patch and rebuild the staff client CSS. Perform a search in the staff client which will return multiple pages of results. Check that the pagination links look good. Signed-off-by: Maryse Simard Signed-off-by: Bin Wen Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize commit 14af35852edf33f05883184cc451662438114c12 Author: Kyle M Hall Date: Fri Nov 30 12:23:43 2018 -0500 Bug 20292: Filter/censor info sent via SIP Some libraries would like to limit the amount of personal information a SIP server sends to arbitrary parties on a per-login basis. Test Plan: 1) Add a new key/value pair to one of your existing login stanzas in your SIP config file For example: hide_fields="BD,BE,BF,PB" 2) Restart SIP 3) Send a SIP message that would normally return those fields ( in this example, a Patron Information Request ) 4) Note the response has had those fields removed Signed-off-by: Kyle M Hall Signed-off-by: Christopher Davis Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit 0141b797d7f495bbcea350c14e3b6aae635ce7cf Author: Martin Renvoize Date: Mon Jun 24 15:07:53 2019 +0100 Bug 22509: (RM follow-up) Add use of Koha::Script base class Signed-off-by: Martin Renvoize commit 0b783783706f88d04225c0a42759798ae14c9755 Author: Jonathan Druart Date: Sat May 11 18:58:20 2019 -0500 Bug 22509: Clarify with an example the usage of --unless-exists Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit da12cf7551dd1bd533b7cbcf5a679ea58f6a0f4e Author: Jonathan Druart Date: Sat May 11 18:53:25 2019 -0500 Bug 22509: Add more POD and fix --where We should not need the "WHERE" keyword to have the same behavior as existing script (rebuild_zebra.pl) Signed-off-by: Martin Renvoize commit 7f3c98478ab63e834d7787c1ce6ab06e46d44395 Author: Jonathan Druart Date: Fri May 10 07:55:49 2019 -0500 Bug 22509: Fix POD error 1. "Apparent command =item not preceded by blank line" 2. Display the options for help 3. Do not run if no --field passed Signed-off-by: Martin Renvoize commit e8a4f97e95c8206c2cc60ba81d953ae1c4c12963 Author: Jonathan Druart Date: Thu Apr 4 23:02:09 2019 -0300 Bug 22509: Add the --unless-exists option to the script It will avoid to create the fields several times if it is not needed. Signed-off-by: Hugo Agud Signed-off-by: Martin Renvoize commit e54e887b58d7daa0309d16923cce4419aee6314b Author: Jonathan Druart Date: Wed Mar 13 11:23:13 2019 -0300 Bug 22509: Add new script to add MARC fields with date formatted stringsto bib records Say you want to add, into a new MARC fields, the following string: 2/2019/Mar-03/13 Depending on today's date. Test plan: Use the script after with the different options (see --help option for the list) Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Martin Renvoize commit 982fd9fecbe6777805d2d0d3f977f10c522b86c5 Author: Kyle M Hall Date: Thu May 9 14:14:25 2019 -0400 Bug 22862: (QA follow-up) Make regexes match Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 115f4f2045a6c695d1eed47cd401b7759630ac4d Author: Kyle M Hall Date: Tue May 7 14:53:29 2019 -0400 Bug 22862: Normalize SMS messaging numbers before validating them Librarians often copy and paste patron data, including phone numbers. SMS phone numbers are now being validated to conform to the E.164 specification. It would be nice to try to normalize that data by stripping non-numeric data from the paste (i.e. dashes, parens, etc ). Test Plan: 1) Apply this patch 2) On the staff side, Attempt to enter invalid characters the SMS number field 3) Note you cannot enter invalid characters 4) Attempt to paste a phone number with invalid characters 5) Note those characters are removed on paste 6) Repeat these steps on the OPAC Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit cc9d167af6081009bd3c41c7dd91f90c76c6ca1b Author: Martin Renvoize Date: Mon Jun 24 14:59:04 2019 +0100 Bug 22888: Compiled CSS Signed-off-by: Martin Renvoize commit a1083587b235ac0d85e85a625944179e2c087785 Author: Owen Leonard Date: Thu May 9 16:55:00 2019 +0000 Bug 22888: Use DataTables for Koha news table filtering This patch modifies the Koha news page so that filtering the table of news is done using DataTables' built-in search functionality. This allows for the table to be filtered without requiring a reload of the page. The patch also moves the table filter into a sidebar form and adds a keyword field. A minor change has been made to the global CSS to improve the display of the form in the sidebar. To test, apply the patch and rebuild the staff client CSS. - Go to Tools -> News. - Test the various table filter options: keyword, display location, and library. Confirm that all work as expected. - Changes to the keyword search text should be reflected in the search field at the top of the table, and vice versa. - Changes to the sidebar filter should trigger the correct state of the "Clear filter" button at the top of the news table (enabled or disabled). Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit a6d732f563bfcd19691decbb9968dc1f4b25c07c Author: Jonathan Druart Date: Thu May 9 12:27:15 2019 -0500 Bug 21588: Add expand/collapse all links to the "Acquisition details" subscriptions In order to make the view cleaner, a librarian may need to expand or collapse all the orders at once. Test plan: - Create a subscription - Create several orders from this subscription (quantity > 1) - Receive partially the orders - Go to the subscription detail page, "Acquisition details" tab => Notice the 2 new links "Expand all" and "Collapse all" Make sure they work as expected. Also note that a bug has been fixed, when the page is loaded the tree is now expanded. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 3599e57bf67a1357c13903fbf07f07cb2c94e756 Author: Nick Clemens Date: Mon Dec 18 15:41:33 2017 +0000 Bug 15704: Split up Zebra indexing of RDA 264 information To test: 1 - Add a record with a unique publisher "Supercalifragilistic" in the 264 b field 2 - Search for the value 3 - Record not found 4 - Apply patch (may need ot copy the .xml file into koha install) 5 - Reindex all the things 6 - Search for the value 7 - Success! Signed-off-by: Felicia Martin Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Patron.pm | 2 +- C4/SIP/Sip.pm | 14 +- C4/SIP/Sip/MsgType.pm | 313 ++++++++++---------- etc/SIPconfig.xml | 3 +- .../marc21/biblios/biblio-koha-indexdefs.xml | 16 + .../marc21/biblios/biblio-zebra-indexdefs.xsl | 25 +- .../intranet-tmpl/prog/css/src/staff-global.scss | 30 +- koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +- .../prog/en/includes/page-numbers.inc | 8 +- .../prog/en/modules/serials/subscription-detail.tt | 18 +- .../prog/en/modules/tools/koha-news.tt | 121 ++++++-- koha-tmpl/intranet-tmpl/prog/js/members.js | 6 + .../bootstrap/en/modules/opac-messaging.tt | 22 ++ misc/add_date_fields_to_marc_records.pl | 151 ++++++++++ t/db_dependent/SIP/Message.t | 12 +- tools/koha-news.pl | 2 +- 16 files changed, 543 insertions(+), 202 deletions(-) create mode 100755 misc/add_date_fields_to_marc_records.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 24 18:23:44 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Jun 2019 16:23:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-190-ga87f5a0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a87f5a01502b5df08f5e7b61650be6ea7dbafa30 (commit) via a60a6f40c3e25753c7474c4ff20f28e71353c351 (commit) via b6dc26e93d9d0170c9980291a0f217adcc429e6a (commit) via 088522032f33b6a5931cbea1b928537e7fe33fd0 (commit) via 1020fe5b1f95a606d445acb4ac16c0c30586e71d (commit) via c7147fcde03f7ba1ac13e485adcac587f2dde85c (commit) via d52f58682cbae7f903a0459f3ec282a65a8ae1f6 (commit) via 23065fe0d8e09be78d1234a3a5bebf322da34925 (commit) via f04747c89c8a318e3ee7c49cadc859f1fe7bb5b3 (commit) from 535925e23f58d654ddd3a1da62d6bf2572aca0a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a87f5a01502b5df08f5e7b61650be6ea7dbafa30 Author: Martin Renvoize Date: Mon Jun 24 16:56:56 2019 +0100 Bug 23152: (RM follow-up) Add handling for Koha::Plugin::Methods Signed-off-by: Martin Renvoize commit a60a6f40c3e25753c7474c4ff20f28e71353c351 Author: Jonathan Druart Date: Tue Jun 18 21:42:07 2019 -0500 Bug 23152: Implement koha_object[s]_class when needed A simple use case is the ->get_from_storage (useful when writing tests) Test plan: Apply only the first patch and notice the test failures Apply the second patch and confirm the the tests are returning green Signed-off-by: Martin Renvoize commit b6dc26e93d9d0170c9980291a0f217adcc429e6a Author: Jonathan Druart Date: Tue Jun 18 21:39:45 2019 -0500 Bug 23152: Add tests Signed-off-by: Martin Renvoize commit 088522032f33b6a5931cbea1b928537e7fe33fd0 Author: Julian Maurice Date: Wed Jun 19 11:10:14 2019 +0200 Bug 23154: Add pagination to /api/v1/checkouts Allow to use _page and _per_page query parameters for /api/v1/checkouts Also fix a timezone problem in t/db_dependent/api/v1/checkouts.t Test plan: 1. With your favorite REST tester tool, or directly in the browser, fetch http://koha/api/v1/checkouts and check that you have results 2. Fetch /api/v1/checkouts?_per_page=1&_page=1 and check that only the first result is returned. Check that response contains headers X-Total-Count and Link 3. Fetch /api/v1/checkouts?_per_page=1&_page=2 and check that only the second result is returned. Check that response contains headers X-Total-Count and Link 4. prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 1020fe5b1f95a606d445acb4ac16c0c30586e71d Author: Mark Tompsett Date: Wed Jun 19 14:06:28 2019 +0000 Bug 23159: Add comments to addbiblio.tt This patch adds code comments to the template to clarify indenting over the page boundary. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit c7147fcde03f7ba1ac13e485adcac587f2dde85c Author: Owen Leonard Date: Tue Jun 18 15:32:24 2019 +0000 Bug 23159: Reindent addbiblio.tt This patch corrects whitespace in the basic MARC editor template, addbiblio.tt: Tabs converted to spaces, indentation corrected. Some comments have been added in the markup to clarify the page structure. To test, apply the patch and open the basic MARC editor. Confirm that everything works correctly, including: - Showing/hiding subfields - Re-ordering subfields - Removing tags and subfields - Cloning tags and subfields - Plugin links Use the "-w" flag when using diff to examine the patch. The only changes should be places where single lines were broken up and where comments were added. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize commit d52f58682cbae7f903a0459f3ec282a65a8ae1f6 Author: Tomas Cohen Arazi Date: Wed Jun 19 12:30:28 2019 -0300 Bug 23146: (QA follow-up) Make sure we use the absolute path When making a request using any tool (like cUrl or Postman) you get a 'Basic authentication disabled' error (if it is actually disabled) or an 'invalid password' error if it is disabled. This is because the comparisson of the path we do passes on oauth.t but fails on external tools. This is probably related to our stack including Apache URL mappings and then in the plack.psgi file. The safest way is to just ask Mojo::URL the absolute path to be sure. To test: - Having the rest of the patches applied and plack restarted, run: [1] $ curl -X POST -H 'Authorization: Basic ZGQ2NjlmNGUtZmI1NS00Y2YzLWE4ZmYtYmFiYzJiNDIwNWY1OmM0ZDJmYmYzLWYwOWMtNGJkZi1iNWE4LTgxMDJmNjcwYTI1Mw' -i 'http://kohadev.myDNSname.org:8081/api/v1/oauth/token' --data grant_type=client_credentials => FAIL: It fails saying Basic auth is disabled - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass - Apply this patch - Replicate your curl/postman test => SUCCESS: It now works as expected - Run: k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests still pass! - Sign off :-D [1] You need to generate a client_id and client_secret, and encode them using: encode_base64url( "$client_id:$client_secret" ); Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 23065fe0d8e09be78d1234a3a5bebf322da34925 Author: Tomas Cohen Arazi Date: Tue Jun 18 16:09:01 2019 -0300 Bug 23146: Add support for Basic auth on the OAuth2 token endpoint The original implementation only contemplated the option to pass the client_id and client_secret on the request body. It is very common that clients expect to be able to pass them as a Basic authorization header: Authorization: Basic encode_base64(client_id:client_secret) This patch introduces support for this, by: - Adding a check for the presence of the Authorization header in the OAuth token request handling code and making that case extract the client_id and client_secret from the header instead of the original implementation. No behaviour changes. - The Auth#under sub is changed so it doesn't go through the authenticate_api_request chain step, as it would be in conflict with general Basic authentication. - Original tests are generalized so they are run in both ways, with the same expected results. To test: - Apply the unit tests patch - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => FAIL: Tests fail because the current API doesn't support the feature - Apply this patch - Run: k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit f04747c89c8a318e3ee7c49cadc859f1fe7bb5b3 Author: Tomas Cohen Arazi Date: Tue Jun 18 16:08:54 2019 -0300 Bug 23146: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1/Auth.pm | 8 +- Koha/REST/V1/OAuth.pm | 22 +- Koha/Schema/Result/AccountOffset.pm | 7 +- Koha/Schema/Result/Aqbasket.pm | 8 +- Koha/Schema/Result/Aqbasketgroup.pm | 8 +- Koha/Schema/Result/Aqbookseller.pm | 7 +- Koha/Schema/Result/Aqbudget.pm | 8 +- Koha/Schema/Result/Aqbudgetperiod.pm | 7 +- Koha/Schema/Result/Aqcontact.pm | 7 +- Koha/Schema/Result/Aqinvoice.pm | 7 +- Koha/Schema/Result/AqinvoiceAdjustment.pm | 7 +- Koha/Schema/Result/AuthHeader.pm | 7 +- Koha/Schema/Result/AuthSubfieldStructure.pm | 7 +- Koha/Schema/Result/AuthTagStructure.pm | 7 +- Koha/Schema/Result/AuthType.pm | 7 +- Koha/Schema/Result/BiblioMetadata.pm | 4 +- Koha/Schema/Result/BorrowerAttribute.pm | 7 +- Koha/Schema/Result/BorrowerAttributeType.pm | 7 +- Koha/Schema/Result/BorrowerModification.pm | 7 +- Koha/Schema/Result/Branch.pm | 5 +- Koha/Schema/Result/BranchTransferLimit.pm | 7 +- Koha/Schema/Result/BranchesOverdrive.pm | 7 +- Koha/Schema/Result/Branchtransfer.pm | 7 +- Koha/Schema/Result/Category.pm | 7 +- Koha/Schema/Result/ClubEnrollment.pm | 7 +- Koha/Schema/Result/ClubEnrollmentField.pm | 7 +- Koha/Schema/Result/ClubField.pm | 7 +- Koha/Schema/Result/ClubTemplate.pm | 7 + Koha/Schema/Result/ClubTemplateEnrollmentField.pm | 7 +- Koha/Schema/Result/ClubTemplateField.pm | 7 +- Koha/Schema/Result/Currency.pm | 8 +- Koha/Schema/Result/ExportFormat.pm | 7 +- Koha/Schema/Result/Fieldmapping.pm | 7 +- Koha/Schema/Result/HouseboundProfile.pm | 7 +- Koha/Schema/Result/HouseboundRole.pm | 7 +- Koha/Schema/Result/HouseboundVisit.pm | 7 +- Koha/Schema/Result/Issue.pm | 7 + Koha/Schema/Result/Issuingrule.pm | 7 +- Koha/Schema/Result/Itemtype.pm | 7 + Koha/Schema/Result/Letter.pm | 7 +- Koha/Schema/Result/LibraryGroup.pm | 7 +- Koha/Schema/Result/Message.pm | 7 +- Koha/Schema/Result/MessageQueue.pm | 7 +- Koha/Schema/Result/NeedMergeAuthority.pm | 7 +- Koha/Schema/Result/OauthAccessToken.pm | 7 +- Koha/Schema/Result/OldIssue.pm | 3 + Koha/Schema/Result/OldReserve.pm | 7 +- Koha/Schema/Result/OpacNews.pm | 7 +- Koha/Schema/Result/PatronConsent.pm | 7 +- Koha/Schema/Result/Patronimage.pm | 7 +- Koha/Schema/Result/PluginMethod.pm | 6 + Koha/Schema/Result/Reserve.pm | 7 + Koha/Schema/Result/SavedSql.pm | 7 +- Koha/Schema/Result/Serialitem.pm | 7 +- Koha/Schema/Result/SmsProvider.pm | 7 +- Koha/Schema/Result/Stockrotationitem.pm | 8 +- Koha/Schema/Result/Stockrotationrota.pm | 8 +- Koha/Schema/Result/Stockrotationstage.pm | 7 + Koha/Schema/Result/SubscriptionFrequency.pm | 7 +- Koha/Schema/Result/SubscriptionNumberpattern.pm | 7 +- Koha/Schema/Result/Subscriptionhistory.pm | 7 +- Koha/Schema/Result/Subscriptionroutinglist.pm | 7 +- Koha/Schema/Result/Systempreference.pm | 7 +- Koha/Schema/Result/TagAll.pm | 7 +- Koha/Schema/Result/TagsApproval.pm | 7 +- Koha/Schema/Result/TagsIndex.pm | 7 +- Koha/Schema/Result/Virtualshelve.pm | 7 +- Koha/Schema/Result/Z3950server.pm | 7 +- api/v1/swagger/paths/checkouts.json | 4 + .../prog/en/modules/cataloguing/addbiblio.tt | 1202 ++++++++++---------- t/db_dependent/TestBuilder.t | 2 + t/db_dependent/api/v1/checkouts.t | 29 +- t/db_dependent/api/v1/oauth.t | 170 ++- 73 files changed, 1187 insertions(+), 708 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 24 18:34:49 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Jun 2019 16:34:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-198-gb5ad077 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b5ad077342faed74de34c3f185379ddf1b8ff4ad (commit) via a19bd0e0267e9173a8c766c565ef67ecd1babcb7 (commit) via dc0e8002fa6219cd49a5cc457191ef7855163c28 (commit) via 9f4c2306ebc42e107603f6f8bf393a20d1013458 (commit) via 12ef157d757431520d63ab154b9572a855acf317 (commit) via e17cff4d5aea108010850ff4a6bada80ba6ef055 (commit) via aa8abb916f8aa19c109abdd7841560abc01db239 (commit) via c5ca160e3b79b7ad1cbc4cfc1c2c7db30d2686ff (commit) from a87f5a01502b5df08f5e7b61650be6ea7dbafa30 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5ad077342faed74de34c3f185379ddf1b8ff4ad Author: Martin Renvoize Date: Mon Jun 24 17:12:44 2019 +0100 Bug 23109: DBRev 19.06.00.008 Signed-off-by: Martin Renvoize commit a19bd0e0267e9173a8c766c565ef67ecd1babcb7 Author: Mark Tompsett Date: Thu Jun 20 16:42:22 2019 +0000 Bug 23109: (follow-up) fix typo in upgrade script Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit dc0e8002fa6219cd49a5cc457191ef7855163c28 Author: Katrin Fischer Date: Mon Jun 17 21:50:01 2019 +0000 Bug 23109: Improve description of staffaccess permission Changes: Allow staff members to modify permissions for other staff members To: Allow staff members to modify permissions and passwords for other staff members. As suggested by Andre on the initial bug report. To test: - Go to any patron account and check More > permissions - Veriy the description is shown as noted above - Apply patch and run database update - Reload the page and verify the description has changed - Run the following SQL and verify the description in the database table matches as well: SELECT * FROM userflags where flag = "staffaccess"; Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 9f4c2306ebc42e107603f6f8bf393a20d1013458 Author: Jonathan Druart Date: Mon Jun 24 10:37:54 2019 -0500 Bug 23158: Make the assignment statement more readable Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 12ef157d757431520d63ab154b9572a855acf317 Author: Fridolin Somers Date: Wed Jun 19 13:42:16 2019 +0200 Bug 23158: keep on-site checkout info when using itemBarcodeFallbackSearch When using preference itemBarcodeFallbackSearch one can enter a search term instead of a barcode in checkout form. If on-site is selected this should be transmitted to itemBarcodeFallbackSearch form. Test plan : 1) Enable system preferences "itemBarcodeFallbackSearch" and "OnSiteCheckouts" 2) Disable system preference "ConsiderOnSiteCheckoutsAsNormalCheckouts" 3) Go to a patron circulation page 4) Check "On-site checkout" in "Checkout settings" 5) Enter a barcode in checkout form and click on "Check out" 6) You see the checkout in table with red "(On-site checkout)" 7) Check "On-site checkout" in "Checkout settings" 8) Enter the title of a record in in checkout form and click on "Check out" 9) Click on "Checkout" on a line 10) You see the checkout in table with red "(On-site checkout)" Signed-off-by: Arthur Bousquet Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit e17cff4d5aea108010850ff4a6bada80ba6ef055 Author: Martin Renvoize Date: Mon Jun 24 17:07:04 2019 +0100 Bug 5287: Compiled CSS Signed-off-by: Martin Renvoize commit aa8abb916f8aa19c109abdd7841560abc01db239 Author: Liz Rea Date: Sat Jun 8 17:57:17 2019 +0000 Bug 5287: (QA follow-up) update deprecated button Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit c5ca160e3b79b7ad1cbc4cfc1c2c7db30d2686ff Author: Owen Leonard Date: Tue Jun 11 12:16:10 2019 +0000 Bug 5287: Add floating toolbar to search results in OPAC This patch adds the "hc-sticky" JavaScript library to the OPAC and uses it to make the search results toolbar "stick" to the top of the page as the user scrolls down. This patch also moves search results pagination into the toolbar so that pagination links are available. Font Awesome icons are added to the pagination include to replace arrow HTML entities. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform a catalog search in the OPAC which will return multiple pages of results. Confirm that the toolbar "sticks" and that all controls in the toolbar work correctly. - Test at various browser widths to confirm that it adapt well to various sizes. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- circ/circulation.pl | 8 +- installer/data/mysql/updatedatabase.pl | 7 ++ installer/data/mysql/userflags.sql | 2 +- .../intranet-tmpl/prog/en/includes/permissions.inc | 2 +- .../prog/en/modules/circ/circulation.tt | 1 + koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +- .../opac-tmpl/bootstrap/css/src/_responsive.scss | 61 +++++++++++-- koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 18 +++- .../bootstrap/en/includes/page-numbers.inc | 12 +-- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 95 +++++++++++--------- koha-tmpl/opac-tmpl/bootstrap/js/script.js | 2 - .../{intranet-tmpl => opac-tmpl}/lib/hc-sticky.js | 0 13 files changed, 146 insertions(+), 66 deletions(-) copy koha-tmpl/{intranet-tmpl => opac-tmpl}/lib/hc-sticky.js (100%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 24 19:42:20 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Jun 2019 17:42:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-199-g8bf6f4d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8bf6f4dc5ad2aad0a5dd59c4fb7f70fd6b0f069e (commit) from b5ad077342faed74de34c3f185379ddf1b8ff4ad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8bf6f4dc5ad2aad0a5dd59c4fb7f70fd6b0f069e Author: Martin Renvoize Date: Mon Jun 24 18:22:08 2019 +0100 Bug 23152: (RM follow-up) Correct pluralisation of Koha::Libraries Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Branch.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jun 24 19:45:14 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 24 Jun 2019 17:45:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-200-gc7047b4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c7047b45cb44adf12189e9180ef27fe8e63efa23 (commit) from 8bf6f4dc5ad2aad0a5dd59c4fb7f70fd6b0f069e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c7047b45cb44adf12189e9180ef27fe8e63efa23 Author: Martin Renvoize Date: Mon Jun 24 18:24:47 2019 +0100 Bug 23109: (RM follow-up) Correction to typo in DBRev Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 25 17:43:50 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 25 Jun 2019 15:43:50 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-201-g90bd976 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 90bd9763bd0cf49df722955008af0c59d79edfe0 (commit) from c7047b45cb44adf12189e9180ef27fe8e63efa23 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 90bd9763bd0cf49df722955008af0c59d79edfe0 Author: Martin Renvoize Date: Tue Jun 25 16:19:43 2019 +0100 Bug 5287: (RM follow-up) Make tests basket compatible The selenium tests for addtobasket/removefrombasket started to fail after the introduction of bug 5287. It turns out that a selenium click handler will trigger a scroll event if the element you're trying to click isn't in the view port. Unfortunately it scrolls the viewport just enough for the element to come on screen but that also triggers the floating toolbar in this case which ends up floating directly over the element we want to 'click' and so the click rightfully fails as the element is not 'clickable'. This patch works around the issue by setting the window size to being a HD screen in portrait orientation and therefore negates the need for scrolling to put the elements in within the viewport. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/selenium/regressions.t | 7 +++++++ 1 file changed, 7 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 25 18:22:24 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 25 Jun 2019 16:22:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-211-g3509303 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 35093039df3b42ae33c746385669ba13deb38c7d (commit) via b3795df8012545af4134d7402e9609e2d89f7be9 (commit) via 4e4f0b637c66ca04a07473c347cc741d456c20c5 (commit) via 7e226ba3c018a890c823f10365dbe2b3d1d22d23 (commit) via 2b392a6db231c8069d57be88ebf4f2960af199fa (commit) via 4f3413f0d2688017f6a35b43d0d1d4a9d7295c5a (commit) via b62473d192abaf9371bffb0ec4d73267a0070447 (commit) via 35fe9cf40bb1472799db0f7596d33f1bd184fb9b (commit) via 8947d5939fb33efd0887a6f443d392b9df17e2aa (commit) via 2c5e9bed7de83d01be755475b96a3cf439e0126c (commit) from 90bd9763bd0cf49df722955008af0c59d79edfe0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 35093039df3b42ae33c746385669ba13deb38c7d Author: Nick Clemens Date: Tue Jun 25 12:40:57 2019 +0000 Bug 22566: (QA follow-up) Fix pod complaint Signed-off-by: Martin Renvoize commit b3795df8012545af4134d7402e9609e2d89f7be9 Author: Martin Renvoize Date: Tue Jun 18 14:29:02 2019 +0100 Bug 22566: Add 'branch' key to GetPreparedLetter The branch key was missing from the subsitution call to GetPreparedLetter. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 4e4f0b637c66ca04a07473c347cc741d456c20c5 Author: Martin Renvoize Date: Tue Jun 18 14:24:27 2019 +0100 Bug 22566: Clarify intent of reports and add warnings Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 7e226ba3c018a890c823f10365dbe2b3d1d22d23 Author: Martin Renvoize Date: Tue Jun 18 13:38:43 2019 +0100 Bug 22566: Rename 'report_email' to 'report_by_branch' To clarify the intention of this routine, lets rename it Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 2b392a6db231c8069d57be88ebf4f2960af199fa Author: Martin Renvoize Date: Tue Jun 18 12:57:07 2019 +0100 Bug 22566: Accept 'all' in the branch params Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 4f3413f0d2688017f6a35b43d0d1d4a9d7295c5a Author: Martin Renvoize Date: Fri Jun 7 12:50:32 2019 +0100 Bug 22566: Fix some more issues 1) Fix warning for undefined value in sprintf when no items have the indemand flag set. 2) Corrections to report_full for bad ternary in string construction 3) Perldoc corrections Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit b62473d192abaf9371bffb0ec4d73267a0070447 Author: Nick Clemens Date: Fri Mar 22 13:23:35 2019 -0400 Bug 22566: Fix some problems Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize commit 35fe9cf40bb1472799db0f7596d33f1bd184fb9b Author: Owen Leonard Date: Tue May 21 14:45:06 2019 +0000 Bug 22949: Markup error in OPAC course reserves template This patch adds a missing "=" in opac-course-reserves.tt in order to quiet errors returned by the HTML validator. To reproduce the problem you should have one or more course reserves available in the OPAC. Go to the course reserves page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses these errors: - 'Quote " in attribute name. Probable cause: Matching quote missing somewhere earlier.' - 'Attribute class"inst_surname" not allowed on element span at this point.' To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Frederik Chenier Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 8947d5939fb33efd0887a6f443d392b9df17e2aa Author: Jonathan Druart Date: Mon Jun 24 09:58:00 2019 -0500 Bug 23082: Fatal error editing a restricted patron In members/memberentry.pl we have to explicitely remove the template's params that are not patron's attributes. Certainly caused by commit 1bb6cec902088d07c7a43addc4b4adb5b0bf3d4f Bug 20287: Fix update of patrons, clean the data before ->store Test plan: Create a restriction for a patron Edit patron's details Remove the restriction => Without this patch you get "No property remove_debarment for Koha::Patron" => With this patch applied the restriction is removed Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 2c5e9bed7de83d01be755475b96a3cf439e0126c Author: Kyle M Hall Date: Thu Jun 13 06:34:38 2019 -0400 Bug 23116: AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold A library appears to be able to place a second item level hold on an item a patron already has on hold if A) AllowHoldPolicyOverride is enabled and B) the circ rule allow for multple item level holds. Once the patron submits the hold requests though, the hold does not get stored in the database. Because allowing two item level holds for the same item makes no sense, we should not allow this attempt to take place, even if AllowHoldPolicyOverride is enabled. Test Plan: 1) Enable AllowHoldPolicyOverride 2) Set up circ rules to allow for multiple item level holds on one record 3) Place an item level hold on a record 4) Note you can force placing a second item hold on that reocrd 5) Attempt to do so, it will not actually work 6) Apply this patch 7) Note you can no longer place another item level hold for the same item you just placed an item-level hold on 8) Note you can still force holds that contravene the circ rules for any and all other reasons 9) Test with record level holds 10) Test by placing multiple holds from search results Signed-off-by: Martha Fuerst Signed-off-by: Tomas Cohen Arazi Simple fix for a regression. Works as expected. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha/StockRotationRotas.pm | 1 + .../bootstrap/en/modules/opac-course-reserves.tt | 2 +- members/memberentry.pl | 2 +- misc/cronjobs/stockrotation.pl | 76 ++++++++++++-------- reserve/placerequest.pl | 13 +++- reserve/request.pl | 7 +- 6 files changed, 63 insertions(+), 38 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jun 25 18:41:07 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 25 Jun 2019 16:41:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-219-g6c773a8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6c773a891704ee94c0e8159048c3c1aec62986d3 (commit) via 6538de6397a337f1f1181a3197994a7fff0410d8 (commit) via e639400225e2d04823eee7a00e490d87f8d60401 (commit) via 2455286da42b73fa3efc29ac1a51ca81a0017a8e (commit) via 316eda1036fd08f9c78578b27e85fd79c6895237 (commit) via 2351693b61db83e0405157fd75951abee8df0116 (commit) via 6b6dc7bc791853d4dafb7f9ab02d3767c926ff08 (commit) via 7bc7cd4676632c835a16341191e07a5e7e13054a (commit) from 35093039df3b42ae33c746385669ba13deb38c7d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6c773a891704ee94c0e8159048c3c1aec62986d3 Author: Martin Renvoize Date: Tue Jun 25 09:21:44 2019 +0100 Bug 23191: (follow-up) Improve output This patch adds a check of what plugins installed before the script run and outputs only those plugins that have been installed for the first time or upgraded during this run. Signed-off-by: Alex Arnaud Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 6538de6397a337f1f1181a3197994a7fff0410d8 Author: Martin Renvoize Date: Mon Jun 24 13:30:54 2019 +0100 Bug 23191: Add commandline script to install plugins This adds an initial skeliton script to enable plugin installation at the commandline. Signed-off-by: Alex Arnaud Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit e639400225e2d04823eee7a00e490d87f8d60401 Author: Jonathan Druart Date: Mon Jun 24 12:39:15 2019 -0500 Bug 23126: Add tests Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2455286da42b73fa3efc29ac1a51ca81a0017a8e Author: Katrin Fischer Date: Fri Jun 21 01:25:02 2019 +0000 Bug 23126: Remove more unnecessary linebreak processing from serial collection This should have no visible effect on the templates as the information the grep changes is not used in the template. It's also strange, that these lines existed, as GetSubscriptionsFromBiblionumber contained the same changes. Signed-off-by: David Nind Signed-off-by: Arthur Bousquet Signed-off-by: Nadine Pierre Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 316eda1036fd08f9c78578b27e85fd79c6895237 Author: Katrin Fischer Date: Tue Jun 18 08:06:10 2019 +0200 Bug 23126: Display multi-line entries in subscrpitions correctly There are several notes and other fields in a subscription that can be entered as multi-line input with breaks. We should display them as they were entered with keeping the line breaks intact. To test: - Add a subscription - Add comments including line breaks in internal and OPAC note - Check the manual history checkbox - Go to the subscription detail page, tab 'Planning' - Use the 'Edit history' link to edit the history - Enter content with line breaks in all the input fields where it's possible - Go to the OPAC detail page for your subscription record - Go to tab 'Subscriptions' > More details > Brief history - Verify the line breaks show there as
- Apply patch - Relaod page, verify all information displays correctly now - Go back to the detail page, subscription tab - verify same there - Go back to the subscription detail page in staff - Check editing the history works as expected - Verify information on all tabs displays correctly - Receive a serial issue - verify note on top displays right - Go to the serial collection page of the subscription - same there Signed-off-by: David Nind Signed-off-by: Nadine Pierre Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 2351693b61db83e0405157fd75951abee8df0116 Author: Julian Maurice Date: Wed Jun 19 12:07:58 2019 +0200 Bug 23156: Add pagination to checkouts in ILS-DI GetPatronInfo service When patrons have a lot of checkouts, GetPatronInfo can take a lot of time. This patch introduces two new parameters to allow pagination of this list of checkouts Also, fix a warning in C4::ILSDI::Services::GetPatronInfo Test plan: 1. Go to /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=X&show_loans=1 where X is a borrowernumber of a patron who has several checkouts Verify that all checkouts are listed 2. Add '&loans_per_page=1&loans_page=1' to the URL. Verify that you have now only one checkout listed, and that there is a new element which contain the total number of checkouts 3. Increase the page number in the URL until you have seen all checkouts 4. prove t/db_dependent/ILSDI_Services.t Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 6b6dc7bc791853d4dafb7f9ab02d3767c926ff08 Author: Nick Clemens Date: Fri Jun 21 11:02:43 2019 +0000 Bug 23179: Add 'edit subfields' button to framework management To test: 1) Go to Administration > MARC bibliographic framework 2) On a line click Actions > MARC structure 3) Note the dropdowns for each tag are: Edit, Subfields, Delete 4) Apply patch 5) Reload and note dropdowns are: Edit tag, View subfields, Edit subfields, Delete 6) Confirm options do what is selected Signed-off-by: Bin Wen Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize commit 7bc7cd4676632c835a16341191e07a5e7e13054a Author: Owen Leonard Date: Tue Jun 11 16:46:27 2019 +0000 Bug 23096: Add floating toolbar to OPAC lists This patch makes the list contents table's toolbar "stick" to the top of the screen when scrolling. Minor markup changes have been made to enable this change. To test, apply the patch and open a list in the OPAC which has multiple titles on it. Confirm that the toolbar sticks to the top of the screen when you scroll down. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/ILSDI/Services.pm | 17 ++- C4/Serials.pm | 3 - .../prog/en/modules/admin/marctagstructure.tt | 5 +- .../prog/en/modules/serials/serials-collection.tt | 2 +- .../prog/en/modules/serials/serials-edit.tt | 2 +- .../prog/en/modules/serials/subscription-detail.tt | 4 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- .../bootstrap/en/modules/opac-serial-issues.tt | 4 +- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 10 ++ misc/devel/install_plugins.pl | 112 ++++++++++++++++++++ opac/ilsdi.pl | 2 +- opac/opac-serial-issues.pl | 6 -- serials/serials-collection.pl | 4 - t/db_dependent/ILSDI_Services.t | 55 +++++++++- t/db_dependent/Serials.t | 27 ++++- 15 files changed, 227 insertions(+), 28 deletions(-) create mode 100755 misc/devel/install_plugins.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 26 10:22:42 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Jun 2019 08:22:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-220-g466f99e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 466f99e44230968aeb51598e50f65d212941c5b4 (commit) from 6c773a891704ee94c0e8159048c3c1aec62986d3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 466f99e44230968aeb51598e50f65d212941c5b4 Author: Jonathan Druart Date: Tue Jun 25 17:43:41 2019 -0500 Bug 23211: Prevent SIP/Transaction.t to fail randomly The checkout failed because patron's category is the one used for statistics (category_type=X). To recreate the failure: modified: t/db_dependent/SIP/Transaction.t @ Transaction.t:37 @ subtest fill_holds_at_checkout => sub { plan tests => 6; - my $category = $builder->build({ source => 'Category' }); + my $category = $builder->build({ source => 'Category', value => { category_type => 'X' }}); my $branch = $builder->build({ source => 'Branch' }); my $borrower = $builder->build({ source => 'Borrower', value =>{ branchcode => $branch->{branchcode}, Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: t/db_dependent/SIP/Transaction.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 26 16:40:57 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Jun 2019 14:40:57 +0000 Subject: [koha-commits] main Koha release repository branch 19.05.x updated. v19.05.00-78-g0d2ebac Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.05.x has been updated via 0d2ebac7649f35c9273c5181e81a21f654e71f85 (commit) from 0529975851150363a64e1528c84db29d0872ada9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d2ebac7649f35c9273c5181e81a21f654e71f85 Author: Jonathan Druart Date: Mon Jun 24 09:58:00 2019 -0500 Bug 23082: Fatal error editing a restricted patron In members/memberentry.pl we have to explicitely remove the template's params that are not patron's attributes. Certainly caused by commit 1bb6cec902088d07c7a43addc4b4adb5b0bf3d4f Bug 20287: Fix update of patrons, clean the data before ->store Test plan: Create a restriction for a patron Edit patron's details Remove the restriction => Without this patch you get "No property remove_debarment for Koha::Patron" => With this patch applied the restriction is removed Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize (cherry picked from commit 8947d5939fb33efd0887a6f443d392b9df17e2aa) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: members/memberentry.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 26 17:01:00 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Jun 2019 15:01:00 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-32-g5236cda Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 5236cdac02136a080595c0c4e692907e3f3ecedb (commit) via 9f708577bd3f85b4401d90ec113872dbca378d91 (commit) from d16af2544c62552ac6e8c96b18bb4cd4eb6fe1cb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5236cdac02136a080595c0c4e692907e3f3ecedb Author: Nick Clemens Date: Mon Jun 10 13:34:18 2019 +0000 Bug 14794: (follow-up) Add tooltip to filter box Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit ac41566cddb737c19282bc577cf31882f168384b) Signed-off-by: Fridolin Somers (cherry picked from commit c41379c0b8a1aab0802c3acde94bd071b57a296d) Signed-off-by: Lucas Gass commit 9f708577bd3f85b4401d90ec113872dbca378d91 Author: Nick Clemens Date: Fri Jun 7 14:53:16 2019 +0000 Bug 14794: Display JS tooltip whenever dateofbirth is being searched This updates the code that adds a tooltip for the correct date format to display after the initial search To test: 1 - Do a patron search, choosing date of birth as the search field 2 - Note on choosing that field you get a tooltip defining the format 3 - Do a search 4 - Note tooltip is gone, but date fo birth is still selected as the field to search 5 - Apply patch, reload 6 - Note tooltip shows after initial search and until field is changed Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 07d6e9f142a588f26c52582d9b5d99b714fa1fd7) Signed-off-by: Fridolin Somers (cherry picked from commit a0d2e4582c9351cd33196e061ed1414dc6ceac09) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/members-menu.js | 43 +++++++++++++++-------- 1 file changed, 28 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 26 17:06:33 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Jun 2019 15:06:33 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-33-g1eb77d6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 1eb77d6475872805407ff7512b8ebe578fbe4181 (commit) from 5236cdac02136a080595c0c4e692907e3f3ecedb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1eb77d6475872805407ff7512b8ebe578fbe4181 Author: Kyle M Hall Date: Thu Jun 16 11:08:59 2016 +0000 Bug 16750: Redirect from selectbranchprinter.pl to additem.pl causes software error How to reproduce: 1) Edit and save an item in the items editor 2) You should be redirected back to the items editor, note that the biblionumber is passed in the url 3) Choose "set library" from the upper right hand pulldown on the page 4) Choose a different library, click submit 5) You should get the error message: Software error: Can't call method "fields" on an undefined value at /home/vagrant/kohaclone/cataloguing/additem.pl line 736. Test Plan: 1) Apply this patch 2) Follow plan above 3) No software error should occur at step 5 Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 7d7c8c12e70295f4dd15a3435235c81539c333f5) Signed-off-by: Fridolin Somers (cherry picked from commit a539d9c4b6e88d290136b5218ea0ac3c982a39f5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 26 17:09:28 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Jun 2019 15:09:28 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-34-gde3abe6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via de3abe6cd8090c39f4daccc7dbe8d14afed9a93c (commit) from 1eb77d6475872805407ff7512b8ebe578fbe4181 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit de3abe6cd8090c39f4daccc7dbe8d14afed9a93c Author: Justin Rittenhouse Date: Fri May 31 16:37:11 2019 +0000 Bug 22585: remove double-escape for CAS URL The return URL that is part of the link to CAS login is double-escaped on the staff login page. It appears that this is the same issue as bug 21973 but in the staff intranet template. I have attached an identical patch for the intranet auth.tt file. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit a3e047f638ac7e6095d56c064f0e6cb8038a8524) Signed-off-by: Fridolin Somers (cherry picked from commit d782843a71caa60409807b01bb971c2805a6218c) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 26 17:11:30 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Jun 2019 15:11:30 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-35-g02e14bb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 02e14bb316080220082ecd88e4eb940817d94305 (commit) from de3abe6cd8090c39f4daccc7dbe8d14afed9a93c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 02e14bb316080220082ecd88e4eb940817d94305 Author: Nick Clemens Date: Mon Jun 10 13:42:18 2019 +0000 Bug 22585: (follow-up) Fix additional occurences Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 15dcde21fe9b34d287844aab75426e6387c7b4cf) Signed-off-by: Fridolin Somers (cherry picked from commit 518856e59405eeeac4bc9d7cff10cc0666664446) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 26 17:36:33 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Jun 2019 15:36:33 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-36-g5d7cd47 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via 5d7cd4771863ea94a6a81db1f8e136a272aad06a (commit) from 02e14bb316080220082ecd88e4eb940817d94305 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5d7cd4771863ea94a6a81db1f8e136a272aad06a Author: Owen Leonard Date: Tue Mar 5 18:56:55 2019 +0000 Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required." Signed-off-by: Maryse Simard Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize (cherry picked from commit 93c9b5d553261acda55f1f29f8687c5f4c276e04) Signed-off-by: Fridolin Somers (cherry picked from commit 8710c15c8aa074d54d6a04f6cbd2d8c0a3796d67) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 26 18:59:18 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Jun 2019 16:59:18 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-37-gf61cb04 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via f61cb044721d2fe3594b3e92f5d8f7da56ac4d04 (commit) from 5d7cd4771863ea94a6a81db1f8e136a272aad06a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f61cb044721d2fe3594b3e92f5d8f7da56ac4d04 Author: Jonathan Druart Date: Sat Jun 8 14:45:33 2019 -0500 Bug 22941: Do not return 500 if sortfield contain parenthesis Test plan: Hit /virtualshelves/shelves.pl?op=view&shelfnumber=1&sortfield=author( You must not get: Unmatched ( in regex; marked by <-- HERE in m/^author( <-- HERE $/ at /home/vagrant/kohaclone/virtualshelves/shelves.pl line 236 Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize Signed-off-by: Martin Renvoize (cherry picked from commit f8db499f4a9c71e7a2ffef0fadaecddb938330d4) Signed-off-by: Fridolin Somers (cherry picked from commit 5a1a3f0161ae15536137454dc1affb1724e9b58b) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: virtualshelves/shelves.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 26 19:10:34 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Jun 2019 17:10:34 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-39-gf85b8df Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via f85b8df1eb8b4de240f9e74a1e7bb70bb51c49a7 (commit) via d53330a64d60296027c2d46b4fa29205d3e27d12 (commit) from f61cb044721d2fe3594b3e92f5d8f7da56ac4d04 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f85b8df1eb8b4de240f9e74a1e7bb70bb51c49a7 Author: Lucas Gass Date: Wed Jun 26 16:49:43 2019 +0000 Bug 22770: DBRev 18.11.06.002 Signed-off-by: Lucas Gass commit d53330a64d60296027c2d46b4fa29205d3e27d12 Author: Katrin Fischer Date: Sun Jun 2 10:48:00 2019 +0200 Bug 22770: Fix typo in German language description of el Fixes: Griechisch (Moern [1453- ] ==> Griechisch (Modern 1453-) To test: - Install de-DE language and activate it - Check the language pull down on advanced search has the typo - Apply patch and run database update - Check advanced search again - Verify the description now shows correctly Signed-off-by: Liz Rea Signed-off-by: Martin Renvoize Signed-off-by: Martin Renvoize (cherry picked from commit eba980b3519263856c725cd42d4ff151d7822205) Signed-off-by: Fridolin Somers (cherry picked from commit 9aac2c9051922d16c7f726dc72ed6c95c3c932a5) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/mandatory/subtag_registry.sql | 2 +- installer/data/mysql/updatedatabase.pl | 8 ++++++++ 3 files changed, 10 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 26 19:14:28 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Jun 2019 17:14:28 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-40-gd8e5645 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via d8e56452c0d4b34e55499887516360a1139da902 (commit) from f85b8df1eb8b4de240f9e74a1e7bb70bb51c49a7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d8e56452c0d4b34e55499887516360a1139da902 Author: Jonathan Druart Date: Wed Jun 5 19:11:59 2019 -0500 Bug 23022: Remove the SQl mode NO_AUTO_CREATE_USER To make our sql mode list compatible with MySQL 8.0.11 NO_AUTO_CREATE_USER has been removed in MySQL 8.0.11 https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-11.html I do not think we needed it. Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 77716188757d11e2a9fa79788ce99982e3c39839) Signed-off-by: Fridolin Somers (cherry picked from commit 7bd5324c58181323a665aa2cf036de0f933b8f49) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: Koha/Database.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jun 26 19:35:18 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 26 Jun 2019 17:35:18 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-41-gf60f3ca Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via f60f3ca0e64f66bc72c09abbb230ac22ce343dbe (commit) from d8e56452c0d4b34e55499887516360a1139da902 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f60f3ca0e64f66bc72c09abbb230ac22ce343dbe Author: Owen Leonard Date: Tue May 21 12:07:10 2019 +0000 Bug 22945: Markup error in OPAC search results around lists display This patch makes minor corrections to the template for OPAC search results. These corrections fix errors returned by the HTML validator. To reproduce the problem, perform a search in the OPAC which will return results which are on one or more lists. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Text not allowed in element ul in this context." - "Stray end tag span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the search results view. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 1efe0d4606f844c28e2524d0341779381fc4980b) Signed-off-by: Fridolin Somers (cherry picked from commit 0529975851150363a64e1528c84db29d0872ada9) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 27 17:20:58 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 27 Jun 2019 15:20:58 +0000 Subject: [koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-42-gde41a7d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.11.x has been updated via de41a7de104f846e9d2b3bc967d0cd9de0173341 (commit) from f60f3ca0e64f66bc72c09abbb230ac22ce343dbe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit de41a7de104f846e9d2b3bc967d0cd9de0173341 Author: Jonathan Druart Date: Mon Jun 24 09:58:00 2019 -0500 Bug 23082: Fatal error editing a restricted patron In members/memberentry.pl we have to explicitely remove the template's params that are not patron's attributes. Certainly caused by commit 1bb6cec902088d07c7a43addc4b4adb5b0bf3d4f Bug 20287: Fix update of patrons, clean the data before ->store Test plan: Create a restriction for a patron Edit patron's details Remove the restriction => Without this patch you get "No property remove_debarment for Koha::Patron" => With this patch applied the restriction is removed Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize (cherry picked from commit 8947d5939fb33efd0887a6f443d392b9df17e2aa) Signed-off-by: Fridolin Somers (cherry picked from commit 0d2ebac7649f35c9273c5181e81a21f654e71f85) Signed-off-by: Lucas Gass ----------------------------------------------------------------------- Summary of changes: members/memberentry.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jun 27 22:18:38 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 27 Jun 2019 20:18:38 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-114-g4b47ac8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 4b47ac8b2df7b0d5de18fc556903d3992c02b7b2 (commit) via df28fcb33f9f04b040fe29408ddbc1662a72148e (commit) via a84fcfe1b2f8b9e37cf5ef54cda6c90c14dcda74 (commit) via e3463082a1764baedbd0030c6840b81c6dfd01d9 (commit) via ddca212bd458aab2276e9c4aacbc32205812e232 (commit) via 96e2d9cbcb14bb9114565b2997681288ac7d8401 (commit) via 855dbb44c222c32991f841c002c727572ad30256 (commit) via 41f52e2d298a75e5aa0ca55c829cc5d10ca88bbe (commit) via 7b4c6e218952a15d2b6bc15f1027205001d17b27 (commit) via f3e12af72efa049a6d216b886f674785a49d517b (commit) via bde475c055397495a7a494b8fa574005751e88df (commit) via 09280ec598b7c32c1cf4c8b47eeda09dd3013b63 (commit) from f50c9a95722c019aa5ce7f2a56693724430d6006 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4b47ac8b2df7b0d5de18fc556903d3992c02b7b2 Author: Liz Rea Date: Thu Jun 27 18:46:32 2019 +0000 Database update for 18.05.14 commit df28fcb33f9f04b040fe29408ddbc1662a72148e Author: Liz Rea Date: Thu Jun 27 18:40:45 2019 +0000 Bump version number for release Signed-off-by: Liz Rea commit a84fcfe1b2f8b9e37cf5ef54cda6c90c14dcda74 Author: Katrin Fischer Date: Sun May 12 00:34:03 2019 +0200 Bug 22886: Missing space between fields from Keyword to MARC mapping in cataloguing search If you have multiple subfields mapped to the 'subtitle' keyword, those fields will show up without separating space. To test: - Add 3 subtitle entries in Keyword to MARC mapping for a framework - 245 b - 245 c - 245 h - Edit a record, make sure the framework matches, add: - 245 b, c, h - Search for it in cataloguing search (not catalog!) - Verify the subtitle fields show, but are all concatenated - Apply patch - Search again and verify the display is improved with a separating space Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens (cherry picked from commit f00d909220ebde5162335e255e4ba938a9563bff) Signed-off-by: Martin Renvoize Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt Signed-off-by: Liz Rea commit e3463082a1764baedbd0030c6840b81c6dfd01d9 Author: Jonathan Druart Date: Sat May 11 10:23:28 2019 -0500 Bug 20514: Use streetnumber when searching for patrons by address The streetnumber field was ignored from the search. Test plan: Create a patron with streetnumber="12", address="rue des cerisiers" Search for patrons using the search field "street address" using: 12 rue des cerisiers => Without this patch the patron will not be returned => With this patch applied it will! Signed-off-by: Hayley Mapley Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 97ec0a2e4bf76cf2e67a7ddbd463d9942a4fe383) Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea commit ddca212bd458aab2276e9c4aacbc32205812e232 Author: Jonathan Druart Date: Wed May 1 21:05:30 2019 -0400 Bug 22781: Correctly filter the emails Ho, another bug! The email was not correctly filtered. Test plan: Use the evil string for an email, do a search. => Notice that without this patch the results never show up Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 5410186f6829fc4b74a845e8954bd7eea3f19862) Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea commit 96e2d9cbcb14bb9114565b2997681288ac7d8401 Author: Jonathan Druart Date: Wed May 1 20:54:02 2019 -0400 Bug 22781: Does not double filter address Ho, a bug! Some fields in the address where double filtered. Test plan: Use the evil strings in the address field and do a search, you will see double html encoded characters without this patch. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit ecb12104ffc7284089a1c8134ca8811e99e7419c) Signed-off-by: Martin Renvoize Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt Signed-off-by: Liz Rea commit 855dbb44c222c32991f841c002c727572ad30256 Author: Jonathan Druart Date: Wed May 1 20:29:05 2019 -0400 Bug 22781: Test patron's info filtering The patron's data was not correctly escaped actually. Test plan: This is a good value for the whole patchset: fir's"tname \123 ? use it for a patron's firstname, then do a search Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 35d00030ceb572822979300a5291356a32427a16) Signed-off-by: Martin Renvoize Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt Signed-off-by: Liz Rea commit 41f52e2d298a75e5aa0ca55c829cc5d10ca88bbe Author: Jonathan Druart Date: Wed May 1 20:28:04 2019 -0400 Bug 22781: Escape cardnumber, category's description, library's name and dateexpiry This will fix the previous failure. Note that other fields like borrowernumber, Price escaped values, integers, etc. could be escaped the same way but will be useless (save polar bears). Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 3a3057545c56f4f1a41fcd7643265204844cd2d3) Signed-off-by: Martin Renvoize Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt Signed-off-by: Liz Rea commit 7b4c6e218952a15d2b6bc15f1027205001d17b27 Author: Jonathan Druart Date: Wed May 1 20:28:55 2019 -0400 Bug 22781: Add tests Test plan: Apply only this patch => The tests will fail, the library's name is not correctly escaped. Note: This applies for the whole patchset, when the tests fail you will need to remove the patrons added by the tests with the following SQL query: delete from borrowers where surname like "test_patron_%"; We are expecting END to be called even if something goes wrong, but DESTROY must be used instead. This will be fixed separately, on its own bug report. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 6e8ecb8c6c8cf5d5188d2ad138e4fdbd8f395b3e) Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea commit f3e12af72efa049a6d216b886f674785a49d517b Author: Jonathan Druart Date: Fri May 10 12:27:40 2019 -0500 Bug 22878: Do not pass layout_id on creating a layout Attempting to create a patron card layout with mysql strict mode on gives the following error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1 Test plan: - Turn on sql_strict_modes - Create a new patron card => Must success with this patch applied Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 8d53fae9494b50c0cf2dcc98b18982b0d8fc416f) Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea commit bde475c055397495a7a494b8fa574005751e88df Author: Jonathan Druart Date: Fri May 10 12:27:34 2019 -0500 Bug 22878: Add tests Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 9f18afa7b34574cd872c94ee366a8d3e75085413) Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea commit 09280ec598b7c32c1cf4c8b47eeda09dd3013b63 Author: Aleisha Amohia Date: Mon Apr 29 03:14:35 2019 +0000 Bug 7862: Preventing warns when creating a notice To reproduce warns: 1) Go to Tools -> Notices & slips 2) Create a new notice of any module Notice these warns: Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. Use of uninitialized value $code in regexp compilation at /home/vagrant/kohaclone/tools/letter.pl line 265. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. 3) Create a new notice of the Circulation module Notice this additional warn: Use of uninitialized value $code in pattern match (m//) at /home/vagrant/kohaclone/tools/letter.pl line 258. To test: 4) Apply patch and refresh page 5) Run steps 1-3 again and confirm no warns show Sponsored-by: Catalyst IT Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens (cherry picked from commit 700b7dfa09e38c074cebbbb5caac64e031d5c0d5) Signed-off-by: Martin Renvoize Signed-off-by: Liz Rea ----------------------------------------------------------------------- Summary of changes: C4/Creators/Layout.pm | 1 + C4/Utils/DataTables/Members.pm | 2 +- Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + .../prog/en/modules/cataloguing/addbooks.tt | 4 +- .../en/modules/members/tables/members_results.tt | 12 +- svc/letters/get | 4 +- t/Patroncards_Layout.t | 14 --- t/db_dependent/Patroncards.t | 34 ++++++ t/db_dependent/selenium/patrons_search.t | 117 ++++++++++++++++++++ tools/letter.pl | 11 +- 11 files changed, 178 insertions(+), 29 deletions(-) delete mode 100755 t/Patroncards_Layout.t create mode 100755 t/db_dependent/Patroncards.t create mode 100644 t/db_dependent/selenium/patrons_search.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 28 15:54:20 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Jun 2019 13:54:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-225-gd5fd85d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d5fd85da18e7e3c548cc9d56689b09fd34615aed (commit) via 18767d62a873570637d199586bbeca4200e67d1c (commit) via 787b86f9d4d3aa83502f9b2afdc98d9ff6761b8e (commit) via e9bb407f62a208d42aefb03d16decd87bae228e7 (commit) via 4dcf416dc9547fd28e6ed846d08d6bbecb144552 (commit) from 466f99e44230968aeb51598e50f65d212941c5b4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d5fd85da18e7e3c548cc9d56689b09fd34615aed Author: Tomas Cohen Arazi Date: Mon Jun 24 10:28:00 2019 -0300 Bug 23193: Make set_password.pl use Koha::Script Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 18767d62a873570637d199586bbeca4200e67d1c Author: Martin Renvoize Date: Fri Jun 28 14:31:03 2019 +0100 Bug 22128: Add Rudolf Byker to contributors Signed-off-by: Martin Renvoize commit 787b86f9d4d3aa83502f9b2afdc98d9ff6761b8e Author: Mark Tompsett Date: Tue Jun 11 13:39:48 2019 +0000 Bug 22128: Removed outdated comment Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit e9bb407f62a208d42aefb03d16decd87bae228e7 Author: Rudolf Byker Date: Fri May 24 13:25:45 2019 -0500 Bug 22128: Use DROP USER IF EXISTS instead of GRANT USAGE before DROP USAGE MySQL 5.7 is old, and the latest versions fail on "GRANT USAGE" if the user does not exist. "DROP USER IF EXISTS" has been with us since 5.7, so all users should have it by now. This patch fixes the issue. To test: Try to koha_remove a site, and if it works with no errors, all good! Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize commit 4dcf416dc9547fd28e6ed846d08d6bbecb144552 Author: Nick Clemens Date: Wed Jun 26 12:49:14 2019 +0000 Bug 23220: Prevent form submission before redirect To test: 1 - Check in an item to generate a transfer (form another library, no floating) 2 - Check it in again, click 'Cancel transfer' 3 - It may or may not work 4 - To highlight the issue edit return.tt to add the delay line as below: $('.cancel-transfer').on("click",function(e){ delay(5000); window.location.href='/cgi-bin/koha/circ/returns.pl?itemnumber=[% itemnumber | html %]&canceltransfer=1' }); 5 - Check in the item repeatedly, click 'Cancel transfer' 6 - View the item in the staff or opac and verify it remains in transit 7 - Undo changes above, apply patch 8 - Test 'Cancel transfer', note it works 9 - Add the delay back in, confirm it still works Signed-off-by: Owen Leonard Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-remove | 7 ++----- docs/contributors.yaml | 3 +++ docs/history.txt | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 1 + misc/admin/set_password.pl | 1 + 5 files changed, 8 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 28 16:25:33 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Jun 2019 14:25:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-228-gfc39e24 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fc39e24eb502c1f724e8c5aa8b7264db901be278 (commit) via 1693c2e01d6eb001a35caf3bb31b9d057c2136fe (commit) via f50afc1fc0b9044c21564b45f44687993ebc07e3 (commit) from d5fd85da18e7e3c548cc9d56689b09fd34615aed (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fc39e24eb502c1f724e8c5aa8b7264db901be278 Author: Owen Leonard Date: Mon Jun 24 17:16:07 2019 +0000 Bug 23196: (follow-up) Add comments to highlight structure This follow-up adds a few comments to the markup in order to highlight and clarify the the HTML structure. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master You should only see the addition of HTML comments. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit 1693c2e01d6eb001a35caf3bb31b9d057c2136fe Author: Owen Leonard Date: Mon Jun 24 17:09:36 2019 +0000 Bug 23196: Reindent tools/batch_record_modification.tt This patch re-indents the template for batch record modifications. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize commit f50afc1fc0b9044c21564b45f44687993ebc07e3 Author: Owen Leonard Date: Fri Jun 21 14:07:49 2019 +0000 Bug 23183: Reindent cataloging.js This patch makes some very minor corrections to indentation in cataloging.js, a JavaScript file used by the bibliographic and item records editors. To test, apply the patch and perform a diff against master using the '-w' flag: git diff -w origin/master There should be no changes reported. Signed-off-by: Nadine Pierre Signed-off-by: Bin Wen Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: .../en/modules/tools/batch_record_modification.tt | 650 ++++++++++---------- koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 38 +- 2 files changed, 344 insertions(+), 344 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Jun 28 18:02:20 2019 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 28 Jun 2019 16:02:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v19.05.00-233-gbb80b2d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bb80b2d38b9861e7e81b76608cc097654b27fcb4 (commit) via 04f508452c151a530988c98717aa4a96e6d89398 (commit) via ad52ccd1be0ff9a23fdd31c24b5bab38b20b244e (commit) via 9e91662ac7bab81a6d3267d2e891c1ef5508a741 (commit) via 00b71e8ea3deb717a343a266888744939d23187b (commit) from fc39e24eb502c1f724e8c5aa8b7264db901be278 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bb80b2d38b9861e7e81b76608cc097654b27fcb4 Author: Martin Renvoize Date: Fri Jun 28 16:41:58 2019 +0100 Bug 17178: DBRev 19.06.00.009 Signed-off-by: Martin Renvoize commit 04f508452c151a530988c98717aa4a96e6d89398 Author: Martin Renvoize Date: Fri Jun 28 16:33:29 2019 +0100 Bug 17178: (RM follow-up) Use latest version of library This patch just updates us to the latest version of the jQuery library introduced in this patchset. Thankyou goes out to Josef Moravec who has already contributed a language translation upstream for Czech (and the reason I pulled in this updated library at this time) Signed-off-by: Martin Renvoize commit ad52ccd1be0ff9a23fdd31c24b5bab38b20b244e Author: Martin Renvoize Date: Fri Jun 28 15:52:37 2019 +0100 Bug 17178: (QA follow-up) Make DB update idempotent Signed-off-by: Martin Renvoize commit 9e91662ac7bab81a6d3267d2e891c1ef5508a741 Author: Agustin Moyano Date: Wed May 8 23:41:43 2019 -0300 Bug 17178: Add virtual keyboard to advanced cataloguing editor This patch adds Mottie keyboard (https://github.com/Mottie/Keyboard) to advanced editor. To test: 1) Apply patches 2) perl install/data/mysql/updatedatabase.pl 3) Enable EnableAdvancedCatalogingEditor system preference 4) Go to cataloguing and to Advanced editor 5) Click on Keyboard shortcuts SUCCESS => the keyboard shortcut "Ctrl-K" should be displayed, with "Toggle keyboard" as description 6) press Ctrl-K SUCCESS => a virtual keyboard should be displayed, and a new toolbar button labeled "Keyboard layout" should appear. => when you press a letter on both the physical and virtual keyboard, they should be added to the editor. 7) Click on "Keyboard layout" SUCCESS => a modal should appear, where you can filter and select keyboard layouts. => when you select a layout, it should be reflected on the keyboard. => when you close the modal without selecting a layout, it should keep using the previous layout. 8) Sign off Sponsored-by: Round Rock Public Library Signed-off-by: Liz Rea Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize commit 00b71e8ea3deb717a343a266888744939d23187b Author: Agustin Moyano Date: Tue May 14 02:57:07 2019 -0300 Bug 17178: Add shortcut to keyboard_shortcut table This patch adds Ctrl-K shortcut to toggle virtual keyboard shortcut Sponsored-by: Round Rock Public Library Signed-off-by: Liz Rea Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- .../data/mysql/mandatory/keyboard_shortcuts.sql | 3 +- installer/data/mysql/updatedatabase.pl | 11 + .../lib/keyboard/css/keyboard-basic.min.css | 1 + .../lib/keyboard/css/keyboard-dark.min.css | 1 + .../keyboard/css/keyboard-previewkeyset.min.css | 1 + .../lib/keyboard/css/keyboard.min.css | 1 + .../js/jquery.keyboard.extension-all.min.js | 5 + .../jquery.keyboard.extension-altkeyspopup.min.js | 2 + .../jquery.keyboard.extension-autocomplete.min.js | 2 + .../js/jquery.keyboard.extension-caret.min.js | 2 + .../js/jquery.keyboard.extension-extender.min.js | 2 + .../js/jquery.keyboard.extension-mobile.min.js | 2 + .../js/jquery.keyboard.extension-navigation.min.js | 2 + .../jquery.keyboard.extension-previewkeyset.min.js | 2 + .../js/jquery.keyboard.extension-scramble.min.js | 2 + .../js/jquery.keyboard.extension-typing.min.js | 2 + .../lib/keyboard/js/jquery.keyboard.js | 3570 ++++++++++++++++++++ .../lib/keyboard/js/jquery.keyboard.min.js | 2 + .../lib/keyboard/js/jquery.mousewheel.min.js | 2 + .../lib/keyboard/languages/all.min.js | 1 + .../intranet-tmpl/lib/keyboard/layouts/all.min.js | 5 + .../lib/koha/cateditor/marc-editor.js | 78 + koha-tmpl/intranet-tmpl/prog/css/cateditor.css | 12 + .../prog/en/includes/cateditor-ui.inc | 4 + .../prog/en/includes/keyboard_shortcuts.inc | 1 + .../prog/en/modules/cataloguing/editor.tt | 20 + 27 files changed, 3736 insertions(+), 2 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/css/keyboard-basic.min.css create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/css/keyboard-dark.min.css create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/css/keyboard-previewkeyset.min.css create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/css/keyboard.min.css create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-all.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-altkeyspopup.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-autocomplete.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-caret.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-extender.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-mobile.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-navigation.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-previewkeyset.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-scramble.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-typing.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.mousewheel.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/languages/all.min.js create mode 100644 koha-tmpl/intranet-tmpl/lib/keyboard/layouts/all.min.js hooks/post-receive -- main Koha release repository