[koha-commits] main Koha release repository branch master updated. v19.05.00-12-gd26991c

Mon Jun 3 20:12:15 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  d26991cf4cc298fc3900b8133ff9b40cd061fb96 (commit)
       via  87cbb27826a9d03a424e8c944293669157924a01 (commit)
       via  1653ae887103d783b91e00775f60e80041fd9860 (commit)
       via  457000102e7e2228c6bd834283a9e58f32bb2104 (commit)
       via  fa411c2f80d3464c9205f49fc31de492bc265c57 (commit)
       via  55289562468f77e6f6a2c1671d8a3ec472a50f99 (commit)
       via  d1b6e320860060ffe35e7df7f3df1b8c10517a73 (commit)
       via  01c4ee5703af156e2bb2057da83e156f9090be40 (commit)
      from  83af64f59fdc02c470f6e9754cbc922862aa1d18 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d26991cf4cc298fc3900b8133ff9b40cd061fb96
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue May 21 17:14:36 2019 +0000

    Bug 22955: Markup error in OPAC lists template

    This patch makes a minor correction to the template for OPAC lists.
    This correction fixes an error returned by the HTML validator by adding
    an empty "alt" attribute to an image tag.

    To reproduce the problem you should have at least one list available in
    the OPAC with one or more items on it. View the contents of that list in
    the OPAC. Run the page through the W3C validation service:
    https://validator.w3.org. Either by pasting in the URL for the search
    results (if web accessible) or by viewing source, copying, and pasting
    into "Validate by Direct Input."

    This patch addresses one specific error:

     - "An img element must have an alt attribute, except
        under certain conditions."

    To test, apply the patch and try again to reproduce the validation
    error. The error should no longer be present. There should be no
    visible change to the page.

    Click "Download list." A modal window should appear with a "Loading"
    message, followed by a form for selecting a download format.

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 87cbb27826a9d03a424e8c944293669157924a01
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue May 21 13:19:17 2019 +0000

    Bug 22947: Markup error in OPAC preferences file

    This patch corrects a markup error in the OPAC .pref file which can
    cause display problems. The patch also corrects a validator warning by
    changing at <tt> to a <code>.

    To reproduce the problem, go to Administration -> Global system
    preferences -> OPAC.

    Run the page through the W3C validation service:
    https://validator.w3.org. Either by pasting in the URL for the search
    results (if web accessible) or by viewing source, copying, and pasting
    into "Validate by Direct Input."

    This patch addresses two specific errors:

     - "Unclosed element code."
     - "The tt element is obsolete. Use CSS instead."

    To test, apply the patch and try again to reproduce the validation
    errors. Those errors should no longer be present. There should be no
    visible change to the display.

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1653ae887103d783b91e00775f60e80041fd9860
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Jun 3 18:46:40 2019 +0100

    Bug 22950: Compiled CSS

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 457000102e7e2228c6bd834283a9e58f32bb2104
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue May 21 15:04:33 2019 +0000

    Bug 22950: Markup error in OPAC recent comment template

    This patch makes minor corrections to the template for the OPAC's
    recent comments view. These corrections fix errors returned by the HTML
    validator.

    The patch moves some inline CSS into a class in the global OPAC CSS.
    Some minor reindentation has also been done, so use diff with the '-w'
    flag.

    To reproduce the problem you should have the 'reviewson' system
    preference turned on, and your system should have one or more
    approved comments. View the "Recent comments" page in the OPAC. Run the
    page through the W3C validation service: https://validator.w3.org.
    Either by pasting in the URL for the search results (if web accessible)
    or by viewing source, copying, and pasting into "Validate by Direct
    Input."

    This patch addresses one specific error:

     - "CSS: font-color: Property font-color doesn't exist."

    To test, apply the patch and rebuild the OPAC CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

    Try again to reproduce the validation errors. Those errors should no
    longer be present. There should be no visible change to the page.

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fa411c2f80d3464c9205f49fc31de492bc265c57
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu May 9 16:34:09 2019 +0100

    Bug 22877: (QA follow-up) Clarify intent of tests and remove one.

    This patch embelishes the existing comments slightly and removes a test
    which had a FIXME, but was in fact just a duplicate of the test directly
    above it.  I beleive it became a duplicate after the subroutine signature
    changed at some point recently.  I also move the bug 22877 specific test
    into a subtest.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 55289562468f77e6f6a2c1671d8a3ec472a50f99
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu May 9 16:00:59 2019 +0100

    Bug 22877: (follow-up) Fix test plan count

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d1b6e320860060ffe35e7df7f3df1b8c10517a73
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu May 9 15:53:56 2019 +0100

    Bug 22877: Prevent double overdue processing for lost and returned

    Test plan:
    1 - Issue an item to a patron with a backdated due date
    2 - Run fines.pl - note you generate a fine for the patron
    3 - Run longoverdue.pl - make sure MarkLostItemsAsReturned is turned off
    and to charge
    4 - Confirm the patron has a lost fee and an overdue
    5 - Return the item
    6 - With patch applied, patron should now have 1 overdue fine and 1 lost fine

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 01c4ee5703af156e2bb2057da83e156f9090be40
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu May 9 12:32:38 2019 +0000

    Bug 22877: Unit test to highlight problem

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    2 +-
 .../prog/en/modules/admin/preferences/opac.pref    |    4 +-
 koha-tmpl/opac-tmpl/bootstrap/css/opac.css         |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss    |    5 ++
 .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt |    2 +-
 .../bootstrap/en/modules/opac-showreviews.tt       |   41 +++++++------
 t/db_dependent/Circulation.t                       |   63 ++++++++++++++++----
 7 files changed, 84 insertions(+), 35 deletions(-)

hooks/post-receive
-- 
main Koha release repository