[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.00-16-g67bddf7
Git repo owner
gitmaster at git.koha-community.org
Mon Jun 10 17:03:26 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 19.05.x has been updated
via 67bddf78e245e5ef2dfe1c3040e5c820124a3b99 (commit)
via 6b44e314577ade8b92ae330668510ae94f2f6469 (commit)
via 93cc499ed786630840845df21b4f52a2da4e6ea8 (commit)
via 6dd6ce120ad28f16fcddfb8acc94a019a7c34509 (commit)
via 483f94e7202bfa14ed8e910e0f2b4db229b8d8c5 (commit)
via 327977abd6fe95ff8ee8f743d690e3efc45501d5 (commit)
via f59aff442748b447caab068743f011f94ff3ad29 (commit)
via 43e16861da807876e2b041c6a5bc78fdebefbbee (commit)
via 50eaced45a52615d4125726e146552ac54ac2594 (commit)
via 3b805b8b81af5faf31e0f71472cce541961fcba0 (commit)
via 76074180ead15621b63ac84cedc43f3df151ca1c (commit)
via b551b502f768317ff01323ba24c4e9bee0a3b74f (commit)
via 39bb183f5387fedc01428e08d8633bf6bf666c81 (commit)
via f9f8c1e3831b87dd2747605008e798f9d4d09f7f (commit)
via f2bbefc4038598137d5a3eab60d9ffaa5142b0ef (commit)
via 9cf37c375a0dacf63baff16b5211b8dfac493691 (commit)
from 1b5635bebd75c418fdda68036e1e91f857cb1e4d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 67bddf78e245e5ef2dfe1c3040e5c820124a3b99
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 12 09:38:39 2018 -0700
Bug 19457: Handle 'PREVISSUE' return by CanBookBeIssued from SIP (CheckPrevCheckout)
If CheckPrevCheckout is set to Do, then checkouts are blocked at the SIPServer
To test:
- Do not apply this patch
- Set CheckPrevCheckout to "Do", or "Unless overridden, do"
Verify the SIP server is blocking checkouts with this setting set
- Apply this patch
- Note that the checkout is now allowed, with a screen message telling
the borrower they've issued the item before.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit b40e58343ef65aabe0a575a0b3f842b5e22a3600)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 6b44e314577ade8b92ae330668510ae94f2f6469
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Fri Dec 14 02:05:36 2018 +0000
Bug 11492: (follow-up) Don't pass publisheddatetext param to NewIssue
I have removed publisheddatetext as a param from my patch, but only in
the places where my patch added it. Any other instance already existed
before my patch.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit ac423d5dcf2c7503a8ca78cbafdb94dfc43dfdb6)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 93cc499ed786630840845df21b4f52a2da4e6ea8
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Fri Dec 7 01:03:42 2018 +0000
Bug 11492: Keep routing notes when receiving next serial
This patch ensures the routing notes are carried over when generating
the next serial.
To test:
1) Create a routing list for a subscription
2) Add a borrower and a note to the routing list
3) Generate the next serial (serials-collection.pl)
4) Edit the routing list to see the notes
5) Note that the notes have disappeared
6) Apply patch
7) Edit the routing list, add a note
8) Generate the next serial
9) Edit the routing list and confirm the note is still there
10) Confirm you are still able to edit serials (serials-edit.pl) and
routing notes stay
Sponsored-by: Plant and Food Research Limited
Signed-off-by: Nazlı Çetin <nazli at devinim.com.tr>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 2c25016a8e17b52e23c3d9806264e141b6426254)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 6dd6ce120ad28f16fcddfb8acc94a019a7c34509
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date: Thu Mar 21 14:39:59 2019 +1300
Bug 22099: Fixed ILL toolbar to say Refresh when displaying requests
On the ILL requests page that lists all requests, the List Request
button is displayed as part of the ILL toolbar. This patch fixes this by
instead changing the wording of the button to Refresh when on the main
page.
Test plan:
1) More -> ILL Requests, note that the List Requests button displays
while all the requests are already displayed
2) Apply the patch and restart things
3) More -> ILL Requests, note that the button now says Refresh, and
clicking it refreshes the page
4) Check that on all the other functions of the ILLs the button says
List Requests
5) Sign off!
Sponsored-by: Catalyst IT
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Small conflict resolved. Works as advertised.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 66877b780a775daf135ef1137364d76f67166e61)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 483f94e7202bfa14ed8e910e0f2b4db229b8d8c5
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue May 21 17:14:36 2019 +0000
Bug 22955: Markup error in OPAC lists template
This patch makes a minor correction to the template for OPAC lists.
This correction fixes an error returned by the HTML validator by adding
an empty "alt" attribute to an image tag.
To reproduce the problem you should have at least one list available in
the OPAC with one or more items on it. View the contents of that list in
the OPAC. Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."
This patch addresses one specific error:
- "An img element must have an alt attribute, except
under certain conditions."
To test, apply the patch and try again to reproduce the validation
error. The error should no longer be present. There should be no
visible change to the page.
Click "Download list." A modal window should appear with a "Loading"
message, followed by a form for selecting a download format.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit d26991cf4cc298fc3900b8133ff9b40cd061fb96)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 327977abd6fe95ff8ee8f743d690e3efc45501d5
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue May 21 13:19:17 2019 +0000
Bug 22947: Markup error in OPAC preferences file
This patch corrects a markup error in the OPAC .pref file which can
cause display problems. The patch also corrects a validator warning by
changing at <tt> to a <code>.
To reproduce the problem, go to Administration -> Global system
preferences -> OPAC.
Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."
This patch addresses two specific errors:
- "Unclosed element code."
- "The tt element is obsolete. Use CSS instead."
To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the display.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 87cbb27826a9d03a424e8c944293669157924a01)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit f59aff442748b447caab068743f011f94ff3ad29
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Jun 10 16:01:28 2019 +0200
Bug 22950: Compiled CSS
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 43e16861da807876e2b041c6a5bc78fdebefbbee
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue May 21 15:04:33 2019 +0000
Bug 22950: Markup error in OPAC recent comment template
This patch makes minor corrections to the template for the OPAC's
recent comments view. These corrections fix errors returned by the HTML
validator.
The patch moves some inline CSS into a class in the global OPAC CSS.
Some minor reindentation has also been done, so use diff with the '-w'
flag.
To reproduce the problem you should have the 'reviewson' system
preference turned on, and your system should have one or more
approved comments. View the "Recent comments" page in the OPAC. Run the
page through the W3C validation service: https://validator.w3.org.
Either by pasting in the URL for the search results (if web accessible)
or by viewing source, copying, and pasting into "Validate by Direct
Input."
This patch addresses one specific error:
- "CSS: font-color: Property font-color doesn't exist."
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Try again to reproduce the validation errors. Those errors should no
longer be present. There should be no visible change to the page.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 457000102e7e2228c6bd834283a9e58f32bb2104)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 50eaced45a52615d4125726e146552ac54ac2594
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Jun 10 15:50:57 2019 +0200
Bug 22906: Compiled CSS
commit 3b805b8b81af5faf31e0f71472cce541961fcba0
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue May 14 13:10:32 2019 +0000
Bug 22906: Minor corrections to plugins home page
This patch makes a few minor markup improvements to the plugins home
page and corrects some CSS introduced by Bug 22053 which was having
unintended consequences elsewhere.
To test, apply the patch and rebuild the staff client CSS.
- You should have one or more plugins installed.
- Go to Administration -> Manage plugins.
- The "badges" for disabled and enabled should look correct.
- Go to Tools -> Staged MARC management and click on an batch.
- In the information about the batch, the labels should be bold.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit e9294c3cc20584adebb6d38451ebccce86a8f1aa)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 76074180ead15621b63ac84cedc43f3df151ca1c
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu May 9 16:34:09 2019 +0100
Bug 22877: (QA follow-up) Clarify intent of tests and remove one.
This patch embelishes the existing comments slightly and removes a test
which had a FIXME, but was in fact just a duplicate of the test directly
above it. I beleive it became a duplicate after the subroutine signature
changed at some point recently. I also move the bug 22877 specific test
into a subtest.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit fa411c2f80d3464c9205f49fc31de492bc265c57)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit b551b502f768317ff01323ba24c4e9bee0a3b74f
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu May 9 16:00:59 2019 +0100
Bug 22877: (follow-up) Fix test plan count
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 55289562468f77e6f6a2c1671d8a3ec472a50f99)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 39bb183f5387fedc01428e08d8633bf6bf666c81
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu May 9 15:53:56 2019 +0100
Bug 22877: Prevent double overdue processing for lost and returned
Test plan:
1 - Issue an item to a patron with a backdated due date
2 - Run fines.pl - note you generate a fine for the patron
3 - Run longoverdue.pl - make sure MarkLostItemsAsReturned is turned off
and to charge
4 - Confirm the patron has a lost fee and an overdue
5 - Return the item
6 - With patch applied, patron should now have 1 overdue fine and 1 lost fine
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit d1b6e320860060ffe35e7df7f3df1b8c10517a73)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit f9f8c1e3831b87dd2747605008e798f9d4d09f7f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu May 9 12:32:38 2019 +0000
Bug 22877: Unit test to highlight problem
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 01c4ee5703af156e2bb2057da83e156f9090be40)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit f2bbefc4038598137d5a3eab60d9ffaa5142b0ef
Author: Nightly Build Bot <nightly at abunchofthings.net>
Date: Tue Jun 4 14:44:58 2019 +0200
Bug 17108- Automatic debian/control updates (stable/19.05.x)
commit 9cf37c375a0dacf63baff16b5211b8dfac493691
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue May 21 16:29:06 2019 +0000
Bug 22953: Markup warning in OPAC user summary template
This patch makes a minor markup change to the OPAC user summary template
(opac-user.tt) in order to quiet warnings from the HTML validator. The
obsolete name attribute on two links is removed in favor of class names.
The JavaScript has been modified accordingly.
To reproduce the problem you should have the AllowCheckoutNotes system
preference enabled. Log in to the OPAC as a user who has checkouts and
view the "your summary" page. Run the page through the W3C validation
service: https://validator.w3.org. Either by pasting in the URL for the
search results (if web accessible) or by viewing source, copying, and
pasting into "Validate by Direct Input."
This patch specifically addresses this warning:
- "The name attribute is obsolete. Consider putting an id attribute on
the nearest container instead."
To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.
Test the process of adding or editing an note on a checkout. It should
work correctly.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit a4844b85eed809c20053adb7862c21601d6cf148)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 2 +-
C4/SIP/ILS/Transaction/Checkout.pm | 3 +
C4/Serials.pm | 18 +++---
debian/control | 4 +-
.../intranet-tmpl/prog/css/src/staff-global.scss | 18 ++++--
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../intranet-tmpl/prog/en/includes/ill-toolbar.inc | 12 +++-
.../prog/en/modules/admin/preferences/opac.pref | 4 +-
.../prog/en/modules/plugins/plugins-home.tt | 14 ++---
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 5 ++
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
.../bootstrap/en/modules/opac-showreviews.tt | 41 +++++++------
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 8 +--
serials/serials-collection.pl | 5 +-
serials/serials-edit.pl | 3 +-
t/db_dependent/Circulation.t | 63 ++++++++++++++++----
t/db_dependent/Serials.t | 2 +-
18 files changed, 137 insertions(+), 71 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list