[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.06-1-ge8e83db

Git repo owner gitmaster at git.koha-community.org
Mon Jun 10 23:28:29 CEST 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  e8e83db8587fc484f149d576933c0a61dd1c4354 (commit)
      from  63a2fe541a4ef87378df55ab3dde5a3688159854 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e8e83db8587fc484f149d576933c0a61dd1c4354
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue May 21 16:29:06 2019 +0000

    Bug 22953: Markup warning in OPAC user summary template
    
    This patch makes a minor markup change to the OPAC user summary template
    (opac-user.tt) in order to quiet warnings from the HTML validator. The
    obsolete name attribute on two links is removed in favor of class names.
    The JavaScript has been modified accordingly.
    
    To reproduce the problem you should have the AllowCheckoutNotes system
    preference enabled. Log in to the OPAC as a user who has checkouts and
    view the "your summary" page. Run the page through the W3C validation
    service: https://validator.w3.org. Either by pasting in the URL for the
    search results (if web accessible) or by viewing source, copying, and
    pasting into "Validate by Direct Input."
    
    This patch specifically addresses this warning:
    
     - "The name attribute is obsolete. Consider putting an id attribute on
       the nearest container instead."
    
    To test, apply the patch and try again to reproduce the validation
    errors. Those errors should no longer be present. There should be no
    visible change to the page.
    
    Test the process of adding or editing an note on a checkout. It should
    work correctly.
    
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a4844b85eed809c20053adb7862c21601d6cf148)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
    (cherry picked from commit 9cf37c375a0dacf63baff16b5211b8dfac493691)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list