[koha-commits] main Koha release repository branch master updated. v19.05.00-118-g60ba3e8

Git repo owner gitmaster at git.koha-community.org
Tue Jun 18 19:26:58 CEST 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  60ba3e8c639bf4ade1b3d837250468b979da4728 (commit)
       via  c3cc7c06b39f1a47238dc50175de07668e5c2668 (commit)
       via  688967e6eaab4c1f5670cbef254cb4a7101c4e18 (commit)
       via  0cca2795cdae643a6a94b95ad7879c363006cfed (commit)
       via  4adb1791c66a3577d32f10c417e4953a86f5769f (commit)
       via  c13eb384b3db124611bbe1c8d49df3017bfe86f9 (commit)
       via  3175eebdfcb9a8bd0c7fa3cfd456e928c081976f (commit)
       via  0bdb41bf1a7aaec3cbcde969527113b59b72144a (commit)
       via  493292b36c1513a90415d144ec72c10e36ff7968 (commit)
       via  22aa6ecd478c1c5a08eecb2780f5c0b1b7589b99 (commit)
       via  81186ea2696dd23f37e539cc25b73e6355ffddc0 (commit)
       via  f380a06cb99c99f74c3475a3b93f18ca9883a8b1 (commit)
       via  50bdd416e68e76c573932b01ea97e4b241171d87 (commit)
       via  a080ffdf76bf3056f0c422d632f87bb2b8a92d92 (commit)
       via  e42b571269dfb737ec7184f67ff95b7a6ff3a692 (commit)
       via  b4088b93a4fc26b442d43eafad98025ca11441d0 (commit)
       via  96c0c7d0bd7326809de4929e52b6c98c525e8cff (commit)
       via  3f16d3b8e5d9f5deed2705d2de684b2e5850e210 (commit)
       via  2270ab4056972b669ab24189979924a0243fa282 (commit)
       via  9d81b1dd7ad1bb2957630e1ec40d636d8839bb16 (commit)
       via  1ed59cbe5565ca493702691d3a8811f4ebc4da17 (commit)
      from  6dd40712c1c20af3408c50546d9b97560082ce2c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 60ba3e8c639bf4ade1b3d837250468b979da4728
Author: Agustin Moyano <agustinmoyano at theke.io>
Date:   Thu May 16 00:09:38 2019 -0300

    Bug 22835: (follow-up) Remove comented code
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c3cc7c06b39f1a47238dc50175de07668e5c2668
Author: Agustin Moyano <agustinmoyano at theke.io>
Date:   Fri May 3 00:15:12 2019 -0300

    Bug 22835: (follow-up) Remove unwanted warn
    
    Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 688967e6eaab4c1f5670cbef254cb4a7101c4e18
Author: Agustin Moyano <agustinmoyano at theke.io>
Date:   Thu Apr 25 02:13:37 2019 -0300

    Bug 22835: Serve plugin static files through API
    
    This patch serves static files declared within plugins.
    
    To declare static files the plugin must implement the method 'static_routes' which retrieves the spec of static file routes to add to the API.
    
    Once those routes are added to the API, the become available through the /api/v1/contrib/<api_namespace>/static/<path>/<to>/<file>/<filename> endpoint.
    
    To test:
    1) Install bug-22835-plugin.kpz
    2) Point your browser to /api/v1/contrib/kitchensink/static/static_files/mm.gif
    CHECK => No file is served
    3) Apply this patch
    4) restart_all
    5) Repeat step 2.
    SUCCESS => File is served!
    6) Sign off
    
    Sponsored-by: Theke Solutions
    Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0cca2795cdae643a6a94b95ad7879c363006cfed
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 2 15:51:30 2019 -0300

    Bug 22834: Add Koha::Plugins::Base->bundle_path
    
    This patch adds a 'bundle_path' method that return the base path for
    assets included in the plugin. The idea is that it will be used for
    calculation of the absolute path in the filesystem for static content.
    
    To test:
    - Apply the unit tests patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Plugins.t
    => FAIL: The method is not implemented
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Plugins.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4adb1791c66a3577d32f10c417e4953a86f5769f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 2 15:51:17 2019 -0300

    Bug 22834: Add tests for Koha::Plugins::Base->bundle_path
    
    Signed-off-by: Arthur Suzuki <arthur.suzuki at biblibre.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c13eb384b3db124611bbe1c8d49df3017bfe86f9
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Jun 18 17:23:15 2019 +0100

    Bug 21073: DBRev 19.06.00.006
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3175eebdfcb9a8bd0c7fa3cfd456e928c081976f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jun 17 08:18:48 2019 -0300

    Bug 21073: (QA follow-up) Avoid unnecessary unless/else construct
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0bdb41bf1a7aaec3cbcde969527113b59b72144a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jun 17 08:17:43 2019 -0300

    Bug 21073: (QA follow-up) Don't call -> twice!
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 493292b36c1513a90415d144ec72c10e36ff7968
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jun 17 08:07:03 2019 -0300

    Bug 21073: (QA follow-up) Simplify logic
    
    This patch simplifies the logic inside GetPlugins so:
    - It uses Koha::Plugins::Methods instead of plain SQL
    - It doesn't do more DB calls than needed, by filtering on method in the
      initial query to Koha::Plugins::Methods.
    
    It also relies on the (newly introduced) ->is_enabled method in
    Koha::Plugins::Base, for better readability.
    
    To test:
    - Run the tests and notice no behaviour changes are introduced.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 22aa6ecd478c1c5a08eecb2780f5c0b1b7589b99
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jun 17 08:06:23 2019 -0300

    Bug 21073: (QA follow-up) Add ->is_enabled and tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 81186ea2696dd23f37e539cc25b73e6355ffddc0
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jun 14 16:51:07 2019 -0300

    Bug 21073: (QA follow-up) Only public subs should be considered
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f380a06cb99c99f74c3475a3b93f18ca9883a8b1
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jun 14 16:38:15 2019 -0300

    Bug 21073: (follow-up) Add Class::Inspector to PerlDependencies
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 50bdd416e68e76c573932b01ea97e4b241171d87
Author: Agustin Moyano <agustinmoyano at theke.io>
Date:   Wed May 15 20:49:08 2019 -0300

    Bug 21073: (follow-up) QA fixes after rebase
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a080ffdf76bf3056f0c422d632f87bb2b8a92d92
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 2 13:15:49 2019 -0300

    Bug 21073: Restore filtering by metadata
    
    This patch restores filtering the plugins by metadata. That got lost on
    rebase at some point. Regression tests are added on a prior patch.
    
    To test:
    - Have the 'regression tests for GetPlugins' patch applied
    - Run:
      $ kshell
     k$ prove t/db_dependent/Plugins.t
    => FAIL: Tests fail!
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Plugins.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e42b571269dfb737ec7184f67ff95b7a6ff3a692
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 2 14:00:52 2019 -0300

    Bug 21073: Regression tests for GetPlugins
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b4088b93a4fc26b442d43eafad98025ca11441d0
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 2 12:12:10 2019 -0300

    Bug 21073: (QA follow-up) Remove unused libraries
    
    Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 96c0c7d0bd7326809de4929e52b6c98c525e8cff
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 2 12:14:50 2019 -0300

    Bug 21073: (QA follow-up) Restore check on template
    
    Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 3f16d3b8e5d9f5deed2705d2de684b2e5850e210
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 2 11:42:18 2019 -0300

    Bug 21073: (QA follow-up) Atomic update shouldn't fail if plugins are disabled
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2270ab4056972b669ab24189979924a0243fa282
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Apr 22 09:58:18 2019 -0400

    Bug 21073: Upgrade the kitchen sink plugin to get rid of warnings
    
    Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9d81b1dd7ad1bb2957630e1ec40d636d8839bb16
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Jul 13 12:40:52 2018 -0400

    Bug 21073: Improve plugin performance
    
    Right now, to check if a plugin is functional and what methods it exposes we load the module and test for a given method at run time. This is highly inefficient. It makes far more sense to do this at install time and store the data in the db. I believe we should store a table of methods that each plugin exposes and check that instead. Then, at install time we can test that a) the plugin can be loaded and b) add the available methods to the plugin_methods table.
    
    Test Plan:
    1) Apply this patch
    2) Restart all the things
    3) Run updatedatabase.pl
    4) Verify you can use existing plugins
    5) Verify you can install new plugins
    
    Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1ed59cbe5565ca493702691d3a8811f4ebc4da17
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Jul 13 08:55:32 2018 -0400

    Bug 21073: Add new table, schema and classes
    
    Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Installer/PerlDependencies.pm                 |    5 +
 Koha.pm                                          |    2 +-
 Koha/Plugins.pm                                  |   83 +++++++++--
 Koha/Plugins/Base.pm                             |   30 ++++
 Koha/Plugins/Handler.pm                          |   17 +--
 Koha/{FieldMapping.pm => Plugins/Method.pm}      |    6 +-
 Koha/{BiblioFrameworks.pm => Plugins/Methods.pm} |   14 +-
 Koha/REST/Plugin/PluginRoutes.pm                 |   42 ++++--
 Koha/REST/V1/Static.pm                           |   84 +++++++++++
 Koha/Schema/Result/PluginMethod.pm               |   67 +++++++++
 installer/data/mysql/kohastructure.sql           |   11 ++
 installer/data/mysql/updatedatabase.pl           |   20 +++
 plugins/plugins-upload.pl                        |    6 +-
 t/db_dependent/KitchenSinkPlugin.kpz             |  Bin 75857 -> 81187 bytes
 t/db_dependent/Plugins.t                         |  168 ++++++++++++++++++----
 t/lib/Koha/Plugin/Test.pm                        |    4 +
 16 files changed, 482 insertions(+), 77 deletions(-)
 copy Koha/{FieldMapping.pm => Plugins/Method.pm} (88%)
 copy Koha/{BiblioFrameworks.pm => Plugins/Methods.pm} (81%)
 create mode 100644 Koha/REST/V1/Static.pm
 create mode 100644 Koha/Schema/Result/PluginMethod.pm


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list