[koha-commits] main Koha release repository branch 19.05.x updated. v19.05.00-77-g0529975

Thu Jun 20 16:29:11 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 19.05.x has been updated
       via  0529975851150363a64e1528c84db29d0872ada9 (commit)
       via  bf11cd06c556322fe0ed52c3cbf0352ff0bdcc5f (commit)
       via  cf1c06e8f059b6ac017132fa451d9e5df0d6c4f2 (commit)
       via  aeb70dd2d280d6dd912bebdfa2202c86723dd72e (commit)
       via  1f0c8fd9bdd819f872a287538de976ccbea0cbda (commit)
       via  2def4aee187eeaf3fb48b3ebfaa85ce6c48f2fe6 (commit)
       via  b57aaed3fffeb4017dbde770bd30cb4ea5a74097 (commit)
       via  8c8d86ef30f38d13f75d7ed1600b3d27b70a6568 (commit)
       via  a8cc9d5f49f36a5bf69265f3062f1a7a8ee0fdf4 (commit)
       via  16858fd5d5b14680bce00a5c7c85c62c9584980e (commit)
       via  6a3c93eeeba7d6457af22cb31c6464e3ac5786f9 (commit)
       via  eecce39379b590aa6615d63da109431358d03846 (commit)
       via  d017e2f7c412001677b2cec08781977d5935e8ee (commit)
       via  7bd5324c58181323a665aa2cf036de0f933b8f49 (commit)
      from  b728906d349a901e4ca443c2dcea9815020b3a9f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0529975851150363a64e1528c84db29d0872ada9
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue May 21 12:07:10 2019 +0000

    Bug 22945: Markup error in OPAC search results around lists display

    This patch makes minor corrections to the template for OPAC search
    results. These corrections fix errors returned by the HTML validator.

    To reproduce the problem, perform a search in the OPAC which will return
    results which are on one or more lists. Run the page through the W3C
    validation service: https://validator.w3.org. Either by pasting in the
    URL for the search results (if web accessible) or by viewing source,
    copying, and pasting into "Validate by Direct Input."

    This patch addresses two specific errors:

     - "Text not allowed in element ul in this context."
     - "Stray end tag span."

    To test, apply the patch and try again to reproduce the validation
    errors. Those errors should no longer be present. There should be no
    visible change to the search results view.

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 1efe0d4606f844c28e2524d0341779381fc4980b)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit bf11cd06c556322fe0ed52c3cbf0352ff0bdcc5f
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Thu Jun 13 19:27:00 2019 +0000

    Bug 17526: Change grep to deal with malformed sortfield

    Giving sortfield a malformed value when viewing lists results in
    Internal Server Error.

    eg.
    http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=1&sortfield=title(

    Note the trailing (

    Before Patch: kaboom
    apply patch
    restart
    After Patch: No kaboom

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 42a26a758079830758a51845b4526e681b75d434)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit cf1c06e8f059b6ac017132fa451d9e5df0d6c4f2
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Mon Jun 17 13:54:39 2019 +0000

    Bug 23104: (follow-up) fix display for 0/Unlimited

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 6a75f99200f6659d09e46ce9e11c5ded11020d89)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit aeb70dd2d280d6dd912bebdfa2202c86723dd72e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jun 13 11:28:40 2019 -0500

    Bug 23104: Add tests for maxonsiteissueqty

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 5b7e563f4e923bb5cf9f6b1f6ecef3bdc8b77f52)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 1f0c8fd9bdd819f872a287538de976ccbea0cbda
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 12 09:12:27 2019 -0500

    Bug 23104: (bug 18925 follow-up): Fix null/empty behavior, again

    Not kidding, it's again, and will certainly appear more.
    The problem is that we should have a NULL value in DB to make things
    more readable and logical. Now we need a quick fix.

    Test plan:
    Set "Current checkouts allowed" to unlimited (empty string)
    Try to check an item out
    => Without this patch we are blocked with a "too many" message
    => With this patch applied the correct behavior is back!

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 8c8e36cf7abf51113654c5e1c0497f918a1cd56c)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 2def4aee187eeaf3fb48b3ebfaa85ce6c48f2fe6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 12 09:12:23 2019 -0500

    Bug 23104: Add tests

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 1521a5567ea17c8adf5339249251bb275b5109de)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit b57aaed3fffeb4017dbde770bd30cb4ea5a74097
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Jun 17 08:30:13 2019 +0100

    Bug 10215: (RM follow-up) Rebuid DBIC classes

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a3cf29c5f714b5888718885f5a0cf2576a6cb5be)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 8c8d86ef30f38d13f75d7ed1600b3d27b70a6568
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jun 13 11:06:29 2019 -0500

    Bug 23117: Shortcut additem.pl on nonexistent biblionumber

    To prevent additem.pl to crash when called with a nonexistent
    biblionumber we are here implementing the blocking_error.inc trick to
    display a friendly message instead.

    Can't call method "fields" on an undefined value at
    /home/vagrant/kohaclone/cataloguing/additem.pl line 736.

    Test plan:
    hit
    /cataloguing/additem.pl?biblionumber=
    /cataloguing/additem.pl?biblionumber=424242
    You will get a friendly "Bibliographic record not found." message,
    instead of a 500

    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 62ae7ac7275329f6396d656a216ffc95b4f9494a)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit a8cc9d5f49f36a5bf69265f3062f1a7a8ee0fdf4
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed May 29 15:20:41 2019 +0200

    Bug 21534: Always compute wildcards

    You get no results when searching with an hyphen + with * in query string (or with preference QueryAutoTruncate) :
    ie /cgi-bin/koha/opac-search.pl?q=saints-anges*

    Looks like query-string by default does not compute wildcards, see analyze_wildcard in :
    https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html

    Test plan :
    1) Use Elasticsearch
    2) Create a record with "saints-anges"
    3) Search for "saints-anges" => you get results
    4) Search for "saints-anges*" => you get results
    5) Search for "saints-ang*" => you get results

    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Arthur Bousquet <arthur.bousquet at inlibro.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 001d433b427731a6efd55208ac3169107c830730)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 16858fd5d5b14680bce00a5c7c85c62c9584980e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Sat Jun 15 07:55:35 2019 +0100

    Bug 22358: (RM follow-up) Typo fix

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 0e8a95b4bdcde76646ad3a45a2022d82e6da277e)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 6a3c93eeeba7d6457af22cb31c6464e3ac5786f9
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jun 14 17:40:52 2019 +0000

    Bug 22358: (QA follow-up) Clear up phrasing

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a72feaa40cbcf34f8f77ecac58ca6b269e9b95c9)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit eecce39379b590aa6615d63da109431358d03846
Author: Alex Arnaud <alex.arnaud at biblibre.com>
Date:   Thu Jun 6 12:00:22 2019 +0200

    Bug 22358: fix POD header and typo

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 5438355b1d016b2699ea2efc5367eaa8d807496d)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit d017e2f7c412001677b2cec08781977d5935e8ee
Author: Alex Arnaud <alex.arnaud at biblibre.com>
Date:   Wed Mar 13 15:14:31 2019 +0100

    Bug 22358: Add POD to Koha::SharedContent

    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit c6540d1b72d45b2682860fc50716b0d74e3f5e2c)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 7bd5324c58181323a665aa2cf036de0f933b8f49
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 5 19:11:59 2019 -0500

    Bug 23022: Remove the SQl mode NO_AUTO_CREATE_USER

    To make our sql mode list compatible with MySQL 8.0.11

    NO_AUTO_CREATE_USER has been removed in MySQL 8.0.11
    https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-11.html

    I do not think we needed it.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 77716188757d11e2a9fa79788ce99982e3c39839)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    2 +-
 C4/Output.pm                                       |    4 ++
 Koha/Database.pm                                   |    4 +-
 Koha/Schema/Result/Subscriptionhistory.pm          |   20 +++----
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    |    1 +
 Koha/SharedContent.pm                              |   61 ++++++++++++++++----
 cataloguing/additem.pl                             |    4 ++
 .../prog/en/modules/admin/smart-rules.tt           |    4 +-
 .../prog/en/modules/cataloguing/additem.tt         |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |   13 +++--
 opac/opac-shelves.pl                               |    2 +-
 t/db_dependent/Circulation/TooMany.t               |   28 ++++++++-
 12 files changed, 108 insertions(+), 37 deletions(-)

hooks/post-receive
-- 
main Koha release repository