[koha-commits] main Koha release repository branch master updated. v19.05.00-155-gd08e776
Git repo owner
gitmaster at git.koha-community.org
Fri Jun 21 14:33:51 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via d08e776cf1e25ffa407bb3a5d668c1b140be6ec2 (commit)
via c59586aebe1d8eab56d3cd32b5156fc1a61f11ec (commit)
via f6009342a95575dc6b1157c953f5e6e8c249b6d0 (commit)
via 206498dc5585fbd555181a1b241d5049632870df (commit)
via 49e0384f10f659e337fac1b08e6bdd2c163151ae (commit)
via 12a9dfb6593c4d5ccc6936b85c82479c12337309 (commit)
via 7a80483a1358a7bc3e516a8fbc92d34b6559dcac (commit)
via 6dc8306b58bc1207f396d2df919a3daf4712e8e5 (commit)
via 3b14f7d636fea4425b2f6eab922be9aa2a9eed1d (commit)
via 48259267f6830b2e388b2a91268117645bda80f3 (commit)
via d018953ca1947649c35df8670a385a942c80c134 (commit)
from 3bf26cfb934cb699839aabb136df09ea97c030bb (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d08e776cf1e25ffa407bb3a5d668c1b140be6ec2
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Jun 17 17:57:46 2019 +0000
Bug 22571: (follow up) fix Donald cut-&-paste error
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c59586aebe1d8eab56d3cd32b5156fc1a61f11ec
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun May 5 12:41:46 2019 -0500
Bug 22571: Handle control fields in MMT for conditionals
Control fields are not handled correctly by Koha::SimpleMARC when
comparaison (with or without regex) is done.
Which means we did not support something like:
Do something if control field 008 equals or matches "a string"
Test plan:
Create a new MARC modification template and a new action, like:
Add new field 100$a with value "foo bar" if 008 (or any other control
fields) matches (or equals) a regex
Then use the record mofication tool and confirm that the new field is
create if the regex matches 008 of the bib record
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f6009342a95575dc6b1157c953f5e6e8c249b6d0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun May 5 12:41:43 2019 -0500
Bug 22571: Add tests
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 206498dc5585fbd555181a1b241d5049632870df
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Jun 14 10:43:15 2019 +0200
Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage
When logged into the staff client with an account with full circulate permissions (and therefore including the manage_checkout_notes permission) an error occurs when clicking on the Checkout notes pending link. The account is logged out automatically with the message: "Error: you do not have permission to view this page. Log in as a different user".
The same error occurs for both the link on the home page dashboard and from the Circulation module button. Works as expected if Superlibrarian permission is set.
This is just a typo in perl script : circulation instead of circulate
Test plan :
1) Set preference "AllowCheckoutNotes" to "Allow"
2) Create a user with only permissions "catalogue" and "circulate > manage_checkout_notes"
3) Loggin with this user
4) Go to "Circulation" home page
5) Click on "Checkout notes"
6) You should be allowed to access
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 49e0384f10f659e337fac1b08e6bdd2c163151ae
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed Jun 19 07:04:25 2019 +0200
Bug 23153: In framework management action subfields must not go directly to edition
Since 18.11, when viewing a framework field clicking on Actions >
Subfields goes to subfields edition instead of subfields table view.
This is because link contains op=add_form.
This is is also missing /cgi-bin/koha/admin.
Test plan :
1) Go to Administration > MARC bibliographic framework
2) On a line click Actions > MARC structure
3) On a line click Actions > Subfields
4) You see subfields table
5) Click on Edit subfields
6) You see subfields edition tabs
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 12a9dfb6593c4d5ccc6936b85c82479c12337309
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jun 17 20:07:29 2019 -0500
Bug 15814: Add missing filters
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 7a80483a1358a7bc3e516a8fbc92d34b6559dcac
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed May 29 21:28:23 2019 -0500
Bug 15814: Handle correctly MMTA edit button
The MARC modification template action edit buton does not correctly
handle variable escaping.
Assigning a JS variable containing the JSON representation of the
hashref will make the processing much more easier.
Test plan:
Create a MARC Modification Template with several actions.
In the description you should use the following characters, to try to
break this patch: \ ' " \n \r
(not sure what we handled \n and \r)
Then edit the action, modify and save again.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 6dc8306b58bc1207f396d2df919a3daf4712e8e5
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Jun 20 12:37:27 2019 +0000
Bug 23150: (follow-up) Make gdpr_proc_consent mandatory for create
When updating (patron modification), the field should not be required.
Test plan:
Check patron modification on opac.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 3b14f7d636fea4425b2f6eab922be9aa2a9eed1d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jun 19 14:49:15 2019 -0500
Bug 23150: Do not consider gdpr_proc_consent a mandatory field
It introduced a regression in the patron's self modification feature.
Patron's details are no longer modificable, the screen displays
"You have not filled out all required fields. Please fill in all missing
fields and resubmit."
Test plan:
- Set GDPR_Policy to either Enforced or Permissive
- Set PatronSelfRegistrationBorrowerMandatoryField to empty
- Set OPACPatronDetails to Allow
- Log into the OPAC
- Accept the GDPR screen
- Go to opac-memberentry.pl, change something, submit modification
request
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 48259267f6830b2e388b2a91268117645bda80f3
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue May 21 12:39:09 2019 +0000
Bug 22946: Markup error in OPAC search results around selection links
This patch makes minor corrections to the template for OPAC search
results. These corrections fix errors returned by the HTML validator.
To reproduce the problem, make sure holds and/or tags are enabled in the
OPAC. Perform a search in the OPAC which will return multiple results.
Run the page through the W3C validation service:
https://validator.w3.org. Either by pasting in the URL for the search
results (if web accessible) or by viewing source, copying, and pasting
into "Validate by Direct Input."
This patch addresses one specific error:
- "Element div not allowed as child of element span in this context."
To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the search results view.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d018953ca1947649c35df8670a385a942c80c134
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Jun 17 21:35:19 2019 +0000
Bug 23097: Fix regression on overdues report and link patrons to moremember
The link from the patron name in the circulation > overdues report
shouldn't point to the reserves tab, as this report is about checkouts.
The patch restores the behaviour as it was in 17.11.
To test:
- Make sure you have a patron account with overdue items
- If you don't have one, check out an item with specified due date in the
past
- Go to Circulation > Overdues
- Veriy the overdue shows
- Click on the patron name that is linked
- Verify you go to the checkouts tab in patron account with holds tab selected
- Apply patch
- Reload Overdues report
- Verify the link now leads to the Details tab with the checkouts tab in front
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/SimpleMARC.pm | 12 +++--
circ/checkout-notes.pl | 2 +-
.../prog/en/modules/admin/marctagstructure.tt | 2 +-
.../intranet-tmpl/prog/en/modules/circ/overdue.tt | 2 +-
.../modules/tools/marc_modification_templates.tt | 24 ++-------
.../prog/js/marc_modification_templates.js | 53 +++++++++++---------
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 8 +--
opac/opac-memberentry.pl | 2 +-
t/SimpleMARC.t | 49 +++++++++++++++++-
9 files changed, 97 insertions(+), 57 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list