[koha-commits] main Koha release repository branch master updated. v19.05.00-190-ga87f5a0
Git repo owner
gitmaster at git.koha-community.org
Mon Jun 24 18:23:44 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via a87f5a01502b5df08f5e7b61650be6ea7dbafa30 (commit)
via a60a6f40c3e25753c7474c4ff20f28e71353c351 (commit)
via b6dc26e93d9d0170c9980291a0f217adcc429e6a (commit)
via 088522032f33b6a5931cbea1b928537e7fe33fd0 (commit)
via 1020fe5b1f95a606d445acb4ac16c0c30586e71d (commit)
via c7147fcde03f7ba1ac13e485adcac587f2dde85c (commit)
via d52f58682cbae7f903a0459f3ec282a65a8ae1f6 (commit)
via 23065fe0d8e09be78d1234a3a5bebf322da34925 (commit)
via f04747c89c8a318e3ee7c49cadc859f1fe7bb5b3 (commit)
from 535925e23f58d654ddd3a1da62d6bf2572aca0a2 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a87f5a01502b5df08f5e7b61650be6ea7dbafa30
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon Jun 24 16:56:56 2019 +0100
Bug 23152: (RM follow-up) Add handling for Koha::Plugin::Methods
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit a60a6f40c3e25753c7474c4ff20f28e71353c351
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 18 21:42:07 2019 -0500
Bug 23152: Implement koha_object[s]_class when needed
A simple use case is the ->get_from_storage (useful when writing tests)
Test plan:
Apply only the first patch and notice the test failures
Apply the second patch and confirm the the tests are returning green
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b6dc26e93d9d0170c9980291a0f217adcc429e6a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 18 21:39:45 2019 -0500
Bug 23152: Add tests
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 088522032f33b6a5931cbea1b928537e7fe33fd0
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Jun 19 11:10:14 2019 +0200
Bug 23154: Add pagination to /api/v1/checkouts
Allow to use _page and _per_page query parameters for
/api/v1/checkouts
Also fix a timezone problem in t/db_dependent/api/v1/checkouts.t
Test plan:
1. With your favorite REST tester tool, or directly in the browser,
fetch http://koha/api/v1/checkouts and check that you have results
2. Fetch /api/v1/checkouts?_per_page=1&_page=1 and check that only the
first result is returned. Check that response contains headers
X-Total-Count and Link
3. Fetch /api/v1/checkouts?_per_page=1&_page=2 and check that only the
second result is returned. Check that response contains headers
X-Total-Count and Link
4. prove t/db_dependent/api/v1/checkouts.t
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 1020fe5b1f95a606d445acb4ac16c0c30586e71d
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Jun 19 14:06:28 2019 +0000
Bug 23159: Add comments to addbiblio.tt
This patch adds code comments to the template to clarify indenting over
the page boundary.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit c7147fcde03f7ba1ac13e485adcac587f2dde85c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Jun 18 15:32:24 2019 +0000
Bug 23159: Reindent addbiblio.tt
This patch corrects whitespace in the basic MARC editor template,
addbiblio.tt: Tabs converted to spaces, indentation corrected. Some
comments have been added in the markup to clarify the page structure.
To test, apply the patch and open the basic MARC editor. Confirm that
everything works correctly, including:
- Showing/hiding subfields
- Re-ordering subfields
- Removing tags and subfields
- Cloning tags and subfields
- Plugin links
Use the "-w" flag when using diff to examine the patch. The only changes
should be places where single lines were broken up and where comments
were added.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit d52f58682cbae7f903a0459f3ec282a65a8ae1f6
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jun 19 12:30:28 2019 -0300
Bug 23146: (QA follow-up) Make sure we use the absolute path
When making a request using any tool (like cUrl or Postman) you get a
'Basic authentication disabled' error (if it is actually disabled) or an
'invalid password' error if it is disabled. This is because the
comparisson of the path we do passes on oauth.t but fails on external
tools. This is probably related to our stack including Apache URL
mappings and then in the plack.psgi file. The safest way is to just ask
Mojo::URL the absolute path to be sure.
To test:
- Having the rest of the patches applied and plack restarted, run: [1]
$ curl -X POST -H 'Authorization: Basic ZGQ2NjlmNGUtZmI1NS00Y2YzLWE4ZmYtYmFiYzJiNDIwNWY1OmM0ZDJmYmYzLWYwOWMtNGJkZi1iNWE4LTgxMDJmNjcwYTI1Mw' -i 'http://kohadev.myDNSname.org:8081/api/v1/oauth/token' --data grant_type=client_credentials
=> FAIL: It fails saying Basic auth is disabled
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/oauth.t
=> SUCCESS: Tests pass
- Apply this patch
- Replicate your curl/postman test
=> SUCCESS: It now works as expected
- Run:
k$ prove t/db_dependent/api/v1/oauth.t
=> SUCCESS: Tests still pass!
- Sign off :-D
[1] You need to generate a client_id and client_secret, and encode them
using: encode_base64url( "$client_id:$client_secret" );
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 23065fe0d8e09be78d1234a3a5bebf322da34925
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jun 18 16:09:01 2019 -0300
Bug 23146: Add support for Basic auth on the OAuth2 token endpoint
The original implementation only contemplated the option to pass the
client_id and client_secret on the request body. It is very common that
clients expect to be able to pass them as a Basic authorization header:
Authorization: Basic encode_base64(client_id:client_secret)
This patch introduces support for this, by:
- Adding a check for the presence of the Authorization header in the
OAuth token request handling code and making that case extract the
client_id and client_secret from the header instead of the original
implementation. No behaviour changes.
- The Auth#under sub is changed so it doesn't go through the
authenticate_api_request chain step, as it would be in conflict with
general Basic authentication.
- Original tests are generalized so they are run in both ways, with the
same expected results.
To test:
- Apply the unit tests patch
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/oauth.t
=> FAIL: Tests fail because the current API doesn't support the feature
- Apply this patch
- Run:
k$ prove t/db_dependent/api/v1/oauth.t
=> SUCCESS: Tests pass!
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit f04747c89c8a318e3ee7c49cadc859f1fe7bb5b3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jun 18 16:08:54 2019 -0300
Bug 23146: Unit tests
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/REST/V1/Auth.pm | 8 +-
Koha/REST/V1/OAuth.pm | 22 +-
Koha/Schema/Result/AccountOffset.pm | 7 +-
Koha/Schema/Result/Aqbasket.pm | 8 +-
Koha/Schema/Result/Aqbasketgroup.pm | 8 +-
Koha/Schema/Result/Aqbookseller.pm | 7 +-
Koha/Schema/Result/Aqbudget.pm | 8 +-
Koha/Schema/Result/Aqbudgetperiod.pm | 7 +-
Koha/Schema/Result/Aqcontact.pm | 7 +-
Koha/Schema/Result/Aqinvoice.pm | 7 +-
Koha/Schema/Result/AqinvoiceAdjustment.pm | 7 +-
Koha/Schema/Result/AuthHeader.pm | 7 +-
Koha/Schema/Result/AuthSubfieldStructure.pm | 7 +-
Koha/Schema/Result/AuthTagStructure.pm | 7 +-
Koha/Schema/Result/AuthType.pm | 7 +-
Koha/Schema/Result/BiblioMetadata.pm | 4 +-
Koha/Schema/Result/BorrowerAttribute.pm | 7 +-
Koha/Schema/Result/BorrowerAttributeType.pm | 7 +-
Koha/Schema/Result/BorrowerModification.pm | 7 +-
Koha/Schema/Result/Branch.pm | 5 +-
Koha/Schema/Result/BranchTransferLimit.pm | 7 +-
Koha/Schema/Result/BranchesOverdrive.pm | 7 +-
Koha/Schema/Result/Branchtransfer.pm | 7 +-
Koha/Schema/Result/Category.pm | 7 +-
Koha/Schema/Result/ClubEnrollment.pm | 7 +-
Koha/Schema/Result/ClubEnrollmentField.pm | 7 +-
Koha/Schema/Result/ClubField.pm | 7 +-
Koha/Schema/Result/ClubTemplate.pm | 7 +
Koha/Schema/Result/ClubTemplateEnrollmentField.pm | 7 +-
Koha/Schema/Result/ClubTemplateField.pm | 7 +-
Koha/Schema/Result/Currency.pm | 8 +-
Koha/Schema/Result/ExportFormat.pm | 7 +-
Koha/Schema/Result/Fieldmapping.pm | 7 +-
Koha/Schema/Result/HouseboundProfile.pm | 7 +-
Koha/Schema/Result/HouseboundRole.pm | 7 +-
Koha/Schema/Result/HouseboundVisit.pm | 7 +-
Koha/Schema/Result/Issue.pm | 7 +
Koha/Schema/Result/Issuingrule.pm | 7 +-
Koha/Schema/Result/Itemtype.pm | 7 +
Koha/Schema/Result/Letter.pm | 7 +-
Koha/Schema/Result/LibraryGroup.pm | 7 +-
Koha/Schema/Result/Message.pm | 7 +-
Koha/Schema/Result/MessageQueue.pm | 7 +-
Koha/Schema/Result/NeedMergeAuthority.pm | 7 +-
Koha/Schema/Result/OauthAccessToken.pm | 7 +-
Koha/Schema/Result/OldIssue.pm | 3 +
Koha/Schema/Result/OldReserve.pm | 7 +-
Koha/Schema/Result/OpacNews.pm | 7 +-
Koha/Schema/Result/PatronConsent.pm | 7 +-
Koha/Schema/Result/Patronimage.pm | 7 +-
Koha/Schema/Result/PluginMethod.pm | 6 +
Koha/Schema/Result/Reserve.pm | 7 +
Koha/Schema/Result/SavedSql.pm | 7 +-
Koha/Schema/Result/Serialitem.pm | 7 +-
Koha/Schema/Result/SmsProvider.pm | 7 +-
Koha/Schema/Result/Stockrotationitem.pm | 8 +-
Koha/Schema/Result/Stockrotationrota.pm | 8 +-
Koha/Schema/Result/Stockrotationstage.pm | 7 +
Koha/Schema/Result/SubscriptionFrequency.pm | 7 +-
Koha/Schema/Result/SubscriptionNumberpattern.pm | 7 +-
Koha/Schema/Result/Subscriptionhistory.pm | 7 +-
Koha/Schema/Result/Subscriptionroutinglist.pm | 7 +-
Koha/Schema/Result/Systempreference.pm | 7 +-
Koha/Schema/Result/TagAll.pm | 7 +-
Koha/Schema/Result/TagsApproval.pm | 7 +-
Koha/Schema/Result/TagsIndex.pm | 7 +-
Koha/Schema/Result/Virtualshelve.pm | 7 +-
Koha/Schema/Result/Z3950server.pm | 7 +-
api/v1/swagger/paths/checkouts.json | 4 +
.../prog/en/modules/cataloguing/addbiblio.tt | 1202 ++++++++++----------
t/db_dependent/TestBuilder.t | 2 +
t/db_dependent/api/v1/checkouts.t | 29 +-
t/db_dependent/api/v1/oauth.t | 170 ++-
73 files changed, 1187 insertions(+), 708 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list