[koha-commits] main Koha release repository branch master updated. v19.05.00-211-g3509303

Tue Jun 25 18:22:24 CEST 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  35093039df3b42ae33c746385669ba13deb38c7d (commit)
       via  b3795df8012545af4134d7402e9609e2d89f7be9 (commit)
       via  4e4f0b637c66ca04a07473c347cc741d456c20c5 (commit)
       via  7e226ba3c018a890c823f10365dbe2b3d1d22d23 (commit)
       via  2b392a6db231c8069d57be88ebf4f2960af199fa (commit)
       via  4f3413f0d2688017f6a35b43d0d1d4a9d7295c5a (commit)
       via  b62473d192abaf9371bffb0ec4d73267a0070447 (commit)
       via  35fe9cf40bb1472799db0f7596d33f1bd184fb9b (commit)
       via  8947d5939fb33efd0887a6f443d392b9df17e2aa (commit)
       via  2c5e9bed7de83d01be755475b96a3cf439e0126c (commit)
      from  90bd9763bd0cf49df722955008af0c59d79edfe0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 35093039df3b42ae33c746385669ba13deb38c7d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Jun 25 12:40:57 2019 +0000

    Bug 22566: (QA follow-up) Fix pod complaint

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b3795df8012545af4134d7402e9609e2d89f7be9
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Jun 18 14:29:02 2019 +0100

    Bug 22566: Add 'branch' key to GetPreparedLetter

    The branch key was missing from the subsitution call to
    GetPreparedLetter.

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4e4f0b637c66ca04a07473c347cc741d456c20c5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Jun 18 14:24:27 2019 +0100

    Bug 22566: Clarify intent of reports and add warnings

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7e226ba3c018a890c823f10365dbe2b3d1d22d23
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Jun 18 13:38:43 2019 +0100

    Bug 22566: Rename 'report_email' to 'report_by_branch'

    To clarify the intention of this routine, lets rename it

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2b392a6db231c8069d57be88ebf4f2960af199fa
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Jun 18 12:57:07 2019 +0100

    Bug 22566: Accept 'all' in the branch params

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4f3413f0d2688017f6a35b43d0d1d4a9d7295c5a
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Jun 7 12:50:32 2019 +0100

    Bug 22566: Fix some more issues

    1) Fix warning for undefined value in sprintf when no items have the
    indemand flag set.
    2) Corrections to report_full for bad ternary in string construction
    3) Perldoc corrections

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b62473d192abaf9371bffb0ec4d73267a0070447
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Mar 22 13:23:35 2019 -0400

    Bug 22566: Fix some problems

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 35fe9cf40bb1472799db0f7596d33f1bd184fb9b
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue May 21 14:45:06 2019 +0000

    Bug 22949: Markup error in OPAC course reserves template

    This patch adds a missing "=" in opac-course-reserves.tt in order to
    quiet errors returned by the HTML validator.

    To reproduce the problem you should have one or more course reserves
    available in the OPAC. Go to the course reserves page. Run the page
    through the W3C validation service: https://validator.w3.org. Either by
    pasting in the URL for the search results (if web accessible) or by
    viewing source, copying, and pasting into "Validate by Direct Input."

    This patch addresses these errors:

     - 'Quote " in attribute name. Probable cause: Matching quote missing
        somewhere earlier.'
     - 'Attribute class"inst_surname" not allowed on element span at this
        point.'

    To test, apply the patch and try again to reproduce the validation
    errors. Those errors should no longer be present. There should be no
    visible change to the page.

    Signed-off-by: Frederik Chenier <frederik at inlibro.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8947d5939fb33efd0887a6f443d392b9df17e2aa
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jun 24 09:58:00 2019 -0500

    Bug 23082: Fatal error editing a restricted patron

    In members/memberentry.pl we have to explicitely remove the template's
    params that are not patron's attributes.

    Certainly caused by
      commit 1bb6cec902088d07c7a43addc4b4adb5b0bf3d4f
      Bug 20287: Fix update of patrons, clean the data before ->store

    Test plan:
    Create a restriction for a patron
    Edit patron's details
    Remove the restriction
    => Without this patch you get "No property remove_debarment for
    Koha::Patron"
    => With this patch applied the restriction is removed

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2c5e9bed7de83d01be755475b96a3cf439e0126c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Jun 13 06:34:38 2019 -0400

    Bug 23116: AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold

    A library appears to be able to place a second item level hold on an item a patron already has on hold if
    A) AllowHoldPolicyOverride is enabled
    and
    B) the circ rule allow for multple item level holds.

    Once the patron submits the hold requests though, the hold does not get stored in the database.

    Because allowing two item level holds for the same item makes no sense, we should not allow
    this attempt to take place, even if AllowHoldPolicyOverride is enabled.

    Test Plan:
     1) Enable AllowHoldPolicyOverride
     2) Set up circ rules to allow for multiple item level holds on one record
     3) Place an item level hold on a record
     4) Note you can force placing a second item hold on that reocrd
     5) Attempt to do so, it will not actually work
     6) Apply this patch
     7) Note you can no longer place another item level hold for the same item
       you just placed an item-level hold on
     8) Note you can still force holds that contravene the circ rules for
       any and all other reasons
     9) Test with record level holds
    10) Test by placing multiple holds from search results

    Signed-off-by: Martha Fuerst <mfurest at hmcpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Simple fix for a regression. Works as expected.
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/StockRotationRotas.pm                         |    1 +
 .../bootstrap/en/modules/opac-course-reserves.tt   |    2 +-
 members/memberentry.pl                             |    2 +-
 misc/cronjobs/stockrotation.pl                     |   76 ++++++++++++--------
 reserve/placerequest.pl                            |   13 +++-
 reserve/request.pl                                 |    7 +-
 6 files changed, 63 insertions(+), 38 deletions(-)

hooks/post-receive
-- 
main Koha release repository