[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.11-114-g4b47ac8

Git repo owner gitmaster at git.koha-community.org
Thu Jun 27 22:18:38 CEST 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  4b47ac8b2df7b0d5de18fc556903d3992c02b7b2 (commit)
       via  df28fcb33f9f04b040fe29408ddbc1662a72148e (commit)
       via  a84fcfe1b2f8b9e37cf5ef54cda6c90c14dcda74 (commit)
       via  e3463082a1764baedbd0030c6840b81c6dfd01d9 (commit)
       via  ddca212bd458aab2276e9c4aacbc32205812e232 (commit)
       via  96e2d9cbcb14bb9114565b2997681288ac7d8401 (commit)
       via  855dbb44c222c32991f841c002c727572ad30256 (commit)
       via  41f52e2d298a75e5aa0ca55c829cc5d10ca88bbe (commit)
       via  7b4c6e218952a15d2b6bc15f1027205001d17b27 (commit)
       via  f3e12af72efa049a6d216b886f674785a49d517b (commit)
       via  bde475c055397495a7a494b8fa574005751e88df (commit)
       via  09280ec598b7c32c1cf4c8b47eeda09dd3013b63 (commit)
      from  f50c9a95722c019aa5ce7f2a56693724430d6006 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4b47ac8b2df7b0d5de18fc556903d3992c02b7b2
Author: Liz Rea <liz at bywatersolutions.com>
Date:   Thu Jun 27 18:46:32 2019 +0000

    Database update for 18.05.14

commit df28fcb33f9f04b040fe29408ddbc1662a72148e
Author: Liz Rea <liz at bywatersolutions.com>
Date:   Thu Jun 27 18:40:45 2019 +0000

    Bump version number for release
    
    Signed-off-by: Liz Rea <liz at bywatersolutions.com>

commit a84fcfe1b2f8b9e37cf5ef54cda6c90c14dcda74
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun May 12 00:34:03 2019 +0200

    Bug 22886: Missing space between fields from Keyword to MARC mapping in cataloguing search
    
    If you have multiple subfields mapped to the 'subtitle' keyword,
    those fields will show up without separating space.
    
    To test:
    - Add 3 subtitle entries in Keyword to MARC mapping for a framework
      - 245 b
      - 245 c
      - 245 h
    - Edit a record, make sure the framework matches, add:
      - 245 b, c, h
    - Search for it in cataloguing search (not catalog!)
    - Verify the subtitle fields show, but are all concatenated
    - Apply patch
    - Search again and verify the display is improved with a separating
      space
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f00d909220ebde5162335e255e4ba938a9563bff)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
     Conflicts:
    	koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
    
    Signed-off-by: Liz Rea <liz at bywatersolutions.com>

commit e3463082a1764baedbd0030c6840b81c6dfd01d9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sat May 11 10:23:28 2019 -0500

    Bug 20514: Use streetnumber when searching for patrons by address
    
    The streetnumber field was ignored from the search.
    
    Test plan:
    Create a patron with streetnumber="12", address="rue des cerisiers"
    Search for patrons using the search field "street address"
    using: 12 rue des cerisiers
    => Without this patch the patron will not be returned
    => With this patch applied it will!
    
    Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 97ec0a2e4bf76cf2e67a7ddbd463d9942a4fe383)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Liz Rea <liz at bywatersolutions.com>

commit ddca212bd458aab2276e9c4aacbc32205812e232
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed May 1 21:05:30 2019 -0400

    Bug 22781: Correctly filter the emails
    
    Ho, another bug!
    
    The email was not correctly filtered.
    
    Test plan:
    Use the evil string for an email, do a search.
    => Notice that without this patch the results never show up
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5410186f6829fc4b74a845e8954bd7eea3f19862)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Liz Rea <liz at bywatersolutions.com>

commit 96e2d9cbcb14bb9114565b2997681288ac7d8401
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed May 1 20:54:02 2019 -0400

    Bug 22781: Does not double filter address
    
    Ho, a bug!
    Some fields in the address where double filtered.
    
    Test plan:
    Use the evil strings in the address field and do a search, you will see
    double html encoded characters without this patch.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ecb12104ffc7284089a1c8134ca8811e99e7419c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
     Conflicts:
    	koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
    
    Signed-off-by: Liz Rea <liz at bywatersolutions.com>

commit 855dbb44c222c32991f841c002c727572ad30256
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed May 1 20:29:05 2019 -0400

    Bug 22781: Test patron's info filtering
    
    The patron's data was not correctly escaped actually.
    
    Test plan:
    This is a good value for the whole patchset: <strong>fir's"tname</strong> \123 ❤
    use it for a patron's firstname, then do a search
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 35d00030ceb572822979300a5291356a32427a16)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
     Conflicts:
    	koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
    
    Signed-off-by: Liz Rea <liz at bywatersolutions.com>

commit 41f52e2d298a75e5aa0ca55c829cc5d10ca88bbe
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed May 1 20:28:04 2019 -0400

    Bug 22781: Escape cardnumber, category's description, library's name and dateexpiry
    
    This will fix the previous failure. Note that other fields like
    borrowernumber, Price escaped values, integers, etc. could be escaped
    the same way but will be useless (save polar bears).
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3a3057545c56f4f1a41fcd7643265204844cd2d3)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
     Conflicts:
    	koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
    
    Signed-off-by: Liz Rea <liz at bywatersolutions.com>

commit 7b4c6e218952a15d2b6bc15f1027205001d17b27
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed May 1 20:28:55 2019 -0400

    Bug 22781: Add tests
    
    Test plan:
    Apply only this patch
    => The tests will fail, the library's name is not correctly escaped.
    
    Note:
    This applies for the whole patchset, when the tests fail you will need
    to remove the patrons added by the tests with the following SQL query:
      delete from borrowers where surname like "test_patron_%";
    We are expecting END to be called even if something goes wrong, but
    DESTROY must be used instead. This will be fixed separately, on its own
    bug report.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 6e8ecb8c6c8cf5d5188d2ad138e4fdbd8f395b3e)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Liz Rea <liz at bywatersolutions.com>

commit f3e12af72efa049a6d216b886f674785a49d517b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri May 10 12:27:40 2019 -0500

    Bug 22878: Do not pass layout_id on creating a layout
    
    Attempting to create a patron card layout with mysql strict mode on gives the following error:
      DBD::mysql::st execute failed: Incorrect integer value: '' for column 'layout_id' at row 1
    
    Test plan:
    - Turn on sql_strict_modes
    - Create a new patron card
    => Must success with this patch applied
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8d53fae9494b50c0cf2dcc98b18982b0d8fc416f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Liz Rea <liz at bywatersolutions.com>

commit bde475c055397495a7a494b8fa574005751e88df
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri May 10 12:27:34 2019 -0500

    Bug 22878: Add tests
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9f18afa7b34574cd872c94ee366a8d3e75085413)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Liz Rea <liz at bywatersolutions.com>

commit 09280ec598b7c32c1cf4c8b47eeda09dd3013b63
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Mon Apr 29 03:14:35 2019 +0000

    Bug 7862: Preventing warns when creating a notice
    
    To reproduce warns:
    1) Go to Tools -> Notices & slips
    2) Create a new notice of any module
    
    Notice these warns:
    Use of uninitialized value $code in regexp compilation at
    /home/vagrant/kohaclone/tools/letter.pl line 265.
    Use of uninitialized value $code in regexp compilation at
    /home/vagrant/kohaclone/tools/letter.pl line 265.
    Use of uninitialized value $code in regexp compilation at
    /home/vagrant/kohaclone/tools/letter.pl line 265.
    
    CGI::param called in list context from package
    CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this
    can lead to vulnerabilities. See the warning in "Fetching the value or
    values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
    CGI::param called in list context from package
    CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this
    can lead to vulnerabilities. See the warning in "Fetching the value or
    values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
    
    3) Create a new notice of the Circulation module
    
    Notice this additional warn:
    Use of uninitialized value $code in pattern match (m//) at
    /home/vagrant/kohaclone/tools/letter.pl line 258.
    
    To test:
    4) Apply patch and refresh page
    5) Run steps 1-3 again and confirm no warns show
    
    Sponsored-by: Catalyst IT
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 700b7dfa09e38c074cebbbb5caac64e031d5c0d5)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Liz Rea <liz at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Creators/Layout.pm                              |    1 +
 C4/Utils/DataTables/Members.pm                     |    2 +-
 Koha.pm                                            |    2 +-
 installer/data/mysql/updatedatabase.pl             |    6 +
 .../prog/en/modules/cataloguing/addbooks.tt        |    4 +-
 .../en/modules/members/tables/members_results.tt   |   12 +-
 svc/letters/get                                    |    4 +-
 t/Patroncards_Layout.t                             |   14 ---
 t/db_dependent/Patroncards.t                       |   34 ++++++
 t/db_dependent/selenium/patrons_search.t           |  117 ++++++++++++++++++++
 tools/letter.pl                                    |   11 +-
 11 files changed, 178 insertions(+), 29 deletions(-)
 delete mode 100755 t/Patroncards_Layout.t
 create mode 100755 t/db_dependent/Patroncards.t
 create mode 100644 t/db_dependent/selenium/patrons_search.t


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list