[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.03-90-gb19b36f

Fri Mar 1 13:00:41 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  b19b36fb6260932dff3961ec9ed1202188d367de (commit)
       via  00fff866dd25c89f740b46e6366868027fe7512a (commit)
       via  7609009a7319ad6e631bac6fd39a8a5397566782 (commit)
       via  eeeae403a1cf3ef0860abec23cd05ac8577e996d (commit)
       via  2daeeafc23b0872b4640ef48d7b84558129c130b (commit)
       via  1ca64ce757ca92071d1c0c6c4c9fc306e8808972 (commit)
       via  f9892cd621e9c1c17dac41771b607119bee05840 (commit)
       via  c20af7c877b8a13f51cb94aec97dee55fc15db56 (commit)
       via  6e091d5d236226346b2d354dd43c38121352ed7b (commit)
       via  fe9a4b624fe2cc1cd6e351b027ef3c9187bf18b4 (commit)
       via  0e174855a0a11f3b530163b4559624d883f60a4d (commit)
       via  ba368d929f9d739d4f7e4e3c3e9710fd08e000d9 (commit)
       via  8b570caf8aba4b883a5631caca652191df3aed9e (commit)
      from  37374dc82b25b90d843a77634bbbc0d0ea6aef6d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b19b36fb6260932dff3961ec9ed1202188d367de
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Jan 8 13:10:53 2019 -0500

    Bug 22084: Plugin upgrade method and database plugin version storage will never be triggered for existing installs

    If an existing plugin begins using the upgrade() method, it will never actually get triggered because the installation has already occurred and no database plugin version was stored at the time. Without that database version, the upgrade method will never be triggered.

    In addition, if the plugin has no upgrade method, the installed version is never updated in the database!

    Lastly, when an upgrade succeeds it prints a warning that the upgrade failed.

    Test Plan:
    1) Install an older version of the Kitchen sink plugin:
       * https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.0/koha-plugin-kitchen-sink-v2.1.0.kpz
    2) Delete the "__INSTALLED_VERSION__" key, and the "last_upgraded" key from plugin_data for this plugin, to simulate having installed from an earlier version of Koha
    3) Upgrade to the latest version of the Kitchen sink plugin:
       * https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.22/koha-plugin-kitchen-sink-v2.1.22.kpz
    4) Note "__INSTALLED_VERSION__" still doesn't exist for the plugin, in the plugin_data table
    5) Apply this patch
    6) Restart all the things
    7) Browse to the Kitchen sink configuration page, this should trigger the upgrade method
    8) Note the "__INSTALLED_VERSION__" and "last_upgraded" keys exist in plugin_data for the Kitchen Sink plugin

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8c2e03020dc02519dec70b9697794a3624c73937)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 00fff866dd25c89f740b46e6366868027fe7512a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Jan 9 07:33:15 2019 -0300

    Bug 22084: Regression tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 57f4c01b9a09d1c2e0fc8a3449ba86574775b840)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7609009a7319ad6e631bac6fd39a8a5397566782
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Feb 11 16:05:23 2019 -0300

    Bug 21765: Make AutoUnsuspendReserves call Koha::Hold->resume

    This patch makes the mentioned method use the biult-in method for
    resuming a suspended hold, instead of manually setting the specific
    attributes using the accessors.

    The side effect for this is that HoldsLog is now honoured.

    This patchset also refactors the tests a bit so they rely on the exposed
    methods and thus don't rely on specific implementation details (like
    suspended hold means a date in suspended_until plus suspended=1).

    To test:
    - Apply the regression tests patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t
    => FAIL: It fails loudly because things are done manually
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t
    => SUCCESS: Tests pass!

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7c3a5c78c1aacbdb0ad7eb758cb9880ecefcce3a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit eeeae403a1cf3ef0860abec23cd05ac8577e996d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Feb 11 16:04:59 2019 -0300

    Bug 21765: Regression tests

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d441ce5cdadba7a87570162b9f54600c82f150e2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2daeeafc23b0872b4640ef48d7b84558129c130b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Feb 22 11:31:52 2019 -0300

    Bug 22397: Wrong message in koha-sip --start

    This patch makes koha-sip --start calls mention 'SIP server' instead of
    the wrong 'Zebra daemon'.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e47fa012f6e1ecf94712e0cb759625f136703c03)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1ca64ce757ca92071d1c0c6c4c9fc306e8808972
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Feb 20 20:00:01 2019 +0000

    Bug 22378: Fix audio alerts on SCO

    Note: The SCO only supports sounds with a full URL, not KOha built in sounds

    To test:
    1 - Enable audio alerts
    2 -  Enable SCO
    3 - Note JS error on loading the alerts
    4 - Apply patch
    5 - No more error
    6 - Test with bug 18251

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit fb4707b97cec006e0e6f5c4b4dd430146e97f16a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f9892cd621e9c1c17dac41771b607119bee05840
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Feb 25 18:21:26 2019 +0000

    Bug 22411: Date and time in log viewer should respect

    Test plan:
    Go to log viewer and show some log
    -- without patch the date ant time in first column is formatted as
    yyyy-mm-dd hh:mm
    -- with patch the date is formatted according to your dateformat system
    preference

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit dd8749661ce7e48e86fc4eeba3c7c42e0321184e)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c20af7c877b8a13f51cb94aec97dee55fc15db56
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Feb 21 17:21:58 2019 +0100

    Bug 15149: Serial test prediction pattern does not consider end date

    To reproduce:

    1) add a serial.
    2) set first issue = today
    3) set frequency = 1/month
    4) dont set subscription length
    5) set subscription start date = today
    6) set subscription start date = today + 1 year
    7) set numbering pattern = Number
    8) test prediction pattern.
    => Without patch : you will get a list of 1000 issues, going well beyond subscripton end date.
    => With patch : shows only the issues within the date range.

    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: zhihui <zhihui at inlibro.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e3212c8a969ff17783e50d564aaa412bd01a99b1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6e091d5d236226346b2d354dd43c38121352ed7b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Feb 22 11:06:46 2019 -0300

    Bug 18957: Record the time part of the last renewed date

    issues.lastreneweddate is a datetime and we could record the time part
    of the date.

    Test plan:
    Renew an issue
    note that the time part of the last renewed date is set correctly

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4585228ea9b5cc407dcec8e4bae499d59007ea96)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fe9a4b624fe2cc1cd6e351b027ef3c9187bf18b4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Feb 22 11:01:38 2019 -0300

    Bug 18957: Add tests

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 54fd0718da1bd27531c7f3ac4ea16d04fb15e634)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0e174855a0a11f3b530163b4559624d883f60a4d
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Feb 25 09:18:50 2019 +0000

    Bug 14850: (QA follow-up) Remove debugging code

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e99a6de09335fdbe227292835b5231b13d9c1f18)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit ba368d929f9d739d4f7e4e3c3e9710fd08e000d9
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Feb 22 07:12:10 2019 -0500

    Bug 14850: Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl

    Test Plan:
    1) Create some inactive and active budgets
    2) View an invoice in acquisitions
    4) Note the shipping fund dropdown behaves like acqui/parcels.pl

    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 831531d3bbd0e440693595d0b4fadc704b020d68)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 8b570caf8aba4b883a5631caca652191df3aed9e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Feb 22 12:00:35 2019 -0300

    Bug 22396: Make koha-sip set KOHA_HOME and KOHA_CONF correctly

    This patch corrects a typo, and exports KOHA_CONF as other scripts do.

    To test:
    - Apply this patch
    - Run:
      $ # in kohadevbox
      $ perl misc4dev/cp_debian_files.pl
    - Try the new script
      $ sudo koha-sip --start kohadev
    => SUCCESS: tail -f /var/log/koha/kohadev/sip* doesn't show fatal errors
    anymore
    - Sign off :-D

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7128db531c18d3c75a4bad3424bd77732c0d4687)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    2 +-
 C4/Reserves.pm                                     |    2 +-
 Koha/Plugins/Base.pm                               |    7 +-
 acqui/invoice.pl                                   |   66 ++++++----
 debian/scripts/koha-sip                            |    7 +-
 .../intranet-tmpl/prog/en/modules/acqui/invoice.tt |   46 +++++--
 .../intranet-tmpl/prog/en/modules/tools/viewlog.tt |    3 +-
 .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt |    3 +-
 serials/showpredictionpattern.pl                   |    2 +-
 t/db_dependent/Circulation.t                       |    6 +-
 t/db_dependent/Plugins.t                           |   27 +++-
 t/db_dependent/Reserves/AutoUnsuspendReserves.t    |  135 +++++++++++++++++---
 12 files changed, 235 insertions(+), 71 deletions(-)

hooks/post-receive
-- 
main Koha release repository