[koha-commits] main Koha release repository branch master updated. v18.11.00-624-gf40a758

Mon Mar 4 20:40:41 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f40a75876ec681b7a102ba190e63ecda3e2bc43e (commit)
       via  b104046d89ee6457946b998d9221b1d3771b5d5c (commit)
       via  a639299c9834ad80d763143910dd460193820acb (commit)
       via  6ca8b1eed25022fdaeb5a913196ebb502856bdc7 (commit)
       via  e7dbe4124272bfcaa212f71f4da07541f01ec0d8 (commit)
       via  55d18aeca6e8bff1a1484fafe261dc4d2c5f21c8 (commit)
       via  1fa46154d19cfb294bb36c3ca05b98bbe62f14d7 (commit)
      from  62b4fbb9dd6b440630251fd6686bf7af83b6d5e2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f40a75876ec681b7a102ba190e63ecda3e2bc43e
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Nov 30 13:30:24 2018 +0000

    Bug 21720: Update Tests

    AddIssuing charge is always called in void context, but the tests
    checked that the return value was a Koha::Account::Offset and we now
    return a Koha::Account::Line.

    This patch changes the test to accept a Koha::Account::Line as returned,
    adds a test to ensure a Koha::Account::Offset is also created and
    corrects the logic that tests that only one accountline is added.

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b104046d89ee6457946b998d9221b1d3771b5d5c
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Nov 1 12:42:31 2018 +0000

    Bug 21720: Use Koha::Account->add_debit in AddIssuingCharge

    Known Side Effect: Prior to this patch issuing charges were not
    recorded in the FinesLog. After this patch, if the FinesLog is
    enabled then the 'action' will be recorded as `create_rent`.

    Sponsored-by: PTFS Europe

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a639299c9834ad80d763143910dd460193820acb
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Mar 4 19:10:56 2019 +0000

    Bug 21728: DBRev 18.12.00.019

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6ca8b1eed25022fdaeb5a913196ebb502856bdc7
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Nov 30 19:45:19 2018 +0000

    Bug 21728: Add 'Reserve Fee' to the account_offset_types

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e7dbe4124272bfcaa212f71f4da07541f01ec0d8
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Nov 1 11:08:51 2018 +0000

    Bug 21728: Use Koha::Account->add_debit in ChargeReserveFee

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 55d18aeca6e8bff1a1484fafe261dc4d2c5f21c8
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Nov 1 12:26:35 2018 +0000

    Bug 21722: Use Koha::Account->add_debit in chargelostitem

    This patch updates C4::Accounts::chargelostitem to use the newly
    available add_debit method from Koha::Account.

    Known Side Effects: If the FinesLog is enabled then the 'action'
    recorded will change from the generic `create_fee` (for both the lost
    charge and any associated processing charge) to the more descriptive
    terms `create_processing` and `create_lost_item`.

    Sponsored-by: PTFS Europe

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1fa46154d19cfb294bb36c3ca05b98bbe62f14d7
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Dec 13 19:23:07 2018 +0000

    Bug 21722: Tidy up tests and increase coverage

    This patch moves the chargelostitem 'branchcode' test to within the
    'chargelostitem' subtest block in t/db_dependent/Accounts.t. It also
    adds tests for additional accountline fields that should be getting
    set by this method and adds tests for ProcessingFeeNote before removing
    t/db_dependent/Circulation/Chargelostitem.t which covered this
    previously.

    Sponsored-by: PTFS Europe

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Accounts.pm                              |   99 ++------
 C4/Circulation.pm                           |   39 +---
 C4/Reserves.pm                              |   26 +--
 Koha.pm                                     |    2 +-
 installer/data/mysql/updatedatabase.pl      |   11 +
 t/db_dependent/Accounts.t                   |  325 ++++++++++++++++-----------
 t/db_dependent/Circulation/Chargelostitem.t |   85 -------
 t/db_dependent/Circulation/issue.t          |   14 +-
 8 files changed, 255 insertions(+), 346 deletions(-)
 delete mode 100644 t/db_dependent/Circulation/Chargelostitem.t

hooks/post-receive
-- 
main Koha release repository