[koha-commits] main Koha release repository branch master updated. v18.11.00-700-g255af71

Git repo owner gitmaster at git.koha-community.org
Thu Mar 7 22:36:00 CET 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  255af719e65956d84d62ea52fea12619bb851f70 (commit)
       via  bd68e2f75b2bd0cae7935715f4aa03342809cb9f (commit)
       via  eb7b2907c55d896a7c5b8bccf31daeae8bc5720b (commit)
       via  a0e10d97223ae2945f6ac64b7d86f4ac2fea9e03 (commit)
       via  1f2685f7d4965d6aa4a25be81aebf91b1ed01b33 (commit)
       via  916a27686a4e76b0a8b6982dbbbf4ae9eee4267e (commit)
       via  6d3136c7e893011bd7cdfd0b6415d20929b6a66b (commit)
       via  ef6ad443a872c207654721d1e9edee3a6eb88087 (commit)
       via  a8be1966f3855d6950021018254819b04a5287c3 (commit)
       via  29bc2b583264a62c29a0f39dd79a5b3a64721ae6 (commit)
       via  5ebf1a26dae62651d1749a2df2e54ee6d1af148a (commit)
       via  926d7c4ba11ad6cd768c884ec4b2dc71d864b64c (commit)
       via  eeaf59a31ff33ec505fe86a3ef7278aed1733e25 (commit)
       via  0499a3bf2b8aad543a6d0e7b87cbee75cd14f166 (commit)
       via  fa243015988028cfba82eaeef35a7ec53a000586 (commit)
       via  1966c6be2e21613c5e1efb977dc946f0f1c21e20 (commit)
       via  9cfcd21f24c176cecb743084ee22243aeb44848d (commit)
       via  fe8bc587f6f78600b7aecc0b7efd75306e9a2e12 (commit)
       via  7a109482865838f1594e2e84f762e3e9c95a22db (commit)
       via  ee5b5175d9dafa906432835d018081ed62fbab05 (commit)
       via  9bf62c78811e50aa1b3cfbb25e825d2ca093c180 (commit)
       via  e0da941f712a2b2be6e43eefbcdd013ec4bd5adb (commit)
       via  ccd6a334b7447b446bd150d0420f5ad7544bbb8c (commit)
       via  8035151e41fc2e97e8a0c32cfa0e8c252c393bf2 (commit)
       via  feb866a618ad5fccb4384dbc9c8b6fd23fec6472 (commit)
       via  695ce65132e7e88bd5d3da46e99b665b91a71eb6 (commit)
       via  a0a7b779ee39fed7e8d88b7357716d7d4a78d8f0 (commit)
       via  284b543ea4a82dfd4873cc122ba7c2a816f141ca (commit)
       via  904a4884601588ca89faaaee5e0fd53d3907ec10 (commit)
       via  bd9ef8f5843fa7bcb49dc490001c79750035e0d0 (commit)
       via  a108256face480867de76f348d577ade0481cdfa (commit)
       via  84f83012295c90995db48775ff32f06b8d082581 (commit)
      from  9ff997eda7582dbb68d599ab1436b162dd1559da (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 255af719e65956d84d62ea52fea12619bb851f70
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Feb 11 09:54:43 2019 +0100

    Bug 22303: Correct bottom in virtualshelves/addbybiblionumber.tt
    
    In virtualshelves/addbybiblionumber.tt the include intranet-bottom.inc which closes the HTML last tag is not the last line of the template.
    
    This patch moved bottom include to last line and uses popup-bottom.inc.
    
    Test plan :
    1) Permission OK :
    1.1) Login in staff interface with user 'Bob'
    1.2) Create a new list 'Readme' : category public and allow changes to contents from anyone
    1.3) Perform a search
    1.4) Check some results
    1.5) Click 'Add to list' and on the list 'Readme'
    1.6) A popup window opens
    1.7) Check its HTML is OK, ending with </html>
    2) Permission KO :
    2.1) Open a new window (Firefox private session) and login in staff interface with user 'Bill'
    2.2) Perform a search
    2.3) Check some results
    2.4) On session of 'Bob', edit list 'Readme'
    2.5) Change : category private and allow changes to contents from owner only
    2.6) On session of 'Bill'
    2.7) Click 'Add to list' and on the list 'Readme'
    2.8) A popup window opens saying 'Sorry, you do not have permission to add items to this list'
    2.9) Check its HTML is OK, ending with </html>
    
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bd68e2f75b2bd0cae7935715f4aa03342809cb9f
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Fri Feb 1 13:18:11 2019 +0200

    Bug 22246: Fix indexing of large fields with Elasticsearch
    
    Deduplicate multivalued fields and make sure sort fields are not excessively long. Also updates default mappings so that sort fields are not created for item fields where it doesn't make sense.
    
    Test plan:
    1. Reset ES mappings in administration
    2. Check that sort is '0' for local-classification in biblio mappings.
    3. Change sort back to '1' for local-classification for the next steps.
    4. Create a record with 20 items, each with a 100 character long call number
    5. Check that when indexed, the record in ES does not have duplicates in any of the item fields and local-classification__sort is truncated to 255 characters.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit eb7b2907c55d896a7c5b8bccf31daeae8bc5720b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Mar 5 14:29:58 2019 -0300

    Bug 22416: (bug 22140 follow-up) Remove warnings in Search.t
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a0e10d97223ae2945f6ac64b7d86f4ac2fea9e03
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Mar 5 15:16:44 2019 -0300

    Bug 22419: Records listed twice when select/unselect all from the cart
    
    It fixes a browser timeout when records are removed from the cart.
    The onchange event already call selRecord.
    
    Test plan:
    Launch a search
    Add all the result to your cart
    Open the cart
    Click "select all"
    Then remove them all from your cart
    => Without this patch the action will timeout
    => With this patch applied the action is immediate
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1f2685f7d4965d6aa4a25be81aebf91b1ed01b33
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Mar 7 20:52:59 2019 +0000

    Bug 20639: DBRev 18.12.00.023
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 916a27686a4e76b0a8b6982dbbbf4ae9eee4267e
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Feb 9 23:11:55 2019 +0100

    Bug 20639: (QA follow-up) Rephrase system preference
    
    Rephrases system preference a tiny bit and explaining case
    of leaving the pref empty.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6d3136c7e893011bd7cdfd0b6415d20929b6a66b
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Thu Sep 27 11:44:27 2018 +0100

    Bug 20639: (follow-up) Fix population of backends
    
    The OPAC view wasn't correctly restricting the display of backends when
    the ILLOpacbackends preference was set.
    
    See the test plan on comment 7
    
    Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ef6ad443a872c207654721d1e9edee3a6eb88087
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Apr 24 14:15:22 2018 +0100

    Bug 20639: Add ILLOpacbackends syspref
    
    This adds the ILLOpacbackends syspref, allowing users to refine the ill
    backends available to opac users for initiating ill requests
    
    Remove default assignment for backends
    
    We don't need a default assignment for the ILLOpacbackends assignment,
    if the pref isn't set, it returns undef anyway. Also, having this
    default assignment actually breaks the fetching of the preference
    
    Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a8be1966f3855d6950021018254819b04a5287c3
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Sat Dec 22 13:55:23 2018 +0000

    Bug 22031: Add SQL::Abstract like syntax to haspermission
    
    This patch adds an SQL::Abstract inspired query syntax to the
    haspermission method in C4::Auth.  One can now pass Arrayrefs to denote
    an OR list of flags, a Hashref to denote a AND list of flags.
    
    Structures can be nested at arbitrary depth.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 29bc2b583264a62c29a0f39dd79a5b3a64721ae6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Feb 27 09:38:57 2019 -0300

    Bug 22275: (bug 15836 follow-up) Fix class_sources.class_split_rule FK creation
    
    18.06.00.060 will fail if custom Classification sources were created.
    
    In that case we should use the 'generic' split rule.
    
    Test plan:
    % git checkout -b bug_22395_pre 3a0cba67f1387595f570ab9d9efdeabc856345b4
    Reset the DB
    Go to  Home › Administration › Classification sources
    Create a custom "Classification filing rules"
    Create a custom "Classification sources" using this filing rules
    % git checkout master
    % perl installer/data/mysql/updatedatabase.pl
    => Without this patch you will get:
    DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`#sql-33a_67`, CONSTRAINT `class_source_ibfk_2` FOREIGN KEY (`class_split_rule`) REFERENCES `class_split
    _rules` (`class_split_rule`)) [for Statement "
                ALTER TABLE class_sources
                ADD CONSTRAINT class_source_ibfk_2 FOREIGN KEY (class_split_rule)
                REFERENCES class_split_rules (class_split_rule)
            "] at installer/data/mysql/updatedatabase.pl line 17104.
    
    => With this patch applied the FK will be created successfully
    class_sources.class_split_rule will be set to "generic" for these custom values.
    
    Signed-off-by: Oliver Behnke <oliver.behnke at aei.mpg.de>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5ebf1a26dae62651d1749a2df2e54ee6d1af148a
Author: David Gustafsson <david.gustafsson at ub.gu.se>
Date:   Fri Apr 6 11:15:07 2018 +0200

    Bug 20535: ModZebra called with $record with items stripped
    
    ModZebra called with $record with items stripped in
    ModBiblioMarc. Remove $record argument to force
    record to be loaded again from database with items
    embedded.
    
    How to test:
    1) Make sure biblios are indexed (with
       rebuild_elastic_search.pl).
    2) Perform a search that will produce a sample result
       containing at least one biblio with items.
    3) Edit and save a biblio with items.
    4) Perform the same search again, the updated biblio
       should now have no items when viewed in the search
       results (No items).
    5) Apply patch.
    6) Repeat step 1-3.
    7) The updated biblio should now have items when viewed
       in the search results.
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 926d7c4ba11ad6cd768c884ec4b2dc71d864b64c
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Mar 6 08:58:03 2019 +0100

    Bug 16251: Fix value of material select for Rancor 008 widget
    
    The material type is selected in accordance with the leader (06-07)
    
    Test plan:
    1. Create a new record using the advanced editor
    2. Set the leader 6th position to 'c'
    3. Save the record and reload the page
    4. 'Music' should be automatically selected for 008
    5. Try other values for the leader 6th and 7th positions
    
    See comment 0 of this bug for the complete mapping
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit eeaf59a31ff33ec505fe86a3ef7278aed1733e25
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Mar 7 20:40:53 2019 +0000

    Bug 15774: DBRev 18.12.00.022
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0499a3bf2b8aad543a6d0e7b87cbee75cd14f166
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Feb 28 07:45:13 2019 +0000

    Bug 15774: (QA follow-up) Remove asset of datables.css, and corresponding plugins
    
    It is now part of doc-head-close.inc
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit fa243015988028cfba82eaeef35a7ec53a000586
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Feb 28 07:44:52 2019 +0000

    Bug 15774: (QA follow-up) Fix use statemenets
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1966c6be2e21613c5e1efb977dc946f0f1c21e20
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Feb 27 13:22:31 2019 -0500

    Bug 15774: (follow-up) fix rebase issues
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9cfcd21f24c176cecb743084ee22243aeb44848d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Dec 18 12:05:10 2018 +0000

    Bug 15774: Add permission for managing additional fields
    
    To test:
     1 - Have three borrowers, one with order_manage permission, one with
     edit_subscription permisson, andone with both
     2 - Apply patch, updatedatabase
     3 - Verify all three now have the manage_additional_fields permission
     4 - Visit the admin page with these users, they should all see the
     'Manage additional fields' link
     5 - Click the link
     6 - User with order_manage should see 'Order baskest'
     7 - User with edit_subscription should see 'Subscriptions'
     8 - User with both should see both
     9 - Remove the additional permissions from a user - they should see a
     note about needing additional permissions
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit fe8bc587f6f78600b7aecc0b7efd75306e9a2e12
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 1 17:58:14 2018 -0300

    Bug 15774: Remove unecessary returned value for ->delete
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7a109482865838f1594e2e84f762e3e9c95a22db
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 1 17:57:54 2018 -0300

    Bug 15774: Do not fetch additional fields from GetSubscription
    
    Finally we do not want that, they should be fetch when needed
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ee5b5175d9dafa906432835d018081ed62fbab05
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 1 17:57:24 2018 -0300

    Bug 15774: Fix and unify additional_fields in C4::Serials
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9bf62c78811e50aa1b3cfbb25e825d2ca093c180
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 1 17:54:43 2018 -0300

    Bug 15774: Add missing tests for Koha::Object::Mixin::AdditionalFields
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e0da941f712a2b2be6e43eefbcdd013ec4bd5adb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 1 17:51:56 2018 -0300

    Bug 15774: Fix insert and update for subscription
    
    Call it a typo
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ccd6a334b7447b446bd150d0420f5ad7544bbb8c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 1 17:41:37 2018 -0300

    Bug 15774: Use the include file to display the subscription's additional fields
    
    We have it, why not to use it?
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8035151e41fc2e97e8a0c32cfa0e8c252c393bf2
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Nov 1 18:32:05 2018 +0000

    Bug 15774: (follow-up) Address QA issues
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit feb866a618ad5fccb4384dbc9c8b6fd23fec6472
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Oct 16 16:55:18 2018 -0300

    Bug 15774: Fix JS check when AV and MARC field are both selected
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 695ce65132e7e88bd5d3da46e99b665b91a71eb6
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Oct 4 19:46:53 2018 +0000

    Bug 15774: (follow-up) Add html filters
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a0a7b779ee39fed7e8d88b7357716d7d4a78d8f0
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed May 16 09:30:42 2018 +0200

    Bug 15774: Show additional field values in edit form
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 284b543ea4a82dfd4873cc122ba7c2a816f141ca
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Tue May 15 17:16:34 2018 +0200

    Bug 15774: Add POD and license notices
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 904a4884601588ca89faaaee5e0fd53d3907ec10
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri May 4 17:35:45 2018 +0200

    Bug 15774: Use Koha::Object(s) for additional fields
    
    A lot of code can be removed just by using Koha::Object
    
    It also makes fetching and updating additional field values easier.
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bd9ef8f5843fa7bcb49dc490001c79750035e0d0
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Thu Feb 22 13:52:10 2018 +0100

    Bug 15774: Fix additional fields filters
    
    Addresses the following QA comments:
    
    1/ Regression:
    On serials/serials-search.pl, the filters are not filled with what the
    users searched for and the additional fields linked to an AV are not
    displayed as a dropdown list.
    
    4/ When searching an order, there is no way not to set a "all" value for
    additional fields linked to AV.
    
    5/ When searching an order and the search does not return any results,
    the field should contain what the user filled in.
    
    https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774#c10
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a108256face480867de76f348d577ade0481cdfa
Author: Jesse Weaver <jweaver at bywatersolutions.com>
Date:   Thu Jul 21 13:34:26 2016 -0600

    Bug 15774: (QA follow-up) Make sure that tablename is correctly saved
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 84f83012295c90995db48775ff32f06b8d082581
Author: Jesse Weaver <jweaver at bywatersolutions.com>
Date:   Wed Feb 10 12:29:06 2016 -0700

    Bug 15774: Add additional fields to order baskets
    
    This also moves the admin page for additional fields for all tables to a
    single common screen, and factors out display/input parsing logic.
    
    Test plan:
      1. Create an additional field for a subscription (under Serials -> Add
         subscription fields).
      2. Apply patch.
      3. Visit Additional fields under administration, and verify that
         the field created above still shows under the list for the
         subscription table.
      4. Create at least four fields for aqbasket for each combination of
         searchable/not-searchable and with/without an authorized value.
      5. Create an order basket, and verify that all fields are visible and
         correctly save.
      6. Edit the basket, verifying that changes to these additional fields
         are saved.
      7. Add an order to the basket (contents are irrelevant).
      8. Go to advanced search within acquisitions.
      9. Verify that only the searchable fields show in the form, and that
         their contents may be searched.
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm                                  |   10 +
 C4/Auth.pm                                         |   59 ++-
 C4/Biblio.pm                                       |    2 +-
 C4/Serials.pm                                      |   47 +--
 Koha.pm                                            |    2 +-
 Koha/Acquisition/Basket.pm                         |    2 +-
 Koha/Acquisition/Baskets.pm                        |    2 +-
 Koha/AdditionalField.pm                            |  428 +-------------------
 Koha/AdditionalFieldValue.pm                       |   66 +++
 Koha/AdditionalFieldValues.pm                      |   46 +++
 Koha/AdditionalFields.pm                           |   46 +++
 Koha/Illrequest.pm                                 |    4 +-
 Koha/Illrequest/Config.pm                          |    9 +-
 Koha/Object/Mixin/AdditionalFields.pm              |  100 +++++
 Koha/Objects/Mixin/AdditionalFields.pm             |   83 ++++
 Koha/Schema/Result/Aqbasket.pm                     |   15 +
 Koha/Schema/Result/Subscription.pm                 |   15 +
 Koha/SearchEngine/Elasticsearch.pm                 |   21 +-
 Koha/Subscription.pm                               |    2 +-
 Koha/Subscriptions.pm                              |    2 +-
 acqui/basket.pl                                    |    7 +
 acqui/basketheader.pl                              |   21 +
 acqui/histsearch.pl                                |   15 +
 .../add_fields.pl => admin/additional-fields.pl    |   38 +-
 admin/searchengine/elasticsearch/mappings.yaml     |   54 +--
 installer/data/mysql/sysprefs.sql                  |    1 +
 installer/data/mysql/updatedatabase.pl             |   38 ++
 installer/data/mysql/userpermissions.sql           |    1 +
 .../intranet-tmpl/lib/koha/cateditor/widget.js     |    7 +
 .../prog/en/includes/additional-fields-display.inc |   11 +
 .../prog/en/includes/additional-fields-entry.inc   |   34 ++
 .../intranet-tmpl/prog/en/includes/admin-menu.inc  |    5 +-
 .../prog/en/includes/cateditor-widgets-marc21.inc  |   26 +-
 .../prog/en/includes/filter-orders.inc             |    1 +
 .../intranet-tmpl/prog/en/includes/permissions.inc |    1 +
 .../prog/en/includes/serials-menu.inc              |    1 -
 .../intranet-tmpl/prog/en/modules/acqui/basket.tt  |    2 +
 .../prog/en/modules/acqui/basketheader.tt          |    5 +
 .../prog/en/modules/admin/additional-fields.tt     |  211 ++++++++++
 .../prog/en/modules/admin/admin-home.tt            |    6 +-
 .../en/modules/admin/preferences/circulation.pref  |    5 +
 .../prog/en/modules/serials/add_fields.tt          |  178 --------
 .../prog/en/modules/serials/serials-search.tt      |   26 +-
 .../prog/en/modules/serials/subscription-add.tt    |   35 +-
 .../prog/en/modules/serials/subscription-detail.tt |   13 +-
 .../en/modules/virtualshelves/addbybiblionumber.tt |    3 +-
 koha-tmpl/intranet-tmpl/prog/js/cart.js            |    2 -
 opac/opac-illrequests.pl                           |    5 +-
 serials/claims.pl                                  |   10 +-
 serials/serials-search.pl                          |   31 +-
 serials/subscription-add.pl                        |   85 ++--
 serials/subscription-batchedit.pl                  |   30 +-
 serials/subscription-detail.pl                     |   17 +-
 t/Koha/SearchEngine/Elasticsearch.t                |   36 +-
 t/db_dependent/Acquisition.t                       |   38 +-
 t/db_dependent/AdditionalField.t                   |  293 --------------
 t/db_dependent/Auth/haspermission.t                |  248 ++++++++----
 .../Koha/Objects/Mixin/AdditionalFields.t          |  156 +++++++
 t/db_dependent/Search.t                            |    2 +
 59 files changed, 1438 insertions(+), 1221 deletions(-)
 create mode 100644 Koha/AdditionalFieldValue.pm
 create mode 100644 Koha/AdditionalFieldValues.pm
 create mode 100644 Koha/AdditionalFields.pm
 create mode 100644 Koha/Object/Mixin/AdditionalFields.pm
 create mode 100644 Koha/Objects/Mixin/AdditionalFields.pm
 rename serials/add_fields.pl => admin/additional-fields.pl (73%)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-display.inc
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc
 create mode 100755 koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
 delete mode 100644 t/db_dependent/AdditionalField.t
 create mode 100755 t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list