[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.10-26-gc6f8b29

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  c6f8b29803a1bb001e0f2caae85506075d4873a7 (commit)
       via  ca706e6310b30d3e110351409dcdbb19c0da7934 (commit)
      from  e581b73c5d17f48a88424a9467395435fe1e86ff (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c6f8b29803a1bb001e0f2caae85506075d4873a7
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Dec 13 14:56:22 2018 -0500

    Bug 21997: SIP patron information requests can lock patron out of account
    
    Many SIP services send an empty password field (AD). Even if allow_empty_passwords is enabled for the given SIP account, this empty password is run though Koha's password checker which increments the number of login attempts for a patron. Thus repeated patron information requests can lock a patron out! Empty password fields in SIP should not call for a password check if allow_empty_passwords is enabled.
    
    Test Plan:
    1) Enable a patron password attempt with a limit of 3
    2) Send 4 patron information requests with an empty AD field
    3) Note the patron's account is now locked
    4) Apply this patch
    5) Repeat step 2 with a different patron
    6) Note the patron's account does not get locked!
    
    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit fac2c172143b31255767684e4b22c0ba1ae0aaaf)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 9d811184fef4c7db64f616bd631991aef503a8a9)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit ca706e6310b30d3e110351409dcdbb19c0da7934
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Feb 11 13:16:10 2019 -0500

    Bug 21997: Unit tests
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d0a6469ad58ccd6067bdfbb6cfb0e28dabc5862a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a72d11e55dc24764faa6717d3d130ca92777afd0)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/SIP/Sip/MsgType.pm        |    3 ++-
 t/db_dependent/SIP/Message.t |   10 +++++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository