[koha-commits] main Koha release repository branch master updated. v18.11.00-706-g088e024

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  088e0243bf7cd16f7769ddbc2eeefd5857c471f7 (commit)
       via  4cb1a47d0368640b3e10f51d83b0ce8ea5dd953e (commit)
       via  2b2054e6948477a94408f96c08e4621ae2d2d8ed (commit)
       via  6b457885cd325da444d39b031eac567eb0f46351 (commit)
       via  32551fffdb4296456df2061fd5eaaf403a5799c2 (commit)
       via  cc67ff26aad6e6d429a65d6ea3ffb2226b25ab51 (commit)
      from  255af719e65956d84d62ea52fea12619bb851f70 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 088e0243bf7cd16f7769ddbc2eeefd5857c471f7
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 8 16:52:07 2019 +0000

    Bug 22483: Restore undef behaviour
    
    Turns out that we rely heavily on the side effect that passing undef
    to haspermission would always return true no matter what permissions
    or lack of permissions you had.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 4cb1a47d0368640b3e10f51d83b0ce8ea5dd953e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Mar 8 13:45:03 2019 -0300

    Bug 22483: (follow-up) Fix wrong tests higlighted by bug
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 2b2054e6948477a94408f96c08e4621ae2d2d8ed
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 8 15:10:20 2019 +0000

    Bug 22483: (QA follow-up) Tweaking call to haspermission
    
    This patch tweaks the logic to check the permissions is defined before
    passing to haspermission.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 6b457885cd325da444d39b031eac567eb0f46351
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 8 14:20:41 2019 +0000

    Bug 22483: (QA follow-up) Corrections to logic in check_cookie_auth
    
    check_cookie_auth needs to allow for cases where we wish to check for
    ANY permission and cases where we wish to skip the permissions check
    entirely and just authenticate the session.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 32551fffdb4296456df2061fd5eaaf403a5799c2
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 8 12:49:10 2019 +0000

    Bug 22483: (follow-up) Improve POD as requested in bug 22031
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit cc67ff26aad6e6d429a65d6ea3ffb2226b25ab51
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Mar 8 12:24:17 2019 +0000

    Bug 22483: Explicitly ban 'undef' as a valid $flagsrequired
    
    Before bug 22031 the haspermission subroutine signature allowed for
    passing 'undef' to mean 'any permission' in $flagsrequired.  This feels
    like a mistake and was only in practical use in two places in the
    codebase.
    
    This patch explicitly forbids this practice (`*` may be used to the same
    result and is more explicit in it's nature) and replaces the two
    instances of it's use.
    
    Test Plan
    1. Before this patch, the API tests are all failing with authentication
    errors
    2. After this patch the API tests should now all pass.
    3. t/db_dependent/Auth/haspermission.t should continue to pass (with one
    addition subtest added herin)
    3. /svc/members/search is not unit tested. Please check that patron
    searching still yields results in the UI after this patch.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                               |   25 +++++++++++++++++++++----
 Koha/REST/V1/Auth.pm                     |    2 +-
 svc/members/search                       |    2 +-
 t/db_dependent/Auth/haspermission.t      |   17 ++++++++++++++++-
 t/db_dependent/api/v1/patrons_password.t |    6 +++---
 5 files changed, 42 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
main Koha release repository