[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.10-39-gccdc3af

Git repo owner gitmaster at git.koha-community.org
Fri Mar 8 21:02:23 CET 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  ccdc3afb148fb6b1e7ab2b295dc9adbf668184df (commit)
       via  6473493713fcb400829b17b71d8f48626426a461 (commit)
       via  f7c5a910ded2bc15ccc2fa9cea557c61d7989f10 (commit)
       via  13a769c5a8706825093fd85c79619ce8639573c5 (commit)
       via  96e43cdecc5a929c07ec5d25b064bb731c7a07b0 (commit)
       via  7612fc325f48fe7d36ae00a42f29ec1895b2b700 (commit)
      from  d9e1ce3df55c2bc5f8026a8dd18babd558dab1c7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ccdc3afb148fb6b1e7ab2b295dc9adbf668184df
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Jan 8 13:10:53 2019 -0500

    Bug 22084: Plugin upgrade method and database plugin version storage will never be triggered for existing installs
    
    If an existing plugin begins using the upgrade() method, it will never actually get triggered because the installation has already occurred and no database plugin version was stored at the time. Without that database version, the upgrade method will never be triggered.
    
    In addition, if the plugin has no upgrade method, the installed version is never updated in the database!
    
    Lastly, when an upgrade succeeds it prints a warning that the upgrade failed.
    
    Test Plan:
    1) Install an older version of the Kitchen sink plugin:
       * https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.0/koha-plugin-kitchen-sink-v2.1.0.kpz
    2) Delete the "__INSTALLED_VERSION__" key, and the "last_upgraded" key from plugin_data for this plugin, to simulate having installed from an earlier version of Koha
    3) Upgrade to the latest version of the Kitchen sink plugin:
       * https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.22/koha-plugin-kitchen-sink-v2.1.22.kpz
    4) Note "__INSTALLED_VERSION__" still doesn't exist for the plugin, in the plugin_data table
    5) Apply this patch
    6) Restart all the things
    7) Browse to the Kitchen sink configuration page, this should trigger the upgrade method
    8) Note the "__INSTALLED_VERSION__" and "last_upgraded" keys exist in plugin_data for the Kitchen Sink plugin
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8c2e03020dc02519dec70b9697794a3624c73937)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit b19b36fb6260932dff3961ec9ed1202188d367de)
    
    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 6473493713fcb400829b17b71d8f48626426a461
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Jan 9 07:33:15 2019 -0300

    Bug 22084: Regression tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 57f4c01b9a09d1c2e0fc8a3449ba86574775b840)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 00fff866dd25c89f740b46e6366868027fe7512a)
    
    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit f7c5a910ded2bc15ccc2fa9cea557c61d7989f10
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Feb 11 16:05:23 2019 -0300

    Bug 21765: Make AutoUnsuspendReserves call Koha::Hold->resume
    
    This patch makes the mentioned method use the biult-in method for
    resuming a suspended hold, instead of manually setting the specific
    attributes using the accessors.
    
    The side effect for this is that HoldsLog is now honoured.
    
    This patchset also refactors the tests a bit so they rely on the exposed
    methods and thus don't rely on specific implementation details (like
    suspended hold means a date in suspended_until plus suspended=1).
    
    To test:
    - Apply the regression tests patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t
    => FAIL: It fails loudly because things are done manually
    - Apply this patch
    - Run:
     k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t
    => SUCCESS: Tests pass!
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7c3a5c78c1aacbdb0ad7eb758cb9880ecefcce3a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 7609009a7319ad6e631bac6fd39a8a5397566782)
    
    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 13a769c5a8706825093fd85c79619ce8639573c5
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Feb 11 16:04:59 2019 -0300

    Bug 21765: Regression tests
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d441ce5cdadba7a87570162b9f54600c82f150e2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit eeeae403a1cf3ef0860abec23cd05ac8577e996d)
    
    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 96e43cdecc5a929c07ec5d25b064bb731c7a07b0
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Feb 25 18:21:26 2019 +0000

    Bug 22411: Date and time in log viewer should respect
    
    Test plan:
    Go to log viewer and show some log
    -- without patch the date ant time in first column is formatted as
    yyyy-mm-dd hh:mm
    -- with patch the date is formatted according to your dateformat system
    preference
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit dd8749661ce7e48e86fc4eeba3c7c42e0321184e)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit f9892cd621e9c1c17dac41771b607119bee05840)
    
    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

commit 7612fc325f48fe7d36ae00a42f29ec1895b2b700
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Feb 21 17:21:58 2019 +0100

    Bug 15149: Serial test prediction pattern does not consider end date
    
    To reproduce:
    
    1) add a serial.
    2) set first issue = today
    3) set frequency = 1/month
    4) dont set subscription length
    5) set subscription start date = today
    6) set subscription start date = today + 1 year
    7) set numbering pattern = Number
    8) test prediction pattern.
    => Without patch : you will get a list of 1000 issues, going well beyond subscripton end date.
    => With patch : shows only the issues within the date range.
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: zhihui <zhihui at inlibro.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e3212c8a969ff17783e50d564aaa412bd01a99b1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit c20af7c877b8a13f51cb94aec97dee55fc15db56)
    
    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reserves.pm                                     |    2 +-
 Koha/Plugins/Base.pm                               |    7 +-
 .../intranet-tmpl/prog/en/modules/tools/viewlog.tt |    3 +-
 serials/showpredictionpattern.pl                   |    2 +-
 t/db_dependent/Plugins.t                           |   28 +++-
 t/db_dependent/Reserves/AutoUnsuspendReserves.t    |  135 +++++++++++++++++---
 6 files changed, 151 insertions(+), 26 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list