[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.03-121-g9f065fe

Tue Mar 12 10:56:05 CET 2019

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  9f065fe43f62f2bfbecc15b7267d06a9c62b1638 (commit)
       via  a086a063d4895e5a3ac02f300828ca25857d81e5 (commit)
       via  453e2fe464c6a6b1f3ff39058d164b463c23f55c (commit)
       via  2084f0e3cb2496b979dbacb70d17aab868d9ee2b (commit)
       via  d558544afd437466f4a0fc342a127610a98ca184 (commit)
       via  9a82230b2742c51af63f8156e18324556112b572 (commit)
       via  c0dfab31d96e17642f68e7aeb471023eee8c72a8 (commit)
       via  0c8b515fe724c248cae1d6fa696020c5de9957f1 (commit)
       via  7d741a69919c17f8c8c6a4c965d93c95c2355793 (commit)
       via  a03d8dd1735520614492aab207a392b957e34630 (commit)
       via  f5d6b6e4e95e1850908fb73b88a36bd6d76b0f5c (commit)
       via  6729f22ff015cd14c2356f44d7f30843a302937e (commit)
       via  0e56d43b403c1acb4c9c0ce9427bfa3b33692d8b (commit)
       via  d7988f672f68e0cc875eedce6bad0b634df8941c (commit)
       via  f688c463fd4cee3c6a894d583437b198060265e4 (commit)
       via  b102d73fa51c1dabc46b03b2ad873db9e9b7ca42 (commit)
       via  4ca973f55d7eed71b4f0afad3b46ed95fec5ce13 (commit)
      from  85a30f6d9f3170f3652c0c8d4c4d68edb9491bda (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9f065fe43f62f2bfbecc15b7267d06a9c62b1638
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Feb 10 03:09:45 2019 +0100

    Bug 17496: Remove undocumented/maintained install-CPAN.pl file

    The install-CPAN.pl file was added in 2007 and hasn't been
    updated or documented since.

    This patch removed it from Koha.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit cab238755a69ca7e52b3822b390b31484abb5c72)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a086a063d4895e5a3ac02f300828ca25857d81e5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Mar 12 09:21:24 2019 +0000

    Bug 22422: Compiled CSS

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 453e2fe464c6a6b1f3ff39058d164b463c23f55c
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Feb 28 13:37:40 2019 +0100

    Bug 22422: improve item location display with class "shelvingloc"

    In record detail page, item location is displayed with CSS using class "shelvingloc".
    Many many places at intranet and OPAC can use this class.
    It allows to change display in all places using CSS customisation.

    This patch removes the CSS "display:block" for class "shelvingloc".
    Some places where using "inline" to correct the display.
    I think the display should not be managed in template.
    So it will be inline by default and it can be changed by custom CSS, on all places or depending on a selctor.

    Test plan :
    1) Compile SCSS to CSS
    2) Add to preferences IntranetUserCSS and OPACUserCSS : .shelvingloc { color:red }
    3) Go to pages impacted by patch, be sure to look at cart with "more details"
    4) You see item location italic and red

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit bc2d9f869ad0bde3e97e3773e0e050503d8083f4)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2084f0e3cb2496b979dbacb70d17aab868d9ee2b
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Mar 5 18:22:12 2019 +0000

    Bug 21030: Date widget on suspend modal not working correctly

    This patch makes a change to the suspend hold modal markup in order to
    allow the datepicker <selects> to work properly.

    To test, apply the patch and locate a patron in the staff client who has
    holds.

     - On the checkout or patron detail page, open the holds tab.
     - Click the "Suspend" button for one of the holds.
     - In the modal, trigger the date picker and confirm that the dropdowns
       for selecting month and year work correctly.

    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit c91c1a69a23ff8d826a077c61059953bcc51940b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d558544afd437466f4a0fc342a127610a98ca184
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Thu Mar 7 03:10:28 2019 +0000

    Bug 19046: (QA follow-up) Remove doubled up 'Title as phrase'

    One search option was doubled up by accident.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ae2caab54f53bd9b7fbe8e5c1575f38e97002bf2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9a82230b2742c51af63f8156e18324556112b572
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Mar 4 15:39:29 2019 -0300

    Bug 19046: Make seach pulldown to retain index selection

    This patch also fixes add the term in the search input

    Test plan:
    Enable IntranetCatalogSearchPulldown
    Search for a term using the search input in the header (simple search)
    Re-do selecting different indices

    The selection must retain on the search result page.

    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 74ac15800bbf358e3f1133a1f212400797640112)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c0dfab31d96e17642f68e7aeb471023eee8c72a8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Mar 4 14:50:36 2019 -0300

    Bug 22442: (bug 13618 follow-up) Fix item search CSV export

    We must not filter assignements statements.

    Test plan:
    Export item search result as CSV
    Without this patch the biblio and biblioitem values are not displayed.
    With this patch applied everything is displayed correctly

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit bb730c1b05c91ee92db09d117293a0ddb87dace1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0c8b515fe724c248cae1d6fa696020c5de9957f1
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Feb 11 09:54:43 2019 +0100

    Bug 22303: Correct bottom in virtualshelves/addbybiblionumber.tt

    In virtualshelves/addbybiblionumber.tt the include intranet-bottom.inc which closes the HTML last tag is not the last line of the template.

    This patch moved bottom include to last line and uses popup-bottom.inc.

    Test plan :
    1) Permission OK :
    1.1) Login in staff interface with user 'Bob'
    1.2) Create a new list 'Readme' : category public and allow changes to contents from anyone
    1.3) Perform a search
    1.4) Check some results
    1.5) Click 'Add to list' and on the list 'Readme'
    1.6) A popup window opens
    1.7) Check its HTML is OK, ending with </html>
    2) Permission KO :
    2.1) Open a new window (Firefox private session) and login in staff interface with user 'Bill'
    2.2) Perform a search
    2.3) Check some results
    2.4) On session of 'Bob', edit list 'Readme'
    2.5) Change : category private and allow changes to contents from owner only
    2.6) On session of 'Bill'
    2.7) Click 'Add to list' and on the list 'Readme'
    2.8) A popup window opens saying 'Sorry, you do not have permission to add items to this list'
    2.9) Check its HTML is OK, ending with </html>

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 255af719e65956d84d62ea52fea12619bb851f70)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7d741a69919c17f8c8c6a4c965d93c95c2355793
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Fri Feb 1 13:18:11 2019 +0200

    Bug 22246: Fix indexing of large fields with Elasticsearch

    Deduplicate multivalued fields and make sure sort fields are not excessively long. Also updates default mappings so that sort fields are not created for item fields where it doesn't make sense.

    Test plan:
    1. Reset ES mappings in administration
    2. Check that sort is '0' for local-classification in biblio mappings.
    3. Change sort back to '1' for local-classification for the next steps.
    4. Create a record with 20 items, each with a 100 character long call number
    5. Check that when indexed, the record in ES does not have duplicates in any of the item fields and local-classification__sort is truncated to 255 characters.

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit bd68e2f75b2bd0cae7935715f4aa03342809cb9f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a03d8dd1735520614492aab207a392b957e34630
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Mar 5 14:29:58 2019 -0300

    Bug 22416: (bug 22140 follow-up) Remove warnings in Search.t

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit eb7b2907c55d896a7c5b8bccf31daeae8bc5720b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f5d6b6e4e95e1850908fb73b88a36bd6d76b0f5c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Mar 5 15:16:44 2019 -0300

    Bug 22419: Records listed twice when select/unselect all from the cart

    It fixes a browser timeout when records are removed from the cart.
    The onchange event already call selRecord.

    Test plan:
    Launch a search
    Add all the result to your cart
    Open the cart
    Click "select all"
    Then remove them all from your cart
    => Without this patch the action will timeout
    => With this patch applied the action is immediate

    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a0e10d97223ae2945f6ac64b7d86f4ac2fea9e03)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6729f22ff015cd14c2356f44d7f30843a302937e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Feb 27 09:38:57 2019 -0300

    Bug 22275: (bug 15836 follow-up) Fix class_sources.class_split_rule FK creation

    18.06.00.060 will fail if custom Classification sources were created.

    In that case we should use the 'generic' split rule.

    Test plan:
    % git checkout -b bug_22395_pre 3a0cba67f1387595f570ab9d9efdeabc856345b4
    Reset the DB
    Go to  Home › Administration › Classification sources
    Create a custom "Classification filing rules"
    Create a custom "Classification sources" using this filing rules
    % git checkout master
    % perl installer/data/mysql/updatedatabase.pl
    => Without this patch you will get:
    DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`#sql-33a_67`, CONSTRAINT `class_source_ibfk_2` FOREIGN KEY (`class_split_rule`) REFERENCES `class_split
    _rules` (`class_split_rule`)) [for Statement "
                ALTER TABLE class_sources
                ADD CONSTRAINT class_source_ibfk_2 FOREIGN KEY (class_split_rule)
                REFERENCES class_split_rules (class_split_rule)
            "] at installer/data/mysql/updatedatabase.pl line 17104.

    => With this patch applied the FK will be created successfully
    class_sources.class_split_rule will be set to "generic" for these custom values.

    Signed-off-by: Oliver Behnke <oliver.behnke at aei.mpg.de>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 29bc2b583264a62c29a0f39dd79a5b3a64721ae6)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0e56d43b403c1acb4c9c0ce9427bfa3b33692d8b
Author: David Gustafsson <david.gustafsson at ub.gu.se>
Date:   Fri Apr 6 11:15:07 2018 +0200

    Bug 20535: ModZebra called with $record with items stripped

    ModZebra called with $record with items stripped in
    ModBiblioMarc. Remove $record argument to force
    record to be loaded again from database with items
    embedded.

    How to test:
    1) Make sure biblios are indexed (with
       rebuild_elastic_search.pl).
    2) Perform a search that will produce a sample result
       containing at least one biblio with items.
    3) Edit and save a biblio with items.
    4) Perform the same search again, the updated biblio
       should now have no items when viewed in the search
       results (No items).
    5) Apply patch.
    6) Repeat step 1-3.
    7) The updated biblio should now have items when viewed
       in the search results.

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5ebf1a26dae62651d1749a2df2e54ee6d1af148a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit d7988f672f68e0cc875eedce6bad0b634df8941c
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Mar 6 08:58:03 2019 +0100

    Bug 16251: Fix value of material select for Rancor 008 widget

    The material type is selected in accordance with the leader (06-07)

    Test plan:
    1. Create a new record using the advanced editor
    2. Set the leader 6th position to 'c'
    3. Save the record and reload the page
    4. 'Music' should be automatically selected for 008
    5. Try other values for the leader 6th and 7th positions

    See comment 0 of this bug for the complete mapping

    Signed-off-by: Michal Denar <black23 at gmail.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 926d7c4ba11ad6cd768c884ec4b2dc71d864b64c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f688c463fd4cee3c6a894d583437b198060265e4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Mar 6 11:59:58 2019 -0300

    Bug 22466: Replace existing occurrences

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9ff997eda7582dbb68d599ab1436b162dd1559da)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b102d73fa51c1dabc46b03b2ad873db9e9b7ca42
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Mar 6 11:59:55 2019 -0300

    Bug 22466: Do not ask for TT methods to be filtered

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 158b3c3a4cfc8a97cc98a3473ca70395fdb398e1)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 4ca973f55d7eed71b4f0afad3b46ed95fec5ce13
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Mar 6 11:59:35 2019 -0300

    Bug 22466: Add tests

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit c7ef8e6b2db5830745759ad15fe9d6379f6f62b2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |    2 +-
 Koha/SearchEngine/Elasticsearch.pm                 |   21 ++-
 admin/searchengine/elasticsearch/mappings.yaml     |   54 +++---
 catalogue/search.pl                                |    8 +
 install-CPAN.pl                                    |   45 -----
 installer/data/mysql/updatedatabase.pl             |    7 +
 .../intranet-tmpl/lib/koha/cateditor/widget.js     |    7 +
 .../intranet-tmpl/prog/css/src/staff-global.scss   |    1 -
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |    2 +-
 .../intranet-tmpl/prog/en/includes/cat-search.inc  |    2 +-
 .../en/includes/catalogue/itemsearch_item.csv.inc  |    4 +-
 .../prog/en/includes/cateditor-widgets-marc21.inc  |   26 ++-
 .../prog/en/includes/search_indexes.inc            |  198 ++++++++++++++++----
 .../prog/en/modules/acqui/orderreceive.tt          |    2 +-
 .../intranet-tmpl/prog/en/modules/basket/basket.tt |    5 +-
 .../prog/en/modules/catalogue/detail.tt            |    5 +-
 .../prog/en/modules/catalogue/results.tt           |    6 +-
 .../prog/en/modules/cataloguing/addbooks.tt        |    6 +-
 .../prog/en/modules/circ/branchtransfers.tt        |    2 +-
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |    2 +-
 .../prog/en/modules/reserve/request.tt             |   16 +-
 .../prog/en/modules/serials/serials-search.tt      |    2 +-
 .../intranet-tmpl/prog/en/modules/tags/list.tt     |    3 +-
 .../en/modules/virtualshelves/addbybiblionumber.tt |    3 +-
 .../prog/en/modules/virtualshelves/shelves.tt      |    4 +-
 koha-tmpl/intranet-tmpl/prog/js/cart.js            |    2 -
 koha-tmpl/intranet-tmpl/prog/js/holds.js           |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/css/opac.css         |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss    |    1 -
 .../opac-tmpl/bootstrap/en/modules/opac-basket.tt  |    6 +-
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt |    2 +-
 .../bootstrap/en/modules/opac-results-grouped.tt   |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-results.tt |    4 +-
 .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt |    2 +-
 t/Koha/SearchEngine/Elasticsearch.t                |   36 +++-
 t/db_dependent/Search.t                            |    2 +
 t/lib/QA/TemplateFilters.pm                        |    7 +
 t/template_filters.t                               |   19 +-
 39 files changed, 360 insertions(+), 162 deletions(-)
 delete mode 100644 install-CPAN.pl

hooks/post-receive
-- 
main Koha release repository