[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.10-42-g126d7bc

Git repo owner gitmaster at git.koha-community.org
Wed Mar 13 17:52:19 CET 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  126d7bcbe183c8de98fc6c59cb15874430a38c3e (commit)
      from  8126fe6d122140e40053ed74768148952fe30303 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 126d7bcbe183c8de98fc6c59cb15874430a38c3e
Author: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
Date:   Thu Jan 17 16:41:58 2019 -0500

    Bug 18723: Change dot into comma
    
    This fixes the regression that multiplies the amount entered by 100
    when CurrencyFormat is set to FR. It replaces the last dot with a
    comma before dealing with the value of ActualCost and ReplacementCost.
    
    Test Plan:
    a)Replicate the issue:
        0- Set CurrencyFormat to FR
        1- Go to Acquisitions
        2- Search for a Vendor
        3- Click on "New basket"
        4- Give basket a name and click "Save"
        5- Click on "Add to basket"
        6- Add an order through preferred method
        7- In Accounting details, enter a vendor price with dot decimal (i.e. 19.44)
        8- Save your order line
        9- Click on "Close this basket"
        10- Confirm closing of basket by clicking on "Yes, close"
        11- Click on "Receive shipment"
        12- Enter an invoice number and click "Next"
        13- Click on "Receive" to the right of your order
        14- In Accounting details, notice the Actual cost is written with a decimal dot.
        15- Change the Actual cost, using a dot decimal (i.e 20.99)
        16- Receive the order
        17- Click on "Save"
        18- In "Already received" notice the price is multiplied by 100 (i.e. 2099,00)
        19- Click on "Cancel receipt"
        20- Click on "Receive" to the right of your order
        21- In Accounting details, change the Actual cost, using a comma decimal (i.e. 20,99)
        22- Receive the order
        23- Click on "Save"
        24- In "Already received", notice the price is correct.
    b)Apply the patch
    c)Test the patch:
        1- Click on "Cancel receipt"
        2- Click on "Receive to the right of your order
        3- Change the Actual cost/Replacement cost, using a dot decimal (21.99)
        4- Receive the order
        5- Click on "Save"
        6- Notice that the Actual cost and the Replacement cost use commas
        7- Change the Actual cost, using a comma decimal (21,99)
        8- Click on "Save"
        9- In "Already received", notice the price is still correct.
    
    Signed-off-by: Victor Grousset <victor.grousset at biblibre.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit c7f47ea36a8992356c6c055a22891ea168cbdc9c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit bf7524f0b1cebb68584eebf2d3acaec44126355d)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 acqui/finishreceive.pl |    7 +++++++
 1 file changed, 7 insertions(+)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list