[koha-commits] main Koha release repository branch master updated. v18.11.00-786-g0c4bf00

Git repo owner gitmaster at git.koha-community.org
Fri Mar 15 14:03:34 CET 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  0c4bf00c30ce25165a5243bced7b7e19746a7e0b (commit)
       via  08ea70c109ce3432b5dd1a781d126c7353fca3da (commit)
       via  2be9fd23d2e9aa91e2e1f38a2817a54a5cdc5d21 (commit)
       via  3e7620cf46d2e7079ff5494070ff6933fb9650af (commit)
       via  3d462af21f3c13312b0ffb8496e55d277f703ebd (commit)
       via  180781f4748d689674a9f91f546d8e76324e7291 (commit)
       via  d7c0547bd20bd266ea8cd023ac4be22c2a9644d0 (commit)
       via  fa4aeaa87e957298874263ec7c3f8478fcaf8b49 (commit)
       via  293eee9959925397e4fdc84ae0d4baea2cf7d94c (commit)
       via  04f1b0ca950a5a133f6afe6785787d1982414a1e (commit)
       via  865f9a165d5d5e025737324843eccb5c39a74efb (commit)
       via  6c86de628d5873b88a7d6d2d676ecd7b98345aa7 (commit)
       via  1464328718619a673f233406fdb238f0391b0785 (commit)
       via  5c41d584cb654efbfd8c854bac0d30d87a054ab5 (commit)
       via  afb39b132b10b74efec31cd8191cdcd72a61d8d3 (commit)
       via  ed5b7e4575917f07a3e895be754abc2bacc37337 (commit)
       via  d48ae4adafbcb1700ac718c45d78957eb2db3b2e (commit)
       via  a8c473c69160634fb18c0dc9de3b72a011ccd719 (commit)
       via  004609e46814791fac540e1c8bfb21f647758143 (commit)
       via  bc24973c778ce77f1d3726eaad3ce1bc387cd480 (commit)
       via  467c24cb9da02deb00bf49333351a0843cdeda10 (commit)
       via  9f5a1bc7ebbe3954607da88b87bab6e9c2689dad (commit)
       via  7b4ee00a580807b6021758a790fec23c743719d2 (commit)
       via  1934ca1100517ca1622c9c2c0587832504064b25 (commit)
       via  9682cc7d21645a673bd274b24aeab323f61f28aa (commit)
       via  639ad97d844f2774f49881174b559293edd6baa4 (commit)
       via  99ea714345a6278d68e2abb0d182d8b495cf2950 (commit)
       via  ffb40290f88380418635a951dbb0788bf7b7e3ce (commit)
       via  5d4f80feac811a9d6e177975b50c57ba85e3434d (commit)
       via  28edd8848320fd0f0f284245f2f0567a5907619a (commit)
       via  3bd900496690375b2b711743ffaa57371388f687 (commit)
       via  2596e9b795d9e65e4f68a72bb587d323c97bad92 (commit)
       via  deb968ea45276e56826b592026617a96398b61da (commit)
       via  19aebacf7c6162e5628cba1078b2c0f2ec9751a6 (commit)
       via  3c4232e746cef574de9d1a346be7704dc3cd2e33 (commit)
      from  585273b6147d0cda646296a5121e7a3af021473c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0c4bf00c30ce25165a5243bced7b7e19746a7e0b
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri May 25 16:51:15 2018 +0200

    Bug 20823: UNIMARC XSLT add subfield t for subjects
    
    In UNIMARC, 604 contains subfield t, see http://multimedia.bnf.fr/unimarcb_trad/B604-6-2011.pdf.
    Actual XSLT files use template tag_subject for 604, it does not use t subfield.
    
    This patch adds subfield t to tag_subject and tag_onesubject templates in intranet and OPAC XSLT files.
    
    Test plan :
    1) In UNIMARC catalog edit a biblio record to add 604$t
    2) Use default XSLT files in sysprefs
    2) Go to catalogue details page of this record using default XSLT files
    3) Check $t is displayed at OPAC and intranet
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 08ea70c109ce3432b5dd1a781d126c7353fca3da
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Mar 4 16:57:26 2019 -0300

    Bug 22219: Remove duplicated items in inventory (when skipping waiting holds)
    
    Test plan:
    0/ Do not apply this patch
    1/ Place several holds on a given item
    2/ Use the inventory with the "skip waiting holds" option to list this item.
    It will be displayed several times
    3/ Apply this patch and confirm that the item is now only displayed once
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2be9fd23d2e9aa91e2e1f38a2817a54a5cdc5d21
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Mar 4 16:52:30 2019 -0300

    Bug 22219: Add tests
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3e7620cf46d2e7079ff5494070ff6933fb9650af
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Mar 7 17:28:34 2019 +0000

    Bug 22477: Missing DataTables configuration when searching patrons for holds
    
    This patch adds columns configuration to the holds request page to fix a
    JavaScript error in the console and to allow the patron search results
    table to be enabled as a DataTable.
    
    To reproduce: Place a hold on a title in the staff client. When prompted
    for a patron, perform a search which will return multiple results. The
    patron search results will appear in an unsortable table. A JS error can
    be seen in the browser console.
    
    To test, apply the patch and repeat the steps above. The patron search
    results table should be sortable and there should be no JS error.
    
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3d462af21f3c13312b0ffb8496e55d277f703ebd
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Mar 15 12:32:49 2019 +0000

    Bug 21846: DBRev 18.12.00.025
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 180781f4748d689674a9f91f546d8e76324e7291
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Feb 26 17:01:41 2019 -0300

    Bug 21846: Simplify ugly double for loops
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d7c0547bd20bd266ea8cd023ac4be22c2a9644d0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Feb 26 16:32:44 2019 -0300

    Bug 21846: Fix pod2usage return values
    
    According to existing pattern.
    However I am not sure it makes sense to return an errno (and print to STDERR)
    if --help is passed.
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit fa4aeaa87e957298874263ec7c3f8478fcaf8b49
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Feb 26 15:41:02 2019 -0300

    Bug 21846: (QA follow-up) Fix maintenance script path
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 293eee9959925397e4fdc84ae0d4baea2cf7d94c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Jan 8 13:13:46 2019 -0300

    Bug 21846: (follow-up) Add maintenance script
    
    This patch adds a maintenance script that generates the missing
    tags_approval entries based on the tags_all table, and then recalculates
    the weights for both tags_approval and tags_index tables.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 04f1b0ca950a5a133f6afe6785787d1982414a1e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Nov 23 16:47:05 2018 -0300

    Bug 21846: Make 'term' use utf8mb_bin collation on tags tables
    
    This patch makes the utf8mb4_bin collation preferred for comparing tags.
    Otherwise suppolemental unicode characters all match.
    
    To test:
    
    - Enable tags and disable moderation (or plan to moderate and accept tags)
    - Tag 3 records:
       a - with 🐋
       b - with 🌮
       c - with 👍
    - Note the weight on each says '3'
    - Click the tag to search, you get back all the records
    - Apply the previous patches from this bug report
    - Run:
      $ kshell
     k$ prove t/db_dependent/Tags.t
    => FAIL: Tests fail, related to counting stuffs
    - Apply this patch and
    (a) Run updatedatabase to upgrade the schema
    - Run:
     k$ prove t/db_dependent/Tags.t
    => SUCCESS: Tests pass!
    (b) reset_all to get a fresh DB using kohastructure.sql
    - Run:
     k$ prove t/db_dependent/Tags.t
    => SUCCESS: Tests pass too!
    - Sign off :-D
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 865f9a165d5d5e025737324843eccb5c39a74efb
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Nov 23 15:30:52 2018 -0300

    Bug 21846: Regression tests for add_tag_approval
    
    Due to collation issues, add_tag_approval wrongly calculates
    the weight for strings including extended UNICODE characters.
    
    This patch introduces a test for this situation.
    
    To test:
    - Apply this patch on master
    - Run:
      $ kshell
     k$ prove t/db_dependent/Tags.t
    => FAIL: Tests fail because all extended characters match the same
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6c86de628d5873b88a7d6d2d676ecd7b98345aa7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Nov 23 15:44:04 2018 -0300

    Bug 21846: Add Koha::Tags::Approval(s) and Koha::Tags::Index(es)
    
    In order to avoid writing the tests using plain DBIC which would later
    need to be replaced by a Koha::Object-based counterpart, I introduce
    this stub classes.
    
    Stub tests are added as well.
    
    To test:
    - Apply this patch
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Tags.t \
              t/db_dependent/Koha/Tags/Approvals.t \
              t/db_dependent/Koha/Tags/Indexes.t
    => SUCCESS: Tests pass
    - Sign off :-D
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1464328718619a673f233406fdb238f0391b0785
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Mar 15 12:22:32 2019 +0000

    Bug 21987: (RM follow-up) Add text for simple tests
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5c41d584cb654efbfd8c854bac0d30d87a054ab5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Dec 18 14:02:19 2018 -0300

    Bug 21987: Do not generate true color thumbnails if not needed
    
    If the original image is not a true color image we should not generate a
    true color thumbnail.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit afb39b132b10b74efec31cd8191cdcd72a61d8d3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Dec 18 14:02:14 2018 -0300

    Bug 21987: Add tests
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ed5b7e4575917f07a3e895be754abc2bacc37337
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Mar 11 14:47:01 2019 +0000

    Bug 22493: Clean up DecreaseLoanHighHolds.t
    
    To test:
    
    1 - prove -v t/db_dependent/DecreaseLoanHighHolds.t
    2 - should pass
    3 - read code, confirm changes make sense
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d48ae4adafbcb1700ac718c45d78957eb2db3b2e
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Mar 15 09:41:22 2019 +0000

    Bug 14591: (QA follow-up) Fix AddReturn call in Circulation/issue.t
    
    Test plan:
    prove t/db_dependent/Circulation/issue.t
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a8c473c69160634fb18c0dc9de3b72a011ccd719
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Mar 14 16:30:55 2019 +0000

    Bug 14591: (QA follow-up) Optimize DateTime passing
    
    We were passing around possibly undefined $return_date variables from
    AddReturn and then instantiating a new DateTime object as a default for
    each routine. This followup sets the default higher up the stack within
    AddReturn which provider clearer logic and a small performance
    improvment.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 004609e46814791fac540e1c8bfb21f647758143
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Mar 14 08:20:53 2019 -0400

    Bug 14591: Update unit tests
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bc24973c778ce77f1d3726eaad3ce1bc387cd480
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Mar 14 07:58:09 2019 -0400

    Bug 14591: Update other calls to AddReturn
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 467c24cb9da02deb00bf49333351a0843cdeda10
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Mar 14 07:54:09 2019 -0400

    Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9f5a1bc7ebbe3954607da88b87bab6e9c2689dad
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Feb 28 16:13:11 2019 -0500

    Bug 22043: (QA follow-up) Add parameter to control behavior
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7b4ee00a580807b6021758a790fec23c743719d2
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Dec 21 13:54:18 2018 -0500

    Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly
    
    If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field.If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field.
    
    Test Plan:
    1) Set the checked_in_ok sip account flag to 1 for an account
    2) Check in an already checked in item via SIP
    3) Note the alert flag is set to Y
    4) Apply this patch
    5) Restart SIP
    6) Check the item in again
    7) Note the alert flag is set to N
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Jill Kleven <jill.kleven at pueblolibrary.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1934ca1100517ca1622c9c2c0587832504064b25
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Feb 26 15:05:50 2019 +0000

    Bug 22222: Don't send empty params to mana service
    
    Test plan:
    0) Do not apply the patch
    1) Go to serials > Search on Mana
    2) Insert some value into the form
    3) Submit -> you get many (3000+) results
    4) Apply the patch and restart_all
    5) Repeat, now, you get only the subscription matching your query
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9682cc7d21645a673bd274b24aeab323f61f28aa
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Mar 7 16:49:11 2019 +0000

    Bug 22476: Correct default for MarkLostItemsAsReturned
    
    Signed-off-by: Bin Wen <bin.wen at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 639ad97d844f2774f49881174b559293edd6baa4
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Mar 5 15:51:15 2019 +0100

    Bug 21560: (follow-up) move use at the top
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 99ea714345a6278d68e2abb0d182d8b495cf2950
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Feb 19 12:01:16 2019 +0100

    Bug 21560: Unit test for Koha::Util::OpenDocument
    
    Run prove t/Koha/Util/OpenDocument.t
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ffb40290f88380418635a951dbb0788bf7b7e3ce
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Feb 18 17:33:37 2019 +0100

    Bug 21560: create Koha::Util::OpenDocument with subroutine for ODS generation
    
    There is nearly the same code in misc/cronjobs/gather_print_notices.pl and reports/guided_reports.pl.
    This patch creates a new module with subroutine called by both scripts.
    
    If file path or content is undefined, subroutine will just return undef.
    If content is an empty arrayref, empty ods file is still generated.
    
    Unicode encoding is kept outisde because it may not be necessary.
    
    Note that for print notices the first line of message is always the column names so it is extracted only from first message.
    
    Test plan :
    Run previous patches test plans and check ODS files are the same.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5d4f80feac811a9d6e177975b50c57ba85e3434d
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Dec 7 10:30:30 2018 +0100

    Bug 21560: Optimize ODS export of gather_print_notices.pl
    
    Like previous patch, the call on OpenOffice-OODoc lib can be optimized.
    Based on https://grep.metacpan.org/search?qci=&q=expandTable&qft=&qd=OpenOffice-OODoc&f=examples%2Ftext2table
    
    Test plan inspired from Bug 11679.
    
    Test plan:
    - define your ODUE notice for the print template as:
    cardnumber:patron:email:item
    <<borrowers.cardnumber>>:<<borrowers.firstname>> <<borrowers.surname>>:<<borrowers.email>>:<item><<items.barcode>></item>
    - define overdues rules for a patron category
    - check-out 2 items using a due date in order to generate the overdue notices
    - check-in these 2 items
    - launch the script /misc/cronjobs/overdue_notices.pl
    - the 'message_queue' table should now contain 2 new entries
    - launch the gather_print_notices cronjob :
      perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods --letter_code=OVERDUE -d=:
    - A ods file should be generated in your /tmp/test directory
    - Compare times with and without patch
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 28edd8848320fd0f0f284245f2f0567a5907619a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Oct 12 14:09:54 2018 +0200

    Bug 21560: report ODS export optimization
    
    SQL reports can be exported with CSV, TSV of ODS format.
    When report has thousands of rows, using ODS format is around 10 times longer than other formats.
    It also loads CPU and RAM a lot.
    
    The longest call is expandTable().
    I found that the call on OpenOffice-OODoc lib can be optimized.
    Based on https://grep.metacpan.org/search?qci=&q=expandTable&qft=&qd=OpenOffice-OODoc&f=examples%2Ftext2table
    
    Test plan :
    1) Don't apply patch yet
    2) Create a new SQL report : Home > Reports > Create from SQL
    3) Enter a SQL that will return thousands of results
    4) Run report
    5) Click Download > Semicolon separated text (.csv), look execution time
    6) Click Download > Open Document Spreadsheet, look execution time
    7) Apply patch
    8) Redo 5) and 6) and compare times, CSV export should be the same but ODS export should be better
    
    My tests shows 1,5 seconds for CSV export.
    And for ODS export : 18 seconds without patch and 8 seconds with patch.
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3bd900496690375b2b711743ffaa57371388f687
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon Mar 4 17:43:29 2019 +1100

    Bug 22429: Infinite loop in patron card printing
    
    Text fields in Patron Card Text Layouts can contain regular
    expression metacharacters, which - instead of being treated as
    literal values - are interpreted and prevent line wrapping. This
    causes the process to get stuck in an infinite loop, which keeps
    running even after the web server has timed out (at least when
    using CGI).
    
    This patch escapes the relevant input from the text field so the
    regular expression substitution treats characters as literals
    instead of as metacharacters.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2596e9b795d9e65e4f68a72bb587d323c97bad92
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Jan 30 17:13:35 2019 +0000

    Bug 22237: Subscriptions are not linked to Mana upon edit
    
    This patch modifies C4/Serials.pm so that during the process of editing
    a subscription a link to Mana can be created.
    
    To test, apply the patch and go to Serials.
    
     - Locate a subscription which was not created using Mana data but which
       can be found in Mana.
     - Edit the subscription, skipping to the second page.
     - View the results returned by Mana and select one.
     - Save the subscription.
     - Upon being redirected to the subscription detail page you should see
       a "Report mistake" button. This shows that the subscription has been
       linked to Mana successfully.
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit deb968ea45276e56826b592026617a96398b61da
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Feb 8 20:24:05 2019 +0000

    Bug 22296: Add Invoice Adjustments to GetBudgetHierarchy
    
    To test:
    1 - prove -v t/db_dependent/Budgets.t
    2 - Create some invoices on a single budget
        Invoice 1:
          add a non-encumbered adjustment for 1
          add an encumbered adjustment 2
          leave open
        Invoice 2:
          add a non-encumbered adjustment for 4
          add an encumbered adjustment for 8
    3 - View acq home page, should see 2 order and 12 spent for the budget
    4 - View the spent and ordered pages, they should show the correct amounts
    5 - Add more orders etc and confirm things total correctly
    
    https://bugs.koha-community.org/show_bug.cgi?id=22296
    Signed-off-by: Janet McGowan <janet.mcgowan at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 19aebacf7c6162e5628cba1078b2c0f2ec9751a6
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Mar 12 13:15:34 2019 +0000

    Bug 22498: Rename variable for budgets loop for invoice adjustments
    
    To test:
    1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving')
    2 - Note the fund dropdown has only 'No fund'
    3 - Apply patch
    4 - Refresh page
    5 - Note you can now select funds, hooray!
    
    Signed-off-by: Janet McGowan <janet.mcgowan at ptfs-europe.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3c4232e746cef574de9d1a346be7704dc3cd2e33
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Mar 12 17:29:38 2019 +0000

    Bug 22489: Update onboarding tool for bug 18925
    
    When going through the onboarding process, the tool fails on submit of step 5,
    due to changes made in the database structure and rule definitions by bug
    18925.
    
    This patch fixes this, adding code that creates a circulation rule where an
    issuing rule is also created in onboarding.pl. It removes maxissueqty from
    being sent with params to make an issuing rule, and adds it instead to the
    params to make a circulation rule, to reflect the changes that have been made
    in the database.
    
    Test plan:
    1) Drop and recreate your database
    2) Reload the staff client and follow the installer and onboarding
    process
    3) Confirm that the process finishes without errors
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Bug 22489: (follow-up) Correctly set success messages
    
    The original patch was duplicating the success message upon successful
    circ rule insertion. This corrects that.
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Patches squashed for readability
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Budgets.pm                                      |   24 +++-
 C4/Circulation.pm                                  |   78 +++-------
 C4/Images.pm                                       |    4 +-
 C4/Items.pm                                        |    4 +-
 C4/Patroncards/Patroncard.pm                       |    3 +-
 C4/SIP/ILS.pm                                      |    4 +-
 C4/SIP/ILS/Transaction/Checkin.pm                  |   13 +-
 C4/SIP/Sip/MsgType.pm                              |    2 +-
 C4/Serials.pm                                      |    6 +-
 Koha.pm                                            |    2 +-
 Koha/Checkouts.pm                                  |   21 ++-
 Koha/SharedContent.pm                              |    4 +-
 Koha/{Acquisition/Fund.pm => Tag.pm}               |   10 +-
 Koha/{ApiKeys.pm => Tags.pm}                       |   13 +-
 Koha/{Acquisition/Budget.pm => Tags/Approval.pm}   |   10 +-
 Koha/{ApiKeys.pm => Tags/Approvals.pm}             |   13 +-
 Koha/{Acquisition/Fund.pm => Tags/Index.pm}        |   10 +-
 Koha/{ApiKeys.pm => Tags/Indexes.pm}               |   13 +-
 Koha/Util/OpenDocument.pm                          |   95 +++++++++++++
 circ/returns.pl                                    |   32 +++--
 etc/SIPconfig.xml                                  |    1 +
 installer/data/mysql/kohastructure.sql             |    6 +-
 installer/data/mysql/sysprefs.sql                  |    2 +-
 installer/data/mysql/updatedatabase.pl             |   29 ++++
 installer/onboarding.pl                            |   27 +++-
 .../intranet-tmpl/prog/en/modules/acqui/invoice.tt |   16 +--
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |    2 +-
 .../prog/en/modules/reserve/request.tt             |    2 +
 .../prog/en/xslt/UNIMARCslimUtils.xsl              |    2 +-
 .../bootstrap/en/xslt/UNIMARCslimUtils.xsl         |    2 +-
 misc/cronjobs/gather_print_notices.pl              |   66 +++------
 misc/maintenance/fix_tags_weight.pl                |  137 ++++++++++++++++++
 reports/guided_reports.pl                          |   51 +++----
 .../Koha/Util/OpenDocument.t                       |   53 ++++---
 t/db_dependent/Budgets.t                           |   46 ++++--
 t/db_dependent/Circulation.t                       |   43 ++----
 t/db_dependent/Circulation/StoreLastBorrower.t     |   10 +-
 t/db_dependent/Circulation/issue.t                 |    2 +-
 t/db_dependent/DecreaseLoanHighHolds.t             |   41 +++---
 t/db_dependent/Images.t                            |   39 +++++
 t/db_dependent/Items/GetItemsForInventory.t        |   19 ++-
 t/db_dependent/Koha/Patrons.t                      |   10 +-
 t/db_dependent/Koha/SharedContent.t                |    2 +-
 .../{Template/Plugin/To.t => Koha/Tags.t}          |   36 +++--
 .../Plugin/To.t => Koha/Tags/Approvals.t}          |   36 +++--
 .../{Template/Plugin/To.t => Koha/Tags/Indexes.t}  |   36 +++--
 t/db_dependent/SIP/Message.t                       |   21 ++-
 t/db_dependent/Tags.t                              |  149 ++++++++++++++++++--
 48 files changed, 847 insertions(+), 400 deletions(-)
 copy Koha/{Acquisition/Fund.pm => Tag.pm} (88%)
 copy Koha/{ApiKeys.pm => Tags.pm} (83%)
 copy Koha/{Acquisition/Budget.pm => Tags/Approval.pm} (86%)
 copy Koha/{ApiKeys.pm => Tags/Approvals.pm} (83%)
 copy Koha/{Acquisition/Fund.pm => Tags/Index.pm} (87%)
 copy Koha/{ApiKeys.pm => Tags/Indexes.pm} (83%)
 create mode 100644 Koha/Util/OpenDocument.pm
 create mode 100755 misc/maintenance/fix_tags_weight.pl
 copy cataloguing/value_builder/marc21_orgcode.pl => t/Koha/Util/OpenDocument.t (50%)
 mode change 100755 => 100644
 create mode 100644 t/db_dependent/Images.t
 copy t/db_dependent/{Template/Plugin/To.t => Koha/Tags.t} (61%)
 copy t/db_dependent/{Template/Plugin/To.t => Koha/Tags/Approvals.t} (60%)
 copy t/db_dependent/{Template/Plugin/To.t => Koha/Tags/Indexes.t} (61%)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list