[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.10-46-g766b862

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  766b8626c384edb174343952a864ceceb3a844da (commit)
      from  ba0b642cc5f318c9d23e0e22b494adfdb9a45a03 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 766b8626c384edb174343952a864ceceb3a844da
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Feb 11 09:54:43 2019 +0100

    Bug 22303: Correct bottom in virtualshelves/addbybiblionumber.tt
    
    In virtualshelves/addbybiblionumber.tt the include intranet-bottom.inc which closes the HTML last tag is not the last line of the template.
    
    This patch moved bottom include to last line and uses popup-bottom.inc.
    
    Test plan :
    1) Permission OK :
    1.1) Login in staff interface with user 'Bob'
    1.2) Create a new list 'Readme' : category public and allow changes to contents from anyone
    1.3) Perform a search
    1.4) Check some results
    1.5) Click 'Add to list' and on the list 'Readme'
    1.6) A popup window opens
    1.7) Check its HTML is OK, ending with </html>
    2) Permission KO :
    2.1) Open a new window (Firefox private session) and login in staff interface with user 'Bill'
    2.2) Perform a search
    2.3) Check some results
    2.4) On session of 'Bob', edit list 'Readme'
    2.5) Change : category private and allow changes to contents from owner only
    2.6) On session of 'Bill'
    2.7) Click 'Add to list' and on the list 'Readme'
    2.8) A popup window opens saying 'Sorry, you do not have permission to add items to this list'
    2.9) Check its HTML is OK, ending with </html>
    
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 255af719e65956d84d62ea52fea12619bb851f70)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 0c8b515fe724c248cae1d6fa696020c5de9957f1)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/virtualshelves/addbybiblionumber.tt             |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository