[koha-commits] main Koha release repository branch master updated. v18.11.00-819-gb5a742c
Git repo owner
gitmaster at git.koha-community.org
Fri Mar 15 21:13:20 CET 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via b5a742c62f016969dabad9b786a7fe2d75cca760 (commit)
via ef231b41119237952ce8a445c953c3957c987734 (commit)
via 9ceb745fb2f9c226ffab40a32137c8d43d10ad74 (commit)
via 3a7332c742467af3af0c728a3d9c21db00fb4666 (commit)
via 57cfc3bab7d76c3a382f8111f5d5c9490eb2eb91 (commit)
via 6ebcc255d3def898c491333bc8702c56b09e4537 (commit)
via 1db9598e81abf009b80aa44699061e845c9e87e0 (commit)
via 6067d2d49f790ab9ffead1381c571c14b0ba43ff (commit)
via bcc150a9c05c1de4fe2fc5e07a5469f90d48953c (commit)
via 51a887a81d75c5ae561c17143ae9f70651449f04 (commit)
via 41f394f4eedc152627080c0b4a89630034706121 (commit)
via f6b3d9979dc996dff7bf29fd5747e91695f93d0f (commit)
via fc0d64506d75bde53afa3a3385a7f7f42bd566bc (commit)
via 52bb9802dda6f6bb3619cc6d8e921ecd8175c8ce (commit)
via 62f1b2df68f16dcd7eec324d487963f737cbe450 (commit)
via 0af86d0b9b259bc9b171ea60b92cf96865a71c72 (commit)
via 5053ceda3c7fd7a0e0f29336e5d0732c03c1836b (commit)
via 0c7d9e4cc884f60af39859dcd674688d98cf3fae (commit)
via a8435679d41663f9045c4b68d65c06678ac71237 (commit)
via 0c41d8631474ae3fd33a1ff904dc241c791746aa (commit)
via 6979847e8636d87e46551745e84b54afba64ba00 (commit)
via 8fef5120f30b73cd57c8d8f79b288ef0ddbfb608 (commit)
via 9e8c18572b1b6dd36edef72d5e47fd62f0c271d1 (commit)
via 45662b4cc72c2fda2b4f47cfaeb2501b577f899e (commit)
via 67c5956c1915ddab9069a226e45a838380acdf75 (commit)
via b1e076fab0da49d7480d22b8c440342af0bbc652 (commit)
via 7413de82f2d3f4cc359c9963bcfb9008f8d048f4 (commit)
via d777714a573c027dbb4d03f65ae065348ae2448c (commit)
via 3b01a6d063d0e40d3a97fe00dec2b4d4d9ce1c27 (commit)
via 58b81110dcd871bb0eb5131f4af2b3179dbcc2d5 (commit)
via 79d64a37a0d200fc3f6ecf03731ff6c954fc0749 (commit)
from a13dff4b88b0c4efc66a05fa33870d81291da9db (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b5a742c62f016969dabad9b786a7fe2d75cca760
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Feb 22 17:29:36 2019 +0000
Bug 22399: Improve responsive behavior of the basic marc editor
This patch makes markup and style changes to the basic MARC editor in
order to improve the page's handling of smaller browser widths. It adds
Bootstrap grid markup to the form to help accomplish this.
To test, apply the patch and load a record for editing in the basic MARC
editor. Adjust your browser width and confirm that the form adjusts well
to various widths.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ef231b41119237952ce8a445c953c3957c987734
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Sep 24 12:10:47 2018 +0000
Bug 20658: (follow-up) Fix for QA: Add missing html filters
This patch adds missing filters to the installer header and footer
include files.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9ceb745fb2f9c226ffab40a32137c8d43d10ad74
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Apr 25 16:28:18 2018 +0000
Bug 20658: Move template JavaScript to the footer: Installer and onboarding
This patch updates the installer and onboarding templates so that
JavaScript is included in the footer instead of the header. A new
include file is added, installer-intranet-bottom.inc, so that only
required JS is being loaded.
Some markup changes are included to improve validity.
To test, apply the patch and start with a blank Koha database. Run
through the installer and onboarding processes and confirm that there
are no problems. Check especially JS-related interactions like
datepickers and fields which are validated via JS, like the password
inputs.
NOTE: The qa tool will flag this patch for not using the Asset plugin,
but it doesn't work correctly for installer files.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3a7332c742467af3af0c728a3d9c21db00fb4666
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Feb 4 21:36:08 2019 +0100
Bug 18952: Add internal note to acq details tab
Any important notes about an order are usually added to the
internal note. This patch makes the note visible on the
acq detail tab in the staff client.
To test:
- Add a basket
- Order something
- Add an internal note for the order
- Go to the detail page of the ordered record
- Switch to the Acquisition details tab
- Verify that with the patch the internal note shows
- Verify that the new column can be toggled using the
column visibility settings
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 57cfc3bab7d76c3a382f8111f5d5c9490eb2eb91
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Mon May 21 12:15:37 2018 +0100
Bug 20782: Fix link from edifactmessages to invoices
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6ebcc255d3def898c491333bc8702c56b09e4537
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Feb 28 10:00:27 2019 -0300
Bug 22206: (follow-up) Voted RFC changes
This patch changes expiration_date for end_date as voted when the RFC
was approved.
It also adds a test for the Location header being added correctly when
suspending a hold (SWAGGER3.4.1)
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1db9598e81abf009b80aa44699061e845c9e87e0
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Thu Feb 21 00:59:22 2019 +0000
Bug 22206: (QA follow-up) Fix tests for hold suspension api
Test plan:
prove t/db_dependent/api/v1/holds.t
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6067d2d49f790ab9ffead1381c571c14b0ba43ff
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jan 28 07:40:15 2019 -0300
Bug 22206: Add routes to suspend/resume holds
This patch introduces:
- POST /holds/{hold_id}/suspension { "expiration_date": "2019-01-30" }
- DELETE /holds/{hold_id}/suspension
to suspend a hold or resume a suspended hold, respectively.
To test:
- Apply this patches
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit bcc150a9c05c1de4fe2fc5e07a5469f90d48953c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jan 28 07:39:47 2019 -0300
Bug 22206: Unit tests
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 51a887a81d75c5ae561c17143ae9f70651449f04
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jan 28 07:39:27 2019 -0300
Bug 22206: OpenAPI spec
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 41f394f4eedc152627080c0b4a89630034706121
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jan 24 16:13:25 2019 -0300
Bug 20006: (follow-up) Plural class name
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f6b3d9979dc996dff7bf29fd5747e91695f93d0f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jan 24 15:11:21 2019 -0300
Bug 20006: (follow-up) Fix holds.js
This patch makes holds.js call the endpoint with 'pickup_library_id'
instead of the old 'branchcode' property.
To test:
- Place a hold
- Go to the patron's detail page
- Go to the Holds tab
- Change the pickup location
=> SUCCESS: It works!
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fc0d64506d75bde53afa3a3385a7f7f42bd566bc
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jan 24 14:53:30 2019 -0300
Bug 20006: Adapt /holds to the RFC
This patch makes the /holds endpoint respect the voted RFC. Some
behaviours are changed as well:
- As we voted to introduce a /public namespace for unprivileged access to
endpoints, this endpoint gets the ability for owners and guarantors to
manipulate holds through the API.
- GET /holds now uses the objects->search helper, so it now has
pagination.
To test:
- Apply this patches
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 52bb9802dda6f6bb3619cc6d8e921ecd8175c8ce
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jan 24 14:51:03 2019 -0300
Bug 20006: Unit tests fixes
This patch makes the holds endpoint tests pass and expect data structures that match the voted RFC.
As we voted to introduce a /public namespace for unprivileged access to
endpoints, this endpoint gets the ability for owners and guarantors to
manipulate holds through the API.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 62f1b2df68f16dcd7eec324d487963f737cbe450
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jan 24 14:48:26 2019 -0300
Bug 20006: Spec changes
This patch makes the spec match the voted RFC.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0af86d0b9b259bc9b171ea60b92cf96865a71c72
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Mar 11 08:46:54 2019 +0000
Bug 20563: (QA follow-up) Get requested_partners from api
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5053ceda3c7fd7a0e0f29336e5d0732c03c1836b
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Mar 11 08:46:01 2019 +0000
Bug 20563: (QA follow-up) Fix number of tests in api/v1/illrequests.t
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0c7d9e4cc884f60af39859dcd674688d98cf3fae
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Fri Apr 13 09:22:26 2018 +0100
Bug 20563: Allow display of requested partners
This patch adds the display of requested partner email addresses when an
ILL backend provides the ability to send requests to partners. Partner
email addresses are displayed in the illlist and illview displays, they
are also included in the 'illrequests' API response.
* api/v1/swagger/paths/illrequests.json:
- Add 'requested_partners' as an 'embed' enum
* Koha/Illrequest.pm:
- Add 'requested_partners' accessor calling optional backend 'get_requested_partners' method.
- Store requested partners upon email send, calling optional backend 'set_requested_partners' method.
- Add 'requested_parners' embed to overloaded TO_JSON method.
* koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt:
- Add 'requested_partners' embed to illrequests API call
- Add render function for "Additional status" datatables column
- Add display of requested partner email addresses to illlist table
- Add display of requested partner email addresses to illview display
To test:
1) Enable Interlibrary loans
2) Add a backend that supports sending requests to partners, e.g.
FreeForm
3) Set up at least one partner
4) Create an ILL request
5) Send request to partner(s)
6) Observe partner(s) email address(es) are displayed in "View ILL
requests" view
7) Observe partner(s) email address(es) are displayed in "Manage ILL
request" view
Signed-off-by: mmg at interleaf.ie
https://bugs.koha-community.org/show_bug.cgi?id=20653
Bug 20563: (follow-up) Fix requested partners
As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563#c10
Thanks for the suggestion on merging the "Status" and "Additional status" columns, looks much better!
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a8435679d41663f9045c4b68d65c06678ac71237
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Thu Nov 29 12:26:33 2018 +0000
Bug 20563: (follow-up) Fix rebasing bug
Fix erroneous curly brackets
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0c41d8631474ae3fd33a1ff904dc241c791746aa
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Fri Nov 9 12:23:32 2018 +0000
Bug 20563: (follow-up) Add unit test
Test that requested partners are returned in API response when requested
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6979847e8636d87e46551745e84b54afba64ba00
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Mar 15 19:31:45 2019 +0000
Bug 18837: DBRev 18.12.00.027
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8fef5120f30b73cd57c8d8f79b288ef0ddbfb608
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Mar 11 08:21:24 2019 +0000
Bug 18837: (QA follow-up) Fix order of sysprefa.sql
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9e8c18572b1b6dd36edef72d5e47fd62f0c271d1
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Fri Mar 8 11:28:09 2019 +0000
Bug 18837: (follow-up) Add additional tests
As requested by Josef on IRC, we now mock the unmediated_ill backend
method and ensure it is called when the ILLModuleUnmediated syspref is
enabled and ensure it is not called when the syspref is disabled
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 45662b4cc72c2fda2b4f47cfaeb2501b577f899e
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Thu Mar 7 09:49:46 2019 +0000
Bug 18837: (QA follow-up) Update system preference desciprition
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 67c5956c1915ddab9069a226e45a838380acdf75
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Thu Apr 26 12:04:58 2018 +0100
Bug 18837: Introduce delegation to backends for unmediated workflows
This patch adds support to Illrequest.pm to allow delegation of
unmediated requests to happen in backends that support them.
It is a recreation of
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff
which had diverged sufficiently as to make it impossible to apply
Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk>
Signed-off-by: David Peacock <d.m.peacock at herts.ac.uk>
Signed-off-by: Jayne Maisey <j.maisey at herts.ac.uk>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b1e076fab0da49d7480d22b8c440342af0bbc652
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Thu Apr 26 11:56:19 2018 +0100
Bug 18837: Add ILL Unmediated syspref stuff
This patch adds the syspref requirements for unmediated ILL requests. It
is a recreation of
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff
which had diverged sufficiently as to make it impossible to apply.
* installer/data/mysql/atomicupdate/illunmediated_tables.sql: New
file.
* installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref:
Add `ILLModuleUnmediated` handling.
Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk>
Signed-off-by: David Peacock <d.m.peacock at herts.ac.uk>
Signed-off-by: Jayne Maisey <j.maisey at herts.ac.uk>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7413de82f2d3f4cc359c9963bcfb9008f8d048f4
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Thu Jul 12 11:12:00 2018 +0100
Bug 21063: Add "Columns settings" for ILL
This patch adds the "Columns settings" values for the illrequests table
Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Bug 21063: Add ability to show / hide columns
This patch adds the "Column visibility" functionality to the main ILL
request list table.
To test:
- Ensure ILL is enabled and you have some requests
- Apply patch
- From the "Koha administration screen, select "Configure columns"
- In the "Columns settings" page:
=> TEST: Ensure an "Interlibrary loans" category exists
- Upon expanding the category:
=> TEST: Ensure a table is displayed showing columns
=> TEST: Ensure the "action" column has "Cannot be toggled"
pre-selected
=> TEST: Change values for columns and ensure they're saved
- From the main staff menu, select "ILL requests"
- In the table:
=> TEST: Click the "Column visibility" button and ensure a modal
containing all columns (except "Action") is displayed
=> TEST: Select various columns and ensure they are shown and hidden
Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Bug 21063: (follow-up) Add user ID to column list
As originally specified in bug 20883, there is a requirement for some
users to be able to display the user ID (borrowernumber) in the UI.
This patch adds that ability to this bug, 20883 will be marked as a
duplicate of this one.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Bug 21063: (follow-up) Amendments for rebase
Modify to add the additional changes required now we're rebasing on top
of the dependency tree. Includes adding additional columns (and changing
indexes for search/filter where appropriate)
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Bug 21063: (follow-up) Add comments to column list
Since this bug is now dependent on Bug 18591 (Allow an arbitrary number
of comments on ILLs) we need to add the comments column to this table
and the list of selectable columns. This patch does this.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Bug 21063: (follow-up) Sanitize datatable data
This mitigates bug 22268 by sanitizing data prior to display using the
built in $.fn.dataTable.render.text() helper provided by Datatables.
The patch was added here, rather that in 22268 since this is the bug
that introduced the problem by increasing the number of fields that are
displayed in the table, some of which could contain user provided
malicious data
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d777714a573c027dbb4d03f65ae065348ae2448c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Mar 15 19:21:25 2019 +0000
Bug 20750: DBRev 18.12.00.026
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3b01a6d063d0e40d3a97fe00dec2b4d4d9ce1c27
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Thu Feb 28 11:14:46 2019 +0000
Bug 20750: (QA follow-up) Fix templates
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 58b81110dcd871bb0eb5131f4af2b3179dbcc2d5
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Oct 2 14:56:53 2018 +0100
Bug 20750: Add unit tests
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Bug 20750: (follow-up) Remove status_alias test
This test is now redundant.
We can't test the return of $req->status_alias against the value of
$req->{status_alias} any more since we've overloaded the status_alias
method and it won't always return the value of the object's property.
We test the functionality of the status_alias method elsewhere so we're
still covered.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 79d64a37a0d200fc3f6ecf03731ff6c954fc0749
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Tue Oct 2 14:55:58 2018 +0100
Bug 20750: Allow logging of arbitrary actions
This patch allows logging of arbitrary actions on request objects. A
chronological summary of these actions can then be displayed when
viewing a request.
This patch also adds logging of request status changes. Additional work
has been done on the BLDSS backend to log requests to the BLDSS request
status check API.
To test:
- Apply patch
- Ensure the Illlog logging preference is turned on
- Create an ILL request and perform actions on it that change it's
status.
- Navigate to the "Manage ILL request" screen
- Click the "Display request log" button
- Observe that a modal opens displaying a summary of the status changes.
Signed-off-by: Niamh Walker <Niamh.Walker-Headon at it-tallaght.ie>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Since this bug now is dependent on Bug 20581, it should be aware of the
custom statuses provided in 20581. This patch enables logging of request
statuses being changed to custom ones. As such the test plan is
modified:
To test:
- Apply patch
- Ensure the Illlog logging preference is turned on
- Ensure you have some custom request statuses defined in the
Authorised Values ILLSTATUS category
- Create an ILL request and perform actions on it that change it's
status.
- Edit the request and change status to a custom one
- Navigate to the "Manage ILL request" screen
- Click the "Display request log" button
- Observe that a modal opens displaying a summary of the status changes.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
Koha.pm | 2 +-
Koha/Illrequest.pm | 171 ++++++-
Koha/Illrequest/Logger.pm | 237 ++++++++++
Koha/REST/V1/Hold.pm | 171 -------
Koha/REST/V1/Holds.pm | 491 ++++++++++++++++++++
Koha/REST/V1/Illrequests.pm | 12 +-
admin/columns_settings.yml | 73 +++
api/v1/swagger/definitions/hold.json | 73 +--
api/v1/swagger/parameters.json | 6 +-
api/v1/swagger/parameters/hold.json | 4 +-
api/v1/swagger/paths.json | 7 +-
api/v1/swagger/paths/holds.json | 244 +++++++---
api/v1/swagger/paths/illrequests.json | 9 +-
api/v1/swagger/x-primitives.json | 12 +-
ill/ill-requests.pl | 4 +-
installer/data/mysql/sysprefs.sql | 2 +
installer/data/mysql/updatedatabase.pl | 18 +
koha-tmpl/intranet-tmpl/prog/css/addbiblio.css | 48 +-
.../prog/en/includes/installer-doc-head-close.inc | 18 -
.../prog/en/includes/installer-intranet-bottom.inc | 21 +
.../prog/en/modules/acqui/edifactmsgs.tt | 2 +-
.../prog/en/modules/admin/columns_settings.tt | 6 +
.../en/modules/admin/preferences/circulation.pref | 8 +
.../prog/en/modules/admin/preferences/logs.pref | 6 +
.../prog/en/modules/catalogue/detail.tt | 2 +
.../prog/en/modules/cataloguing/addbiblio.tt | 38 +-
.../prog/en/modules/ill/ill-requests.tt | 341 ++++++++------
.../prog/en/modules/ill/log/status_change.tt | 12 +
.../prog/en/modules/installer/auth.tt | 7 +-
.../prog/en/modules/installer/step1.tt | 140 +++---
.../prog/en/modules/installer/step2.tt | 3 +-
.../prog/en/modules/installer/step3.tt | 33 +-
.../prog/en/modules/onboarding/onboardingstep1.tt | 3 +-
.../prog/en/modules/onboarding/onboardingstep2.tt | 12 +-
.../prog/en/modules/onboarding/onboardingstep3.tt | 17 +-
.../prog/en/modules/onboarding/onboardingstep4.tt | 12 +-
.../prog/en/modules/onboarding/onboardingstep5.tt | 12 +-
.../intranet-tmpl/prog/en/modules/tools/viewlog.tt | 6 +-
koha-tmpl/intranet-tmpl/prog/js/holds.js | 2 +-
t/Log.t | 1 -
t/db_dependent/Illrequest/Logger.t | 118 +++++
t/db_dependent/Illrequests.t | 44 +-
t/db_dependent/api/v1/holds.t | 195 ++++----
t/db_dependent/api/v1/illrequests.t | 11 +-
44 files changed, 1930 insertions(+), 724 deletions(-)
create mode 100644 Koha/Illrequest/Logger.pm
delete mode 100644 Koha/REST/V1/Hold.pm
create mode 100644 Koha/REST/V1/Holds.pm
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/installer-intranet-bottom.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/status_change.tt
create mode 100644 t/db_dependent/Illrequest/Logger.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list